summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBharathS24 <BS00493532@techmahindra.com>2018-07-26 11:50:17 +0530
committerBharathS24 <BS00493532@techmahindra.com>2018-07-26 11:50:31 +0530
commit34b81bf5964fe4133bf85fdad4c2a127fc66d330 (patch)
tree70a6af11e1df9b68cd50a1ea77a960787c6654ae
parent484380e9971ea299f9349fef8c98869812fbb207 (diff)
Sonar major issue
T is not used in the interface Sonar link : https://sonar.onap.org/issues?myIssues=true&open=AWFSduLYof9FJ6jfXJex&resolved=false Location : src/main/java/org/onap/dcae/apod/analytics/common/validation/ValidationResponse.java:L34 Change-Id: I48dd2292cd803198f83eddaabad2acdc76c6cbf8 Issue-ID: DCAEGEN2-635 Signed-off-by: BharathS24 <BS00493532@techmahindra.com>
-rw-r--r--dcae-analytics-cdap-common/src/main/java/org/onap/dcae/apod/analytics/cdap/common/utils/ValidationUtils.java2
-rw-r--r--dcae-analytics-cdap-common/src/main/java/org/onap/dcae/apod/analytics/cdap/common/validation/CDAPAppSettingsValidator.java2
-rw-r--r--dcae-analytics-common/src/main/java/org/onap/dcae/apod/analytics/common/validation/GenericValidationResponse.java2
-rw-r--r--dcae-analytics-common/src/main/java/org/onap/dcae/apod/analytics/common/validation/ValidationResponse.java4
4 files changed, 5 insertions, 5 deletions
diff --git a/dcae-analytics-cdap-common/src/main/java/org/onap/dcae/apod/analytics/cdap/common/utils/ValidationUtils.java b/dcae-analytics-cdap-common/src/main/java/org/onap/dcae/apod/analytics/cdap/common/utils/ValidationUtils.java
index 5ab2427..bfd7b31 100644
--- a/dcae-analytics-cdap-common/src/main/java/org/onap/dcae/apod/analytics/cdap/common/utils/ValidationUtils.java
+++ b/dcae-analytics-cdap-common/src/main/java/org/onap/dcae/apod/analytics/cdap/common/utils/ValidationUtils.java
@@ -80,7 +80,7 @@ public abstract class ValidationUtils {
* @param <R> Validation Response type
* @param <V> Validator Type
*/
- public static <T extends CDAPAppSettings, R extends ValidationResponse<T>,
+ public static <T extends CDAPAppSettings, R extends ValidationResponse,
V extends CDAPAppSettingsValidator<T, R>> void validateSettings(@Nonnull final T appSettings,
@Nonnull final V appSettingsValidator) {
checkNotNull(appSettings, "App Settings must not be null");
diff --git a/dcae-analytics-cdap-common/src/main/java/org/onap/dcae/apod/analytics/cdap/common/validation/CDAPAppSettingsValidator.java b/dcae-analytics-cdap-common/src/main/java/org/onap/dcae/apod/analytics/cdap/common/validation/CDAPAppSettingsValidator.java
index 2d3cbb1..0154916 100644
--- a/dcae-analytics-cdap-common/src/main/java/org/onap/dcae/apod/analytics/cdap/common/validation/CDAPAppSettingsValidator.java
+++ b/dcae-analytics-cdap-common/src/main/java/org/onap/dcae/apod/analytics/cdap/common/validation/CDAPAppSettingsValidator.java
@@ -34,7 +34,7 @@ import org.onap.dcae.apod.analytics.common.validation.ValidationResponse;
*
* @author Rajiv Singla . Creation Date: 11/2/2016.
*/
-public interface CDAPAppSettingsValidator<T extends CDAPAppSettings, R extends ValidationResponse<T>>
+public interface CDAPAppSettingsValidator<T extends CDAPAppSettings, R extends ValidationResponse>
extends DCAEValidator {
/**
diff --git a/dcae-analytics-common/src/main/java/org/onap/dcae/apod/analytics/common/validation/GenericValidationResponse.java b/dcae-analytics-common/src/main/java/org/onap/dcae/apod/analytics/common/validation/GenericValidationResponse.java
index 55afe29..9c440ae 100644
--- a/dcae-analytics-common/src/main/java/org/onap/dcae/apod/analytics/common/validation/GenericValidationResponse.java
+++ b/dcae-analytics-common/src/main/java/org/onap/dcae/apod/analytics/common/validation/GenericValidationResponse.java
@@ -35,7 +35,7 @@ import java.util.Set;
*
* @author Rajiv Singla . Creation Date: 10/24/2016.
*/
-public class GenericValidationResponse<T> implements ValidationResponse<T> {
+public class GenericValidationResponse<T> implements ValidationResponse {
private LinkedHashMap<String, String> errorMessageMap = new LinkedHashMap<>();
diff --git a/dcae-analytics-common/src/main/java/org/onap/dcae/apod/analytics/common/validation/ValidationResponse.java b/dcae-analytics-common/src/main/java/org/onap/dcae/apod/analytics/common/validation/ValidationResponse.java
index d64dab7..c0065e2 100644
--- a/dcae-analytics-common/src/main/java/org/onap/dcae/apod/analytics/common/validation/ValidationResponse.java
+++ b/dcae-analytics-common/src/main/java/org/onap/dcae/apod/analytics/common/validation/ValidationResponse.java
@@ -27,11 +27,11 @@ import java.util.Set;
/**
* Validation Response contract
*
- * @param <T> Entity class type which is being validated
+ *
*
* @author Rajiv Singla . Creation Date: 10/24/2016.
*/
-public interface ValidationResponse<T> {
+public interface ValidationResponse {
/**
* Returns true if validation resulted in one or more errors