summaryrefslogtreecommitdiffstats
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2022-07-26Groovy clean tests clean-upemaclee7-204/+205
- test labels are modified to set standards for writing tests - labels are not expected to be technical - labels need to be in simple language that ANYONE can understand - labels should not have exact method names except for some mocking - variables are modified to give highlight to ONLY important parameter of test - wild cards are preferred when possible i.e. for exception cases Issue-ID: CPS-588 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: I3d42471e7aa4bc61f962ad19cc1f237f6985a9a2
2022-06-10Fix sonar code smellsemaclee2-4/+3
- Remove this unused method parameter "operation" (https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps-ncmp-dmi-plugin&open=AYEgIe-wVOe7T_lfxJBt) - Change method to private Issue-ID: CPS-475 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: I07e9b8150da935387f2a63c5b0e622d5157412de
2022-06-01Async request response dmi -> NCMPJosephKeenan15-302/+514
-Added Async for passthrough running and operational -Build will fail until cps is merged https://gerrit.onap.org/r/c/cps/+/128685 Issue-ID: CPS-830 Change-Id: Iedbfab109f5cd777a5be8eed7414758d0f5ec05c Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2022-05-09Security Logging Fieldssourabh_sourabh3-0/+82
- logback encoder and sleuth dependencies are added. - New appender is added to log JSON format content on console. Issue-ID: CPS-986 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: Id7e4d836188da54b94144076a8755e4a2643a7ad
2022-04-25Test scenarios for async infra codempriyank3-5/+45
Issue-ID: CPS-987 Change-Id: Ie4c40b91e45ad325658a32eb474840af761e0029 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-04-12Merge "NCMP Kafka Producer Infrastructure"Toine Siebelink10-24/+282
2022-04-11NCMP Kafka Producer Infrastructurempriyank10-24/+282
- Producer configuration and Topic related information. - Accepted topicParameter and request id from NCMP to process async - Replacing Springfox and using Springdoc instead Issue-ID: CPS-829 Change-Id: I369b5ec6c16318220bb218701006918a0bf21419 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-04-08Fix SonarQube violationsToineSiebelink2-9/+8
- Use EnumMap - Remove use of var Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Iebc3d8a8a87d0477c38967126988a6825b7e80a9
2022-04-06Improve branch coverageToineSiebelink4-70/+56
- update to oparent 3.3.0 to allow for checkstyle @SupressWarnings (not used in the end) - refactor code to minimize unused branches (no more switch-statements :-)) - Added test for neccessary but uncovered branches Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I03c7355a7e9d19f57523a65fbff45c9d8f1c9e07
2022-04-04[dmi-plugin] Fix getResourceDataForPassthroughOperational endpointputhuparambil.aditya7-52/+22
Get endpoint only accepts application/json. Issue-ID: CPS-957 Change-Id: I7b9dd00f293f183dc76623c8e32699e8e90fd17c Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
2022-03-28Increase (branch) coverageToineSiebelink1-12/+20
Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Idc2752dae882dd994892d91b7038ae8ef81e532e
2022-03-25Update SpringBoot when approved version has Log4J 2.17.1 or higherJosephKeenan1-0/+9
-Updated cps-dependencies/pom.xml SpringBoot to v2.6.4 Issue-ID: CPS-958 Change-Id: Idac149e77eab1c273694672ee0282868e0e8589a Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2022-03-23Exception scenario handlingmpriyank1-1/+1
- Updated logic to throw exception when response code is not 2XX, previously it was checking for 201 CREATED Issue-ID: CPS-955 Change-Id: I45cc53cf5b0e603755a75dbd089ead0eb87e5970 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-03-10Refactor dmi plugin code and fix commentssourabh_sourabh2-69/+93
- Used UriComponentBuilder is populate urls. - Removed incorrect import of StringUtils Issue-ID: CPS-569 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I11c6ad2fec528f9792c05405a7242128c0a6d4e2
2022-01-24Merge "Align DMI Plugin REST API Specification and Implementation"Toine Siebelink1-1/+1
2022-01-20Align DMI Plugin REST API Specification and Implementationputhuparambil.aditya1-1/+1
Issue-ID: CPS-824 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: If4478f6afd6a36570dc2d800484cffdb40c256c9
2022-01-19impl patch operation in dmitragait7-11/+44
Change-Id: Ie87216fa6cb120bea685286b7f0dacd8e22f603b Signed-off-by: tragait <rahul.tyagi@est.tech> Issue-ID: CPS-641
2021-12-21Fix Sonar Qube Violations - Recurring tasksourabh_sourabh2-1/+5
Issue-ID: CPS-475 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I4279d5ca24b6cd78f419288eba10f557965c5e7b
2021-12-03Fix conversion to string for result from YangResource request on SDN-CToineSiebelink4-33/+165
-Extracted out relevant method to separate class -Added comprehensive tests around relevant methods Issue-ID: CPS-788 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Icb2104ca606b28f1904ead368bcde27f578e7e53
2021-11-23Generating openapi documentation from openapi.yamlputhuparambil.aditya1-0/+8
Issue-ID: CPS-755 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: Ib19afce259639d0154e6dbeb825c5da0e3dbfa3a
2021-11-12Support Update and Delete operations for DS Passtrough-Running in DMI PluginDylanB95EST14-215/+319
-Add Update operation for Passthrough Running -Use POST operatiosn for all methods as agrred -refactor to simplify and beter reuse of common methods -add delete operation for passthrough running Issue-ID: CPS-637 Issue-ID: CPS-638 Change-Id: I441181f977dee2bc0be944662465d868595ea452 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-11-02Refactor Get Modules by CMHandle flowRenu Kumari9-261/+229
- Used jayway to convert sdnc response to POJO to clean up classes - Moved SDNC error handling to the SDNCOperation - Added SdncException - Added spring-security test Mock user in the controllerSpec Issue-ID: CPS-571 Signed-off-by: Renu Kumari <renu.kumari@bell.ca> Change-Id: Ice91e48536dd2e309721440b61d37a49ce43b403
2021-10-28Upgrade spring boot dependencies to 2.5.5Bruno Sakoto1-8/+0
Also remove org.jetbrains.annotations that is not part of spring boot 2.5.5 anymore. Issue-ID: CPS-582 Change-Id: Ia15861b423c9ba63ebf416513aac9ac61eab4742 Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
2021-10-08Update the ncmp dmi registration urlRenu Kumari1-1/+1
Issue-ID: CPS-722 Signed-off-by: Renu Kumari <renu.kumari@bell.ca> Change-Id: I67ca134c5f3528d5c5e96f006fd58f603b38fc16
2021-10-07Change the dmiRegistrationURl to /ncmpRenu Kumari1-1/+1
Issue-ID: CPS-722 Signed-off-by: Renu Kumari <renu.kumari@bell.ca> Change-Id: I9ae28a5791476950f37fd75a4cf266b8c1249505
2021-10-07Updating get module schema request bodyniamhcore3-38/+15
Issue-ID: CPS-706 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I92d241c4ccde77aaaf8aa5a3903437016edf65d0
2021-10-07Merge "fix query param to options"Niamh Core7-95/+108
2021-10-06Update the ncmp dmi registration urlRenu Kumari1-1/+1
Issue-ID: CPS-722 Signed-off-by: Renu Kumari <renu.kumari@bell.ca> Change-Id: I2ef4dcdff933512aaecc29062dd16329aecddda9
2021-10-06fix query param to optionstragait7-95/+108
Issue-ID: CPS-678 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: I4ac72da512e2c7883920907137b8834ce20d4528
2021-10-05Merge "Fix issues with SOnar Qube coverage report"Niamh Core17-35/+245
2021-10-01Fix issues with SOnar Qube coverage reportToineSiebelink17-35/+245
-removed invalid jacoco exclude -removed strange (generated/accidental?) comment in main pom header -moved manually coded 'models' package (included in coverage now) to separate it from swagger generated package/classes with same name (exluded in coverage) -added some missing test scenarios -increased coverage limit from 70 to 98% to prevent regression Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I2f1c276c543926d2d259e33b418f21de4abfea96
2021-09-30Changing resource identifier to a query paramniamhcore2-15/+24
* Updating yaml * Update jib-maven-plugin version Issue-ID: CPS-679 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: Ie2f49bd8e22723ca4dcd2c20ed39722f22c281c1
2021-09-27fix fetch modules request bodytragait2-17/+22
Issue-ID: CPS-653 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: I6b5f0fc74ea4e70e65b05ed353e25311ed36135e
2021-09-22Add get modules response type to openapiniamhcore6-45/+91
Issue-ID: CPS-657 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: Ifcd22b6e82aaf4993f9071ad56b524fe620afaf7
2021-09-21fix data from object to stringtragait9-85/+86
Also, make dmi service url configurable, change name of dmi creds env var Issue-ID: CPS-675 Issue-ID: CPS-634 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: I6fe794b3e65b6a3aae2a1698ea64a925238a18d3
2021-09-15Update response code for passthrough-running create use-caseniamhcore4-19/+29
Issue-ID: CPS-659 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I4ebc4f68604efe78efb951989c2fb021443c36c9
2021-09-10revert cps:634 postpone this bug to jakartatragait10-14/+27
This commit also have fix in application yaml for correct ncmp api path for registration url. Issue-ID: CPS-634 Issue-ID: CPS-617 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: I465991492a01092e28b97583f84ed959c54ffaa6
2021-09-06Fix Sonar Qube Violationslukegleeson2-9/+13
Issue-ID: CPS-475 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I7d4242f49212fb7b973450a841f0251e2fb36b08
2021-09-03fix data type as string for dmi request bodytragait5-17/+6
Issue-ID: CPS-634 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: Ib3d9d7cab12c77332d799b89e73e5a9b934a4473
2021-09-01Merge "CPS-617 - DMI base path does not conform to agreed API URL"Niamh Core2-2/+2
2021-08-31CPS-617 - DMI base path does not conform to agreed API URLJosephKeenan2-2/+2
-Modified dmi-base-path from /dmi/api to /dmi in src/main/resources/application.yml & src/test/resources/application/yml Issue-ID: CPS-617 Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Change-Id: Ic4e76731ee44abb6e6f260d7c8adb1023ebe4e34
2021-08-31Merge "Adding name and revision tag for yang resources output"Toine Siebelink2-10/+52
2021-08-31Adding name and revision tag for yang resources outputniamhcore2-10/+52
Issue-ID: CPS-589 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I43f6971f416c6aa3ac1b1a56626930ad16288680
2021-08-30Merge "fix getforentity in onap DMI plugin"Niamh Core4-4/+11
2021-08-27fix getforentity in onap DMI plugintragait4-4/+11
Issue-ID: CPS-573 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: Idb2186e6f3275530513bbd5e788c98b4ceda9d10
2021-08-27Address minor code review comments for CPS-484niamhcore3-28/+45
Issue-ID: CPS-565 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I8cb28cf60622e5a9c0211b4fa7db2f255ede165a
2021-08-25Write data for cm handle passthrough:runningniamhcore10-148/+273
Issue-ID: CPS-574 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I15e2ad500d2bbf7a1d408b8a852287e55bddbecb
2021-08-20Merge "Get resource data for pass-through running (dmi-impl)"Niamh Core7-22/+135
2021-08-19Get resource data for pass-through running (dmi-impl)tragait7-22/+135
Issue-ID: CPS-561 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: Ia92a97296e2c3e84d0b6f6d9d1d0daf1e8f46b55
2021-08-18Fix Sonar Qube Violationslukegleeson2-8/+4
Issue-ID: CPS-475 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I04c857c3046c76eb3311ad916af2c4321ca47686