Refactor Get Modules by CMHandle flow

- Used jayway to convert sdnc response to POJO to clean up classes
- Moved SDNC error handling to the SDNCOperation
- Added SdncException
- Added spring-security test Mock user in the controllerSpec

Issue-ID: CPS-571
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ice91e48536dd2e309721440b61d37a49ce43b403

4 files changed, 109 insertions, 129 deletions

diff --git a/src/test/groovy/org/onap/cps/ncmp/dmi/model/ModuleSchemaPropertiesSpec.groovy b/src/test/groovy/org/onap/cps/ncmp/dmi/model/ModuleSchemaPropertiesSpec.groovy
deleted file mode 100644
index 51dddc7d..00000000
--- a/src/test/groovy/org/onap/cps/ncmp/dmi/model/ModuleSchemaPropertiesSpec.groovy
+++ /dev/null
@@ -1,41 +0,0 @@
-/*
- *  ============LICENSE_START=======================================================
- *  Copyright (C) 2021 Nordix Foundation
- *  ================================================================================
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *  you may not use this file except in compliance with the License.
- *  You may obtain a copy of the License at
- *
- *        http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
- *
- *  SPDX-License-Identifier: Apache-2.0
- *  ============LICENSE_END=========================================================
- */
-
-package org.onap.cps.ncmp.dmi.model
-
-import org.onap.cps.ncmp.dmi.service.model.ModuleSchemaProperties
-import spock.lang.Specification
-
-class ModuleSchemaPropertiesSpec extends Specification {
-    def objectUnderTest = new ModuleSchemaProperties(identifier:'some id',
-                                                     version:'some version',
-                                                     format:'some format',
-                                                     namespace:'some namespace',
-                                                     location: ['some','locations'])
-
-    def 'Reading all properties.'() {
-        expect: 'all properties return the expected values'
-            objectUnderTest.identifier == 'some id'
-            objectUnderTest.version == 'some version'
-            objectUnderTest.format == 'some format'
-            objectUnderTest.namespace == 'some namespace'
-            objectUnderTest.location == ['some','locations']
-    }
-}
diff --git a/src/test/groovy/org/onap/cps/ncmp/dmi/rest/controller/DmiRestControllerSpec.groovy b/src/test/groovy/org/onap/cps/ncmp/dmi/rest/controller/DmiRestControllerSpec.groovy
index ac78928d..1446a5aa 100644
--- a/src/test/groovy/org/onap/cps/ncmp/dmi/rest/controller/DmiRestControllerSpec.groovy
+++ b/src/test/groovy/org/onap/cps/ncmp/dmi/rest/controller/DmiRestControllerSpec.groovy
@@ -1,6 +1,7 @@
 /*
  *  ============LICENSE_START=======================================================
  *  Copyright (C) 2021 Nordix Foundation
+ *  Modifications Copyright (C) 2021 Bell Canada
  *  ================================================================================
  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
@@ -26,7 +27,6 @@ import org.onap.cps.ncmp.dmi.exception.DmiException
 import org.onap.cps.ncmp.dmi.exception.ModuleResourceNotFoundException
 import org.onap.cps.ncmp.dmi.exception.ModulesNotFoundException
 import org.onap.cps.ncmp.dmi.service.model.ModuleReference
-import org.onap.cps.ncmp.dmi.service.model.ModuleSchemaList
 import org.onap.cps.ncmp.dmi.model.ModuleSet
 import org.onap.cps.ncmp.dmi.model.ModuleSetSchemas
 import org.onap.cps.ncmp.dmi.model.YangResource
@@ -35,26 +35,25 @@ import org.onap.cps.ncmp.dmi.service.DmiService
 import org.spockframework.spring.SpringBean
 import org.springframework.beans.factory.annotation.Autowired
 import org.springframework.beans.factory.annotation.Value
-import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc
 import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest
+import org.springframework.context.annotation.Import
 import org.springframework.http.HttpStatus
 import org.springframework.http.MediaType
+import org.springframework.security.test.context.support.WithMockUser
 import org.springframework.test.web.servlet.MockMvc
 import spock.lang.Specification
 
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.put
 
-@WebMvcTest
-@AutoConfigureMockMvc(addFilters = false)
+@WebMvcTest(DmiRestController)
+@WithMockUser
+@Import(ObjectMapper)
 class DmiRestControllerSpec extends Specification {
 
     @SpringBean
     DmiService mockDmiService = Mock()
 
-    @SpringBean
-    ObjectMapper mockObjectMapper = Spy()
-
     @Autowired
     private MockMvc mvc
 
@@ -83,20 +82,6 @@ class DmiRestControllerSpec extends Specification {
             response.getContentAsString() == '{"schemas":[{"moduleName":"some-moduleName","revision":"some-revision","namespace":"some-namespace"}]}'
     }
 
-    def 'Get all modules for given cm handle with invalid json.'() {
-        given: 'REST endpoint for getting all modules'
-            def getModuleUrl = "$basePathV1/ch/node1/modules"
-        and: 'get modules for cmHandle throws an exception'
-            mockObjectMapper.readValue(_ as String, _ as ModuleSchemaList) >> { throw Mock(DmiException.class) }
-            mockDmiService.getModulesForCmHandle('node1') >> 'some-value'
-        when: 'post is being called'
-            def response = mvc.perform(post(getModuleUrl)
-                    .contentType(MediaType.APPLICATION_JSON))
-                    .andReturn().response
-        then: 'the status is as expected'
-            response.status == HttpStatus.INTERNAL_SERVER_ERROR.value()
-    }
-
     def 'Get all modules for given cm handle with exception handling of #scenario.'() {
         given: 'REST endpoint for getting all modules'
             def getModuleUrl = "$basePathV1/ch/node1/modules"
diff --git a/src/test/groovy/org/onap/cps/ncmp/dmi/service/DmiServiceImplSpec.groovy b/src/test/groovy/org/onap/cps/ncmp/dmi/service/DmiServiceImplSpec.groovy
index 9325d59b..d5353754 100644
--- a/src/test/groovy/org/onap/cps/ncmp/dmi/service/DmiServiceImplSpec.groovy
+++ b/src/test/groovy/org/onap/cps/ncmp/dmi/service/DmiServiceImplSpec.groovy
@@ -1,6 +1,7 @@
 /*
  *  ============LICENSE_START=======================================================
  *  Copyright (C) 2021 Nordix Foundation
+ *  Modifications Copyright (C) 2021 Bell Canada
  *  ================================================================================
  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
@@ -23,7 +24,6 @@ package org.onap.cps.ncmp.dmi.service
 import com.fasterxml.jackson.core.JsonProcessingException
 import com.fasterxml.jackson.databind.ObjectMapper
 import com.fasterxml.jackson.databind.ObjectWriter
-import org.onap.cps.ncmp.dmi.TestUtils
 import org.onap.cps.ncmp.dmi.config.DmiPluginConfig
 import org.onap.cps.ncmp.dmi.exception.CmHandleRegistrationException
 import org.onap.cps.ncmp.dmi.exception.DmiException
@@ -34,6 +34,7 @@ import org.onap.cps.ncmp.dmi.service.model.ModuleReference
 import org.onap.cps.ncmp.dmi.model.YangResource
 import org.onap.cps.ncmp.dmi.model.YangResources
 import org.onap.cps.ncmp.dmi.service.client.NcmpRestClient
+import org.onap.cps.ncmp.dmi.service.model.ModuleSchema
 import org.onap.cps.ncmp.dmi.service.operation.SdncOperations
 import org.springframework.http.HttpStatus
 import org.springframework.http.ResponseEntity
@@ -49,50 +50,35 @@ class DmiServiceImplSpec extends Specification {
     def mockSdncOperations = Mock(SdncOperations)
     def objectUnderTest = new DmiServiceImpl(mockDmiPluginProperties, mockNcmpRestClient, mockSdncOperations, spyObjectMapper)
 
-    def 'Call get modules for cm-handle on dmi Service.'() {
-        given: 'cm handle id'
-            def cmHandle = 'node1'
-        and: 'request operation returns OK'
-            def body = TestUtils.getResourceFileContent('ModuleSchema.json')
-            mockSdncOperations.getModulesFromNode(cmHandle) >> new ResponseEntity<String>(body, HttpStatus.OK)
-        when: 'get modules for cm-handle is called'
-            def result = objectUnderTest.getModulesForCmHandle(cmHandle)
-        then: 'result is equal to the response from the SDNC service'
-            result.toString().contains('moduleName: example-identifier')
-            result.toString().contains('revision: example-version')
-    }
-
-    def 'Call get modules for cm-handle with invalid json.'() {
-        given: 'cm handle id'
+    def ' Get modules for a cm-handle.'() {
+        given: 'a cm handle'
             def cmHandle = 'node1'
-        and: 'request operation returns invalid json'
-            def body = TestUtils.getResourceFileContent('ModuleSchema.json')
-            mockSdncOperations.getModulesFromNode(cmHandle) >> new ResponseEntity<String>('invalid json', HttpStatus.OK)
+        and: 'sdnc operations returns one module schema for the cmhandle'
+            def moduleSchema = new ModuleSchema(
+                identifier: "example-identifier",
+                namespace: "example:namespace",
+                version: "example-version")
+            mockSdncOperations.getModuleSchemasFromNode(cmHandle) >> List.of(moduleSchema)
         when: 'get modules for cm-handle is called'
             def result = objectUnderTest.getModulesForCmHandle(cmHandle)
-        then: 'a dmi exception is thrown'
-            thrown(DmiException)
-    }
-
-    def 'Call get modules for cm-handle and SDNC returns "bad request" status.'() {
-        given: 'cm handle id'
-            def cmHandle = 'node1'
-        and: 'get modules from node returns "bad request" status'
-            mockSdncOperations.getModulesFromNode(cmHandle) >> new ResponseEntity<String>('body', HttpStatus.BAD_REQUEST)
-        when: 'get modules for cm-handle is called'
-            objectUnderTest.getModulesForCmHandle(cmHandle)
-        then: 'dmi exception is thrown'
-            thrown(DmiException)
+        then: 'one module is returned'
+            result.schemas.size() == 1
+        and: 'module has expected values'
+            with(result.schemas[0]) {
+                it.getRevision() == moduleSchema.getVersion()
+                it.getModuleName() == moduleSchema.getIdentifier()
+                it.getNamespace() == moduleSchema.getNamespace();
+            }
     }
 
-    def 'Call get modules for cm-handle and SDNC returns OK with empty body.'() {
+    def 'no modules found for the cmhandle.'() {
         given: 'cm handle id'
             def cmHandle = 'node1'
-        and: 'get modules for cm-handle returns OK with empty body'
-            mockSdncOperations.getModulesFromNode(cmHandle) >> new ResponseEntity<String>('', HttpStatus.OK)
+        and: 'sdnc operations returns no modules'
+            mockSdncOperations.getModuleSchemasFromNode(cmHandle) >> Collections.emptyList();
         when: 'get modules for cm-handle is called'
             objectUnderTest.getModulesForCmHandle(cmHandle)
-        then: 'ModulesNotFoundException is thrown'
+        then: 'module not found exception is thrown'
             thrown(ModulesNotFoundException)
     }
 
@@ -140,14 +126,14 @@ class DmiServiceImplSpec extends Specification {
     def 'Get multiple module resources.'() {
         given: 'a cmHandle and module reference list'
             def cmHandle = 'some-cmHandle'
-            def moduleReference1 = new ModuleReference(name: 'name-1',revision: 'revision-1')
-            def moduleReference2 = new ModuleReference(name: 'name-2',revision: 'revision-2')
+            def moduleReference1 = new ModuleReference(name: 'name-1', revision: 'revision-1')
+            def moduleReference2 = new ModuleReference(name: 'name-2', revision: 'revision-2')
             def moduleList = [moduleReference1, moduleReference2]
         when: 'get module resources is invoked with the given cm handle and a module list'
             def result = objectUnderTest.getModuleResources(cmHandle, moduleList)
         then: 'get modules resources is called twice'
             2 * mockSdncOperations.getModuleResource(cmHandle, _) >>> [new ResponseEntity<String>('{"ietf-netconf-monitoring:output": {"data": "some-data1"}}', HttpStatus.OK),
-                                                                   new ResponseEntity<String>('{"ietf-netconf-monitoring:output": {"data": "some-data2"}}', HttpStatus.OK)]
+                                                                       new ResponseEntity<String>('{"ietf-netconf-monitoring:output": {"data": "some-data2"}}', HttpStatus.OK)]
         and: 'the result is a yang resources object with the expected names, revisions and yang-sources'
             def yangResources = new YangResources()
             def yangResource1 = new YangResource(yangSource: '"some-data1"', moduleName: 'name-1', revision: 'revision-1')
@@ -160,7 +146,7 @@ class DmiServiceImplSpec extends Specification {
     def 'Get a module resource with module resource not found exception for #scenario.'() {
         given: 'a cmHandle and module reference list'
             def cmHandle = 'some-cmHandle'
-            def moduleReference = new ModuleReference(name: 'NAME',revision: 'REVISION')
+            def moduleReference = new ModuleReference(name: 'NAME', revision: 'REVISION')
             def moduleList = [moduleReference]
         when: 'get module resources is invoked with the given cm handle and a module list'
             objectUnderTest.getModuleResources(cmHandle, moduleList)
@@ -216,8 +202,8 @@ class DmiServiceImplSpec extends Specification {
             mockSdncOperations.getResouceDataForOperationalAndRunning(cmHandle, resourceId, optionsParam, acceptHeaderParam, contentQuery) >> new ResponseEntity<>('response json', HttpStatus.OK)
         when: 'get resource data from cm handles service method invoked'
             def response = objectUnderTest.getResourceDataOperationalForCmHandle(cmHandle,
-                    resourceId, acceptHeaderParam,
-                    optionsParam, null)
+                resourceId, acceptHeaderParam,
+                optionsParam, null)
         then: 'response have expected json'
             response == 'response json'
     }
@@ -232,8 +218,8 @@ class DmiServiceImplSpec extends Specification {
             mockSdncOperations.getResouceDataForOperationalAndRunning(cmHandle, resourceId, optionsParam, acceptHeaderParam, _ as String) >> new ResponseEntity<>(HttpStatus.NOT_FOUND)
         when: 'get resource data from cm handles service method invoked'
             objectUnderTest.getResourceDataOperationalForCmHandle(cmHandle,
-                    resourceId, acceptHeaderParam,
-                    optionsParam, null)
+                resourceId, acceptHeaderParam,
+                optionsParam, null)
         then: 'resource data not found'
             thrown(ResourceDataNotFound.class)
     }
@@ -247,11 +233,11 @@ class DmiServiceImplSpec extends Specification {
             def contentQuery = 'content=config'
         and: 'sdnc operation returns OK response'
             mockSdncOperations.getResouceDataForOperationalAndRunning(cmHandle, resourceId, optionsParam,
-                    acceptHeaderParam, contentQuery) >> new ResponseEntity<>('response json', HttpStatus.OK)
+                acceptHeaderParam, contentQuery) >> new ResponseEntity<>('response json', HttpStatus.OK)
         when: 'get resource data from cm handles service method invoked'
             def response = objectUnderTest.getResourceDataPassThroughRunningForCmHandle(cmHandle,
-                    resourceId, acceptHeaderParam,
-                    optionsParam, null)
+                resourceId, acceptHeaderParam,
+                optionsParam, null)
         then: 'response have expected json'
             response == 'response json'
     }
@@ -261,7 +247,7 @@ class DmiServiceImplSpec extends Specification {
             mockSdncOperations.writeResourceDataPassthroughRunning(_, _, _, _) >> new ResponseEntity<String>('response json', httpResponse)
         when: 'write resource data for cm handle method invoked'
             def response = objectUnderTest.writeResourceDataPassthroughForCmHandle('some-cmHandle',
-                    'some-resourceIdentifier', 'some-dataType', '{some-data}')
+                'some-resourceIdentifier', 'some-dataType', '{some-data}')
         then: 'the response contains the expected json data from sdnc'
             response == 'response json'
         where: 'the following values are used'
@@ -273,10 +259,10 @@ class DmiServiceImplSpec extends Specification {
     def 'Write resource data using for passthrough running for the given cm handle with #scenario.'() {
         given: 'sdnc returns a created response'
             mockSdncOperations.writeResourceDataPassthroughRunning('some-cmHandle',
-                    'some-resourceIdentifier', 'some-dataType', requestBody) >> new ResponseEntity<String>('response json', HttpStatus.CREATED)
+                'some-resourceIdentifier', 'some-dataType', requestBody) >> new ResponseEntity<String>('response json', HttpStatus.CREATED)
         when: 'write resource data from cm handles service method invoked'
             def response = objectUnderTest.writeResourceDataPassthroughForCmHandle('some-cmHandle',
-                    'some-resourceIdentifier', 'some-dataType', requestBody)
+                'some-resourceIdentifier', 'some-dataType', requestBody)
         then: 'response have expected json'
             response == 'response json'
         where: 'given request body'
@@ -290,7 +276,7 @@ class DmiServiceImplSpec extends Specification {
             mockSdncOperations.writeResourceDataPassthroughRunning(_, _, _, _) >> new ResponseEntity<String>('response json', HttpStatus.INTERNAL_SERVER_ERROR)
         when: 'write resource data for pass through method is invoked'
             objectUnderTest.writeResourceDataPassthroughForCmHandle('some-cmHandle',
-                    'some-resourceIdentifier', 'some-dataType', _ as String)
+                'some-resourceIdentifier', 'some-dataType', _ as String)
         then: 'a dmi exception is thrown'
             thrown(DmiException.class)
     }
diff --git a/src/test/groovy/org/onap/cps/ncmp/dmi/service/operation/SdncOperationsSpec.groovy b/src/test/groovy/org/onap/cps/ncmp/dmi/service/operation/SdncOperationsSpec.groovy
index 4411971a..2ce870ab 100644
--- a/src/test/groovy/org/onap/cps/ncmp/dmi/service/operation/SdncOperationsSpec.groovy
+++ b/src/test/groovy/org/onap/cps/ncmp/dmi/service/operation/SdncOperationsSpec.groovy
@@ -1,6 +1,7 @@
 /*
  *  ============LICENSE_START=======================================================
  *  Copyright (C) 2021 Nordix Foundation
+ *  Modifications Copyright (C) 2021 Bell Canada
  *  ================================================================================
  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
@@ -20,12 +21,16 @@
 
 package org.onap.cps.ncmp.dmi.service.operation
 
+import org.onap.cps.ncmp.dmi.TestUtils
 import org.onap.cps.ncmp.dmi.config.DmiConfiguration
+import org.onap.cps.ncmp.dmi.exception.SdncException
 import org.onap.cps.ncmp.dmi.service.client.SdncRestconfClient
 import org.spockframework.spring.SpringBean
 import org.springframework.beans.factory.annotation.Autowired
 import org.springframework.boot.test.context.SpringBootTest
 import org.springframework.http.HttpHeaders
+import org.springframework.http.HttpStatus
+import org.springframework.http.ResponseEntity
 import org.springframework.test.context.ContextConfiguration
 import spock.lang.Specification
 
@@ -39,14 +44,59 @@ class SdncOperationsSpec extends Specification {
     @Autowired
     SdncOperations objectUnderTest
 
-    def 'call get modules from node to SDNC.'() {
+    def 'get modules from node.'() {
         given: 'node id and url'
             def nodeId = 'node1'
             def expectedUrl = '/rests/data/network-topology:network-topology/topology=test-topology/node=node1/yang-ext:mount/ietf-netconf-monitoring:netconf-state/schemas'
-        when: 'called get modules from node'
-            objectUnderTest.getModulesFromNode(nodeId)
-        then: 'the get operation is executed with the correct URL'
-            1 * mockSdncRestClient.getOperation(expectedUrl)
+        and: 'sdnc returns one module in response'
+            mockSdncRestClient.getOperation(expectedUrl) >>
+                ResponseEntity.ok(TestUtils.getResourceFileContent('ModuleSchema.json'))
+        when: 'get modules from node is called'
+            def moduleSchemas = objectUnderTest.getModuleSchemasFromNode(nodeId)
+        then: 'one module is found'
+            moduleSchemas.size() == 1
+        and: 'module schema has expected values'
+            with(moduleSchemas[0]) {
+                it.getIdentifier() == "example-identifier"
+                it.getNamespace() == "example:namespace"
+                it.getVersion() == "example-version"
+                it.getFormat() == "example-format"
+                it.getLocation() == ["example-location"]
+            }
+    }
+
+    def 'No modules from Node: SDNC Response - #scenario .'() {
+        given: 'node id and url'
+            def nodeId = 'node1'
+            def expectedUrl = '/rests/data/network-topology:network-topology/topology=test-topology/node=node1/yang-ext:mount/ietf-netconf-monitoring:netconf-state/schemas'
+        and: 'sdnc operation returns #scenario'
+            mockSdncRestClient.getOperation(expectedUrl) >> ResponseEntity.ok(responseBody)
+        when: 'modules from node is called'
+            def moduleSchemas = objectUnderTest.getModuleSchemasFromNode(nodeId)
+        then: 'no modules are returned'
+            moduleSchemas.size() == 0
+        where:
+            scenario               | responseBody
+            'empty response body ' | ''
+            'no module schema'     | '{ "ietf-netconf-monitoring:schemas" : { "schema" : [] } } '
+    }
+
+    def 'Error handling - modules from node: #scenario'() {
+        given: 'node id and url'
+            def nodeId = 'node1'
+            def expectedUrl = '/rests/data/network-topology:network-topology/topology=test-topology/node=node1/yang-ext:mount/ietf-netconf-monitoring:netconf-state/schemas'
+        and: 'sdnc operation returns configured response'
+            mockSdncRestClient.getOperation(expectedUrl) >> new ResponseEntity<>(sdncResponseBody, sdncHttpStatus)
+        when: 'modules for node are fetched'
+            objectUnderTest.getModuleSchemasFromNode(nodeId)
+        then: 'SDNCException is thrown'
+            def thrownException = thrown(SdncException)
+            thrownException.getDetails().contains(expectedExceptionDetails)
+        where:
+            scenario                             | sdncHttpStatus         | sdncResponseBody                        || expectedExceptionDetails
+            'failed response from SDNC'          | HttpStatus.BAD_REQUEST | '{ "errorMessage" : "incorrect input"}' || '{ "errorMessage" : "incorrect input"}'
+            'invalid json response'              | HttpStatus.OK          | 'invalid-json'                          || 'SDNC response is not in the expected format'
+            'response in unexpected json schema' | HttpStatus.OK          | '{ "format" : "incorrect" }'            || 'SDNC response is not in the expected format'
     }
 
     def 'Get module resources from SDNC.'() {
@@ -64,7 +114,7 @@ class SdncOperationsSpec extends Specification {
             def expectedUrl = '/rests/data/network-topology:network-topology/topology=test-topology/node=node1/yang-ext:mount/testResourceId?a=1&b=2&content=testContent'
         when: 'called get modules from node'
             objectUnderTest.getResouceDataForOperationalAndRunning('node1', 'testResourceId',
-                    '(a=1,b=2)', 'testAcceptParam', 'content=testContent')
+                '(a=1,b=2)', 'testAcceptParam', 'content=testContent')
         then: 'the get operation is executed with the correct URL'
             1 * mockSdncRestClient.getOperation(expectedUrl, _ as HttpHeaders)
     }
@@ -73,30 +123,30 @@ class SdncOperationsSpec extends Specification {
         given: 'expected url, topology-id, sdncOperation object'
             def expectedUrl = '/rests/data/network-topology:network-topology/topology=test-topology/node=node1/yang-ext:mount/testResourceId'
         when: 'write resource data for pass through running is called'
-            objectUnderTest.writeResourceDataPassthroughRunning('node1','testResourceId','application/json','requestData')
+            objectUnderTest.writeResourceDataPassthroughRunning('node1', 'testResourceId', 'application/json', 'requestData')
         then: 'the post operation is executed with the correct URL and data'
             1 * mockSdncRestClient.postOperationWithJsonData(expectedUrl, 'requestData', _ as HttpHeaders)
     }
 
     def 'build query param list for SDNC where options contains a #scenario'() {
         when: 'build query param list is called with #scenario'
-            def result = objectUnderTest.buildQueryParamList(optionsParamInQuery,'d=4')
+            def result = objectUnderTest.buildQueryParamList(optionsParamInQuery, 'd=4')
         then: 'result equals to expected result'
             result == expectedResult
         where: 'following parameters are used'
-            scenario                  | optionsParamInQuery || expectedResult
-            'single key-value pair'   | '(a=x)'             || ['a=x','d=4']
-            'multiple key-value pairs'| '(a=x,b=y,c=z)'     || ['a=x','b=y','c=z','d=4']
-            '/ as special char'       | '(a=x,b=y,c=t/z)'   || ['a=x','b=y','c=t/z','d=4']
-            '" as special char'       | '(a=x,b=y,c="z")'   || ['a=x','b=y','c="z"','d=4']
-            '[] as special char'      | '(a=x,b=y,c=[z])'   || ['a=x','b=y','c=[z]','d=4']
-            '= in value'              | '(a=(x=y),b=x=y)'   || ['a=(x=y)','b=x=y','d=4']
+            scenario                   | optionsParamInQuery || expectedResult
+            'single key-value pair'    | '(a=x)'             || ['a=x', 'd=4']
+            'multiple key-value pairs' | '(a=x,b=y,c=z)'     || ['a=x', 'b=y', 'c=z', 'd=4']
+            '/ as special char'        | '(a=x,b=y,c=t/z)'   || ['a=x', 'b=y', 'c=t/z', 'd=4']
+            '" as special char'        | '(a=x,b=y,c="z")'   || ['a=x', 'b=y', 'c="z"', 'd=4']
+            '[] as special char'       | '(a=x,b=y,c=[z])'   || ['a=x', 'b=y', 'c=[z]', 'd=4']
+            '= in value'               | '(a=(x=y),b=x=y)'   || ['a=(x=y)', 'b=x=y', 'd=4']
     }
 
     def 'options parameters contains a comma #scenario'() {
         // https://jira.onap.org/browse/CPS-719
         when: 'build query param list is called with #scenario'
-            def result = objectUnderTest.buildQueryParamList(optionsParamInQuery,'d=4')
+            def result = objectUnderTest.buildQueryParamList(optionsParamInQuery, 'd=4')
         then: 'expect 2 elements from options +1 from content query param (2+1) = 3 elements'
             def expectedNoOfElements = 3
         and: 'results contains more elements than expected'