aboutsummaryrefslogtreecommitdiffstats
path: root/cps-rest/src
AgeCommit message (Collapse)AuthorFilesLines
2022-09-13Handle partial failure (improvements)ToineSiebelink1-1/+2
- catching of failures on retry of individual nodes - extract cm handle id from xpaths (can only report xpaths in cps core) - add test for same Issue-ID: CPS-1232 Issue-ID: CPS-1126 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Ice2032c8b15fea97ae0aaa4d1ed642b3499228fa
2022-08-25Performance Improvement: Batch Update DataNodeslukegleeson2-4/+4
Implemented methods to perform a batch operation on updating datanodes Refactored replace data node(s) tree methods to update data node(s) and descendants Issue-ID: CPS-1203 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I365d657422b19c9ce384110c9a23d041eaed06f4
2022-04-25Fix Absolute Path to list with Integer/String keyLathish1-1/+0
- Introduced normalizedXpath to normalize the xpath and cpspath - Introduced normalizedAncestorpath to normalize the ancestor path in xpath and cpspath - Added new condition in the ANTLR Grammar to capture the invalid path in the xpath - Introduced PathParsingException to replace the IllegalStateException Issue-ID: CPS-961 Change-Id: Ie10f5c6cfc466387e79eec184b933297d1d79587 Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
2022-03-30Additional validation for names/identifiersDylanB95EST1-4/+3
Implementing additional regex validation for names/identifiers in CPS - Introduces a CpsValidator - Applies to relevent java public API's - Tests have been updated where necessary Issue-ID: CPS-322 Change-Id: I29ab8820bb1fe0eee247e425d6bb018bcd38f28e Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-03-10Replacing ModelMapper with MapStructlukegleeson6-78/+109
- Removed Model Mapper from pom files - Replaced ModelMapper with MapStruct - Added Tests for MapStruct - Changed mapstruct annotations for individual variables to be null safe rather than all variables - Excluded generated code from code coverage - Set ModuleReferences input to required for SchemaSet so that ModuleReferences list set to empty list rather than null Issue-ID: CPS-127 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I43f874aea79f58dda5526c6fdead27d8474d90af
2022-03-01Create Endpoint For Get Cm Handles By NameDylanB95EST1-10/+5
Create endpoint and implement logic for get cm handle details by cm handle name Issue-ID: CPS-817 Change-Id: I83bd2da9219d13fac715a08b19108028ca6f6751 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-02-17Align JSON DataNode for Get and Post/Put API in CPSputhuparambil.aditya4-13/+17
Issue-ID: CPS-865 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I60b1f9c94e79bdd66d60fe6a68f5fc4adc718d35
2022-02-14Improve logging in NCMPsourabh_sourabh1-0/+3
- Code to change to apply logs at runtime - Fix for minor code smell Issue-ID: CPS-855 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I93a556fe0fb7ca05a42e84eb5ec4f84afaa8fd92
2022-01-27Merge "Improve logging in NCMP"Toine Siebelink1-4/+1
2022-01-25Improve logging in NCMPsourabh_sourabh1-4/+1
Issue-ID: CPS-855 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I5d8a6a711d1c6b13d5d8eeba52a1dcd689dbdae2
2022-01-25Replace gson mapper with jackson mappersourabh_sourabh5-36/+45
We introduced JsonObjectMapper (wapper) as Spring component. Issue-ID: CPS-751 Change-Id: I536b0771a3a263325e6907717baf6941d70c0d6c Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2022-01-07CPS-Core: Unable to parse JSON input with space for POST endpointsourabh_sourabh2-30/+31
Issue-ID: CPS-831 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: If2f5f7034f05763990001c9dd8ccd9d8dc0099cf
2021-12-02Adding examples in openapi for cps-coreputhuparambil.aditya3-48/+45
1. Added examples for all parameters, request body and response body 2. Changed the response/request type to Object from String for all json objects 3. Passed json format data in all tests 4. PUT and PATCH operations at present return empty response, hence examples are changed to be in sync Issue-ID: CPS-780 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: If6dd5bb48df4e1bbf1026eaadf315df8f972e282
2021-11-23CPS-314: Delete Dataspaceniamhcore3-1/+28
Issue-ID: CPS-314 Change-Id: I778e2b784c7b1ff3fecc1036425708dc4ec73227 Signed-off-by: niamhcore <niamh.core@est.tech>
2021-11-02Delete DataNode (xpath) for a given AnchorDylanB95EST2-0/+30
Delete Datanode within CPS. Deprecates delete functionality of /v1/dataspaces/{dataspace-name}/anchors/{anchor-name}/list-nodes. New api is backwards compatible with this API Issue-ID: CPS-313 Change-Id: I110c4ab1446e8a1399a0d9bf89c0be614a9104df Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-11-02Clean Up Code around List NodesDylanB95EST2-33/+28
Make sure code refers clearly to List (whole) nodes or List elements incl. method names, parameter names, test descriptions etc. Issue-ID: CPS-756 Change-Id: Ic9dae6565c0e84c1ba4c2d6e891d3ea307f589da Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-09-01Add ncmp endpoints to swagger-uiRenu Kumari9-822/+2
- added ncmp-enpoints to swagger-ui - removed springfox dependencies - removed Docket configuration as we are loading ui from openapi.yml - removed endpoints which are not implemented - Fixed ncmp basepath as per CPS-616 Issue-ID: CPS-601 Issue-ID: CPS-616 Signed-off-by: Renu Kumari <renu.kumari@bell.ca> Change-Id: I03c7789f48a12d3ffd5fcb934d7ba6347d4044e4
2021-08-30Change the list-node rest interfaceRenu Kumari3-8/+8
- Changed the list-node interface to be consistent with datanode api Issue-ID: CPS-598 Signed-off-by: Renu Kumari <renu.kumari@bell.ca> Change-Id: Ic99828f1463e9a724244c05166e477581756f602
2021-08-25Add optional observed timestamp in the cps data apiaditya puthuparambil7-95/+275
- Added optional query parameter in cps data endpoints - Updated service layer and notification to use observedTimestamp Note: - NCMP REST endpoints are not updated as a part of this patch - NCMP does not sent observed timestamp when using cps data services Issue-ID: CPS-477 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I1f92da3da7b3a13c45405fdf44e5fef861991d9a Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
2021-08-18Delete list-node p2 rest layerlukegleeson3-0/+42
Issue-ID: CPS-361 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I5fb8d202fc0a65679d10377cc2959a7f8f854ca7
2021-08-11Merge "Update response query format"aditya puthuparambil2-4/+15
2021-08-11Update response query formatniamhcore2-4/+15
Issue-ID: CPS-560 Change-Id: I1c71270a8cde7e940c5af80bc743d0f01ab6b9bb Signed-off-by: niamhcore <niamh.core@est.tech>
2021-08-10Upgrade Swager Codegen-maven-pluginJosephKeenan5-48/+22
- Removed swagger annotations dependency as latest plugin generates code using v3 annotations. - updated the method signature as per the new generated code - removed unnecessary mock springbeans from the WebMvcTest Issue-ID: CPS-205 Change-Id: Ie7911d7389dca587bde945d913f458de46027e0f Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2021-07-16CPS-401 Update Open API YAML with data types and example for output (cpsData)JosephKeenan5-0/+749
-added response for get data nodes based on dataspace and anchor -modified modelmapper jn DataRestControllerSpec to be Spy not Mock -when openapi.yaml is entered into https://editor.swagger.io/ it displays however locally it does not, This may be due to file segmentation but this is still unclear. -moved files from docs/openapi to src/main/resources/static as required for new swagger sprindoc Issue-ID: CPS-401 Change-Id: I45286530d9a9ca85b56c0a656a44675398a003f4 Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2021-07-13Editing of Nordix Licenses to ONAP guidelineslukegleeson10-15/+26
Issue-ID: CPS-489 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I415534515b3d8325f41d5dc1d02c6e0ae70c6cf1
2021-07-09Support concurrent requests to create schema setsBruno Sakoto1-1/+4
Issue-ID: CPS-466 Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca> Change-Id: I2ecf98b9aa5a6097518e616c08f8bb2a2182a613
2021-06-21Sonar Qube code smell clean upDylanB95EST1-2/+2
Declaring Local Variable with Var Instead Issue-ID: CPS-475 Change-Id: I94bb6d4a3234cd9abeba5a495bd2d0439c21c1df Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-06-18Merge "Missing licence info added in pom file"Bruno Sakoto1-0/+16
2021-06-18Missing licence info added in pom fileshivasubedi1-0/+16
- Added licence info to files that were missing it - Fixed licence info to match with the creator of the file Issue-ID: CPS-467 Signed-off-by: shivasubedi <shiva.subedi@est.tech> Change-Id: I1c0eaedb2c87743a61a1cd58f33b0d0d04b3a977
2021-06-15[OpenAPI] Implemented example as per example wiki page for getting anchors ↵JosephKeenan2-8/+71
based on dataspace -moved components from cpsAdmin.yml to components.yml -refactored variable for anchor details list in AdminRestController.java -reintrocuded paramter for anchorsByDataspace -refactored variables in AdminRestController.java getAnchors() to be more intuitive -refactored AdminRestController.java to use modelmapper and removed extra conversion code. Also modified AdminRestControllerSpec.groovy to use ModelMapper as Spy rather than a Mock -added responses for getAnchor & getSchemaSet -added javadoc for AdminRestController.java public methods -refactored schemaDetils pararmeter from dataSpasceName to name for CSOT tests & added some code review comments Issue-ID: CPS-429 Change-Id: I01d4113313c9a23d9a7e0e96e46b90f9ac767f24 Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2021-06-01Introducing Antlr4 for cpsPath parsingToineSiebelink1-11/+12
-created new module for cpPathParser -added antlr rule for cpsPathWithSingleLeafCondition -added antlr rule for cpsPathWithDescendant (and with leaf conditions) -added antlr rule for ancestor axis -added unit test (copied from existing CpsPathQuerySpec) -udpated cps-ri to use new cpPathQuery from parser module -'imported' lexer rules from publix xPath grammar -Re-used existing CpsPathException but conversion happens in cps-ri to prevent additional dependency in cps-path-parser module Issue-ID: CPS-376 Change-Id: I2c5df98969402cbf69f6573c52705879450ce606 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2021-05-25Replace list-node content (part 2): CPS REST layerRuslan Kashapov2-1/+24
Issue-ID: CPS-362 Change-Id: I46dc9b48758fa10a47a648aa4e6a63775466234b Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
2021-05-20Response code fix (Bad Request instead of Not Found) when modifying ↵Ruslan Kashapov2-2/+30
non-existent node. Issue-ID: CPS-422 Change-Id: I6652f8bcafb9938ce588be3d0a0d2bb1672723b0 Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
2021-05-11Create list-node elements (part2): CPS REST layerRuslan Kashapov2-5/+26
Issue-ID: CPS-360 Change-Id: Iaca8baff085e1659453c06ce0dee0203aa007b4a Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
2021-04-29Investigate and update Spock versionshivasubedi5-18/+1
Issue-ID: CPS-368 Signed-off-by: shivasubedi <shiva.subedi@est.tech> Change-Id: Ie8505cf29068660af6bc6b9887f593f7e3be074f
2021-04-28- Remove redundant and misleading testsToineSiebelink1-29/+11
- Some small improvemnt to tets ins same class Issue-ID: CPS-325 Change-Id: I0d888dbd9db555508b23e37957098b7b4d518912 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2021-04-28Fix Code smellsshivasubedi4-14/+11
Issue-ID: CPS-89 Change-Id: Ib1b6fbc6b6d712f169100825683e6db3e7c85cb9 Signed-off-by: shivasubedi <shiva.subedi@est.tech>
2021-04-26Get Data under anchor using single rootRishi.Chail2-6/+3
Issue-ID: CPS-325 Signed-off-by: Rishi.Chail <rishi.chail@est.tech> Change-Id: Id8da3d767199c5767c625b55d175ac6791dcca48
2021-04-20Create child data node (part 1): CPS service + RESTRuslan Kashapov2-9/+44
Issue-ID: CPS-337 Change-Id: I9c5c62d144b5301ac80e2b82a5cc66a980dad011 Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
2021-04-07Fix SonarQube violationsToineSiebelink1-1/+1
- Used @SupressWarning where issue was casued by 3PP we have not control over - Remove TODO's which are now addt to backlog as new JIRA's; CPS-324 and CPS-325 Issue-ID: CPS-89 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Ieb64fd6d3f09144f6dea965c0aee3aefa6ec253c
2021-04-07Merge "Fix upload size to be greater than 1MB"Bruno Sakoto2-0/+28296
2021-04-07Fix upload size to be greater than 1MBniamhcore2-0/+28296
Issue-ID: CPS-308 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I1de6efa882f85cf6f9054e3ef38ed6e0bd99d7be
2021-04-07Delete anchor part 2: cps restRuslan Kashapov2-8/+22
Issue-ID: CPS-312 Change-Id: I08f92dfff3188bd96a69ec2ae01e0d0891b81d87 Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
2021-04-06Fix for security hotspot related to safe archive expansionputhuparambil.aditya3-8/+198
https://sonarcloud.io/project/security_hotspots?id=onap_cps&hotspots=AXfObcsqA2pnU4Plp4-g Issue-ID: CPS-289 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: Ibe8627413fc9e3964cdc5bb98caf5e25fa4f3a95
2021-03-29Fix for AlreadyDefinedException test.niamhcore1-6/+6
Issue-ID: CPS-290 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: Id3e3764b00dfd462fd20a5c9ded68f8d507e8119
2021-03-24Internal Server Error when creating the same data node twiceniamhcore4-29/+23
This change adds a generic exception handler class for a already defined object and handles a JsonSyntaxException. Issue-ID: CPS-290 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: Ie645237b5dd5b8e2b1d074c5613e7da560f57484
2021-03-18Fix code smellsRishi.Chail1-2/+2
1. removed typedefs annotation 2. chnaged final string constant name Issue-ID: CPS-89 Signed-off-by: Rishi.Chail <rishi.chail@est.tech> Change-Id: I524aa8c13e8bb4c6a00d810c6e89b30a48f37d10
2021-03-12Merge "Move web security configuration to application module"Toine Siebelink6-170/+30
2021-03-12Move web security configuration to application moduleRuslan Kashapov6-170/+30
Issue-ID: CPS-288 Change-Id: Ieba184c3e4727e354c19a3db31325052d15ced44 Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
2021-03-11Exception stack trace is exposedniamhcore2-38/+16
Issue-ID: CPS-249 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I1e03c17364c925c6f976f2147cb17f8ac26ba995