summaryrefslogtreecommitdiffstats
path: root/cps-ncmp-service
AgeCommit message (Collapse)AuthorFilesLines
2024-08-21Release cps3.5.2jenkins-releng1-1/+1
2024-08-21Merge "[BUG] Blank alternateId overwrites existing"Priyank Maheshwari3-11/+16
2024-08-21Merge "Revert "Remove trust level entries from cache when cm handles deleted""Daniel Hanrahan10-150/+73
2024-08-21Revert "Remove trust level entries from cache when cm handles deleted"Lee Anjella Macabuhay10-150/+73
This reverts commit 77b8e25e14e698c853334ef57459c21d7813911a. Reason for revert: Performance degredation Change-Id: Ibd88e626189d821680568c63952b95e7d1e05dc4 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-08-21[BUG] Blank alternateId overwrites existingdanielhanrahan3-11/+16
During CM-handle update, a blank "" alternateId will overwrite an already-set alternateId. Additionally during registration, if an alternateId consisting of whitespace is supplied, it will be persisted with whitespace. This fixes both issues by using isBlank/isNotBlank consistently. Issue-ID: CPS-2372 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I44e536cf87a31c6e975a82ed37769c1d2548653a
2024-08-21Merge "Faster alternate-id checks during registration (CPS-2366 #2)"Priyank Maheshwari5-24/+59
2024-08-21Merge "Refactoring alternate ID checker (CPS-2366 #1)"Priyank Maheshwari2-103/+49
2024-08-21Remove trust level entries from cache when cm handles deletedhalil.cakal10-73/+150
- handle removal of device trust levels from the cache when cm handles deleted - handle initial dmi registration inside trust level manager - add get effective trust level function to trust level manager for get and query cm handle APIs (to set trust level on the return object) Issue-ID: CPS-2315 Change-Id: I8daa4a2ad8310de10e35fdc50351deb85fd3ffd0 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Signed-off-by: halil.cakal <halil.cakal@est.tech>
2024-08-20Faster alternate-id checks during registration (CPS-2366 #2)danielhanrahan5-24/+59
This improves performance when using alternate ID in registration. Instead of one CPS path query for each alternate ID, it sends one query for the whole batch using OR operator, e.g. /dmi-registry/cm-handles[@alternate-id='A' or @alternate-id='B'] Issue-ID: CPS-2366 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I5b10437f4a01c886b3c84e46ac727e0e79917589
2024-08-20Refactoring alternate ID checker (CPS-2366 #1)danielhanrahan2-103/+49
Issue-ID: CPS-2366 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I07228a130ebdab0e2782e54255b5e8cc34c8d77e
2024-08-16Get data job result from DMIleventecsanyi5-0/+185
- added DataJobResult interface - extended the DmiRestClient to retrieve status - added mock response to DmiDispatcher Issue-ID: CPS-2296 Change-Id: I551afd827cccd91c5f9837bd4923b30320865d55 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-08-16Merge "Refactored Data Job interfaces"Priyank Maheshwari7-29/+33
2024-08-14Merge "Support alternate Id interface for CPS-E-05 #2"Lee Anjella Macabuhay11-25/+111
2024-08-13CPS-NCMP: Slow cmHandle registration when we use moduleSetTag, alternateId ↵sourabh_sourabh2-43/+21
and dataProducerIdentifier - Created a new repo. service for fragment table that executes a native sql query to find first ready cm handle id based on moduleset tag and then returns list of module references. - Exposed a new interface into module service that is used by module sync service to get list of midule refs by module set tag. Issue-ID: CPS-2353 Change-Id: I438dbd1ed37c1ff4e15f792e93a095aa604120bc Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-08-13Refactored Data Job interfacesleventecsanyi7-29/+33
-modified writejob & status endpoints Issue-ID: CPS-2360 Change-Id: I87647f59493886593825f5175c6ed708e55b3e30 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-08-12Support alternate Id interface for CPS-E-05 #2seanbeirne11-25/+111
- Supports Alternate Ids for getResourceDataForCmHandle Issue-Id: CPS-2279 Change-Id: I1f145308cec5b545fab2d5c96efbc00fc3a110f4 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-08-06Merge "Handle null NcmpOut event"Lee Anjella Macabuhay3-16/+40
2024-08-06Handle null NcmpOut eventmpriyank3-16/+40
- Handling null event in the Cm Subscription delete use case. - creating taskKey as concat of subscription-id and event type - added relevant test case to cover the branch Issue-ID: CPS-2351 Change-Id: I75a6fa9d4cddd24a5e288be065dffc46f6bbe886 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-08-02Updating CM Data Notification Event Schemasourabh_sourabh3-16/+7
- Updated "avc-event-schema" value attribute to accept type object. - Modified cm avc event consumer to not wrap received event into another cloud event using "CloudEventBuilder.from" Issue-ID: CPS-2299 Change-Id: I3b2acd53a3939d992b337e98debb7f62f3a528dd Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-08-01Merge "Handle duplicate targets NcmpOut event"Lee Anjella Macabuhay2-6/+8
2024-08-01XML content support on add list elementRudrangi Anupriya4-5/+6
Issue-ID: CPS-2287 Change-Id: Ibb7ffb66ccbb03703266132c6d5c2eade0e7cb4a Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2024-07-31Handle duplicate targets NcmpOut eventmpriyank2-6/+8
- Accpted , Rejected and Pending targets in the NcmpOut response to have unique values hence changing the datastructre to Set. Issue-ID: CPS-2338 Change-Id: I24a109fad4c854eff1b052df38947cc121445bb9 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-31Effect changes on scheduled tasks (don't want scheduled tasks to be monitored)sourabh_sourabh4-102/+173
- Applied a filter on tasks.scheduled.execution. - It is configurable from application.ymal into cps.scheduled-task-names: - tasks.scheduled.execution by default. - Added a new property configuration bean for open telemetry. - Introduced new propery attribute that takes list of task names to be filtered. Issue-ID: CPS-2250 Change-Id: I8e5334cd166343181df6dd1985471f5465f14f0e Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-26Delete Subscription methodemaclee12-54/+273
Issue-ID: CPS-2253 Change-Id: I30768dc431e13d0bac0dcc7b9b16cb0854f06702 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-07-26Merge "Added missing authorization header to DataJobService"Sourabh Sourabh5-18/+35
2024-07-26Added missing authorization header to DataJobServiceleventecsanyi5-18/+35
- added auth header to the interface & updated testware Issue-ID: CPS-2330 Change-Id: I091fc5c3c3fa323024f55055129cc7240732479a Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-07-25Get data job status from DMI Pluginleventecsanyi5-0/+198
- added java interface - extended DmiRestClient to get data job status - added testware Issue-ID: CPS-2296 Change-Id: If9006bba06397724c15bdc3bdf1bd52a0188f002 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-07-25Integration test for the writeDataJobleventecsanyi2-2/+3
- added Stub controller - created integration test for writeDataJob Issue-ID: CPS-2236 Change-Id: I067a11dc5bfe629d50128cf303b2a81abc75a348 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-07-25Merge "Fix dataProducerId in SubJobWriteRequest"Sourabh Sourabh2-10/+10
2024-07-24Fix timing issue for data sync CSITdanielhanrahan1-4/+5
The default data sync watchdog sleep time is 30 seconds, while the CSIT only waits 10 seconds for data sync to run. This is leading to intermittent failures. - increase CSIT time out to 40 seconds for data sync operation - adjust log levels for data sync so that issues are easier to debug Issue-ID: CPS-2313 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I3ceb9097bf357f47e5d49f84c70b1c711b52171a
2024-07-24Fix dataProducerId in SubJobWriteRequestleventecsanyi2-10/+10
Issue-ID: CPS-2322 Change-Id: I7bfdfd05ffacb085ac056707d477f348cb5bd64f Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-07-17Merge "CPS NCMP: Add state tags to cps.ncmp.lcm.events.publish metrics"Daniel Hanrahan2-9/+101
2024-07-16CPS NCMP: Add state tags to cps.ncmp.lcm.events.publish metricssourabh_sourabh2-9/+101
- Added cm handle state into micrometer Timer as an extra tags while capturing total time taken to publish a LCM events for publishLcmEvent method. Issue-ID: CPS-2123 Change-Id: I6357c628496700fee7448dbc381a7e0e62d8b540 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-16XML content support on replace a node with descendantsRudrangi Anupriya2-6/+8
Issue-ID: CPS-2282 Change-Id: Ibb7ffb65ccbb03703266712c6d5c2eade0e7ab4b Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2024-07-15Mapper to group Subscription Details for DMImpriyank3-0/+185
- introduced a mapper to group a collection of subscription keys(datastore cmhandle and xpath ) based on datastore and xpath - the information will be used to send out to the dmi plugin Issue-ID: CPS-2312 Change-Id: I99f509eb5b4a8c3a7fb1078ae86490d894f22b6c Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-15Bump CPS to 3.5.2 Snapshotmpriyank1-1/+1
- bump CPS to 3.5.2-SNAPSHOT - updated the release notes and prepared for the next release Issue-ID: CPS-2318 Change-Id: I584faf6218e60ad62e32ef8c3cb0deb4047149a2 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-11Merge "Policy Executor Feature Toggle"Sourabh Sourabh6-6/+168
2024-07-11Policy Executor Feature ToggleToineSiebelink6-6/+168
- defined config parameters for feature toggle and server details - log request details when feature enabled - improved JavaDoc in Controller - improved configuration properties checks in HttpClientConfigurationSpec Issue-ID: CPS-2311 Change-Id: I1ff4bd3592ce2570ac74f9ec6e62b75001cb611a Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-07-10NCMP inventory cm handle search should support cps path querysourabh_sourabh4-15/+28
- Added cps path query conditions for inventory search api Issue-ID: CPS-2289 Change-Id: I0bcc9a45af65ad9d41c4d4cf79b35bfb95f50cff Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-09Refactor remaining classes package structureToineSiebelink68-350/+111
-Introduced org.onap.cps.ncmp.config for all config type classes like http, kafka etc. -Introduced org.onap.cps.ncmp.impl.dmi for dmi specif classes like DmiRestClient etc. -Moved most exception classes to org.onap.cps.ncmp.api.exceptions (only two were 'internal' i.e. NOT used in REST so left in org.onap.cps.ncmp.exceptions) -Deleted unused DateNodeHelper class (and related testware) -Moved some classes to org.onap.cps.ncmp.impl.utils -Moved messaging test base classes to org.onap.cps.ncmp.impl.utils.events -All imports were reorganised automatically by IntelliJ -did NOT update any copyright dates (seems incorrect to me anyway) Issue-ID: CPS-2257 Change-Id: Ie28b1777ea278064b46c6a1c3a28f4d0696565e2 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-07-08Merge "Remove Mappers and Events Facade"Lee Anjella Macabuhay11-325/+56
2024-07-05[BUG] Fix handling of special characters in moduleSetTagdanielhanrahan2-7/+5
During CM-handle registration, moduleSetTag is sent as part of the JSON request body when getting modules from DMI. However, it incorrectly parses the moduleSetTag as JSON, instead of encoding to JSON. This results in parsing errors when moduleSetTag includes characters such as ':' Issue-ID: CPS-2302 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ie38008e0effac2423a4d069a91587e47d8747d66
2024-07-05Remove Mappers and Events Facadempriyank11-325/+56
- Removing Mappers and Events Facade and introducing the normal classes that this facade was wrapping - Corresponding changes in the testware Issue-ID: CPS-2298 Change-Id: I380d73ff3a9b3bf79633cd91580d6a4dee00a662 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-04refactor cmsubscription codempriyank47-1638/+1551
- Moved cmsubscription to the impl package instead of api. - Below packages are renamed or newly created for code and tests - moved ..api.cmsubsription to ..impl.cmsubscription - renamed ..api.cmsubscription.mappers to ..impl.cmsubscription.ncmp or dmi as per the functionality - renamed ..api.cmsubscription.model to ..impl.cmsubscription.models - removed ..api.cmsubscription.producer/consumer and classes moved to ..impl.cmsubscription.ncmp/dmi - new package ..impl.cmsubscription.cache to hold cache config and cache operations - new package ..impl.cmsubscription.avc to hold the CmAvcEventConsumer for the notifications emitted as a result of the subscriptions - Removed the prefix CmNotificationSubscription for majority of the classes , not removed for Config and model classes - Renamed the schemas and package structure as per the code refactoring Note: *EventsFacade and *MappersFacade to be removed in the next patchset Issue-ID: CPS-2298 Change-Id: I1d788ab745d65965570e28beaefa511cbe4a8547 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-03 CPS NCMP: Resolved high cardinality of prometheus metrics for dmi service urlsourabh_sourabh18-489/+473
- Used autoconfigured web client builder for http_client_requests_* prometheus metrics. - Refactored dmi service url builder to create url template and its variables. - Web client is modified to use uri(urlTemplate, urlvars) version. - Deleted InvalidDmiResourceUrlException that no longer needed. - Used DmiServiceUrlBuilder to build dmi health check service url. - Created a new pkg url.builder into utils to have all related classes and record. Issue-ID: CPS-2121 Change-Id: Id67e0f0d4e640bb8f9eea0b6c2db1dba3468e1d7 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-01Improve handling of Invalid Operation exceptionToineSiebelink4-4/+4
- MOve to API package - Handle in REST Controller to return BAD REQUEST Issue-ID: CPS-2256 Change-Id: I4f96519aaf2e7f781729c8b8671ea02630a2e0a8 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-27repackage 'data' featureToineSiebelink75-269/+193
- moved relevant classes into these (new) packages: api.data.exceptions api.data.models impl.data impl.data.async impl.data.exceptions impl.data.models impl.data.utils utils.events - removed old unused event class - moves some missed inventory related class to the right place Issue-ID: CPS-2256 Change-Id: I75563e063acc0054769d8f2b13146e6c1d1c6054 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-27move lcm/common events classesToineSiebelink37-57/+55
-moved api.impl.events.lcm to impl.inventory.sync.lcm -moved most api.impl.events class to utils.events (remaining classes in api.impl.events belong to cmsubscrption and Priyank wil take care of those) Issue-ID: CPS-2258 Change-Id: I1818194e708aa0d9c713b470e878997c2f26fb13 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-26Move TrustLevel FeatureToineSiebelink28-113/+125
-Moved TrustLevel impl from Controller to Inventory Facade -Applied new package name convention using impl\inventory\trustlevel for this (sub)feature -Renamed some trustlevel related classes to better describe their role -Disabled failing architecture test (agreed this is tech. debt and created CPS-2293) -Refactored YangDataConverter method names and signatures (moved Spec to correct place) -Cleaned up names and javadoc of class now called DeviceTrustLevelMessageConsumer -Applied conventions to modified test methods Issue-ID: CPS-2255 Change-Id: Iccd20541488e6b61444bb2c7406c90e61a34124d Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-24Repackage Inventory FeatureToineSiebelink101-423/+428
- decided that cm handle queries is part of 'inventory' feature - a lot of files (~100 total) have changes because of some files have been moved. - The reviewers should probably just focus on the MOVED/renamed (~30) files - New packages (top level only): -- org.onap.cps.ncmp.api.inventory -- org.onap.cps.ncmp.impl.inventory -- org.onap.cps.ncmp.impl.models (common models NOT used in API, this was unforeseen) -- org.onap.cps.ncmp.impl.utils - I am NOT updating copyright years as part of this commit since there are no real code changes and it is simply NOT worth the effort TODO: - extend scope to 'TrustLevel' as an 'internal feature' (TBD) Issue-ID: CPS-2255 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I40b4efc8326068ab9ae1f31b77f46b2fe8579431