summaryrefslogtreecommitdiffstats
path: root/cps-ncmp-service
AgeCommit message (Collapse)AuthorFilesLines
2024-07-26Delete Subscription methodemaclee12-54/+273
Issue-ID: CPS-2253 Change-Id: I30768dc431e13d0bac0dcc7b9b16cb0854f06702 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-07-26Merge "Added missing authorization header to DataJobService"Sourabh Sourabh5-18/+35
2024-07-26Added missing authorization header to DataJobServiceleventecsanyi5-18/+35
- added auth header to the interface & updated testware Issue-ID: CPS-2330 Change-Id: I091fc5c3c3fa323024f55055129cc7240732479a Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-07-25Get data job status from DMI Pluginleventecsanyi5-0/+198
- added java interface - extended DmiRestClient to get data job status - added testware Issue-ID: CPS-2296 Change-Id: If9006bba06397724c15bdc3bdf1bd52a0188f002 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-07-25Integration test for the writeDataJobleventecsanyi2-2/+3
- added Stub controller - created integration test for writeDataJob Issue-ID: CPS-2236 Change-Id: I067a11dc5bfe629d50128cf303b2a81abc75a348 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-07-25Merge "Fix dataProducerId in SubJobWriteRequest"Sourabh Sourabh2-10/+10
2024-07-24Fix timing issue for data sync CSITdanielhanrahan1-4/+5
The default data sync watchdog sleep time is 30 seconds, while the CSIT only waits 10 seconds for data sync to run. This is leading to intermittent failures. - increase CSIT time out to 40 seconds for data sync operation - adjust log levels for data sync so that issues are easier to debug Issue-ID: CPS-2313 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I3ceb9097bf357f47e5d49f84c70b1c711b52171a
2024-07-24Fix dataProducerId in SubJobWriteRequestleventecsanyi2-10/+10
Issue-ID: CPS-2322 Change-Id: I7bfdfd05ffacb085ac056707d477f348cb5bd64f Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-07-17Merge "CPS NCMP: Add state tags to cps.ncmp.lcm.events.publish metrics"Daniel Hanrahan2-9/+101
2024-07-16CPS NCMP: Add state tags to cps.ncmp.lcm.events.publish metricssourabh_sourabh2-9/+101
- Added cm handle state into micrometer Timer as an extra tags while capturing total time taken to publish a LCM events for publishLcmEvent method. Issue-ID: CPS-2123 Change-Id: I6357c628496700fee7448dbc381a7e0e62d8b540 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-16XML content support on replace a node with descendantsRudrangi Anupriya2-6/+8
Issue-ID: CPS-2282 Change-Id: Ibb7ffb65ccbb03703266712c6d5c2eade0e7ab4b Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2024-07-15Mapper to group Subscription Details for DMImpriyank3-0/+185
- introduced a mapper to group a collection of subscription keys(datastore cmhandle and xpath ) based on datastore and xpath - the information will be used to send out to the dmi plugin Issue-ID: CPS-2312 Change-Id: I99f509eb5b4a8c3a7fb1078ae86490d894f22b6c Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-15Bump CPS to 3.5.2 Snapshotmpriyank1-1/+1
- bump CPS to 3.5.2-SNAPSHOT - updated the release notes and prepared for the next release Issue-ID: CPS-2318 Change-Id: I584faf6218e60ad62e32ef8c3cb0deb4047149a2 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-11Merge "Policy Executor Feature Toggle"Sourabh Sourabh6-6/+168
2024-07-11Policy Executor Feature ToggleToineSiebelink6-6/+168
- defined config parameters for feature toggle and server details - log request details when feature enabled - improved JavaDoc in Controller - improved configuration properties checks in HttpClientConfigurationSpec Issue-ID: CPS-2311 Change-Id: I1ff4bd3592ce2570ac74f9ec6e62b75001cb611a Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-07-10NCMP inventory cm handle search should support cps path querysourabh_sourabh4-15/+28
- Added cps path query conditions for inventory search api Issue-ID: CPS-2289 Change-Id: I0bcc9a45af65ad9d41c4d4cf79b35bfb95f50cff Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-09Refactor remaining classes package structureToineSiebelink68-350/+111
-Introduced org.onap.cps.ncmp.config for all config type classes like http, kafka etc. -Introduced org.onap.cps.ncmp.impl.dmi for dmi specif classes like DmiRestClient etc. -Moved most exception classes to org.onap.cps.ncmp.api.exceptions (only two were 'internal' i.e. NOT used in REST so left in org.onap.cps.ncmp.exceptions) -Deleted unused DateNodeHelper class (and related testware) -Moved some classes to org.onap.cps.ncmp.impl.utils -Moved messaging test base classes to org.onap.cps.ncmp.impl.utils.events -All imports were reorganised automatically by IntelliJ -did NOT update any copyright dates (seems incorrect to me anyway) Issue-ID: CPS-2257 Change-Id: Ie28b1777ea278064b46c6a1c3a28f4d0696565e2 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-07-08Merge "Remove Mappers and Events Facade"Lee Anjella Macabuhay11-325/+56
2024-07-05[BUG] Fix handling of special characters in moduleSetTagdanielhanrahan2-7/+5
During CM-handle registration, moduleSetTag is sent as part of the JSON request body when getting modules from DMI. However, it incorrectly parses the moduleSetTag as JSON, instead of encoding to JSON. This results in parsing errors when moduleSetTag includes characters such as ':' Issue-ID: CPS-2302 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ie38008e0effac2423a4d069a91587e47d8747d66
2024-07-05Remove Mappers and Events Facadempriyank11-325/+56
- Removing Mappers and Events Facade and introducing the normal classes that this facade was wrapping - Corresponding changes in the testware Issue-ID: CPS-2298 Change-Id: I380d73ff3a9b3bf79633cd91580d6a4dee00a662 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-04refactor cmsubscription codempriyank47-1638/+1551
- Moved cmsubscription to the impl package instead of api. - Below packages are renamed or newly created for code and tests - moved ..api.cmsubsription to ..impl.cmsubscription - renamed ..api.cmsubscription.mappers to ..impl.cmsubscription.ncmp or dmi as per the functionality - renamed ..api.cmsubscription.model to ..impl.cmsubscription.models - removed ..api.cmsubscription.producer/consumer and classes moved to ..impl.cmsubscription.ncmp/dmi - new package ..impl.cmsubscription.cache to hold cache config and cache operations - new package ..impl.cmsubscription.avc to hold the CmAvcEventConsumer for the notifications emitted as a result of the subscriptions - Removed the prefix CmNotificationSubscription for majority of the classes , not removed for Config and model classes - Renamed the schemas and package structure as per the code refactoring Note: *EventsFacade and *MappersFacade to be removed in the next patchset Issue-ID: CPS-2298 Change-Id: I1d788ab745d65965570e28beaefa511cbe4a8547 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-03 CPS NCMP: Resolved high cardinality of prometheus metrics for dmi service urlsourabh_sourabh18-489/+473
- Used autoconfigured web client builder for http_client_requests_* prometheus metrics. - Refactored dmi service url builder to create url template and its variables. - Web client is modified to use uri(urlTemplate, urlvars) version. - Deleted InvalidDmiResourceUrlException that no longer needed. - Used DmiServiceUrlBuilder to build dmi health check service url. - Created a new pkg url.builder into utils to have all related classes and record. Issue-ID: CPS-2121 Change-Id: Id67e0f0d4e640bb8f9eea0b6c2db1dba3468e1d7 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-01Improve handling of Invalid Operation exceptionToineSiebelink4-4/+4
- MOve to API package - Handle in REST Controller to return BAD REQUEST Issue-ID: CPS-2256 Change-Id: I4f96519aaf2e7f781729c8b8671ea02630a2e0a8 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-27repackage 'data' featureToineSiebelink75-269/+193
- moved relevant classes into these (new) packages: api.data.exceptions api.data.models impl.data impl.data.async impl.data.exceptions impl.data.models impl.data.utils utils.events - removed old unused event class - moves some missed inventory related class to the right place Issue-ID: CPS-2256 Change-Id: I75563e063acc0054769d8f2b13146e6c1d1c6054 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-27move lcm/common events classesToineSiebelink37-57/+55
-moved api.impl.events.lcm to impl.inventory.sync.lcm -moved most api.impl.events class to utils.events (remaining classes in api.impl.events belong to cmsubscrption and Priyank wil take care of those) Issue-ID: CPS-2258 Change-Id: I1818194e708aa0d9c713b470e878997c2f26fb13 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-26Move TrustLevel FeatureToineSiebelink28-113/+125
-Moved TrustLevel impl from Controller to Inventory Facade -Applied new package name convention using impl\inventory\trustlevel for this (sub)feature -Renamed some trustlevel related classes to better describe their role -Disabled failing architecture test (agreed this is tech. debt and created CPS-2293) -Refactored YangDataConverter method names and signatures (moved Spec to correct place) -Cleaned up names and javadoc of class now called DeviceTrustLevelMessageConsumer -Applied conventions to modified test methods Issue-ID: CPS-2255 Change-Id: Iccd20541488e6b61444bb2c7406c90e61a34124d Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-24Repackage Inventory FeatureToineSiebelink101-423/+428
- decided that cm handle queries is part of 'inventory' feature - a lot of files (~100 total) have changes because of some files have been moved. - The reviewers should probably just focus on the MOVED/renamed (~30) files - New packages (top level only): -- org.onap.cps.ncmp.api.inventory -- org.onap.cps.ncmp.impl.inventory -- org.onap.cps.ncmp.impl.models (common models NOT used in API, this was unforeseen) -- org.onap.cps.ncmp.impl.utils - I am NOT updating copyright years as part of this commit since there are no real code changes and it is simply NOT worth the effort TODO: - extend scope to 'TrustLevel' as an 'internal feature' (TBD) Issue-ID: CPS-2255 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I40b4efc8326068ab9ae1f31b77f46b2fe8579431
2024-06-21Fix compile issue after facade introductiondanielhanrahan2-3/+3
Due to automatic rebase, a method got renamed in one commit but not the other. Issue-ID: CPS-2263 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Id0fa8eba79cb98bb24419bfddc0c9b9e8c9a42d3
2024-06-21Merge "Introducing NCMP Facades"Sourabh Sourabh35-1138/+1111
2024-06-21Merge "Spliting a data-job into sub-jobs for DMI Plugin"Sourabh Sourabh13-26/+501
2024-06-20Introducing NCMP FacadesToineSiebelink35-1138/+1111
- NetworkCmProxyDataService was polluted with many non-data operations - it is now split into: 1) NetworkCmProxyFacade, a single thin facade for the (main) controler to redirect calls to the correct services 2) CmHandleRegistrationService(Impl), methods related to registration only - introduced NetworkCmProxyInventoryFacade for the invenoty controller - renamed some services for consitency and clarification - Use facade to acces ncmp data request handlers (instead of direct from controller) - remove unnecesarry wrappings between request handlers and facade - split facades according to names: data & inventory (the REST controllers are not split properly so I think one rest controller will end up needing both facades) Issue-ID: CPS-2263 Change-Id: I250732aa16ec28b43ff642d2adf10ba36f67290e Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-20Bump CPS version to 3.5.1-SNAPSHOTmpriyank1-1/+1
- bump cps version to 3.5.1-SNAPSHOT - updated release notes to make it ready for the next release Issue-ID: CPS-2283 Change-Id: I242cae7c95a87c1a9e225cce3eb7b36097f1e5ba Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-20Spliting a data-job into sub-jobs for DMI Pluginleventecsanyi13-26/+501
- algorithm for create sub-job requests - added new method to DmiServiceUrlBuilder to get the write job url - created WriteOperationExaminer, DmiSubJobClient & testware Issue-ID: CPS-2142 Change-Id: I258d334ef346cd388341a1deb4078d24d8bdb7cc Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-06-19Handle high frequency (faster then DMI) of passthrough request in NCMPsourabh_sourabh5-71/+106
- Added pendingAcquireMaxCount property into appliaction.yml. - Added findbugs google annotations dependency. - Supressed "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE" spotbugs low error for reactor.netty.resources.ConnectionProvider. Issue-ID: CPS-2262 Change-Id: Ie755e40282473933f2052fbe7654e7090bb9b337 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-17Refactor and Move NCMP Data Request HandlersToineSiebelink9-0/+621
- Simplified NCMP Rest Request Handlers - Moved responsEntity wrapping to Controller so most handler methods can have clear return types - Moved NCMP Rest Request Handlers to Service Layer - Moved related exceptions and utils to Service Layer - Used Lombok for constructors - Improved related testware Issue-ID: CPS-2266 Change-Id: I0025fab1c92e0d613825093b6e4b43dae044c01a Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-13 #2: Used async version of web client for single cm handle read operationsourabh_sourabh7-55/+75
- Code change is done to use async web client for single cm handle read data operation. - CpsNcmpTaskExecutor class and groovy test code is removed. - Use of supplier code is removed from cm handle Query service. Issue-ID:CPS-2259 Change-Id: I2b7a36e8a151a9224937afd876fceb30be6a24ce Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-13 #1: Used async version of web client for batch read operationsourabh_sourabh7-134/+105
- Exposed async version of post method into dmi rest client. - Code change is done to use async web client for batch data operation. - Use of CpsNcmpTaskExecutor code is removed. Issue-ID: CPS-2174 Change-Id: I7840fd8c6d9debe42e50c860f9cf39d64274df72 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-06#1: Dedicated web client instance is assigned for data, model and health ↵sourabh_sourabh13-158/+328
services - Switched web client instance based on dmi service type (like data or model) - 3 diff. beans are configured for data, model and health dmi service. - Added configurable properties for data and model. - Hard coded properties are assigned for health service. Issue-ID: CPS-2231 Change-Id: I39fb739c07c41430dae43509fe29ece5306b7d71 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-06Merge "Change ApplicationEvent for ModelLoading"Toine Siebelink5-26/+25
2024-06-05XML content support on update node leavesRudrangi Anupriya5-9/+16
Issue-ID: CPS-2071 Change-Id: Ibe7f59fbfcbb03703626132c6d5c2afde0e7ab4b Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2024-06-05Change ApplicationEvent for ModelLoadingmpriyank5-26/+25
- Application to use ApplicationStartedEvent as the trigger to start the ModelLoading process instead of ApplicationReadyEvent - Modified the testware to reflect the same Issue-ID: CPS-2211 Change-Id: I3176b6373f585ec1915c3d43c553e233660225f5 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-05Merge "CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)"Priyank Maheshwari5-50/+128
2024-06-05Merge "Added OpenTelemetry to CPS"Toine Siebelink5-1/+254
2024-06-04Merge "CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)"Priyank Maheshwari5-28/+114
2024-05-31Added OpenTelemetry to CPSdavid.mcweeney5-1/+254
Change-Id: I192fa53e293ea43cdff92ebd44d0382eb290bb76 Signed-off-by: david.mcweeney <david.mcweeney@est.tech> Issue-ID: CPS-2172
2024-05-31CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)emaclee5-50/+128
Issue-ID: CPS-2241 Change-Id: I218c46e9c16cc78025450494f5019bde1f351a40 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-05-31CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)emaclee5-28/+114
Issue-ID: CPS-2241 Change-Id: Idd074ff4d29cf11f45f1c69200788b2f39b49e74 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-05-31CM SUBSCRIPTION: Update schemasmpriyank4-11/+11
- updated the cm subscription schemas with proper case as agreed before for the events - fixed the tests to reflect the camelCase change Issue-ID: CPS-2245 Change-Id: I64fb8b27a5f64280dfa19d86ae310e6b5309de39 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-05-29Simplify Code around building DMI URLsToineSiebelink14-392/+417
- Bug analysis showed some unclear and complicated code for building URLs - This patch is to clean up the related code and show more clearly what is encoded and what is not - Use SPringBoot provided builder to apply correct encoding of all URI parts - DmiOperations base class no longer need as no common code model and data operations anymore - Converted builder to POJO (client needs to provide the only dmi properties upon build) - Added some missing test (in affected code) to increase coverage percntage (as the production code has significantly reduced in size the overal coverage was inadvertently reduced below the treshold) - Added more unit test. Now impl.operations' package has 100% - removed the test fro Dmi Exception that was incorrectly callign the handleException methdod directly instead of mocking an exception it was really a dupclicate of a test I added but I was able to re-use the event checkign in my test Issue-ID: CPS-2246 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I1ff196cd03bbb95f5877ee590c321febeb672800
2024-05-29Merge "CPS-2187 - Move Module Set Tag into request body for dmi data access ↵Sourabh Sourabh4-35/+26
passthrough calls"