aboutsummaryrefslogtreecommitdiffstats
path: root/cps-ncmp-service/src
AgeCommit message (Collapse)AuthorFilesLines
2025-01-29Merge "Add "dataProducerId" and "dmiServiceName" values to ↵Lee Anjella Macabuhay2-5/+9
SubJobWriteResponse in sendRequestsToDmi method"
2025-01-29Add "dataProducerId" and "dmiServiceName" values to SubJobWriteResponse in ↵egernug2-5/+9
sendRequestsToDmi method - DMI call only returns subJobId - SubJobWriteResponse created using DMI response and request values Issue-ID: CPS-2497 Change-Id: Ib38132f2337de6a12b0b05bc6eebeed99f8d435d Signed-off-by: egernug <gerard.nugent@est.tech>
2025-01-29Address sonar violations related to hazelcastmpriyank1-1/+5
- Supressing warning caused by deprecation of RestApiConfig in hazelcast 5.5 community version , which will be removed in 6.0 so created https://lf-onap.atlassian.net/browse/CPS-2599 to address the issues - Other sonar fixes Issue-ID: CPS-2594 Change-Id: I2e95cd851eae74d8bbb4535cfbaed1dc1ef89543 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2025-01-28Merge "Send new module set tag to DMI during model upgrade"Daniel Hanrahan5-62/+82
2025-01-28Merge "Moved CpsValidator under the utils package"Daniel Hanrahan4-4/+4
2025-01-28Send new module set tag to DMI during model upgradedanielhanrahan5-62/+82
Previously, DMI would receive old module set tag in the request body. The tag being upgrade to is the expected one. Issue-ID: CPS-2589 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I0554136f0d4c55d687b575313d932f6bcab15c92
2025-01-27Moved CpsValidator under the utils packageleventecsanyi4-4/+4
Issue-ID: CPS-2515 Change-Id: I57f6c10c8596281aed686552ad16e1dd6c15ff98 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2025-01-24Less logging during registrationdanielhanrahan2-14/+7
During investigation of CPS-2576 bug, stack traces were added to log output (by logging the exception object). This produces massive log output during registration, since all CM-handles fail to sync and go to LOCKED state initially due to initial DMI delay. This patch logs exception details at warning level but not stacktrace Issue-ID: CPS-2576 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ibb55991e75c058e9f4983bd876285b48917ee28e
2025-01-24Merge "Fix for cm handles stuck in LOCKED during registration"Priyank Maheshwari3-10/+54
2025-01-24Merge "Incorrect Internal Error Code for duplicated registration"Daniel Hanrahan3-11/+9
2025-01-23Fix for cm handles stuck in LOCKED during registrationToineSiebelink3-10/+54
- Additional Error logging when cm handles fail module sync - Swallow already defined exception upon schema and/or anchor creation - Updated integration test to try to reproduce the problem (but couldn't) - Ignored integration tests that depend/affected by race conditions (they are useful for troubleshooting but not for pipeline checks) - Removed last remnants of springboot retry annotation option (incl dependencies) Issue-ID: CPS-2576 Change-Id: I910e802268332f955134c043bd1b46a7ec57233b Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2025-01-23Incorrect Internal Error Code for duplicated registrationseanbeirne3-11/+9
-Deprectated 111 Alternate-Id already exists error code -All dupication scenarios now return 109 Issue-ID: CPS-2563 Change-Id: Ic9b9df936eaf3795441f4dd1ec1cc73e39c9eae1 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2025-01-22Merge "Moved builders under impl in CPS Service"Toine Siebelink3-3/+3
2025-01-21Remove retry mechanism for duplicate module(resource) errorsToineSiebelink2-22/+15
- CM Handle with problems will go into 'LOCKED' state and retried using existing business logic Issue-ID: CPS-2555 Change-Id: I563f6bc536d8fd8c6675891c62318ff2fb43fea6 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2025-01-20Moved builders under impl in CPS Serviceleventecsanyi3-3/+3
- moved builders and fixed the Arch test Issue-ID: CPS-2542 Change-Id: Iac9d47f20fff2e6fa415ada8bc17880b0b032591 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2025-01-17Merge "Make Response Timeout Configurable in WebClient Configuration"Lee Anjella Macabuhay4-7/+10
2025-01-17Merge "One SchemaSet per moduleSetTag"Sourabh Sourabh13-430/+239
2025-01-16Make Response Timeout Configurable in WebClient Configurationsourabh_sourabh4-7/+10
- Added responseTimeoutInSeconds property in the ServiceConfig class to allow dynamic configuration of the timeout. - Updated WebClientConfiguration to read the responseTimeoutInSeconds from ServiceConfig and set it in the HttpClient. Issue-ID: CPS-2565 Change-Id: I096688319c55f0342b524511883ec0d33806b9b7 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2025-01-16Handle restart case for cps-ncmp gauge metricsemaclee7-27/+109
Issue-ID: CPS-2456 Change-Id: I9ac5d6774fcd745d8141551eeff8a1deb1938f57 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2025-01-16One SchemaSet per moduleSetTagToineSiebelink13-430/+239
- Registration: create and upgrade cases. - Handle moduleSetTag deletion (all orphans) for testware - Unit tests updated - additional logging of details for upgrade scenarios - Integration Tests updated - Remove cache for module sets being processed - Removed DbCleaner (startup) - Removed redundant methods in NCMP Inventory for deleting schema set(s) - Removed validation check for all schema set interactions - Updated some schema set tests to use special characters previously not allowed - Checked integration test scenarios for upgrades with and without tags: all scenarios covered! TODO - REST endpoint to remove orphaned schema set data, separate story: CPS-2554 - Investigate exception handling regarding DuplicateYangResourceException: CPS-2555 Issue-ID: CPS-2540 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Iaa59cbdb86b7a4a8044624829bc002506ff40cc7
2025-01-15Merge "Move LockReasonCategory under api package"Lee Anjella Macabuhay36-75/+76
2025-01-13Move LockReasonCategory under api packageleventecsanyi36-75/+76
- reafctored package structure Issue-ID: CPS-2514 Change-Id: Id54cd652e147b585730caacbe550287ae2c329e1 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2025-01-13Add conditionalProperty in subscription consumers and producersemaclee3-0/+6
Issue-ID: CPS-2556 Change-Id: Id6a70dbfabc9119727eb307f3c2928a13f3bf44a Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2025-01-07Merge "Add gauge metric for NCMP "cmhandle states""Daniel Hanrahan6-4/+305
2025-01-07Add gauge metric for NCMP "cmhandle states"emaclee6-4/+305
Issue-ID: CPS-2456 Change-Id: I1aebcc68dfdc9c48c230c74376742d67b05c0615 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-12-20Update docs related to lockmpriyank1-2/+2
- added the distributed lock in the documentation as well - updated the log level to debug to refrain printing every iteration of the scheduler Issue-ID: CPS-2479 Change-Id: Ieeeff46168d70aca6f423e82bda15a12d6c405a5 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-12-20Merge "Add schema to persist notification subscription information"Priyank Maheshwari7-420/+4
2024-12-20Merge "Remove check before removing from hazelcast cache"Toine Siebelink4-24/+5
2024-12-20Add schema to persist notification subscription informationrajesh.kumar7-420/+4
Add required schema to persist notification subscription information. It should contain - Schema yang file - New Dataspace, Anchors or any other database entity - Refactore duplicate code in NCMP Issue-ID:CPS-2427 Change-Id: I56c34400dc73c71b936a51260efd300924ababdc Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
2024-12-19Cps and Ncmp distributed lock for various use casesmpriyank4-37/+73
- introduced cpsAndNcmpLock to be used for any use case needing coordination. Since it can be used for any use case hence placing the class accordingly. - currently lock is being used for populating workQueue. - Removed FencedLock as it was part of CPSubsystem which is moved to hazelcast-enterprise in 5.5.* version onwards. - added info level logging statement to verify just one thread at a time in the critical section - Note : integration test to be part of a separate patch. Issue-ID: CPS-2479 Change-Id: I0f33c7232786c517383e5093fda91fd9a1839021 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-12-19Remove check before removing from hazelcast cacheemaclee4-24/+5
Issue-ID: CPS-2420 Change-Id: I2299d5790792f7c2b2b1a6aa371b5ea43c6a9ee8 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-12-19Hazelcast related code updateemaclee8-22/+13
- this patch answers comments from 'Hazelcast Optimization' patch that was merged Issue-ID: CPS-2420 Change-Id: Ic5cf005730f2a45eba553a7f6d32e9af6676821d Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-12-12Merge "Increase Test coverage for cps-ncmp-service"Toine Siebelink2-19/+46
2024-12-11Increase Test coverage for cps-ncmp-serviceseanbeirne2-19/+46
Issue-ID: CPS-475 Change-Id: I35f127540e0fe5d412a9f855b647fef30f47159f Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-12-11Merge "Policy Executor API Review Board Comments"Lee Anjella Macabuhay2-39/+38
2024-12-10Policy Executor API Review Board CommentsToineSiebelink2-39/+38
- Implemented Guild review comments in API - Updated Stub to reflect new API and 'support' all operations - Updated production code to use new API - Updated Semi-Integration Tests Issue-ID: CPS-2479 Change-Id: Ibe307b0d859312b534009a384e9f71e1ea2affe0 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-12-10Separated inventoryFacade to Interface and Implleventecsanyi3-117/+192
- created NetworkCmProxyInventoryFacade IF Issue-ID: CPS-2513 Change-Id: Ibda2d7899514ee22d4b04cad971e107bfccce2df Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-12-09Hazelcast Optimisationemaclee13-54/+89
Issue-ID: CPS-2420 Change-Id: I707e0fbbddeb4ddc7c573a2b3ebd8fbca08126a6 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-12-06[Module Sync] Store CM-handle IDs in work queuedanielhanrahan11-128/+121
This fixes bug CPS-2474, handling various edge cases, such as CM handles being deleted during module sync. - Change moduleSyncWorkQueue to store CmHandleId instead of DataNode. - Freshly fetch Cm Handles in module sync task, so latest CM-handle state is used, and only process ADVISED CM handles in module sync. Issue-ID: CPS-2474 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I53d5796c56014a2bfbe5b1c3f17d3991e4feef53
2024-12-05Moved common classes under the api package under apileventecsanyi56-131/+129
- moved common classes under the api package - moved Spec files Issue-ID: CPS-2512 Change-Id: I88046280ce359ce8cc488ad37d4e6f85406b0dbf Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-12-04Inventory Persistance returns YangModelCmHandles for alternate Idsseanbeirne9-65/+84
-Remove getCmHandleDataNodeByAlternateId(s) methods and replace with Yang Model methods Issue-ID: CPS-2486 Change-Id: I2c9c96f033b3b1eefadb7eff14c91f9a936630e6 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-12-04[BUG] Effective trust factors in DMI trust leveldanielhanrahan7-30/+131
Effective trust of a CM handle should be the trust level of the handle or the DMI, whichever is lower. Currently, effective trust level of a CM handle is not reported correctly when the DMI is down, as DMI trust level is not considered. - Add DMI service names to NcmpServiceCmHandle - Introduce new DmiServiceNameResolver class - Correctly calculate effective trust level Issue-ID: CPS-2375 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Iaded0fadad58d960eb76c69f79a308df8329e534
2024-12-03Improve test coverage trustlevel managerToineSiebelink1-6/+9
Issue-ID: CPS-475 Change-Id: I572227b4f6c61bd2286d8cb3fb85c3dc21142a47 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-12-02Faster CM-handle searches using Hazelcast optimizationdanielhanrahan8-65/+146
This uses IMap::getAll(setOfKeys) to bulk read trust levels. This reduces CM-handle search time by a third. Issue-ID: CPS-2420 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ie63b45a76bee146def537b749074ecbb7715e6fc
2024-11-27Merge "Catch data validation exception in dmi data operation"Daniel Hanrahan2-7/+12
2024-11-25Catch data validation exception in dmi data operationseanbeirne2-7/+12
Issue-ID: CPS-2510 Change-Id: I4093459c824c202dc8dec4b869e338d4b80fbac8 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-11-25Registration Optimization remaining Code CommentsToineSiebelink3-6/+3
Issue-ID: CPS-2478 Change-Id: I0aa3804225f053ff99176056fe71322a23cff31c Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-11-21Merge "Prioritize cm handle ids over alternate ids in data operations"Daniel Hanrahan5-8/+43
2024-11-21Prioritize cm handle ids over alternate ids in data operationsToineSiebelink5-8/+43
Issue-ID: CPS-2510 Change-Id: I7068d0de45cc2c2e5d8815f0e78c260369f3551e Signed-off-by: seanbeirne <sean.beirne@est.tech> Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-11-21[BUG] Fix for module endpoints using alternate IDdanielhanrahan1-7/+21
The endpoints for fetching modules and module definitions previously returned empty result if a CM handle was not found or not ready. Recent changes for alternate ID have changed the behaviour so it returns an error instead. This restores original behaviour by swallowing the exception. Change-Id: I63091d04d171e6f4ac6ad1c44b359b9a0c4b8f65 Issue-ID: CPS-2509 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>