aboutsummaryrefslogtreecommitdiffstats
path: root/cps-ncmp-service/src
AgeCommit message (Collapse)AuthorFilesLines
2021-12-15Adding unit tests and robuestness for DMI registrationJosephKeenan2-17/+22
-Added more scenarios for combinations of plugins -Made plugin registration more robust Issue-ID: CPS-736 Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Change-Id: I7495eb802fec8708e7ea6b0a97a9d7fe4676c8c1
2021-12-14Merge "Changing putOperationWithJson to postOperationWithJson"Toine Siebelink10-110/+183
2021-12-14Changing putOperationWithJson to postOperationWithJsonJosephKeenan10-110/+183
-Modified responseEntity<String> to reesponseEntity<Object> -Changed behaviour of sync to use new repsonses and removed JSON parsing -Updated tests to use new responsess -Tests have been updated and added jira to docs -Added messageConverters to RestTemplate to support plain text with ResponseEntity<Object> -Added docker log output for cps & dmi containers during CSIT teardown -Moved reponse conversion from service into DMIModelOperations class -Added response handling test (edgecases) -Updated response request body for passthrough-running CSIT test to pass Issue-ID: CPS-777 Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Change-Id: If2acf83a97b8aad5aa2c342154d807a47cace6a0
2021-12-14Add exception handling to delete schema set when a registration is removedniamhcore2-2/+23
Issue-ID: CPS-783 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: Ief4c6727e788822bc29379a757d25dff14f68c94
2021-12-08Delete anchor and schema set when a registration is removedniamhcore2-11/+20
Issue-ID: CPS-783 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I9644949e00c4de900b2609c1e70744ae5a243582
2021-12-08Support Delete operation for ds Passtrough-Running in NCMP 1/3DylanB95EST2-9/+10
Add delete operation for passthrough running within cps-ncmp. Issue-ID: CPS-638 Change-Id: I360672adc1f0f5c8eb351391c94f2d4fa913d0b4 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-12-07Undo manipulation of YangResource string as this is now handled correctly in ↵ToineSiebelink4-114/+6
DMI PLugin Issue-ID: CPS-788 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I7d308a62699709770f3629cbc55a26fb0e382010
2021-12-02Changing putOperationWithJson to postOperationWithJsonJosephKeenan4-28/+3
Issue-ID: CPS-736 Change-Id: I3fd2e0b6d6c20683b18f79ed78ed5c8990aee6d8 Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2021-11-26Patch operation passthrough runningniamhcore1-1/+2
Issue-ID: CPS-640 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I6badf241bbec265800d6b316da7ab8ad7782eb17
2021-11-25Allow separate registration of DMIDataPlugin and DmiModelPuginJosephKeenan25-986/+1508
Moved relevant code from NetworkCmProxyDataServiceImp to DmiOperations Split DmiOperations into DMiData... and DMIModelOperations Merged update-operation changes Added tests for error message validation in NetworkCmProxyDataServiceImplSpec Removede @Service from DMIOperations and added @component to DmiDataOperations & DmiModelOperations Verify sync robot test is now hardened Added exitonfailure so robot tests stop after first encountered failed test Issue-ID: CPS-736 Change-Id: I0b40931cc8cd4fc0452328a0a7e0f60e6fc38d0a Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-11-10Update operation passthrough running - Service Layerniamhcore6-6/+105
Issue-ID: CPS-636 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I13334df383a23e59b3368b8664c10e086b1eb4a8
2021-11-02Add get cm handles by modules names - service layerniamhcore3-14/+50
Issue-ID: CPS-644 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: Ic2a57df02d533a0066382c12c35be8d524b6cdad
2021-11-02Merge "Clean Up Code around List Nodes"Toine Siebelink2-13/+13
2021-11-02Clean Up Code around List NodesDylanB95EST2-13/+13
Make sure code refers clearly to List (whole) nodes or List elements incl. method names, parameter names, test descriptions etc. Issue-ID: CPS-756 Change-Id: Ic9dae6565c0e84c1ba4c2d6e891d3ea307f589da Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-10-28Remove org.jetbrains.annotations dependencyBruno Sakoto1-4/+0
It is not part of spring boot 2.5.5 anymore and using it to enforce code invariant is not consistent in the overall code base. Issue-ID: CPS-582 Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca> Change-Id: I6b2c1b8340cda376b70daa2ac092b3d02daa8960
2021-10-18CPS-475 - fix sonar smellsJosephKeenan1-4/+4
Issue-ID: CPS-475 Change-Id: Ifbf14eaa93a8befa262a24499ab72b6c4cc2441c Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2021-10-12fix for sync and passthough usecasetragait5-38/+55
fixed unknown modules issue, if unknown modules are size 0 dmi should not be called. fixed 2xx issue for create resource. fixed options = null issue. Issue-ID: CPS-730 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: If6226f65e72753189c27648ad903c45a5d8fa14e
2021-10-08Merge "Update get yang resource response body"Toine Siebelink2-21/+29
2021-10-08Update get yang resource response bodyniamhcore2-21/+29
Issue-ID: CPS-706 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: Ic7045e873421ee5ce69e6e0400eeaa7a1d36eaf8
2021-10-07fix fields and depth to option querytragait5-88/+55
Issue-ID: CPS-678 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: I8934bd7708ae51dce77b8684081a71ca57bfa3a4
2021-10-06Changing resource identifier to a query paramniamhcore2-14/+11
*Update dmi operations to build dmi url using query param Issue-ID: CPS-679 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I2292507c5057837932f8e21f1a8e80721066b336
2021-09-27fix fetch modules request bodytragait3-79/+136
Issue-ID: CPS-653 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: I65bc9f10a9260e571810838fcbf4ed59ea1e2c30
2021-09-21Address Sonar Qube issuesToineSiebelink1-1/+1
- Add missing lombok.config to exclude lombok generated code in some modules - Increased Coverage treshold where possible Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I4974aa1abec47980e15c2da10afc7288c2cc7c54
2021-09-21Merge "Address Sonar Qube issues"Niamh Core5-69/+117
2021-09-21Address Sonar Qube issuesToineSiebelink5-69/+117
- Add some basic test for missed coverage - Refactored NetworkCmProxyDataServiceImpl to addres duplcaied code and code coverage - Increased Coverage treshold where possible Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Id05f41ac242aeaf57606748009c0e370199e054f
2021-09-17fix data from object to stringtragait3-3/+3
Issue-ID: CPS-634 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: I13b20bc81a6109da32986088ddcf3d1814902a02
2021-09-14Add test for missing code covereageToineSiebelink11-65/+249
- Add test for error scenarios and otehr mising tests - set up for SpringBean testing - some small typo fixes - fixed some SQ violations Issue-ID: CPS-656 Change-Id: If33f215c8ecaf090f27145005cc1aa7f0331d0f4 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2021-09-10CPS-635 - modified dataspace name for saving schema-set and anchorJosephKeenan2-6/+4
Issue-ID: CPS-635 Change-Id: Iaaaefd24ed9f13db7e1d76fd1295b44cc861b83f Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2021-09-10Merge "CPS-635 - Module Resource call does not include body"Toine Siebelink9-36/+219
2021-09-10CPS-635 - Module Resource call does not include bodyJosephKeenan9-36/+219
Issue-ID: CPS-635 Change-Id: Ie7a783ec1cd5107cef19a128439532bb520e3e89 Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2021-09-09Fix Sonar Qube Violationsniamhcore1-1/+1
Issue-ID: CPS-475 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: Ib8a763545e04c32c493994772f355fd3b4616098
2021-09-08Address minor comments on tests for CPS-577DylanB95EST1-15/+14
Address comments left by Renu on NetworkCmProxyDataServiceImplSpec.groovy Issue-ID: CPS-597 Change-Id: Ieaa1756730640d7ef2d67eb8640c97f56e112e33 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-09-07P2 - Get module names and revisions rest layerniamhcore3-2/+16
Issue-ID: CPS-485 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I1bcf45902207d0dba6b5dfe8277cb06571694db3
2021-09-06P1 - Get module name and revision persistence layerniamhcore3-18/+18
Rename ModuleReference to ExtendedModuleReference Create new ModuleReference class (moduleName and revision) Update existing sync model flow to use new module reference class Create native query to get module name and revision Issue-ID: CPS-485 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I0d0da7742ceef3a68e83a5dd4852091e6adf138b
2021-09-06Fix Sonar Qube Violationslukegleeson1-4/+3
Issue-ID: CPS-475 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: Iffd7b24cf42db73a8b93c4d1f2860e41a82e565d
2021-09-02fix dmi base path in ncmptragait2-9/+9
Issue-ID: CPS-617 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: I3a0018c6054febfea5d9c4aa1c0e62f8aa1c160b
2021-09-01Merge "Add ncmp endpoints to swagger-ui"Toine Siebelink1-22/+0
2021-09-01Add ncmp endpoints to swagger-uiRenu Kumari1-22/+0
- added ncmp-enpoints to swagger-ui - removed springfox dependencies - removed Docket configuration as we are loading ui from openapi.yml - removed endpoints which are not implemented - Fixed ncmp basepath as per CPS-616 Issue-ID: CPS-601 Issue-ID: CPS-616 Signed-off-by: Renu Kumari <renu.kumari@bell.ca> Change-Id: I03c7789f48a12d3ffd5fcb934d7ba6347d4044e4
2021-08-30CPS-505 Retrieving modules for new CM handleJosephKeenan11-139/+452
-Added some production code for getting missing modules for new CM handle -Groovy test template added by Toine for getting msissing modules -Added json example for test -Modified test to check map contents -Differentiated restTemplate calls based on URL -Fixed code review comment`s -Groovy test now passing -Modified behaviour for sending moduleReferences and added null to namespace (jira to follow) -Combined NetworkCmProxyDataServiceImpl tests into one class & addressed code review comments Issue-ID: CPS-505 Change-Id: I91ef65467496caea7834ba2e8af99cfe58d4f880 Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2021-08-26Post impl for passthrough running (Ncmp impl.)tragait8-230/+359
Issue-ID: CPS-577 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: Ic8983349cf88fb123feb95ce01ec6fdf670469f4
2021-08-25Add optional observed timestamp in the cps data apiaditya puthuparambil2-18/+30
- Added optional query parameter in cps data endpoints - Updated service layer and notification to use observedTimestamp Note: - NCMP REST endpoints are not updated as a part of this patch - NCMP does not sent observed timestamp when using cps data services Issue-ID: CPS-477 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I1f92da3da7b3a13c45405fdf44e5fef861991d9a Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
2021-08-25Merge "Remove CmHandle in DMI-Registry"Niamh Core3-8/+28
2021-08-25Remove CmHandle in DMI-RegistryDylanB95EST3-8/+28
Remove CM Handles within DMI-Registry as part of DMI-Registration story. Issue-ID: CPS-444 Change-Id: I91bb5e346354b2723fafb565c25d5728731aa09e Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-08-25Fix exception when registration has no additionPropertiesniamhcore2-37/+58
Issue-ID: CPS-587 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: Ic65b274e66cc7b2967826045a5da43ef2ee888f5
2021-08-24Merge "Update CmHandle in DMI-Registry for a DMI-Plugin Instance in NCMP as ↵Niamh Core3-21/+75
part of dmi registration."
2021-08-24Update CmHandle in DMI-Registry for a DMI-Plugin Instance in NCMP as part of ↵DylanB95EST3-21/+75
dmi registration. Updating existing CM-Handles created previously as part of CPS-442 Note - Can only update cm handles and properties which already exist. Issue-ID: CPS-443 Change-Id: Ib05a4e01336ca463578b45917dcdfe715b6bad07 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-08-20Get resource data from pass through running (Ncmp impl.)tragait5-46/+230
Issue-ID: CPS-580 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: I6dc37d9516078c87efc3f0c5bbd2b7b8a7155d48
2021-08-19get resource data for operational passthroughtragait10-6/+629
Issue-ID: CPS-487 Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: Id1b761f3f6a388556d0cc334fd6f196c78badc39
2021-08-17Fix Sonar Qube Violationslukegleeson3-9/+9
Issue-ID: CPS-475 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I9673fe8ff5373a1ea50df148ac2a3d8af235e508
2021-08-03Implement DMI Registration (NCMP-Side)DylanB95EST8-25/+298
Implementing registration of CM-Handles to NCMP from DMI CM Handles are Written to fragment tables Moved NetworkCmProxyDataServiceImplSpec.groovy as it was not in the same package as the class it was testing. Meaning it didn't cover this when it came to code coverage Have included Json structure validation also within open api Deprecating old API's along with old API Methods Issue-ID: CPS-442 Change-Id: I819b9bf65280b1d968d3b75ca5ef2f9eb5617579 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>