aboutsummaryrefslogtreecommitdiffstats
path: root/cps-ncmp-service/src/test/groovy/org/onap
AgeCommit message (Collapse)AuthorFilesLines
2024-06-26Move TrustLevel FeatureToineSiebelink9-45/+53
-Moved TrustLevel impl from Controller to Inventory Facade -Applied new package name convention using impl\inventory\trustlevel for this (sub)feature -Renamed some trustlevel related classes to better describe their role -Disabled failing architecture test (agreed this is tech. debt and created CPS-2293) -Refactored YangDataConverter method names and signatures (moved Spec to correct place) -Cleaned up names and javadoc of class now called DeviceTrustLevelMessageConsumer -Applied conventions to modified test methods Issue-ID: CPS-2255 Change-Id: Iccd20541488e6b61444bb2c7406c90e61a34124d Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-24Repackage Inventory FeatureToineSiebelink40-219/+222
- decided that cm handle queries is part of 'inventory' feature - a lot of files (~100 total) have changes because of some files have been moved. - The reviewers should probably just focus on the MOVED/renamed (~30) files - New packages (top level only): -- org.onap.cps.ncmp.api.inventory -- org.onap.cps.ncmp.impl.inventory -- org.onap.cps.ncmp.impl.models (common models NOT used in API, this was unforeseen) -- org.onap.cps.ncmp.impl.utils - I am NOT updating copyright years as part of this commit since there are no real code changes and it is simply NOT worth the effort TODO: - extend scope to 'TrustLevel' as an 'internal feature' (TBD) Issue-ID: CPS-2255 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I40b4efc8326068ab9ae1f31b77f46b2fe8579431
2024-06-21Fix compile issue after facade introductiondanielhanrahan1-1/+1
Due to automatic rebase, a method got renamed in one commit but not the other. Issue-ID: CPS-2263 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Id0fa8eba79cb98bb24419bfddc0c9b9e8c9a42d3
2024-06-21Merge "Introducing NCMP Facades"Sourabh Sourabh16-559/+566
2024-06-21Merge "Spliting a data-job into sub-jobs for DMI Plugin"Sourabh Sourabh4-22/+132
2024-06-20Introducing NCMP FacadesToineSiebelink16-559/+566
- NetworkCmProxyDataService was polluted with many non-data operations - it is now split into: 1) NetworkCmProxyFacade, a single thin facade for the (main) controler to redirect calls to the correct services 2) CmHandleRegistrationService(Impl), methods related to registration only - introduced NetworkCmProxyInventoryFacade for the invenoty controller - renamed some services for consitency and clarification - Use facade to acces ncmp data request handlers (instead of direct from controller) - remove unnecesarry wrappings between request handlers and facade - split facades according to names: data & inventory (the REST controllers are not split properly so I think one rest controller will end up needing both facades) Issue-ID: CPS-2263 Change-Id: I250732aa16ec28b43ff642d2adf10ba36f67290e Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-20Spliting a data-job into sub-jobs for DMI Pluginleventecsanyi4-22/+132
- algorithm for create sub-job requests - added new method to DmiServiceUrlBuilder to get the write job url - created WriteOperationExaminer, DmiSubJobClient & testware Issue-ID: CPS-2142 Change-Id: I258d334ef346cd388341a1deb4078d24d8bdb7cc Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-06-19Handle high frequency (faster then DMI) of passthrough request in NCMPsourabh_sourabh1-0/+3
- Added pendingAcquireMaxCount property into appliaction.yml. - Added findbugs google annotations dependency. - Supressed "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE" spotbugs low error for reactor.netty.resources.ConnectionProvider. Issue-ID: CPS-2262 Change-Id: Ie755e40282473933f2052fbe7654e7090bb9b337 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-17Refactor and Move NCMP Data Request HandlersToineSiebelink2-0/+197
- Simplified NCMP Rest Request Handlers - Moved responsEntity wrapping to Controller so most handler methods can have clear return types - Moved NCMP Rest Request Handlers to Service Layer - Moved related exceptions and utils to Service Layer - Used Lombok for constructors - Improved related testware Issue-ID: CPS-2266 Change-Id: I0025fab1c92e0d613825093b6e4b43dae044c01a Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-13 #2: Used async version of web client for single cm handle read operationsourabh_sourabh2-11/+13
- Code change is done to use async web client for single cm handle read data operation. - CpsNcmpTaskExecutor class and groovy test code is removed. - Use of supplier code is removed from cm handle Query service. Issue-ID:CPS-2259 Change-Id: I2b7a36e8a151a9224937afd876fceb30be6a24ce Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-13 #1: Used async version of web client for batch read operationsourabh_sourabh2-47/+31
- Exposed async version of post method into dmi rest client. - Code change is done to use async web client for batch data operation. - Use of CpsNcmpTaskExecutor code is removed. Issue-ID: CPS-2174 Change-Id: I7840fd8c6d9debe42e50c860f9cf39d64274df72 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-06#1: Dedicated web client instance is assigned for data, model and health ↵sourabh_sourabh7-96/+154
services - Switched web client instance based on dmi service type (like data or model) - 3 diff. beans are configured for data, model and health dmi service. - Added configurable properties for data and model. - Hard coded properties are assigned for health service. Issue-ID: CPS-2231 Change-Id: I39fb739c07c41430dae43509fe29ece5306b7d71 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-06Merge "Change ApplicationEvent for ModelLoading"Toine Siebelink3-19/+18
2024-06-05XML content support on update node leavesRudrangi Anupriya2-5/+7
Issue-ID: CPS-2071 Change-Id: Ibe7f59fbfcbb03703626132c6d5c2afde0e7ab4b Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2024-06-05Change ApplicationEvent for ModelLoadingmpriyank3-19/+18
- Application to use ApplicationStartedEvent as the trigger to start the ModelLoading process instead of ApplicationReadyEvent - Modified the testware to reflect the same Issue-ID: CPS-2211 Change-Id: I3176b6373f585ec1915c3d43c553e233660225f5 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-05Merge "CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)"Priyank Maheshwari2-22/+49
2024-06-05Merge "Added OpenTelemetry to CPS"Toine Siebelink2-1/+84
2024-06-04Merge "CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)"Priyank Maheshwari2-5/+57
2024-05-31Added OpenTelemetry to CPSdavid.mcweeney2-1/+84
Change-Id: I192fa53e293ea43cdff92ebd44d0382eb290bb76 Signed-off-by: david.mcweeney <david.mcweeney@est.tech> Issue-ID: CPS-2172
2024-05-31CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)emaclee2-22/+49
Issue-ID: CPS-2241 Change-Id: I218c46e9c16cc78025450494f5019bde1f351a40 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-05-31CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)emaclee2-5/+57
Issue-ID: CPS-2241 Change-Id: Idd074ff4d29cf11f45f1c69200788b2f39b49e74 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-05-31CM SUBSCRIPTION: Update schemasmpriyank2-4/+4
- updated the cm subscription schemas with proper case as agreed before for the events - fixed the tests to reflect the camelCase change Issue-ID: CPS-2245 Change-Id: I64fb8b27a5f64280dfa19d86ae310e6b5309de39 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-05-29Simplify Code around building DMI URLsToineSiebelink9-111/+290
- Bug analysis showed some unclear and complicated code for building URLs - This patch is to clean up the related code and show more clearly what is encoded and what is not - Use SPringBoot provided builder to apply correct encoding of all URI parts - DmiOperations base class no longer need as no common code model and data operations anymore - Converted builder to POJO (client needs to provide the only dmi properties upon build) - Added some missing test (in affected code) to increase coverage percntage (as the production code has significantly reduced in size the overal coverage was inadvertently reduced below the treshold) - Added more unit test. Now impl.operations' package has 100% - removed the test fro Dmi Exception that was incorrectly callign the handleException methdod directly instead of mocking an exception it was really a dupclicate of a test I added but I was able to re-use the event checkign in my test Issue-ID: CPS-2246 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I1ff196cd03bbb95f5877ee590c321febeb672800
2024-05-29Merge "CPS-2187 - Move Module Set Tag into request body for dmi data access ↵Sourabh Sourabh2-20/+19
passthrough calls"
2024-05-29CPS-2187 - Move Module Set Tag into request body for dmi data access ↵david.mcweeney2-20/+19
passthrough calls Change-Id: I9c807d2ef5b3712bf3f8ee5db7663d9628eef3bb Signed-off-by: david.mcweeney <david.mcweeney@est.tech> Issue-ID: CPS-2187
2024-05-28Restructure(package) DataJobs feature in NCMP Serviceleventecsanyi3-41/+72
- restructured already existing classes - added testware for AlternateIdMatcher Issue-ID: CPS 2240 Change-Id: I5691ed99627353903689cd2929163f77ed8c4eca Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-05-27CmDataSubscription status code updatempriyank1-4/+3
- Removing the unused NcmpRespnseStatus internal codes and messages - Introducing statusCode 1 for ACCEPTED and 104 for REJECTED of CmSubscription - Added check for status code and message both in the flow Issue-ID: CPS-2238 Change-Id: Id99f099a398392dbef1504f9d7c658665d163902 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-05-27CmSubscription overlapping casempriyank2-3/+35
- Directly ACCEPT the CmSubscription request in case of overlapping scenario - The confirmation will be sent out when the DMI timeout has happened - No request sent out to DMI plugin in this scenario Issue-ID: CPS-2237 Change-Id: Ic799801058e9c8e1c2db8780a42ab85ea306f45e Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-05-23Merge "CM SUBSCRIPTION: add new subscription for non existing xpath"Priyank Maheshwari1-16/+55
2024-05-23CM SUBSCRIPTION: add new subscription for non existing xpathemaclee1-16/+55
- added new method for when adding new subscription for non existing xpath but existing cmhandle Issue-ID: CPS-2207 Change-Id: I149fbaea2f276503cb9d45c8807519bbe0417f3b Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-05-22Remove un-used code of RestTemplatesourabh_sourabh7-41/+30
- Removed unused property belons to resttemplate - Refactored dmi properties class (from static internal class) - Overriden getter method of dmi basepath that removes any leading and trailing slashes from it. Issue-ID: CPS-2202 Change-Id: I16f61388fce2a6b9e258788fa826d485581d6138 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-05-20CPS-2182 - #4 Add module Set tag to NCMPs DMI Batch Data interfacedavid.mcweeney2-2/+25
Change-Id: I46b261e0a0ef2d37a307291931ba67762fb7767d Signed-off-by: david.mcweeney <david.mcweeney@est.tech> Issue-ID: CPS-2182
2024-05-20Merge "CPS-2187 - #6 Add module Set Tag to ncmp (single cm handle) data ↵Toine Siebelink1-7/+9
request to dmi"
2024-05-20Merge "CmSubscription topics param update"Lee Anjella Macabuhay1-2/+0
2024-05-17Replaced RestTemplate with WebClient in synchronous DMI callssourabh_sourabh7-140/+172
- added DmiWebClientConfiguration - use WebClient in DmiRestClient - fixed unit tests - encode query params for DMI request - added configurable buffer size - Re-used ncmp.dmi.httpclient.maximumConnectionsTotal parameter (as documented in RTD) to control webclient connection poolsize Issue-ID: CPS-2173 Change-Id: I21584563034d58e8ae3ff3cbcf172e0d14b408fb Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-05-17CmSubscription topics param updatempriyank1-2/+0
- topic application parameters updated to be in sync with the actual convention we are following for the flow. - environment variables also updated to follow the same - removed the unused parameters related to notification Issue-ID: CPS-2210 Change-Id: If5adb3dac1ce81df5afe2e99f99513adc2011cc9 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-05-16CPS-2187 - #6 Add module Set Tag to ncmp (single cm handle) data request to dmidavid.mcweeney1-7/+9
Change-Id: I59cdb021d8f2f767b943f09715f4becad820e786 Signed-off-by: david.mcweeney <david.mcweeney@est.tech> Issue-ID: CPS-2187
2024-05-16Merge "CPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang ↵Toine Siebelink2-7/+30
Module Resources"
2024-05-15CPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module ↵david.mcweeney2-7/+30
Resources Change-Id: I4f8cf79667e3155f49b9109d26b5807f5d54f90c Signed-off-by: david.mcweeney <david.mcweeney@est.tech> Issue-ID: CPS-2181
2024-05-09Ncmp out event for REJECTED scenariompriyank1-3/+8
- Handling and publishing the event to client when dmi plugin rejects applying the subscription - test scenarios to support the same Issue-ID: CPS-2214 Change-Id: I2ac6d125a7262a7428a962d81a26a33594b570d9 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-05-03Schedule response to clientmpriyank1-0/+3
- Scheduling sending the response by reading whatever is present in the cache for subscription after a pre-configured time. - Also added test validation for the same Issue-ID: CPS-2209 Change-Id: Ifacb0b12734a0529e671b0b63836189a243e453c Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-05-02Merge "Query operation path by alternate id"Daniel Hanrahan1-10/+44
2024-04-30CM Subscription: Link method to publish to DMI in service layeremaclee4-12/+106
- Add call to method to publish to DMI for create request - Refactor calls to all Mappers to a single Mapper class handler Issue-ID: CPS-2196 Change-Id: I6476f47684ea9a0f55a7d207c1931a0fef8aa672 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-04-30Merge "CM Subscription: REfactor classes of producers and consumers"Priyank Maheshwari6-4/+66
2024-04-30Reverted web client changes as it breaking CPS functionality:sourabh_sourabh7-111/+38
1. Error handling not working 2. Unable to make dmi call as url appens extra "/" Commit 1: Replace RestTemplate with WebClient in synchronous DMI calls - added DmiWebClientConfiguration - use WebClient in DmiRestClient - fixed unit tests - ingnored failing NCMP related integration tests (related to WebClient, will be fixed in a future patch) - encode query params for DMI requests Commit 2: Module sync task failing with WebClient - added configurable buffer size Commit 3: Re-use ncmp.dmi.httpclient.maximumConnectionsTotal parameter (as documented in RTD) to control webclient connection poolsize Issue-ID:CPS-989, CPS-2195, CPS-2198 Change-Id: I6c71ab2801b222708404f51bd60f2b3031ebf32e Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-04-29CM Subscription: REfactor classes of producers and consumersemaclee6-4/+66
Issue-ID: CPS-2196 Change-Id: I0b56f37a1b615b9615d6bd7005348733e1739a46 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-04-29Re-use ncmp.dmi.httpclient.maximumConnectionsTotal parametersourabh_sourabh1-0/+1
(as documented in RTD) to control webclient connection poolsize Issue-ID: CPS-2198 Change-Id: Id441208c66433b2539adf83a0881c3c3c79d2b15 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-04-29Query operation path by alternate idsourabh_sourabh1-10/+44
- New method is written to find longest match for fdn path - Introduced new exception for alternate id Issue-ID: CPS-2142 Change-Id: Ifd048574db88586a2d37a3681034a083eb2b7691 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-04-29Merge "Module sync task failing with WebClient"Daniel Hanrahan1-1/+2
2024-04-29Merge "CM SUBSCRIPTION: Remove accepted and rejected cache entries"Priyank Maheshwari2-3/+37