summaryrefslogtreecommitdiffstats
path: root/cps-ncmp-rest
AgeCommit message (Collapse)AuthorFilesLines
2023-08-18Bring back coverage to 1.00 for ncmp-restmpriyank1-1/+1
Issue-ID: CPS-1832 Change-Id: I1704060d0cd56d7c2d2fb7b932a8142d3940120b Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-08-04Update coverage ratio to 0.99mpriyank1-0/+4
- in order to stabilize the builds , updating the coverage ratio for cps-ncmp-rest package to 0.99 from 1.00 - Will bring back to 1.00 once the necessary fixes are in place. Issue-ID: CPS-1832 Change-Id: If0f106d7c1a44294ed67c83a049f667d9ce13b31 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-07-21Prepare for next CPS-NCMP releaseegernug1-1/+1
Issue-ID: CPS-1797 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: Ib2b840b6b37131f16afd879720658d2e45387d6a
2023-07-21Increase timeout for PollingConditionsegernug1-2/+2
Test failing due to timing issues. Increasing timeout to rectify. Issue-ID: CPS-475 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: I89b512809922470f10940fcdd739f057b8f9c80e
2023-07-20Merge "Refactor ncmp request handlers (fix async issue)"Sourabh Sourabh9-245/+371
2023-07-20Refactor ncmp request handlers (fix async issue)ToineSiebelink9-245/+371
- simplified request handlers (sub)classes (no more need for default interface) - fix issue with async execution of data operation requests (wasn't really async) - removed redundant (unreachable) check in production code - Improved code coverage (branches) ncmp request handlers added UNIT test - removed MVC test scenarios now covered by appropriate unit level tests - applied Spock Polling Condition for verifying async call Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Ibe601c709de65080fa8898f2419fdbd92c5ba27d
2023-07-19Prepare for next CPS-NCMP releaseegernug1-1/+1
Issue-ID: CPS-1791 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: Ide0fcdfa41656e25395ac8478da1bb489fd8663e
2023-07-13Introduced a dmi rest demo csit stubsourabh_sourabh1-4/+2
- Introduced a new response code 0 for data operational success response. - Created a new dmi plugin rest stub for demo and performance testing. - Removed dmi plugin stub of wiremocked. - Updated parent pom to add newely created demo stub. - updated docker compose to add neww demo stub with profile for CSIT, demo and performance testing. - Removed target id list from unsupported operation/datastore from REST response. Issue-ID: CPS-1560 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: Ie8198366df820e7d4b8b6e8a85ff9cdb0fce7435 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2023-07-11Combine alreadyDefinedException classesdanielhanrahan2-12/+10
Issue-ID: CPS-1774 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I52ff9074a9f8188e8635a811b0d2713a97cb4b10
2023-06-30Prepare for next CPS-NCMP releasempriyank1-1/+1
- updated the docs. - Bumped the version to 3.3.4-SNAPSHOT for the next release. Issue-ID: CPS-1773 Change-Id: Ibe9a694baadb33d284913868452b143c14d105cc Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-06-27Generate docs using OpenAPI 3.0egernug1-1/+16
Doc generation in OpenAPI 3.0 requires executions for each file being generated. This change adds those executions and updates the dependency to copy these files. Issue-ID:CPS-1745 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: I144b49b0066f798f15408d955dcd914dd2c0bc91
2023-06-26Chsnge to OpenApi 3.0egernug6-29/+31
In preparation for the Java 17 and Springboot 3 migrations Swagger Codegen has to upgrade to OpenApi 3.0 This effects cps-rest and cps-ncmp-rest Issue-Id: CPS-1745 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: I18b8e9ca26d0123009702c2474efbfbeec6d4c44
2023-06-22NCMP : Replacing the word 'Batch' as 'DataOperation'.raviteja.karumuri10-98/+99
Issue-ID: CPS-1754 Signed-off-by: raviteja.karumuri <raviteja.karumuri@est.tech> Change-Id: Ie9f56effb160582ba7177331fb6260b2bde2342b
2023-06-15Bump CPS version to 3.3.3-SNAPSHOTdanielhanrahan1-1/+1
- Update version properties as well as we prepare for the next release. Issue-ID: CPS-1750 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I0626eee7834499d2fa96812fb416ce7daebf0529
2023-05-25NCMP: Update existing Batch endpoint (Moving url param into rest body)sourabh_sourabh12-104/+272
- NCMP batch endpoint is updated to accept details into request payload. - Removed unused code of previous impl. Issue-ID: CPS-1635 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: Ic290b750557da06b861c5a4a9bb12debc495ec2e Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2023-05-09NCMP: Delete DatastoreType enum from cps-ncmp-restsourabh_sourabh5-104/+6
- Delete duplicate enum of datastore - Use datastore from cps-ncmp-service Issue-ID: CPS-1635 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I36484d6a327c81d81741b18a932fc6a1febfc520
2023-05-03Refactor datatrore handling in API requestsToineSiebelink10-245/+164
- Fully parameterized datastore(name) - Improved controler testing to verify all parameter handling - Simplified service inject (alwasy using contructors instead of @AutoWire) - Added delay to fix isuse with intermitting failign test that tests invocation of a method that is executed on a separate thread Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Iba5d118d2484badee9c7c90ec7694882f6557d16
2023-05-03Bump CPS version to 3.3.2-SNAPSHOTmpriyank1-1/+1
- Update version properties as well as we prepare for the next release. Issue-ID: CPS-1666 Change-Id: I44e44ac1755c44d7050ce30c9e40f83628fe9338 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-04-27CPS-1553 :REST endpoint to accept collection of cm handles for GET operationsourabh_sourabh15-351/+486
-Introduced an interface having all un-implemented or default defination of any method that is further extended or implemented by abstract or stubbed controller. -Exposed an endpoint to accept bulk request -Modified an existing methods for more readability. (Parameterized datasource for ... methods) -Code impl. for getResourceDataFromDmi method to send bulk request to new proposed dmi-plugin endpoint that would accept bulk request. -We need to investigate a groovy test that fails only into onap CICD pipeline. For now it's commented out by added TODO tag. (org/onap/cps/ncmp/rest/controller/NetworkCmProxyControllerSpec.groovy:205) Issue-ID: CPS-1553 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: Ieac39690956e3a0eab41068db57c5d93a16d04f0 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2023-04-203.0.0 Release Step 7lukegleeson1-2/+2
Issue-ID: CPS-1631 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I9d9ea58a769d7b577a90bacf29191aaf4efb6b41
2023-04-07[CPS] Bump minor version - Step12mpriyank1-1/+1
- bump minor cps version from 3.2.7-SNAPSHOT to 3.3.0-SNAPSHOT which is step11 of the release process Issue-ID: CPS-1610 Change-Id: I74f20a7a7fa1edad417c40a09a60fecc0a96ccb7 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-04-03500 Error Response on NCMP ID-Searches Testingseanbeirne1-1/+43
Issue-ID: CPS-1563 Signed-off-by: seanbeirne <sean.beirne@est.tech> Change-Id: Idc393e90d31b369095bc2b122537e17a4464a364
2023-03-23Prepare the next drop by bumping patch versionhalil.cakal1-1/+1
- Bumping modules up to 3.2.7-SNAPSHOT - Update version.properties and release notes Issue-ID: CPS-1577 Change-Id: Ib223c8bea164c42caceaba31a13f43c77d55c48c Signed-off-by: halil.cakal <halil.cakal@est.tech>
2023-03-22500 Error Reponse on NCMP inventory cmhandle searchseanbeirne1-1/+4
Issue-ID: CPS-1563 Signed-off-by: seanbeirne <sean.beirne@est.tech> Change-Id: I5579e8e852c20ce61a6684140198e989f7876d79
2023-03-10Bump CPS versionmpriyank1-1/+1
- bump cps version to 3.2.6-snapshot Issue-ID: CPS-1547 Change-Id: I397b8e5f22269c270c2fa7823713869b478622f9 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-03-09Bump CPS versionmpriyank1-1/+1
- bump the CPS version from 3.2.4-SNAPSHOT to 3.2.5-SNAPSHOT Issue-ID: CPS-1543 Change-Id: I28e46fdeff86c71bd1ad89ae9aaef8ddb4994bfc Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-03-07Release process stage 7seanbeirne1-1/+1
Issue-ID: CPS-1529 Signed-off-by: seanbeirne <sean.beirne@est.tech> Change-Id: Ie6c6276f4612b919762479d2461b4e72cb886245
2023-03-02Refactor cmHandle(ID) queriesseanbeirne2-7/+8
- first execute cm-handle id search only - get cm handles for ids only when needed using multiple-get-method - use Collection interface where posisble (instead of Set) - use java Function to combine multiple queries in a more genric way Issue-ID: CPS-1494 Signed-off-by: seanbeirne <sean.beirne@est.tech> Change-Id: Icfcb8ec94f75e261303aaee5c9034b920c01f3c4
2023-02-08Release Process Step 7mpriyank1-1/+1
- updated pom to 3.2.3-SNAPSHOT - updated version.properties and updated the release notes to properly depict the correct version Issue-ID: CPS-1476 Change-Id: Ied60194c6dd4153b58a43715cb729ad75b8e12bf Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-01-31Merge "Introduce Instrumentation"Luke Gleeson1-1/+4
2023-01-31Introduce InstrumentationToineSiebelink1-1/+4
- Add instrumentation related dependency - Added Timed Instrumentation - CPS-Service Crud methods - CPS Yang parsing - NCMP Registration methods - NCMP Events handling - Remove manual Gauge for YanResources Cache as (better!) instrumentation is already built into the 3PP - Sorted dependecies alphabetically (as we used to enforce, to prevent duplicates) - Added ## P E R F O R M A N C E T E S T R E S U L T S ### mini report - (unrelated) test improvement (because of bug that turned out to be invalid) Reviewers: Sourabh,Priyank, Luke Issue-ID: CPS-1457 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I34b20bece2f59488b022b8effa9470704c57be4d
2023-01-30Edit example given for ncmp datastoreseanbeirne1-1/+1
Issue-ID: CPS-1468 Signed-off-by: seanbeirne <sean.beirne@est.tech> Change-Id: Id746604fca83333f4ee186ce96ea80cb779c4ac2
2023-01-27Update version files for release processseanbeirne1-1/+1
- Updated version.properties - Updated release-notes - Updated pom files Issue-ID: CPS-1835 Signed-off-by: seanbeirne <sean.beirne@est.tech> Change-Id: I0f837ac41d24b41d7c2b9e3dfe2dacc550c0aafa
2022-12-01Filter on private properties of CM Handlesleventecsanyi7-3/+101
- Moved cm handle query validation to cps-ncmp-service (where it belongs!) - Added new enum type for private/public field types - Created new methods for private and public queries - Added new REST endpoint - Created service methods for filtering on different types of properties - Refactored getPublicPropertyPairs and queryCmHandleAnyProperties - Added unit test for the controller layer - Fixed refactoring suggestions - Imporved code coverage with unit tests - Refactoring - Added new functionality to NcmpRestInputMapper - Updated version number to 3.2.1-SNAPSHOT and updated release-notes.rst Issue-ID: CPS-1236 Change-Id: I0ddf6866473f7c3c6b8507d222d441bf97ca6bdc Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2022-11-15Query data NCMP-Operational with CPSpathlukegleeson14-152/+368
New GET Endpoint: /v1/ch/{cm-handle}/data/ds/{ncmp-datastore-name}/query?cps-path={CPSPath} Implemented error for {ncmp-datastore-name} other than operational - (Toine) Refactored and renamed (abstract) handler for better re-use Mainly by introducing a separate handler for OperationalQuery Reviewers Toine, Sourabh, Priyank Issue-ID: CPS-1002 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: Iaca018869d95d4ce800072431baa190050a6dad0
2022-10-26Merge "[NCMP] Add Basic Auth to OpenAPI Definitions"Toine Siebelink2-1/+15
2022-10-24[NCMP] Add Basic Auth to OpenAPI DefinitionsJosephKeenan2-1/+15
-Adding basic auth to OpenAPI definitions Issue-ID: CPS-1350 Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Change-Id: Iab677f2abc07eed8c3e2910191b15ba27028ee88
2022-10-19Improve code coverageleventecsanyi4-49/+7
- Fixed and refactored unit test to get over the 97% coverage baseline. - Removed unused exception. Issue-ID: CPS-475 Change-Id: I6dbcba58b880a584f6d9346e2aca6c763e5d2081 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2022-10-18Merge "Fix SonarQube Violations"Joseph Keenan2-1/+3
2022-10-17Bump the minor CPS versionmpriyank1-1/+1
- Bumped the CPS version from 3.1.5-SNAPSHOT to 3.2.0-SNAPSHOT - Step 11 of the release process. Issue-ID: CPS-1318 Change-Id: I0dce0070afcc019d2562c2f3ab9fe02207dcd86b Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-10-17Fix SonarQube Violationsleventecsanyi2-1/+3
- Fixed SonarCube issue: added private constructor to TopicValidator and a unit test. Issue-ID: CPS-475 Change-Id: I4379522f023f32c8999a3ee595392bfbab147050 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2022-10-05Bump CPS version to 3.1.5-SNAPSHOTmpriyank1-1/+1
- Bumped the version to 3.1.5-snapshot and updated the version properties file Issue-ID: CPS-1325 Change-Id: I61848166b94a5ce14651f2d0fe42e4cc39f5c5e2 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-09-30Bump CPS to 3.1.4-SNAPSHOTmpriyank1-1/+1
- bumping the cps version from 3.1.3-SNAPSHOT to 3.1.4-SNAPSHOT - Also updated the release notes to accomodate 3.1.4 version changes Issue-ID: CPS-1313 Change-Id: I487ab4301123cce6afb5a4086b8ebca24acf5e14 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-09-29Bump CPS to 3.1.3-SNAPSHOTmpriyank1-1/+1
- update cps to 3.1.3-SNAPSHOT Issue-ID: CPS-1309 Change-Id: I43b1442533d10c32a74808830239e83f4abed9c0 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-09-28Prep for 3.1.2 of CPSmpriyank1-1/+1
- updated release notes - bumbed cps version to 3.1.2-SNAPSHOT from 3.1.1-SNAPSHOT Issue-ID: CPS-1304 Change-Id: Ie65f76032b087dffc716e00fa3868f89f165a6b1 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-09-23Prepare for next CPS Core releasempriyank1-1/+1
- Bumping the CPS Core version from 3.1.0 to 3.1.1 Issue-ID: CPS-1295 Change-Id: I6bdff6dd3b266a24c3e89ba811be6bc64beb6e54 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-09-13Handle partial failure (improvements)ToineSiebelink2-8/+19
- catching of failures on retry of individual nodes - extract cm handle id from xpaths (can only report xpaths in cps core) - add test for same Issue-ID: CPS-1232 Issue-ID: CPS-1126 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Ice2032c8b15fea97ae0aaa4d1ed642b3499228fa
2022-09-07Handle invalid operations on merged datastore endpointbmiklos7-33/+142
- Move the other endpoints under the same thats handling the get - Add exceptions to handle invalid cases - Add new tests for testing the invalid cases Issue-ID: CPS-1001 Issue-ID: CPS-1219 Change-Id: I26fd57b5921f976cde7089b4cf1e8c0e5d8dc43b Signed-off-by: bmiklos <miklos.baranyak@est.tech>
2022-09-01Implement merging all ncmp datastore endpoints into onebmiklos18-305/+823
- Merging all endpoints under /v1/ch/{cm-handle}/data/ds/ncmp-datastore:* to /v1/ch/{cm-handle}/data/ds/{ncmp-datastore-name} - Implementing missing tests from parent - Introducing abstract class to keep the common code and just pass in the supplier to be executed in sync or async manner - Removed the existing get endpoints for passthrough-running, passthrough-operational and operational and merged them into a common get endpoint Issue-ID: CPS-1178 Issue-ID: CPS-1001 Change-Id: I6956c81d5acfa8fb11217bcc16cb795b62070fa3 Signed-off-by: bmiklos <miklos.baranyak@est.tech>
2022-09-01Get all cm handles by DMI plugin Identifieremaclee5-4/+70
- api added to get cm handles by dmi plugin identifier - response object refactored from RestOutputCmHandle to collection of Strings (cm handle ids) - added public and private methods in CmHandleQueries to get cm handle ID by dmi plugin - added unit tests including test to show that there are no duplicates on response Issue-ID: CPS-1136 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: Ia3bdc16172a90ad3a3f9ae11cddcad1352188726