summaryrefslogtreecommitdiffstats
path: root/cps-ncmp-rest
AgeCommit message (Collapse)AuthorFilesLines
2022-04-08Fix Sonar Qube Violations - Recurring taskDylanB95EST1-1/+2
Fix sonar issues in CPS. - Remove Unnecessary cast to List - Immediately return expession Issue-ID: CPS-475 Change-Id: Ic3fa2f3f92784682045a780d87c6737d04f37659 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-04-08Refactoring/ Adding Tests for ValidationDylanB95EST4-4/+4
Refactored classes affected by validation Have added tests for anywhere where validation is used Have refactored the parse and sync modules validation to be validated at the public api method Issue-ID: CPS-322 Change-Id: I4989cfd03300fbdca41571d0aa2d0b96978858ba Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-04-06Query based on Public CM PropertiesJosephKeenan5-2/+86
-Updated OpenAPI for new Endpoint -Will replace SQL with CPSPathQuery once investigation is complete -Functionality in place to determine if public properties match - -Added Unit and CSIT tests - small modifications may need to be made -CSIT tests enhanced to add additional nodes and tests Issue-ID: CPS-731 Change-Id: I403e603ce79c4a4a6994d51b459b5703510d5a83 Signed-off-by: DylanB95EST <dylan.byrne@est.tech> Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2022-04-05Async: NCMP Rest impl. including Request ID generationsourabh_sourabh2-18/+104
- Restructured code and moved some of them at controller and service layer. - Unit is fixed and organized to it's belonging classes. Issue-ID: CPS-828 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I0919218e35b1d11cb579d707f376b76de80409da
2022-04-05[cps] Fix getResourceDataForPassthroughOperational endpointputhuparambil.aditya4-29/+6
Get endpoint only accepts application/json. Issue-ID: CPS-957 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: Ifc7426fbcd6073a39554014dc18b2107b6343b16
2022-04-05Merge "Structured Exception details for DMI"Bruno Sakoto4-4/+77
2022-04-04Structured Exception details for DMImpriyank4-5/+77
- Introduced DmiErrorMessage in API docs with 502 Bad Gateway - HttpClientRequestException will be thrown which will be exposed as 502 BAD Gateway for the client from NCMP Issue-ID: CPS-917 Change-Id: Iba8f159e8216bc1f63a9ab86208e5c802437e2e8 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-04-01Update CM-Handle registration responseRenu Kumari4-12/+190
- update openapi.yml with new response structure - send only details of failed cm-handle operations - updated csit to validate 200 status Issue-ID: CPS-896 Signed-off-by: Renu Kumari <renu.kumari@bell.ca> Change-Id: I3b868bcc5b8ff488c31faef51edc82c771452234
2022-03-30Additional validation for names/identifiersDylanB95EST4-6/+5
Implementing additional regex validation for names/identifiers in CPS - Introduces a CpsValidator - Applies to relevent java public API's - Tests have been updated where necessary Issue-ID: CPS-322 Change-Id: I29ab8820bb1fe0eee247e425d6bb018bcd38f28e Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-03-21Update versions for next releaseToineSiebelink1-1/+1
Update Minor version number (on master) for next release as part of creating Jakarta release branch Issue-ID: CPS-952 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Ie96ae7ce8997774d3ea27275c73e7d0703257e5e
2022-03-16Upgrade to next snapshot versionBruno Sakoto1-1/+1
Issue-ID: CPS-933 Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca> Change-Id: I5ba87c850aa932737cc62e312a825c69a3db5a02
2022-03-14Async: NCMP Rest impl. including Request ID generationsourabh_sourabh1-1/+3
- In case of invalid topic return http status 400 with error message - Unit test is modified to handle/validate InvalidTopicException Issue-ID: CPS-828 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I05645c92ccebb8aa422a47f6edcde7b64088a118
2022-03-14Merge "Replacing ModelMapper with MapStruct"Toine Siebelink9-30/+65
2022-03-11Merge "Async: NCMP Rest impl. including Request ID generation"Bruno Sakoto6-24/+83
2022-03-11Merge "Updated cmhandle registration openapi documentation"Toine Siebelink1-11/+11
2022-03-10Updated cmhandle registration openapi documentationRenu Kumari1-11/+11
- Fixed the cmhandle registration request example Issue-ID: CPS-896 Signed-off-by: Renu Kumari <renu.kumari@bell.ca> Change-Id: If4a7c820add676adb9637ce56678da3f5607bbcd
2022-03-10Replacing ModelMapper with MapStructlukegleeson9-30/+65
- Removed Model Mapper from pom files - Replaced ModelMapper with MapStruct - Added Tests for MapStruct - Changed mapstruct annotations for individual variables to be null safe rather than all variables - Excluded generated code from code coverage - Set ModuleReferences input to required for SchemaSet so that ModuleReferences list set to empty list rather than null Issue-ID: CPS-127 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I43f874aea79f58dda5526c6fdead27d8474d90af
2022-03-10Removed ExtendedModuleReference Objectsourabh_sourabh1-1/+1
-Introduced ModuleReference with 2 prop name and revision -Removed default constructor of ModuleReference Issue-ID: CPS-592 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I27a8a521f133c0773ef0aa0b9700ac42f6bc613b
2022-03-10Async: NCMP Rest impl. including Request ID generationsourabh_sourabh6-24/+83
- Based on topic api can be sync or async - RequestId is generated using UUID - Used UriComponentBuilder to populate dmi service url. - New test cases are introduced to validate service url generation. Issue-ID: CPS-828 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I2696d5cb012d9274b0c1265f16aa9b2369657f05
2022-03-01Create Endpoint For Get Cm Handles By NameDylanB95EST9-36/+124
Create endpoint and implement logic for get cm handle details by cm handle name Issue-ID: CPS-817 Change-Id: I83bd2da9219d13fac715a08b19108028ca6f6751 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-02-28NCMP Java API depends on NCM-Rest-API (cyclic) through json properties on ↵DylanB95EST13-67/+236
Java API Using POJO and new converter class instead of previous object mapper Issue-ID: CPS-893 Change-Id: I75531f386f08cb172d2901a4bbe97ae22cc5937e Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-02-28Merge "Updated openapi.yaml to match to changes in get data node API"Toine Siebelink1-1/+1
2022-02-28Updated openapi.yaml to match to changes in get data node APIputhuparambil.aditya1-1/+1
1. updated the pom version to 3.0.0-SNAPSHOT 2. modified the examples for get data node api to match the post api. Issue-ID: CPS-865 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: Icf03522e9ba7fb9c245fd9f09b3eb8bb6f3ee60d
2022-02-25Fix success response code CM Handle Registrationmpriyank5-28/+61
- changed registartion response code to 204 NO_CONTENT - improved exception handling for registration API - fixed failing csit related to changed response code - updated the release notes for CPS-892 and CPS-837 Issue-ID: CPS-892 Change-Id: I616e340debf1583b058e7ae6b8960972eec00f3e Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-02-16Core logic to update,add or remove cmHandle propertiesmpriyank1-0/+10
Issue-ID: CPS-837 Change-Id: Ia078b6a0291ae916931259a309dd592b0554da28 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-02-14Improve logging in NCMPsourabh_sourabh1-0/+3
- Code to change to apply logs at runtime - Fix for minor code smell Issue-ID: CPS-855 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I93a556fe0fb7ca05a42e84eb5ec4f84afaa8fd92
2022-02-02[TECHDEBT] Align CPS NCMP REST API SpecificationJosephKeenan5-24/+50
- Updated ncmp.yml to align implementation with specification - Added new Exception classes to differentiate between server NCMP issues and client based NCMP issues - Added 500 error to specification - To be merged after https://gerrit.onap.org/r/c/cps/+/126848 - Added excpetion handlers for SerNcmpException & DmiRequestException Issue-ID: CPS-823 Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Change-Id: If1c9c6c29c6ea2daa07753d7f766ef15c1ba4ca0
2022-01-28Support 'public' Cm Handle PropertiesDylanB95EST3-7/+11
Add support for new Public Additional Properties list to Register CM Handles API Issue-ID: CPS-677 Change-Id: I6efc88734da2416f72f71a403622e519398b502d Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-01-27Merge "Improve logging in NCMP"Toine Siebelink1-4/+1
2022-01-25Improve logging in NCMPsourabh_sourabh1-4/+1
Issue-ID: CPS-855 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I5d8a6a711d1c6b13d5d8eeba52a1dcd689dbdae2
2022-01-25Replace gson mapper with jackson mappersourabh_sourabh4-28/+33
We introduced JsonObjectMapper (wapper) as Spring component. Issue-ID: CPS-751 Change-Id: I536b0771a3a263325e6907717baf6941d70c0d6c Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2022-01-21Merge "patch operation for ncmp running"aditya puthuparambil3-4/+48
2022-01-21patch operation for ncmp runningtragait3-4/+48
Signed-off-by: tragait <rahul.tyagi@est.tech> Change-Id: Ib136291963a5d7f115c8637708a1d5a64c62c9f2 Issue-ID: CPS-641
2022-01-19[TECHDEBT] Remove deprecated API methods related to NCMPmpriyank5-400/+10
CpsQueryService instantiation removed as it was not in use. License Header updated for Nordix Foundation to 2021-2022. Issue-ID: CPS-642 Change-Id: I1aa204730f5d347d379cfdaaf0740323a317a559 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-01-04Remove compulsory body from delete passthrough requestToineSiebelink3-20/+8
- yaml spec (please note how order of parameter changed!) - Updated CSIT test - Slight improvement of cist setup script to prevent double download Issue-ID: CPS-836 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Ic3510c9dfe28a3be09f5239ab5c8c4797d4f4792
2021-12-20Fix Sonar Qube Violations - Recurring tasksourabh_sourabh1-0/+6
Issue-ID: CPS-475 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I5c10360ec42bc9737ed86140398ef954109275dd
2021-12-13Define response objects(schemas) in cps-ncmpputhuparambil.aditya5-81/+105
Issue-ID: CPS-559 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: Id181f2a1b9554118f5e7464c95e873f09fc908eb
2021-12-08Support Delete operation for ds Passtrough-Running in NCMP 1/3DylanB95EST3-7/+75
Add delete operation for passthrough running within cps-ncmp. Issue-ID: CPS-638 Change-Id: I360672adc1f0f5c8eb351391c94f2d4fa913d0b4 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-12-07Merge "CPS-723: Add Examples in the NCMP openapi"Niamh Core2-29/+118
2021-12-03CPS-723: Add Examples in the NCMP openapiemaclee2-29/+118
Issue-ID: CPS-723 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: I1263402595c0f97db7390716fcf8e086edc0a78a
2021-11-26Patch operation passthrough runningniamhcore3-0/+55
Issue-ID: CPS-640 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I6badf241bbec265800d6b316da7ab8ad7782eb17
2021-11-25Allow separate registration of DMIDataPlugin and DmiModelPuginJosephKeenan5-37/+104
Moved relevant code from NetworkCmProxyDataServiceImp to DmiOperations Split DmiOperations into DMiData... and DMIModelOperations Merged update-operation changes Added tests for error message validation in NetworkCmProxyDataServiceImplSpec Removede @Service from DMIOperations and added @component to DmiDataOperations & DmiModelOperations Verify sync robot test is now hardened Added exitonfailure so robot tests stop after first encountered failed test Issue-ID: CPS-736 Change-Id: I0b40931cc8cd4fc0452328a0a7e0f60e6fc38d0a Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2021-11-15Merge "Update operation passthrough running - Service Layer"Toine Siebelink2-9/+14
2021-11-10Update operation passthrough running - Service Layerniamhcore2-9/+14
Issue-ID: CPS-636 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I13334df383a23e59b3368b8664c10e086b1eb4a8
2021-11-10Fix for get cm handle identifiers response bodyniamhcore2-10/+11
Issue-ID: CPS-636 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I35dabf8e5839c56a9ae1851495cc9bf15e633c21
2021-11-08Update operation passthrough running - openapiniamhcore3-0/+51
Issue-ID: CPS-636 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I16d7d84ae6897e3901f5f5a5a59dbc5deae7d4e8
2021-11-02Add get cm handles by modules names - service layerniamhcore5-5/+106
Issue-ID: CPS-644 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: Ic2a57df02d533a0066382c12c35be8d524b6cdad
2021-10-20Add get cm handles by modules to open apiniamhcore4-2/+86
Issue-ID: CPS-644 Signed-off-by: niamhcore <niamh.core@est.tech> Change-Id: I228782027cafcf59843ff4b8de1dd5ea3988ddba
2021-10-14Step 10 : Bumping origin/master version cps-2.1.0puthuparambil.aditya1-1/+1
Issue-ID: CPS-727 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I2b287e4443be9214f89e90880af3c33ec0424e92
2021-10-14Step 6 : Bumping version cps-2.0.2puthuparambil.aditya1-1/+1
Issue-ID: CPS-727 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I83035b8e504a1c52e222ba1bd247cbc26ea01ff5