aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2024-06-26Move TrustLevel FeatureToineSiebelink32-148/+146
-Moved TrustLevel impl from Controller to Inventory Facade -Applied new package name convention using impl\inventory\trustlevel for this (sub)feature -Renamed some trustlevel related classes to better describe their role -Disabled failing architecture test (agreed this is tech. debt and created CPS-2293) -Refactored YangDataConverter method names and signatures (moved Spec to correct place) -Cleaned up names and javadoc of class now called DeviceTrustLevelMessageConsumer -Applied conventions to modified test methods Issue-ID: CPS-2255 Change-Id: Iccd20541488e6b61444bb2c7406c90e61a34124d Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-24Repackage Inventory FeatureToineSiebelink117-493/+498
- decided that cm handle queries is part of 'inventory' feature - a lot of files (~100 total) have changes because of some files have been moved. - The reviewers should probably just focus on the MOVED/renamed (~30) files - New packages (top level only): -- org.onap.cps.ncmp.api.inventory -- org.onap.cps.ncmp.impl.inventory -- org.onap.cps.ncmp.impl.models (common models NOT used in API, this was unforeseen) -- org.onap.cps.ncmp.impl.utils - I am NOT updating copyright years as part of this commit since there are no real code changes and it is simply NOT worth the effort TODO: - extend scope to 'TrustLevel' as an 'internal feature' (TBD) Issue-ID: CPS-2255 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I40b4efc8326068ab9ae1f31b77f46b2fe8579431
2024-06-21Fix compile issue after facade introductiondanielhanrahan2-3/+3
Due to automatic rebase, a method got renamed in one commit but not the other. Issue-ID: CPS-2263 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Id0fa8eba79cb98bb24419bfddc0c9b9e8c9a42d3
2024-06-21Merge "Introducing NCMP Facades"Sourabh Sourabh44-1342/+1241
2024-06-21Merge "Spliting a data-job into sub-jobs for DMI Plugin"Sourabh Sourabh14-27/+502
2024-06-20Introducing NCMP FacadesToineSiebelink44-1342/+1241
- NetworkCmProxyDataService was polluted with many non-data operations - it is now split into: 1) NetworkCmProxyFacade, a single thin facade for the (main) controler to redirect calls to the correct services 2) CmHandleRegistrationService(Impl), methods related to registration only - introduced NetworkCmProxyInventoryFacade for the invenoty controller - renamed some services for consitency and clarification - Use facade to acces ncmp data request handlers (instead of direct from controller) - remove unnecesarry wrappings between request handlers and facade - split facades according to names: data & inventory (the REST controllers are not split properly so I think one rest controller will end up needing both facades) Issue-ID: CPS-2263 Change-Id: I250732aa16ec28b43ff642d2adf10ba36f67290e Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-20Bump CPS version to 3.5.1-SNAPSHOTmpriyank25-25/+53
- bump cps version to 3.5.1-SNAPSHOT - updated release notes to make it ready for the next release Issue-ID: CPS-2283 Change-Id: I242cae7c95a87c1a9e225cce3eb7b36097f1e5ba Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-20Maven container yaml for releasempriyank1-0/+8
- added maven container yaml to release cps 3.5.0 version Issue-ID: CPS-2283 Change-Id: I45ce5b440d8ca2f6ff3999971202f9fc3bd4a8fa Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-20Spliting a data-job into sub-jobs for DMI Pluginleventecsanyi14-27/+502
- algorithm for create sub-job requests - added new method to DmiServiceUrlBuilder to get the write job url - created WriteOperationExaminer, DmiSubJobClient & testware Issue-ID: CPS-2142 Change-Id: I258d334ef346cd388341a1deb4078d24d8bdb7cc Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-06-20Maven yaml for releasempriyank1-0/+4
- added maven yaml file to release cps 3.5.0 Issue-ID: CPS-2283 Change-Id: Ifc9cc9f33381d64bf573593949cf59303ff8d0fc Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-20Release notes and OpenApi syncmpriyank2-10/+151
- Release notes updated and openapi syncd for CPS-Core and NCMP Issue-ID: CPS-2283 Change-Id: Iafdebc65cbcec01bf0d6e6963bd9601fea5f5081 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-19Addressed an adaptability issuesourabh_sourabh1-5/+5
- Defined a constant instead of duplicating literal "No data nodes 4 times. Issue-ID: CPS-478 Change-Id: I2b980a228217e85424342d4c2b9e97c5cfa618d1 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-19Handle high frequency (faster then DMI) of passthrough request in NCMPsourabh_sourabh7-71/+113
- Added pendingAcquireMaxCount property into appliaction.yml. - Added findbugs google annotations dependency. - Supressed "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE" spotbugs low error for reactor.netty.resources.ConnectionProvider. Issue-ID: CPS-2262 Change-Id: Ie755e40282473933f2052fbe7654e7090bb9b337 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-17Merge "[k6] Add JVM warmup phase (#2)"Priyank Maheshwari4-9/+14
2024-06-17Merge "[k6] Refactoring k6 tests (#1)"Priyank Maheshwari15-117/+174
2024-06-17Refactor and Move NCMP Data Request HandlersToineSiebelink13-157/+126
- Simplified NCMP Rest Request Handlers - Moved responsEntity wrapping to Controller so most handler methods can have clear return types - Moved NCMP Rest Request Handlers to Service Layer - Moved related exceptions and utils to Service Layer - Used Lombok for constructors - Improved related testware Issue-ID: CPS-2266 Change-Id: I0025fab1c92e0d613825093b6e4b43dae044c01a Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-14[k6] Add JVM warmup phase (#2)danielhanrahan4-9/+14
To account for JVM warmup effect, the k6 test suite is run twice: initially, the whole test suite is run without recording results. - Added environment variables to allow setting total CM-handles and batch size for registration. By reducing total CM-handles during warm-up, many more operations will be run. Issue-ID: CPS-2264 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ib1d1e76d31719d788a3e026797faa0a425b320a2
2024-06-14[k6] Refactoring k6 tests (#1)danielhanrahan15-117/+174
This commit moves all common request logic into a common folder. It is needed to avoid duplication before adding JVM warmup phase. - move registration-related code into common folder - move passthrough operations into common folder Issue-ID: CPS-2208 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ia9ebf61d21044b43063bde153f9c526e67d607c8
2024-06-14Update ONAP DMI version in NCMPmpriyank2-2/+2
- update the docker compose file to point to latest version on onap-dmi-plugin. Same to be used to run the CSITs during build. Issue-ID: CPS-2271 Change-Id: Ifbb2ee9c9548d54979a04595e19062d9192bfd1d Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-13 #2: Used async version of web client for single cm handle read operationsourabh_sourabh16-344/+162
- Code change is done to use async web client for single cm handle read data operation. - CpsNcmpTaskExecutor class and groovy test code is removed. - Use of supplier code is removed from cm handle Query service. Issue-ID:CPS-2259 Change-Id: I2b7a36e8a151a9224937afd876fceb30be6a24ce Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-13 #1: Used async version of web client for batch read operationsourabh_sourabh10-196/+136
- Exposed async version of post method into dmi rest client. - Code change is done to use async web client for batch data operation. - Use of CpsNcmpTaskExecutor code is removed. Issue-ID: CPS-2174 Change-Id: I7840fd8c6d9debe42e50c860f9cf39d64274df72 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-10Merge "[k6] Refactor k6 tests for CM handle searches"Lee Anjella Macabuhay8-66/+46
2024-06-06Merge "Cm Subscription: Predicates optional now"Lee Anjella Macabuhay2-4/+2
2024-06-06[k6] Refactor k6 tests for CM handle searchesdanielhanrahan8-66/+46
A cleanup of the k6 tests to avoid code duplication Issue-ID: CPS-2208 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: If1e58ee87300cd28ed72b365d9a86e2709dc6c13
2024-06-06#1: Dedicated web client instance is assigned for data, model and health ↵sourabh_sourabh14-163/+340
services - Switched web client instance based on dmi service type (like data or model) - 3 diff. beans are configured for data, model and health dmi service. - Added configurable properties for data and model. - Hard coded properties are assigned for health service. Issue-ID: CPS-2231 Change-Id: I39fb739c07c41430dae43509fe29ece5306b7d71 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-06Cm Subscription: Predicates optional nowmpriyank2-4/+2
- making the predicates sectional OPTIONAL as the schemas are common for both create and delete use case and we dont have the need to send in the predicates information for DELETE use case. - Delete is done based on the incoming subscriptionId only Issue-ID: CPS-2252 Change-Id: I43ec480821a6088c5fa161480ce2b29b660a2ba5 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-06CPS Delta API 2: Delta between anchor and payloadArpit Singh13-29/+478
- Second API to get Delta between an anchor and JSON payload - added new API getDeltaByDataspaceAnchorAndPayload - added controller and service layer methods getDeltaByDataspaceAnchorAndPayload - Core Delta algorithm remains same as the first API. getDeltaByDataspaceAnchorAndPayload will call getDeltaBetweenDataNodes Issue-ID: CPS-1836 Signed-off-by: Arpit Singh <as00745003@techmahindra.com> Change-Id: Id74cd930ce48e5cb414aa62c5381b79675788a37
2024-06-06Merge "Change ApplicationEvent for ModelLoading"Toine Siebelink5-26/+25
2024-06-05XML content support on update node leavesRudrangi Anupriya17-53/+90
Issue-ID: CPS-2071 Change-Id: Ibe7f59fbfcbb03703626132c6d5c2afde0e7ab4b Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2024-06-05Change ApplicationEvent for ModelLoadingmpriyank5-26/+25
- Application to use ApplicationStartedEvent as the trigger to start the ModelLoading process instead of ApplicationReadyEvent - Modified the testware to reflect the same Issue-ID: CPS-2211 Change-Id: I3176b6373f585ec1915c3d43c553e233660225f5 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-05Merge "CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)"Priyank Maheshwari5-50/+128
2024-06-05Merge "Added OpenTelemetry to CPS"Toine Siebelink9-5/+295
2024-06-04Merge "CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)"Priyank Maheshwari5-28/+114
2024-05-31Added OpenTelemetry to CPSdavid.mcweeney9-5/+295
Change-Id: I192fa53e293ea43cdff92ebd44d0382eb290bb76 Signed-off-by: david.mcweeney <david.mcweeney@est.tech> Issue-ID: CPS-2172
2024-05-31CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)emaclee5-50/+128
Issue-ID: CPS-2241 Change-Id: I218c46e9c16cc78025450494f5019bde1f351a40 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-05-31CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)emaclee5-28/+114
Issue-ID: CPS-2241 Change-Id: Idd074ff4d29cf11f45f1c69200788b2f39b49e74 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-05-31CM SUBSCRIPTION: Update schemasmpriyank7-24/+24
- updated the cm subscription schemas with proper case as agreed before for the events - fixed the tests to reflect the camelCase change Issue-ID: CPS-2245 Change-Id: I64fb8b27a5f64280dfa19d86ae310e6b5309de39 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-05-29Simplify Code around building DMI URLsToineSiebelink14-392/+417
- Bug analysis showed some unclear and complicated code for building URLs - This patch is to clean up the related code and show more clearly what is encoded and what is not - Use SPringBoot provided builder to apply correct encoding of all URI parts - DmiOperations base class no longer need as no common code model and data operations anymore - Converted builder to POJO (client needs to provide the only dmi properties upon build) - Added some missing test (in affected code) to increase coverage percntage (as the production code has significantly reduced in size the overal coverage was inadvertently reduced below the treshold) - Added more unit test. Now impl.operations' package has 100% - removed the test fro Dmi Exception that was incorrectly callign the handleException methdod directly instead of mocking an exception it was really a dupclicate of a test I added but I was able to re-use the event checkign in my test Issue-ID: CPS-2246 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I1ff196cd03bbb95f5877ee590c321febeb672800
2024-05-29Merge "CPS-2187 - Move Module Set Tag into request body for dmi data access ↵Sourabh Sourabh6-38/+30
passthrough calls"
2024-05-29CPS-2187 - Move Module Set Tag into request body for dmi data access ↵david.mcweeney6-38/+30
passthrough calls Change-Id: I9c807d2ef5b3712bf3f8ee5db7663d9628eef3bb Signed-off-by: david.mcweeney <david.mcweeney@est.tech> Issue-ID: CPS-2187
2024-05-28Adjust K6 thresholdsdanielhanrahan11-28/+28
- Adjust timings based on previous runs. - Reduce from 5 to 4 parallel clients for CM handle searches to avoid OutOfMemoryErrors. Issue-ID: CPS-2208 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I339cc3df84b2295bb11371ab73b4948f43615c15
2024-05-28Restructure(package) DataJobs feature in NCMP Serviceleventecsanyi16-92/+161
- restructured already existing classes - added testware for AlternateIdMatcher Issue-ID: CPS 2240 Change-Id: I5691ed99627353903689cd2929163f77ed8c4eca Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-05-28Merge "CmDataSubscription status code update"Lee Anjella Macabuhay4-18/+24
2024-05-28Merge "Print summary report for K6 tests"Daniel Hanrahan15-80/+183
2024-05-27Print summary report for K6 testshalil.cakal15-80/+183
- add a generic template to print summary of k6 test results - remove container logs since its around 50 mb Issue-ID: CPS-2215 Change-Id: I8971fc30b9dc8be2ed16eda6755d17a91f608b48 Signed-off-by: halil.cakal <halil.cakal@est.tech> Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Signed-off-by: halil.cakal <halil.cakal@est.tech>
2024-05-27CmDataSubscription status code updatempriyank4-18/+24
- Removing the unused NcmpRespnseStatus internal codes and messages - Introducing statusCode 1 for ACCEPTED and 104 for REJECTED of CmSubscription - Added check for status code and message both in the flow Issue-ID: CPS-2238 Change-Id: Id99f099a398392dbef1504f9d7c658665d163902 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-05-27CmSubscription overlapping casempriyank4-16/+74
- Directly ACCEPT the CmSubscription request in case of overlapping scenario - The confirmation will be sent out when the DMI timeout has happened - No request sent out to DMI plugin in this scenario Issue-ID: CPS-2237 Change-Id: Ic799801058e9c8e1c2db8780a42ab85ea306f45e Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-05-23Merge "CM SUBSCRIPTION: add new subscription for non existing xpath"Priyank Maheshwari3-74/+143
2024-05-23Merge "Add k6 performance tests for NCMP"Lee Anjella Macabuhay18-0/+781
2024-05-23Merge "Remove un-used code of RestTemplate"Toine Siebelink17-112/+113