aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2022-07-29Query CmHandles using CPS pathlukegleeson19-327/+699
Added withCpsPath condition parameter Validated to prevent misuse and blocking of querying using private properties Updated OpenAPI with examples and links to documentation Moved methods related to cmHandle querying using cps path from InventoryPersistence to CmHandleQueries Renamed private method deleteSchemaSetAndListElementByCmHandleId to deleteCmHandleByCmHandleId Issue-ID: CPS-977 Change-Id: I83827215b7e58de74f8f62cd0140516d217d93f1 Signed-off-by: lukegleeson <luke.gleeson@est.tech>
2022-07-25CmHandle creation performance degradationsourabh_sourabh9-37/+153
- Created a dedicated threadpool for scheduler. - Tuned async threadpool of notification executor from setting RejectedExecutionHandler and application.yml. Issue-ID: CPS-1126 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I2afe3c76c1aec78751777df0d2f08ddb8dcee102
2022-07-25De-registration: send event(s) using central statesourabh_sourabh5-34/+102
- refactored method "parseAndRemoveCmHandlesInDmiRegistration" - added method to send events for DELETING and DELETED - introduced private method in state handler - updated unit tests for registration spec - added unit test to cover new private method in state handler Issue-ID: CPS-1003 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: Ifc1d1e94b7103d85b6352b196edf7075257c211a Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2022-07-20Refractor code to use the new LcmEvent schemabmiklos11-185/+124
-Old schema deleted and comments from tests are removed -EventDateTimeFormatter utility added -From LcmEventsCreator.populateLcmEvent the NcmpServiceCmHandle param removed and tests are fixed accordingly -Changes made in test of the LcmEventsCreator for payload testing to make it more clear Issue-ID: CPS-1147 Change-Id: Id87c81f2755a6617a0fc68ba92a3d0e3170fd20f Signed-off-by: bmiklos <miklos.baranyak@est.tech>
2022-07-18Update dependencies (release task)ToineSiebelink1-5/+0
Removed unnecessary direct dependency - spring-context Issue-ID: CPS-1106 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I4c3b2e8ffb16504f442f2eda5553c185dc290f4b
2022-07-14Update dependencies (release task)ToineSiebelink1-2/+2
Update to latest dependencies (minor) releases -spring-boot-dependencies 2.6.9 -spring-cloud-dependencies 2021.0.3 Issue-ID: CPS-1106 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I4780ca9a6f87d257d430b6c6fefd2c0621aeeec4
2022-07-14Remove ALL Docker File Versionssourabh_sourabh3-9/+3
Issue-ID: CPS-1095 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I11790e271ec784dfa9dbdaea497d50e95f884600
2022-07-14Merge "Code Refactoring Ncmp* to Lcm* as per new scope"Toine Siebelink15-95/+104
2022-07-14Merge "Refactor unit test for Notification Error Handler"Toine Siebelink1-7/+24
2022-07-14Code Refactoring Ncmp* to Lcm* as per new scopempriyank15-95/+104
- Refactored code to reflect the LcmEvents scope now. - Test cases updated and dependencies reviewed. - You can find few occurences of NcmpEvent for now but that will be cleaned up once we implement CPS-1104 which is for LcmEvent schema - UPCOMING: LcmEvent schema and then the code to publish the events on cmHandleStates - LATER : LcmEvents based on public properties update. Issue-ID: CPS-1137 Change-Id: I9f395ed733b4028e706205894c36a38412e3452e Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-07-13Refactor unit test for Notification Error Handleremaclee1-7/+24
Issue-ID: CPS-1146 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: Idd1c1236b9574c1d070c3dc4111ebcce8d800b23
2022-07-13Agree LCM Event Schema(s)bmiklos1-0/+106
New schema was created according to discussion with minor fixes 2 Issue-ID: CPS-1104 Change-Id: I1809b679b2cc4d17c278f9e3a6fbd477ea2f3c84 Signed-off-by: bmiklos <miklos.baranyak@est.tech>
2022-07-12Merge "Updating docker-compose version from 3.3 to 3.8"Toine Siebelink1-1/+1
2022-07-12Updating docker-compose version from 3.3 to 3.8JosephKeenan1-1/+1
Issue-ID: CPS-1095 Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Change-Id: I31601a1f486a4925ed880283c160cd827fe2255b
2022-07-08CmHandleState Handlermpriyank6-40/+367
- State handler taking care of ADVISED, READY and LOCKED state transition at the moment. - For now I have not removed the actual code but eventually state handler will take care of persisting the state and publishing of the events - Rebased code to add the global parameter related to dataSyncCache - UPCOMING : The classes will be prefixed/renamed with LCM once we have the LcmEvent created with new schema Issue-ID: CPS-1118 Change-Id: Ic45d95169eb0c06cfb35c907d34380dbcbf2da11 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-07-07Merge "Define Initial Data Sync Enabled Flag and state"Joseph Keenan3-7/+28
2022-07-07Define Initial Data Sync Enabled Flag and stateDylanB95EST3-7/+28
- Define the initial Data Sync Cache enabled through configuration parameter - Set the data sync enabled flag based on this - And in turn define the initial sync state of the Data Sync Issue-ID: CPS-1119 Change-Id: I43bf03c79481291bf47c9b672f7bf408d789df61 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-07-07Merge "Improve test coverage on CompositeStateBuilder"Toine Siebelink1-0/+22
2022-07-07Update cps-ncmp info.yamlJosephKeenan1-6/+1
Issue-ID: CPS-1134 Change-Id: I093eeb6e6f70bf82ba7868eb8985be91eb1d1c24 Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2022-07-07Improve test coverage on CompositeStateBuilderbmiklos1-0/+22
Issue-ID: CPS-475 Change-Id: Id24f2b0c6fe95ca9c7559a8dbd160c4566ddc32f Signed-off-by: bmiklos <miklos.baranyak@est.tech>
2022-07-06Merge "Move persistence methods from NCMPproperty handler"Joseph Keenan7-71/+93
2022-07-06Merge "Distributed map setup for Module and Data Sync"Toine Siebelink4-0/+126
2022-07-06Distributed map setup for Module and Data Syncmpriyank4-0/+126
- Introduce the hazelcast dependency and check how the builds react to it. - Data Sync and Module Sync Map config. - Added basic test scenarios. - Updating the artifact-id from hazelcast-all to hazelcast-spring and version is 4.2.5. (5.1.2 is latest but has known vulnerabilities) - Refactored the code as per the onsite review session - Upcoming : Actual sub-task which will use the distributed maps in respective use cases. Issue-ID: CPS-1050 Change-Id: I60314c4ff95c267b186b20862aef93a5c389a971 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-07-05Move persistence methods from NCMPproperty handleremaclee7-71/+93
Issue-ID: CPS-1117 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: If6a0c620970a2a34a601267c6610f85e4bc07f60
2022-07-05Coverage for NotificationErrorHandleremaclee1-0/+41
Issue-ID: CPS-475 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: Iadcb89c83aaa72afa0839d53a31799316c5966c5
2022-07-04Move persistence related methodsemaclee9-118/+247
-created new method in inventory persistence service for getting module references Issue-ID: CPS-1117 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: Ic1f3c180a62a7211e19982d8f3570829db58370e
2022-07-04Merge "Fix: cps-ncmp-rest-stub implement new methods"Toine Siebelink1-0/+12
2022-07-04Fix: cps-ncmp-rest-stub implement new methodslukegleeson1-0/+12
Override getModuleDefinitionsByCmHandleId Override getModuleReferencesByCmHandle Issue-ID: CPS-1094 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I3e4f91602f338e6f22eaf89212cf31a1e7af0c33
2022-07-04Merge "Simplified 'External' lock reason Mapping"Joseph Keenan15-51/+85
2022-07-04Simplified 'External' lock reason Mappinglukegleeson15-51/+85
Refactored LOCKED_MISBEHAVING -> LOCKED_MODULE_SYNC_FAILED CompositeStateMapper will change internal reason LOCKED_MODULE_SYNC_FAILED to external reason LOCKED_MISBEHAVING for client payloads Changed openapi description of lock-reason to reflect only enum currently available LOCKED_MISBEHAVING Issue-ID: CPS-1099 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I9cda45f6c30b94684ee1c8ad0c49e35a3a824d52
2022-07-04Merge "Add Logging to specify next retry"Joseph Keenan1-3/+7
2022-07-01Add Logging to specify next retryDylanB95EST1-3/+7
Adding logging to specify the next time in minutes until the retry mechanism will attempt to unlock the cm handle if it is not yet ready to be unlocked Issue-ID: CPS-1076 Change-Id: Ic2b011966c779f13ad8380ebfd7d4b4354e6b3e1 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-07-01Merge "Modify Unit test for module definition"Toine Siebelink1-3/+3
2022-07-01Modify Unit test for module definitionemaclee1-3/+3
Issue-ID: CPS-1064 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: I9f17d95ba6fb2c7be5a10b1612bcc8db69f8a64d
2022-07-01Merge "cps-ncmp-rest-stub can not be compiled and executed"Toine Siebelink3-21/+23
2022-07-01Merge "use separated get methods for every cmHandle instead of one "get all" ↵Toine Siebelink2-15/+20
query"
2022-07-01cps-ncmp-rest-stub can not be compiled and executedputhuparambil.aditya3-21/+23
Issue-ID: CPS-1094 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I2cd010e0bbe140198db22cf1f62cc8b0b9c80729
2022-07-01use separated get methods for every cmHandle instead of one "get all"kissand2-15/+20
query Issue-ID: CPS-1085 Change-Id: Ifac152f606b25b7a7d143315dba6d73698ef914e Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
2022-07-01Merge "Allow Module Re-Sync"Toine Siebelink4-2/+66
2022-06-30Allow Module Re-Synclukegleeson4-2/+66
Allows the Resync of an already synced CmHandle Currently: Advised -(create schemaset)-> Ready -(manual write)-> Advised -> Locked as schemaset for cmhandle already exists With this: Advised -(create schemaset)-> Ready -(manual write)-> Advised -(delete schemaset, create schemaset)-> Ready Included some logging Renamed ModuleSyncSpec -> ModuleSyncWatchdogSpec to match class Issue-ID: CPS-1045 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I408fbea698b7926dbf5d0cddc74acf1b00235b1f
2022-06-30Composite state transition code changesourabh_sourabh5-25/+58
- Code cannge to set datastore to Unsynchronized when state moves from advice to ready - if resource data is not available or there is any issue while reading data from simulator then state will be set to synchronized else remain unsynchronized. - Handle serialization failure on empty bean. Issue-ID: CPS-1000 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: Ie51a787770da649e00aaefc00341756f92f9fa83
2022-06-30Add method to get YANG module sources for CM handleemaclee33-40/+311
- part of this commit includes renaming the enum SyncState to DataStoreSyncState Issue-ID: CPS-1064 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: I6bf419141a1b33f09871946445cdfff422c8c354
2022-06-30Merge "Fix performance degradation bug"Joseph Keenan7-190/+216
2022-06-30Merge "Retry Module-Sync based on from last failure"Toine Siebelink5-12/+72
2022-06-30Merge "Kafka consumer can not be turned off"Toine Siebelink13-114/+68
2022-06-30Kafka consumer can not be turned offJosephKeenan13-114/+68
-NOTE: Build will fail until docker-compose version issues on build server are fixed --Ticket raised https://jira.linuxfoundation.org/plugins/servlet/theme/portal/2/IT-24219 -added flag for async -added response if async is triggered without being enabled & associated test -modified to use one global flag for notifications Issue-ID: CPS-1088 Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Change-Id: If9d988b4dcb71bf37c1b1bf9464090782708ffc2
2022-06-30Fix performance degradation bugkissand7-190/+216
- do NOT use cpsPath query for gettign individual CM Handles - change order of queries for more efficency (property query first) Issue-ID: CPS-1085 Change-Id: Ia3bdf4f0d245a2b128557352685d2aa17c1f939c Signed-off-by: kissand <andras.zoltan.kiss@est.tech> Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2022-06-29Get cm-handle state endpointlukegleeson12-34/+231
Added new get cm-handle state endpoint Refactored RestOutputCmHandleState to CmHandleCompositeState Created new RestOutputCmHandleCompositeState OpenApi object ^This is done so that we get '"state: {" at the start of JSON response Refactored RestOutputCmHandleStateMapper to CmHandleStateMapper Added more detailed composite state to get cmHandleDetails endpoint tests Rebased code Code rebased on top of 129658: Unable to change state from LOCKED to ADVISED | https://gerrit.onap.org/r/c/cps/+/129658 which fixes output error Issue-ID: CPS-1019 Signed-off-by: mpriyank <priyank.maheshwari@est.tech> Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I361117c98c256a4aa578c13d21926bc6d7876a15
2022-06-29Retry Module-Sync based on from last failureDylanB95EST5-12/+72
Retry algorithm for module-sync based on last failure Poll Lock Reason, check if lock has surpassed minimum time based on last update time and lock reason Issue-ID: CPS-1076 Change-Id: Ifbbabd2b403f88f1bbe3fae3f125b1e9cb2091aa Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-06-28Unable to change state from LOCKED to ADVISEDsourabh_sourabh14-57/+81
-Refactor Cm Handle Registration to deal with null pointer during Module Sync Retry -Add Last Update Time to cm handle registration -Add Fetch Descendants Option as paramater for get misbehaving locked cm handles -Fixes issue when state that goes to advised after retry mechanism won't be retried again Issue-ID: CPS-1097 Change-Id: Iffe1cef3479a796ea5c78b293a0bd24a86d13efd Signed-off-by: DylanB95EST <dylan.byrne@est.tech> Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>