aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2024-02-22Introduce class for Module Delta during module syncdanielhanrahan4-81/+57
Removed ImmutableTriple<String, Map<String, String>, Collection<ModuleReference>> and replaced it with a ModuleDelta class to hold results. Split syncAndCreateOrUpgradeSchemaSetAndAnchor into methods syncAndCreateSchemaSetAndAnchor and syncAndUpgradeSchemaSet Issue-ID: CPS-2027 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I95462ab55dcae7d98b9e2671fc278c4ded45f3fc
2024-02-22Improve performance of moduleSetTag lookupdanielhanrahan2-25/+26
- Using absolute cps-path /dmi-registry/cm-handles is faster than descendant cps-path //cm-handles due to CPS-2087. - Converting DataNodes to YangModelCmHandle allows checking if the handles are READY without needing to send additional DB queries via cmHandleQueries::cmHandleHasState. Issue-ID: CPS-2027 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ied7e884b0f779f394854603a7f8b186d09eb5be8
2024-02-22Merge "Refactor YangDataConverter.convertCmHandleToYangModel"Sourabh Sourabh9-32/+24
2024-02-22Refactor check for no new modules in Module Syncdanielhanrahan4-48/+40
This change moves the check for no new module references into DmiModelOperations::getNewYangResourcesFromDmi (The method is only used by ModuleSyncService) Issue-ID: CPS-2027 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I3cc65e7a327148ebe01b98b61dc64b70872e2cf5
2024-02-22Refactor YangDataConverter.convertCmHandleToYangModeldanielhanrahan9-32/+24
This method redundantly takes cmHandleId as a parameter, even though the DataNode representing a CM-handle is guaranteed to have the ID in a leaf called 'id'. Issue-ID: CPS-245 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ib10097b6e13f7188fd933d6f6913110ec664273e
2024-02-21Improve unit test for regsitration, upgradeToineSiebelink1-13/+14
- verify schema set is created - add test case for upgarde to same tag Issue-ID: CPS-2027 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Id853f477d2a90a86d13828a27b9269c62e1d9462
2024-02-21Merge "adding isUniqueSubscriptionId method"Priyank Maheshwari3-2/+37
2024-02-21Upgrade yang modules using module set tagdanielhanrahan10-283/+110
- New algorithm is implemented as per the pseudo code -> https://wiki.onap.org/display/DW/CPS-1733%3A+Upgrade+YANG+Schema-Set+for+CM+Handle+Using+a+Module+Set+Tag Issue-ID: CPS-2027 Change-Id: I78fc1c8f927de1a1b814c3c1c62351dda58f2139 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
2024-02-21Fix handling of blank moduleSetTagdanielhanrahan3-8/+10
Handling of blank moduleSetTag is very inconsistent. Sometimes it will be returned as null, '' or 'not-specified'. Specifically in the case of MODULE_UPGRADE_FAILED, on the retry, a blank moduleSetTag will be returned as 'not-specified', leading to incorrect upgrade. Issue-ID: CPS-2027 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I3f4290dc5659c386c7b2b924325da2560d00d73b
2024-02-21Add moduleSetTag when getting a CM handledanielhanrahan5-16/+34
Test changes: - Check moduleSetTag (and alternateId) in unit test of get CM handle. - Verify moduleSetTag is updated in tests of CM handle upgrade. Code changes: - Set moduleSetTag when converting a YangModelCmHandle to NcmpServiceCmHandle. - Set moduleSetTag in YangModelCmHandle copy constructor. - Minor refactor using StringUtils::isBlank. Issue-ID: CPS-2027 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I6a9a92aa58d15c6ecf5a6bb21aa5c9d6ec8dc817
2024-02-21Remove alternate ID cachesleventecsanyi3-123/+1
- removed alternate id cache related classes and updated deployment.rst Issue-ID: CPS-2107 Change-Id: I567af7b2f44107fceffaef370205b00a5cf79522 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-02-19Merge "Use DB for checking Alternate IDs"Toine Siebelink12-341/+424
2024-02-19adding isUniqueSubscriptionId methodemaclee3-2/+37
Issue-ID: CPS-2044 Change-Id: I26b209ead80add7e60b4de9257a9f5c326ddea6f Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-02-19Tests of CM-handle module upgrade & moduleSetTagdanielhanrahan10-244/+429
Integration tests covering scenarios of the creation and upgrade of CM-handles with: - no moduleSetTag - new moduleSetTag - existing moduleSetTag Failing tests are marked @Ignore. Issue-ID: CPS-2102 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Id5567e08a13d8c26dc7b6458f0af8449bef6f082
2024-02-16Use DB for checking Alternate IDshalil.cakal12-341/+424
- do NOT use hazelcast cache - introduced AlternateIcChecker - use checks during Inital registration - TODO: remvoe Hazalcast Cache (once perf test are OK) - TODO: use checks during UPDATE registration - TODO: error reporting during registration Issue-Id: CPS-2049 Change-Id: I0adcac52a7a49e26301758eafc4684152ddfcaf5 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2024-02-15Add NCMP to integration-test moduledanielhanrahan6-0/+357
- Add NCMP to integration test base class - Use MockRestServiceServer to mock DMI responses in groovy tests - Added tests for CM-handle registration to READY and LOCKED states - Add test of CM-handle deregistration Issue-ID: CPS-2033 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I89f9f8aab2bba9d4eb5b3136a2feb238e7cf1b06
2024-02-14Merge "Mapper to form event for DMI Plugin"Lee Anjella Macabuhay2-0/+169
2024-02-14Merge "Clean up of integration-test base classes"Lee Anjella Macabuhay5-176/+104
2024-02-14Merge "Faster absolute xpath query using parent path lookup"Lee Anjella Macabuhay1-6/+27
2024-02-14Clean up of integration-test base classesdanielhanrahan5-176/+104
- Remove TestConfig and instead use auto-configuration - Add needed application.yml config - Refactor helper methods for creating JSON Issue-ID: CPS-2090 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I4f618a1d4a83e9c75e468928c257b817d449c22f
2024-02-14Merge "Remove liquibase test changelog"Lee Anjella Macabuhay2-629/+1
2024-02-14Faster absolute xpath query using parent path lookupdanielhanrahan1-6/+27
Issue-ID: CPS-2087 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I62b452f34f08a32a6d80671c7af560fbceec1285
2024-02-14Merge "Update release notes for Extending Module API retrieval"Toine Siebelink1-0/+1
2024-02-13Remove liquibase test changelogdanielhanrahan2-629/+1
Complete liquibase changelog takes under 1 second to run, so having separate changelog for integration tests offers no benefit. Issue-ID: CPS-2090 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ib0e928f35d401b91c23dfcb5dc82c77778a044dc
2024-02-13Mapper to form event for DMI Pluginmpriyank2-0/+169
- cmSubscriptionPredicate to CmNotificationSubscriptionDmiInEvent mapper code and testware. - Based on the delta we find , we will be sending the events to the dmi plugins. Finding delta code will be separate patchset Issue-ID: CPS-2060 Change-Id: If1e15679b72c39352e3cf166651226df7e207ce0 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-02-13Update release notes for Extending Module API retrievalhalil.cakal1-0/+1
- Add the user story: CPS-1135 for CPS version 3.4.3 Issue-ID: CPS-1135 Change-Id: I9e9cdc5f648d38eb4dbd76cc98a884fed03a28b2 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2024-02-13Prefix with CmNotificationSubscription refactoringmpriyank6-36/+35
- event schemas are now suffixed with CmNotificationSubscription - testware updated appropriately Issue-ID: CPS-2091 Change-Id: I9d0c4bdfaf7ea94812d35b071824d0fb083aa845 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-02-13Merge "Update cm-data-subscriptions model"Lee Anjella Macabuhay6-12/+13
2024-02-13Merge "Add a configurable delay to the DMI stub"Sourabh Sourabh3-0/+29
2024-02-13Merge "Fix test failure by ordering leaf-lists"Priyank Maheshwari5-17/+51
2024-02-13Merge "Create schemas for notification service in cps-core"Priyank Maheshwari1-0/+61
2024-02-12Update cm-data-subscriptions modelmpriyank6-12/+13
- rename leaf-list subscribers to subscriptionIds - code using the same also updated - not creating a new version of model as nobody is using it at the moment Issue-ID: CPS-2088 Change-Id: I43d679047bdfc665b56f262757acc4bbaba2733f Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-02-12CmSubscription minor code refactoringmpriyank14-249/+126
- As per discusstion , refactoring the naming of the classes and caches - Combining the validation service with CmSubscriptionPersistence service - removed dmiCmNotificationScopeFilter class and the attributes are part of Predicates only Issue-ID: CPS-2078 Change-Id: Ic2b3ee28a150f3ae6e0911e88296f01e22604ef5 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-02-12Fix test failure by ordering leaf-listsdanielhanrahan5-17/+51
YANG specifies two ways that leaf-lists can be ordered: - ordered-by user: original order in JSON is preserved - ordered-by system (default): it is up to the system how to order For leaf-lists to preserve same order as the JSON, the Yang module must specify 'ordered-by user'. To ensure consistent behaviour even when system ordering is used, the leaf-list is sorted during parsing. - Add 'ordered-by user' to authors field in bookstore.yang - Sort leaf-list during parsing when using 'ordered-by system' - Add new tests to verify ordering Issue-ID: CPS-2057 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I6ab688ec2fa4a22182e853d1a8b26642f278c40a
2024-02-12Include integration test results in Jacocodanielhanrahan3-35/+15
integration-test module is not recording code coverage due to incorrectly overriding the maven surefire config from parent pom. Issue-ID: CPS-2086 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I774c64acedca546f5c01403597bd9f5010de73d2
2024-02-12Add a configurable delay to the DMI stubJvD_Ericsson3-0/+29
Added realistic default delay to application.yaml Added realistic default delay to docker-compose.yml Issue-ID: CPS-2053 Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech> Change-Id: I756774e9538926aa341f1338fcb6882951ce3e69
2024-02-09Create schemas for notification service in cps-corerajesh.kumar1-0/+61
Add schema files for notification service Issue-ID:CPS-2066 Change-Id: I56c34400dc73c71b936a51260efd230205abbacd Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
2024-02-08Merge "Add CSIT test: Delete CM Handle"Toine Siebelink1-4/+16
2024-02-08Merge "Correct use of Spock setup and cleanup methods (no need for @Before ↵Toine Siebelink4-44/+13
@After)"
2024-02-08Merge "Revert "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - ↵Toine Siebelink8-136/+43
error collection""
2024-02-08Revert "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error ↵Levente Csanyi8-136/+43
collection" This reverts commit 67681820f2a7fea88cbc6cbe5b3d483dae506d55. Reason for revert: does not work Change-Id: I92c063b59261d25774ee34664d834399c269f0c2 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-02-08Merge "Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error ↵Toine Siebelink8-43/+136
collection"
2024-02-08Introduce Hazelcast for alternateId-cmHandle relation pt. 2 - error collectionleventecsanyi8-43/+136
- added business logic to check duplicated ids (create and update scenarios) - added new unit test for CmHandleIdMapperSpec - added test for the new registration scenario Issue-ID: CPS-1988 Change-Id: I4bf2e25c87c57938d336f2fe70378b400bab07b0 Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-02-08Correct use of Spock setup and cleanup methods (no need for @Before @After)ToineSiebelink4-44/+13
- unfortunately we copied the bad test code for logging about 4 times alraedy... - simplified setup for WatchdogSchedulingConfigurerSpec Issue-ID:CPS-465 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I8d068541263272fdf99a6e30d365d85e31726432
2024-02-08Merge "CmHandle delete is failing with InternalServerError: Null key is not ↵Toine Siebelink1-0/+9
allowed - add missing unit test"
2024-02-08Add alternateId to legacy lcm-eventJvD_Ericsson5-5/+26
Issue-ID: CPS-2039 Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech> Change-Id: I03863e986ea6b847fd7d25e55a24f948ca9a983d
2024-02-07Merge "Replace sleep with PollingConditions"Toine Siebelink6-70/+86
2024-02-07Merge "Orphaned modules are removed from the DB before cmhandle removal"Toine Siebelink1-1/+1
2024-02-07Bump CPS to 3.4.4-SNAPSHOTdanielhanrahan25-25/+53
- bump CPS to 3.4.4-SNAPSHOT and update the docs Issue-ID: CPS-2077 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I1658c83642c8e64903f4bc03b74b6f5726d0227e
2024-02-07Add CSIT test: Delete CM Handlehalil.cakal1-4/+16
- Add new csit test to ncmp inventory Issue-ID: CPS-2073 Change-Id: Ie683f043b2dc1cc742945a4874f19688a8702009 Signed-off-by: halil.cakal <halil.cakal@est.tech>