summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2023-08-09Refactoring Subscription Create LCM use casempriyank32-341/+343
- Client to NCMP: CmSubscriptionNcmpInEvent - NCMP to DMI: CmSubscriptionDmiInEvent - DMI to NCMP: CmSubscriptionDmiOutEvent - NCMP to Client: CmSubscriptionNcmpOutEvent - code package changed from avcsubscription to cmsubscription - Other classes name as per the events naming above - Test classes refactored - NO LOGIC changes incorporated in this patch Issue-ID: CPS-1831 Change-Id: Id5ad5f799007deaaf6d6fc0f402c130339263d09 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-08-09Modify DmiDataOperationRequest to make it identical as DataOperationRequestsourabh_sourabh7-21/+68
- Modified DmiDataOperationRequest attribute from operationType to operation. - Wrapped operation details to parent attribute operationd array. Issue-ID: CPS-1833 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I79aa943e10e1c32c3252a6eb4375c14496476f8b Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2023-08-08Merge "Subscription Creation: Fixes for code review after demo"Priyank Maheshwari22-137/+259
2023-08-04Update performance test timings for larger datasetdanielhanrahan9-159/+159
- Populate 3 anchors with 1000 openroadm devices nodes for read and query tests (over 250,000 fragments) - Increase update perf tests to update 100 out of 1000 devices - Increase delete perf tests to delete 100 out of 300 devices - Remove bookstore data from performance tests - Update test timings Issue-ID: CPS-1811 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Iaa36694be907278e772ae729a85510ea9d004fd1
2023-08-04Subscription Creation: Fixes for code review after demohalil.cakal22-137/+259
- Change missleading subscription details in testware - Change datastore check to comply with CPS enum - Remove redundant CloudConstructionException - Change exception handling in cloud event mappers to avoid loss of information - Remove exception handling from scheduler service as discussed in the meeting Issue-ID: CPS-1732 Change-Id: I9fee2eafd4db97a0eed80e39219463c904f5a980 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2023-08-04Update coverage ratio to 0.99mpriyank1-0/+4
- in order to stabilize the builds , updating the coverage ratio for cps-ncmp-rest package to 0.99 from 1.00 - Will bring back to 1.00 once the necessary fixes are in place. Issue-ID: CPS-1832 Change-Id: If0f106d7c1a44294ed67c83a049f667d9ce13b31 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-08-04Ability to disable sending auth headermpriyank8-2/+31
- introduced configurable parameter to disable sending auth header in the request to dmi-plugin - default is to include the auth header - DMI_AUTH_ENABLED flag can be set to true/false to control the behaviour - Also added the env variables to the CSITs - updated release-notes Issue-ID: CPS-1819 Change-Id: If97c06e33f06e391d2190b7300d73210ed2f4e27 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-08-03Fix: integration test that is for add and delete top level list elementhalil.cakal1-1/+1
Issue-ID: CPS-1605 Change-Id: Ia6ba73d5e4930bcc547cf24d06c50c681c3a7452 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2023-08-03Merge "Support pagination in query across all anchors(ep4)"Luke Gleeson26-85/+527
2023-08-02Support pagination in query across all anchors(ep4)rajesh.kumar26-85/+527
Add pagination query parameters in query across all anchors API pagination parameters (pageIndex and pageSize) are optional default is to query all fragments each pageSize represents number of records(number of anchors) TotalRecords is returned in response header to find number of pages. - If pagination option is provided in request then query number of anchors equal to pageSize. pageIndex is used for setting offset. - return number of records(one anchor per record) as per pagesize and pageSize Issue-ID: CPS-1605 Change-ID: I73f97f986a817d423f93a8d922dcd9647b2504bc Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
2023-08-01Merge "Fix: Make bookstore data consistent"Toine Siebelink6-53/+33
2023-07-31Add 'direct' keyword to descendants option to query direct children (ep1)Rudrangi Anupriya11-41/+37
-added 'direct' keyword also to Fetch Descendants Option along with 'all' and 'none' to Query direct child. -added unit tests to test direct keyword Issue-ID: CPS-1784 Change-Id: Icb7f59fbeebb03703626132d6d5d2cfde0e5ab4d Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2023-07-31Merge "Use constants for magic numbers in perf tests"Toine Siebelink3-30/+30
2023-07-31Increase code coverage in cps-service moduleToineSiebelink29-263/+432
- After last rebase I had to remove 3 unused recent cloud eventd specific exceptions/constructors - Moved the only used new exception from SPI to the relevant util package (please NOTE not all exceptions belong in SPI and always question need for new exception when there is no specific handling, try to use standard or existign CPS exception instead!) - Increased cps-service module (line) coverage from 95 to 100% - Added tests for missing exceptions (handling i.e. thrown up) - Removed incorrect SPI defined OperationNotYetSupportedException (replaced with standard java exception instead) - Fixed some legacy issues with existign test classes I modified (unnecessary setup, conventions etc) - Increased coverage for DataNodeBuilder - Added or modified test to include more spi models - Added tests for Hazelcast Configs - Added more tests for json object mapper - Added test and fixed error handling in YangUtils/XmlFileUtils (it was incorrectly converting a config exception to a data validation exception) Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I5852ba01bc5b33ae361b8f29daae9868f05baa35
2023-07-28Use constants for magic numbers in perf testsdanielhanrahan3-30/+30
Issue-ID: CPS-1811 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ic87bcb1847b97a0e8c59b2e3636e9ccd66f814ae
2023-07-28Fix pom.xml versionleventecsanyi1-1/+1
- corrected version number Issue-ID: CPS-1817 Signed-off-by: Levente Csanyi <levente.csanyi@est.tech> Change-Id: Id97b3d55e7342619804b8e007238718b56ef3120
2023-07-28Add 'direct' keyword to descendants option to query direct children (ep1)Rudrangi Anupriya13-48/+61
-added 'direct' keyword also to Fetch Descendants Option along with 'all' and 'none' to Query direct child. -added unit tests to test direct keyword Issue-ID:CPS-1784 Change-Id: Iab7f59fbeebb03703626132c6d5c2afde0e5ab4d Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2023-07-27Merge "Improve 32K limit tests"Toine Siebelink1-20/+56
2023-07-27Merge "Add write performance tests"Toine Siebelink1-0/+83
2023-07-27Update RTD (CPS-1515: Spike: Support Multiple CM-Handles for NCMP Get Operation)sourabh_sourabh8-151/+514
- Added information about data operation NCMP endpoint and kafka event details. - Re-structured "CPS-Events" and "Modeling" page. Issue-ID:CPS-1785 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I2b077ccd7ccd6144a8f9f2183d927f922075f532 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2023-07-27Improve 32K limit testsdanielhanrahan1-20/+56
Some operations were previously limited to 32,768 parameters, such as getDataNodesForMultipleXpaths. After this limit was lifted, the tests only verified that database exceptions were not thrown. This commit improves the tests by verifying that the operations return or delete the expected data. - Create 33,000 data nodes - Verify that getDataNodesForMultipleXpaths returns 33,000 nodes - Verify than deleteDataNodes deletes 33,000 nodes Issue-ID: CPS-1811 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I7029ea0cf1d4e95c5ca814ca62c222fc5b9ddc7e
2023-07-27Merge "Allow getDataNodes to read whole lists(ep 1)"Sourabh Sourabh6-53/+102
2023-07-27Allow getDataNodes to read whole lists(ep 1)danielhanrahan6-53/+102
- getDataNodes can now retrieve list data nodes. Issue-ID: CPS-1696 Signed-off-by: arpitsingh <as00745003@techmahindra.com> Change-Id: I320a368d6cb73599d3f7c13fe9b8ab7d0cc69470
2023-07-27Merge "Subscription Creation: NCMP to Client CloudEvent transformation"Luke Gleeson36-670/+893
2023-07-27Merge "Performance test of reading non-existing datanodes"Toine Siebelink2-3/+19
2023-07-27Fix: Make bookstore data consistentArpit Singh6-53/+33
- Removed list named invoice from all bookstore files - Added a new parent list as bookstore-address - Refactored tests Issue-ID: CPS-1813 Signed-off-by: Arpit Singh <as00745003@techmahindra.com> Change-Id: I5c7e83e1ee0ad9ac1d94d1906c2361c7a00d49af
2023-07-27Add write performance testsdanielhanrahan1-0/+83
- Add perf test for openroadm (linear time) - Add perf test for bookstore (exponential time!) Issue-ID: CPS-1811 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I9c1772a9e9684707f2dbb32b2c361ec248fb1c60
2023-07-26Performance test of reading non-existing datanodesdanielhanrahan2-3/+19
Issue-ID: CPS-1811 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I183129bb5b0a2d620b87e9b36f3113fe8e169798
2023-07-26Performance test of deleting non-existing datanodesdanielhanrahan1-2/+18
Issue-ID: CPS-1811 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ifae635f45d8ec1990452ade958253972fde68415
2023-07-26Subscription Creation: NCMP to Client CloudEvent transformationhalil.cakal36-670/+893
- Delete legacy avc subscription event and event outcome schemas - Change subscription response and outcome sample json file contents - Change ncmp event response code to support avc subscriptions - Add mapper that maps cloud event to subscription event response - Add mapper that maps subscription event outcome to cloud event - Change subscription event response consumer to consume CloudEvents - Change time out task to support response event instead client id and name - Change subscription event response mapper to support Cloud Event - Change subscription outcome mapper to group subscription responses as per details and status - Change subscription status to have fromString functionality - Change all unit tests to support new functionalities - Add cps exceptions for cloud event and outcome type - Add details field in yang model - Change data node helper to supoort details field - Consolidate final subscription response codes - Fix code smells reported by SonarLint Issue-ID: CPS-1739 Change-Id: I5eadeb8ef40d3d7befb762b5a8d2139fe3c85d7e Signed-off-by: halil.cakal <halil.cakal@est.tech>
2023-07-26Some performance tests are skipped due to filenamedanielhanrahan2-2/+2
CPS POM is setup so that only files ending in 'Spec' or 'Test' are run as tests, and files ending in 'PerfTest' will only run in the 'include-performance' profile. The 32K limit tests are currently being skipped always, as they do not end in 'Spec', 'Test', or 'PerfTest'. This commit renames them to PerfTest. Issue-ID: CPS-1811 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I75a4ae92edf324213f734503c23dedb2b31fd007
2023-07-25Update dmi-stub details in test-deregistration scriptdanielhanrahan1-2/+2
dmi-plugin-stub was renamed to dmi-plugin-demo-and-csit-stub, and port changed to 8092. Issue-ID: CPS-1560 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I3005087ace35aa131df720ed04c642d2d72f1255
2023-07-24Fix code coverage reportingToineSiebelink7-37/+35
- Fixed (partly duplicated) exclusion list: all exlusings now in PARENT pom only (this means module reports and aggregate report use same exclusion - Set common minimum to 100% (3 modules now achieve this :-) ) - Added./clean cm-parsre test to get too 10% in that module too - Increased module specif minima to actual coverge today Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Ic155f963bfd472e11481fcab6ee8ca227903d9ae
2023-07-21Prepare for next CPS-NCMP releaseegernug24-24/+53
Issue-ID: CPS-1797 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: Ib2b840b6b37131f16afd879720658d2e45387d6a
2023-07-21Container for release 3.3.5egernug1-0/+8
Issue-ID: CPS-1797 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: Id8bcefe615947a7ec160275bf7a3326e80a0f2f3
2023-07-21Maven stage yaml for 3.3.5egernug1-0/+4
Issue-ID: CPS-1797 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: I99232dde07a4ad92fd124265214bc760a032de12
2023-07-21Increase timeout for PollingConditionsegernug1-2/+2
Test failing due to timing issues. Increasing timeout to rectify. Issue-ID: CPS-475 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: I89b512809922470f10940fcdd739f057b8f9c80e
2023-07-20Merge "Refactor ncmp request handlers (fix async issue)"Sourabh Sourabh9-245/+371
2023-07-20Merge "Apostrophe handling in CpsPathParser"Toine Siebelink15-34/+143
2023-07-20Refactor ncmp request handlers (fix async issue)ToineSiebelink9-245/+371
- simplified request handlers (sub)classes (no more need for default interface) - fix issue with async execution of data operation requests (wasn't really async) - removed redundant (unreachable) check in production code - Improved code coverage (branches) ncmp request handlers added UNIT test - removed MVC test scenarios now covered by appropriate unit level tests - applied Spock Polling Condition for verifying async call Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: Ibe601c709de65080fa8898f2419fdbd92c5ba27d
2023-07-20Merge "Persisting a list element to a parent list (ep2)"Luke Gleeson8-4/+150
2023-07-20Apostrophe handling in CpsPathParserdanielhanrahan15-34/+143
Apostrophe is not currently handled correctly, and having apostrophe in the xpath will lead to various errors. For example, normalizing this xpath works: /path[@name="I'm quoted"] -> /path[@name='I\'m quoted'] However the resulting xpath will throw a PathParsingException if parsed! (Thus path normalization is not idempotent.) - Use '' for escaping apostrophe in single quoted leaf value, to comply with XPath standard (and use "" for escaping in "). - Use Liquibase to make existing data comply with new rules. - Leaf values in data leaves are now unescaped, e.g. "I'm quoted" - Quoting is now consistent for leaf/text/contains conditions. Issue-ID: CPS-1769 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Iafc287f738254d7f99706c6bc548091c0ecd5aa0
2023-07-20Merge "Allow duplicate leaf names in Cps Path leaf condition"Toine Siebelink9-238/+201
2023-07-19Prepare for next CPS-NCMP releaseegernug25-26/+53
Issue-ID: CPS-1791 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: Ide0fcdfa41656e25395ac8478da1bb489fd8663e
2023-07-19Container yaml for releaseegernug1-0/+8
Issue-ID: CPS-1793 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: If7ac05d814da42b12c66704afcb153f4af72f3e5
2023-07-18Maven stage yamlegernug1-0/+4
Issue-ID: CPS-1793 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: Ie553550137038e4086f049beca76506df48e2a21
2023-07-18Update release notes for release 3.3.4egernug1-0/+1
Issue-ID: CPS-1792 Signed-off-by: egernug <gerard.nugent@est.tech> Change-Id: I3f278d3e89dbc1a757f603ac312686d83612eec8
2023-07-18Persisting a list element to a parent list (ep2)Rudrangi Anupriya8-4/+150
Post List Element does not allow for create List Element, only appends onto existing node as children -Add a check in saveListElements to see if the parent xpath is a root path ("/").If root node store list element as top node. Else add passed list element to parent xpath node. -Add test for scenario for above -Add test scenario Saving list element data fragment under Root node -Add Integration Tests Add and Delete top-level list (element) data nodes with root node -Update bookstore model with TopLevelList datanode Issue-ID: CPS-1586 Change-Id: Iaa7f59fbeebb03703626132c6d5c2afde0e7ab4b Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
2023-07-17Allow duplicate leaf names in Cps Path leaf conditiondanielhanrahan9-238/+201
Presently, a query using the same leaf name twice will fail: //books[@price > 10 and @price < 20] It is caused by storing data leaves in a Map. This is fixed by storing data leaves in a List<DataLeaf>. Issue-ID: CPS-1779 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ie6990ea5e622cf37e986b720a0a07fb69ce4f03b
2023-07-17Improved code coverage for CpsDataServiceImplToineSiebelink3-46/+38
- Added (extended) test to cover missed scenarios - Removed unnecesarry null check from Production code - Improved error messages in production code - Removed duplicate test - Cleaned up existign test somewhat (labels and aligment) Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I9761ad6d4777a6bcfee4cbe1b876dd39fa218fc8