summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2023-03-01Add DataNodeNotFoundException to deleteDataNodesdanielhanrahan5-25/+88
Current implementation of NCMP handle de-registration relies on DataNodeNotFoundException being thrown to report errors. - Make deleteDataNodes throw DataNodeFoundExceptionBatch - Update performance test timings Issue-ID: CPS-1481 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ib833bdb4a23d24e1784bdaf4e5e5e8a9acb41c54
2023-02-28Skip deleting list xpaths that are list elementsdanielhanrahan4-14/+24
List elements cannot be lists. Filtering list elements before trying to delete lists by xpaths doubles performance when deleting list elements (which doubles performance of CM handle de-registration). Issue-ID: CPS-1511 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ieb6002212d006396d468f27f853708b5aa1e31f2
2023-02-27Merge "Expand CPS Service Integration Test (framework)"Toine Siebelink11-122/+275
2023-02-27Expand CPS Service Integration Test (framework)ToineSiebelink11-122/+275
- Created package structure - Created several test bases - Created complete test set for Admin service - Created first test for Data service - Added human-readable toString() to FetchDescendantsOption for test reporting and debuging purposes - Renamed fetch descendants (enum) direct children option for consistency with others options - TODO: Add sample performance test (and base) Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I75317686161be41662b6bf81314a9cd425ddd6eb
2023-02-24Improve performance for update data nodesdanielhanrahan3-52/+72
- Extract method getFragmentEntities from getDataNodes - Remove unused code from getFragmentEntity - Use bulk getFragmentEntities in updateDataNodesAndDescendants - Update performance test timings Issue-ID: CPS-1504 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Icd2c6a0e6009e152de43090cbc23a21349703da2
2023-02-23Revert "Omit descendants when not need in ncmp inventory queries"lukegleeson3-45/+14
This reverts commit eba77598601a7e3430f9582dfe433495ded3244c. Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I76a0d1252177c4115de9190ee7f3bb6d15c4e19a
2023-02-22Add performance tests for update data nodesdanielhanrahan2-8/+52
Issue-ID: CPS-1504 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I1356e4a67a40d03cd71a98dad1571583229f414d
2023-02-22Merge "Improve performance of deleteDataNodes SQL"Luke Gleeson2-43/+46
2023-02-22Omit descendants when not need in ncmp inventory queriesseanbeirne3-14/+45
-Seperated tests by Id and details Issue-ID: CPS-1494 Signed-off-by: seanbeirne <sean.beirne@est.tech> Change-Id: Ia1c2b637aa5ab2ffe3a92930d74af1dd7d0dbe92
2023-02-21Improve performance of deleteDataNodes SQLdanielhanrahan2-43/+46
- Use SQL IN operator instead of temp table when deleting nodes - Use Postgresql LIKE ANY array operator when deleting lists - Update delete perf test timings - Refactor adding cascade delete constraint Issue-ID: CPS-1502 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ic90b867e7c71ec1981f05a9122322ece84dd8bde
2023-02-21Merge "Fix sonar code smell"Priyank Maheshwari3-5/+5
2023-02-21Merge "Update performance test timings"Toine Siebelink2-23/+23
2023-02-20Merge "FragmentEntity stuck in memory on "Already exists" error"Toine Siebelink1-0/+2
2023-02-20Update performance test timingsdanielhanrahan2-23/+23
- Tighten delete perf test timings - Fix timings for getDataNodes Issue-ID: CPS-1502 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ib89a70ef90b1b30e2720e48ebfb66650a2fafa12
2023-02-20Fix sonar code smellhalil.cakal3-5/+5
Issue-ID: CPS-475 Change-Id: I6c213090862b68ccf44fb95395c57c717f52a9b2 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2023-02-20RTD support to get all data nodes under an anchorarpitsingh1-1/+1
Signed-off-by: arpitsingh <as00745003@techmahindra.com> Change-Id: I118b6475d2e8c5953b520112deb79869802bac7a
2023-02-20Merge "CPS-1401 Implement V2 of GET Data Node API"Luke Gleeson27-236/+355
2023-02-17CPS-1401 Implement V2 of GET Data Node APIarpitsingh27-236/+355
- Modified the GET Data Node API so it returns all the data nodes when xpath set to root "/" - Fragment Repository now returns a collection of Fragment Entities - Instead of returning only the first Fragment Entity now all fragment entities are returned when xpath is set to root - The Fragemnt Entities are further processed to a Collection of Data Nodes. As opposed to singular Data Node in current implementation. - Finally the DataRestController also returns a Collection of Data Nodes when xpath is set to root and valid data is present - Response body changed from JSON object to JSON Array. - Exception handling for invalid xpath and non-existing xpath is now done separately at persistence layer. - Refactored code against CPS-1422 - Deprecated getDataNode method from Service and Persistence layer - Modified V1 of Get Data Node API to use the getDataNodes method and get the first data node from the collection returned. - Modified NCMP to use getDataNodes method - NCMP still does not support multiple data nodes. It retrieves the first data node from the collection returned by getDataNodes Signed-off-by: arpitsingh <as00745003@techmahindra.com> Change-Id: I494a5740a53f65376d135fcb9f1e2e8900a2803e
2023-02-16FragmentEntity stuck in memory on "Already exists" errorkissand1-0/+2
- exclude childFragments from toString method Issue-ID: CPS-1493 Change-Id: I3d0c7ef601f06ed36265d88cadb6fb0ab0cb6ea2 Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
2023-02-16Improve batch delete schemasets performancedanielhanrahan17-29/+221
- Bulk delete anchors and datanodes associated with schemasets. Improves de-registration performance by approx 10% Issue-ID: CPS-1423 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ie38e8b4c64356bf5935d8c7a5d3f5bfa73fb1714
2023-02-15Bulk delete schemasets in CM handle deregistrationdanielhanrahan15-19/+162
- Batch delete schema sets in single query - Call deleteUnusedYangResourceModules once per batch, not per CM handle - Results for deregistering 10k: 14 mins before; 6 mins after Issue-ID: CPS-1423 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ia3a86a0dc88677323e2f386253a99022a7f02603
2023-02-15Merge "Use getDataNodes (plural version) into NCMP to get CM handles ↵Toine Siebelink5-114/+42
Performance improvement"
2023-02-15Introducing GrafanaToineSiebelink3-5/+60
- Added profiles to docker compose: dmi-service/dmi-stub, monitoring - NOTE: now need to add '--profile dmi-service' to enable dm-plugin (e.g. for csit) - using container names to resolve hosts for prometheus Issue-ID: CPS-1465 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I5d7365a3f789cc698e2702d72700a002cf03eaef
2023-02-14Use getDataNodes (plural version) into NCMP to get CM handles Performance ↵seanbeirne5-114/+42
improvement - Code clean-up on existing classes - Removed duplicate code Issue-ID: CPS-1426 Signed-off-by: seanbeirne <sean.beirne@est.tech> Change-Id: I3e2ce5b804d7a6e87838490d970cde3cd563f06b
2023-02-13Merge "Test for yang file archive limitation"Luke Gleeson5-38/+72
2023-02-13Merge "Generate report of Instrumentation Metrics"Toine Siebelink2-1/+112
2023-02-13Test for yang file archive limitationhalil.cakal5-38/+72
- add new test - fixed misleading method names Issue-ID: CPS-1480 Change-Id: I9dd8f41d0acfc8b1c063aab65567d619670f4905 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2023-02-11Generate report of Instrumentation Metricsdanielhanrahan2-1/+112
Generate a tab-seperated-value report of Prometheus metrics. By default, assume CPS/NCMP is running on localhost:8887, and output file named metrics-YYYY-MM-DDThh:mm:ss+00:00.tsv Issue-ID: CPS-1488 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I8bb356a1b6caacaec4a025a7d6d29cd34420e6c9
2023-02-09Use getDataNodes (plural) in CmHandle deregistrationdanielhanrahan2-24/+19
Issue-ID: CPS-1426 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I0ad79bf36840cdecc13898e185dc618cedafd529
2023-02-09Merge "Produce subscription create event for subscription-topic: ↵Toine Siebelink4-4/+119
cm-avc-subscription"
2023-02-09Merge "Update CmHandleState on deregistration response"Priyank Maheshwari2-46/+75
2023-02-09Produce subscription create event for subscription-topic: cm-avc-subscriptionsourabh_sourabh4-4/+119
- Groovy Kafka (component level) : Produce subscription create event. Issue-ID: CPS-1394 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: Ib020c0a4458406925792fc074afd998aa09af158 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2023-02-08Merge "Correct calculation of zip archive size for schemaset upload"Toine Siebelink1-1/+1
2023-02-08Use getDataNodes (plural version) into NCMP to get CM handlessourabh_sourabh6-12/+225
- Use plural getYangModelCmHandles get YangModelCmHandles by CmHandles in batches. Issue-ID: CPS-1426 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: Ie175b471bd98b02b572ca4a3ff699d721b5b782a Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2023-02-08Release Process Step 7mpriyank20-21/+50
- updated pom to 3.2.3-SNAPSHOT - updated version.properties and updated the release notes to properly depict the correct version Issue-ID: CPS-1476 Change-Id: Ied60194c6dd4153b58a43715cb729ad75b8e12bf Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-02-08Release Step 6mpriyank1-0/+8
- adding container yaml file for the release Issue-ID: CPS-1476 Change-Id: Ib61a14591b9fe62e96d24ae3c557f720a23217c7 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-02-08Release process Step 4mpriyank1-0/+4
- adding maven stage yaml file Issue-ID: CPS-1476 Change-Id: Iafbc5ed63cf4edc275e5b4087c154439c5c5ac55 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-02-08Release Steps 1 and 2mpriyank2-5/+11
- added the jira ticket as part of step1 - copied the changes of openapi.yaml as part of step2 of release process Issue-ID: CPS-1476 Change-Id: I877757e0396e6349b1ab5e966ae4440c4fead829 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2023-02-08Correct calculation of zip archive size for schemaset uploadArne Chrestin1-1/+1
Correct calculation of zip archive size for schemaset upload Issue-ID: CPS-1477 Change-Id: I73f97f986a817d423f93a8d922dcd9647b0203ab Signed-off-by: Arne Chrestin <arne.chrestin@telekom.de>
2023-02-07Update CmHandleState on deregistration responsedanielhanrahan2-46/+75
Current implementation incorrectly sets CmHandleState to DELETED for CM handles that were not deleted. - Update CmHandleState to DELETED only for deleted CM handles - Minor test refactoring Issue-ID: CPS-1471 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ibf8b6d2b87d46a7633f0497b065e3d4099851fd6
2023-02-03Merge "Descendants description changed in openApi"Luke Gleeson2-4/+3
2023-02-03Descendants description changed in openApirajesh.kumar2-4/+3
Issue-ID: CPS-1381 Change-ID: I73f97f986a817d423f93a8d922dcd9647b0203aa Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
2023-02-02CmHandle batch deletiondanielhanrahan5-29/+79
- Use plural deleteDataNodes to remove CmHandles in batches, falling back to individual delete on error - Use single deleteDataNode instead of deleteListOrListElement for individual delete Issue-ID: CPS-1464 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: If09f22478df8703290c8fc24aa6fe2a11c90788a
2023-02-02Modify CSIT script to have absolute root path envemaclee4-6/+6
- change set up to call docker compose for cps-ncmp - add root as a property in 'test.properties' - root is specified to be root directory folder for the current project - modified docker compose init container to use ROOT env var Issue-ID: CPS-1472 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: Ie5ac6bbff7cb1e761501bd0db8447f86af06b95f
2023-02-01Create plural version of deleteDataNodedanielhanrahan14-104/+315
- Add method to CpsDataService to batch delete data nodes and lists - Use native queries to batch delete fragment entities by xpaths, for data nodes and lists - Add performance tests for batch delete - Refactor FragmentNativeRepository - Add single-column version of createTemporaryTable - Renamed metric cps.data.service.datanode.batch.delete to cps.data.service.datanode.all.delete Issue-ID: CPS-1438 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I1851f9c7ef0b1be4bd421b3352d9697a2dd23f79
2023-01-31Merge "Introduce Instrumentation"Luke Gleeson27-115/+431
2023-01-31Introduce InstrumentationToineSiebelink27-115/+431
- Add instrumentation related dependency - Added Timed Instrumentation - CPS-Service Crud methods - CPS Yang parsing - NCMP Registration methods - NCMP Events handling - Remove manual Gauge for YanResources Cache as (better!) instrumentation is already built into the 3PP - Sorted dependecies alphabetically (as we used to enforce, to prevent duplicates) - Added ## P E R F O R M A N C E T E S T R E S U L T S ### mini report - (unrelated) test improvement (because of bug that turned out to be invalid) Reviewers: Sourabh,Priyank, Luke Issue-ID: CPS-1457 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I34b20bece2f59488b022b8effa9470704c57be4d
2023-01-30Edit example given for ncmp datastoreseanbeirne2-7/+7
Issue-ID: CPS-1468 Signed-off-by: seanbeirne <sean.beirne@est.tech> Change-Id: Id746604fca83333f4ee186ce96ea80cb779c4ac2
2023-01-30Fix for integration test module testslukegleeson2-26/+6
Added Fragment Native Repository to test config Removed test profile Issue-ID: CPS-1466 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: Id845b713e760801be480aa9aea6cb304decd05b9
2023-01-27Update version files for release processseanbeirne20-19/+43
- Updated version.properties - Updated release-notes - Updated pom files Issue-ID: CPS-1835 Signed-off-by: seanbeirne <sean.beirne@est.tech> Change-Id: I0f837ac41d24b41d7c2b9e3dfe2dacc550c0aafa