summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2024-07-09Merge "[k6] Measure CM-handle (de)registration in CM-handles/sec"Sourabh Sourabh10-231/+130
2024-07-09Merge "Remove forced module sync from NCMP integration tests"Lee Anjella Macabuhay5-54/+30
2024-07-09Merge "Refactor integration tests so only one DmiDispatcher is used"Lee Anjella Macabuhay2-34/+32
2024-07-08Merge "Remove Mappers and Events Facade"Lee Anjella Macabuhay11-325/+56
2024-07-05[BUG] Fix handling of special characters in moduleSetTagdanielhanrahan3-7/+6
During CM-handle registration, moduleSetTag is sent as part of the JSON request body when getting modules from DMI. However, it incorrectly parses the moduleSetTag as JSON, instead of encoding to JSON. This results in parsing errors when moduleSetTag includes characters such as ':' Issue-ID: CPS-2302 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ie38008e0effac2423a4d069a91587e47d8747d66
2024-07-05Remove Mappers and Events Facadempriyank11-325/+56
- Removing Mappers and Events Facade and introducing the normal classes that this facade was wrapping - Corresponding changes in the testware Issue-ID: CPS-2298 Change-Id: I380d73ff3a9b3bf79633cd91580d6a4dee00a662 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-05[k6] Measure CM-handle (de)registration in CM-handles/secdanielhanrahan10-231/+130
As per characteristics requirements document: - measure registration in CM-handles/second - measure deregistration in CM-handles/second - summary table includes test case number, description, units of measurement, actual value and limit. Issue-ID: CPS-2269 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I838004da1c230ab722f49c2adacf34e730d7ac79
2024-07-05Merge "refactor cmsubscription code"Daniel Hanrahan52-1677/+1587
2024-07-04Remove forced module sync from NCMP integration testsdanielhanrahan5-54/+30
- remove forced module sync in tests - set module sync timers to 1 second in test application.yml - have tests wait up to 2 seconds for module sync to run Issue-ID: CPS-2304 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I727894dc1b4b9cee1ab82d05a9c31d1e3e067cf3
2024-07-04Refactor integration tests so only one DmiDispatcher is useddanielhanrahan2-34/+32
Issue-ID: CPS-2303 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I4d04fb9b7693a769e9059d3b2b7257a714da0532
2024-07-04refactor cmsubscription codempriyank52-1677/+1587
- Moved cmsubscription to the impl package instead of api. - Below packages are renamed or newly created for code and tests - moved ..api.cmsubsription to ..impl.cmsubscription - renamed ..api.cmsubscription.mappers to ..impl.cmsubscription.ncmp or dmi as per the functionality - renamed ..api.cmsubscription.model to ..impl.cmsubscription.models - removed ..api.cmsubscription.producer/consumer and classes moved to ..impl.cmsubscription.ncmp/dmi - new package ..impl.cmsubscription.cache to hold cache config and cache operations - new package ..impl.cmsubscription.avc to hold the CmAvcEventConsumer for the notifications emitted as a result of the subscriptions - Removed the prefix CmNotificationSubscription for majority of the classes , not removed for Config and model classes - Renamed the schemas and package structure as per the code refactoring Note: *EventsFacade and *MappersFacade to be removed in the next patchset Issue-ID: CPS-2298 Change-Id: I1d788ab745d65965570e28beaefa511cbe4a8547 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-04Release notes for Web Client prometheus metricssourabh_sourabh1-0/+1
- Release notes updated as we enabled http client prometheus metrics. Issue-ID: CPS-2121 Change-Id: I6918da7cd4e4523c1ec0ab6060bdc1686c141a9d Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-04Merge "Add Policy Executor Open API Interface definition"Sourabh Sourabh3-4/+250
2024-07-03Merge " CPS NCMP: Resolved high cardinality of prometheus metrics for dmi ↵Toine Siebelink19-491/+474
service url"
2024-07-03 CPS NCMP: Resolved high cardinality of prometheus metrics for dmi service urlsourabh_sourabh19-491/+474
- Used autoconfigured web client builder for http_client_requests_* prometheus metrics. - Refactored dmi service url builder to create url template and its variables. - Web client is modified to use uri(urlTemplate, urlvars) version. - Deleted InvalidDmiResourceUrlException that no longer needed. - Used DmiServiceUrlBuilder to build dmi health check service url. - Created a new pkg url.builder into utils to have all related classes and record. Issue-ID: CPS-2121 Change-Id: Id67e0f0d4e640bb8f9eea0b6c2db1dba3468e1d7 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-03Add Policy Executor Open API Interface definitionToineSiebelink3-4/+250
- OPenApi in RTD only (for now) - Bear authentication included in OpenApi - Placeholder RTD page (to be completed upon feature delivery) - For consistency (and color coding in editors) I put all Description and Example strings inside double qoutes "..." Issue-ID: CPS-2291 Change-Id: I7f16cdce2a06cb011997005fa8b86b54c044304a Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-07-03Fix sonar issue in performance test ResourceMeterdanielhanrahan1-3/+4
Replace busy loop with await().until as suggested by sonar Issue-ID: CPS-89 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ic6c870c419a67708082ceb05ef3ccba884ae375e
2024-07-01Merge "Improve handling of Invalid Operation exception"Sourabh Sourabh6-17/+22
2024-07-01Merge "Fix incorrect use of getAnchors(dataspace, schemasets)"Daniel Hanrahan10-73/+132
2024-07-01Improve handling of Invalid Operation exceptionToineSiebelink6-17/+22
- MOve to API package - Handle in REST Controller to return BAD REQUEST Issue-ID: CPS-2256 Change-Id: I4f96519aaf2e7f781729c8b8671ea02630a2e0a8 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-27repackage 'data' featureToineSiebelink84-312/+231
- moved relevant classes into these (new) packages: api.data.exceptions api.data.models impl.data impl.data.async impl.data.exceptions impl.data.models impl.data.utils utils.events - removed old unused event class - moves some missed inventory related class to the right place Issue-ID: CPS-2256 Change-Id: I75563e063acc0054769d8f2b13146e6c1d1c6054 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-27move lcm/common events classesToineSiebelink37-57/+55
-moved api.impl.events.lcm to impl.inventory.sync.lcm -moved most api.impl.events class to utils.events (remaining classes in api.impl.events belong to cmsubscrption and Priyank wil take care of those) Issue-ID: CPS-2258 Change-Id: I1818194e708aa0d9c713b470e878997c2f26fb13 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-27Merge "Simplify package structure cps-ncmp-rest"Priyank Maheshwari11-18/+20
2024-06-27Simplify package structure cps-ncmp-restToineSiebelink11-18/+20
Issue-ID: CPS-2294 Change-Id: Idc3605c1b877be13a8d344875612da6bef791fc7 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-26Merge "Move TrustLevel Feature"Priyank Maheshwari32-148/+146
2024-06-26Move TrustLevel FeatureToineSiebelink32-148/+146
-Moved TrustLevel impl from Controller to Inventory Facade -Applied new package name convention using impl\inventory\trustlevel for this (sub)feature -Renamed some trustlevel related classes to better describe their role -Disabled failing architecture test (agreed this is tech. debt and created CPS-2293) -Refactored YangDataConverter method names and signatures (moved Spec to correct place) -Cleaned up names and javadoc of class now called DeviceTrustLevelMessageConsumer -Applied conventions to modified test methods Issue-ID: CPS-2255 Change-Id: Iccd20541488e6b61444bb2c7406c90e61a34124d Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-26Merge "Disable the java debug port permanently"Sourabh Sourabh1-2/+2
2024-06-26Disable the java debug port permanentlyhalil.cakal1-2/+2
Issue-ID: CPS-1864 Change-Id: I0366b126920cf0bc706545bc5b4e469d3faa2486 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2024-06-26Merge "Clean up the k6 test suite"Daniel Hanrahan10-324/+9
2024-06-25Fix incorrect use of getAnchors(dataspace, schemasets)danielhanrahan10-73/+132
There is an issue in a method deleteDataNodes(dataspace, anchors) where it doesn't send data update events. This is because it fetches anchors using a method getAnchors(dataspace, schemaSetNames), when it needs to fetch anchors by name: getAnchors(dataspace, anchorNames) Changes: - Rename getAnchors method using schemasets to getAnchorsBySchemaSetNames - Add a method getAnchors(dataspace, anchorNames) - Update test of deleteDataNodes method using getAnchors so it checks that data update events are sent Issue-ID: CPS-2254 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I55fe853f0a9278a66a5724bf4cf2723b0e2fbc8b
2024-06-24Repackage Inventory FeatureToineSiebelink117-493/+498
- decided that cm handle queries is part of 'inventory' feature - a lot of files (~100 total) have changes because of some files have been moved. - The reviewers should probably just focus on the MOVED/renamed (~30) files - New packages (top level only): -- org.onap.cps.ncmp.api.inventory -- org.onap.cps.ncmp.impl.inventory -- org.onap.cps.ncmp.impl.models (common models NOT used in API, this was unforeseen) -- org.onap.cps.ncmp.impl.utils - I am NOT updating copyright years as part of this commit since there are no real code changes and it is simply NOT worth the effort TODO: - extend scope to 'TrustLevel' as an 'internal feature' (TBD) Issue-ID: CPS-2255 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I40b4efc8326068ab9ae1f31b77f46b2fe8579431
2024-06-24Clean up the k6 test suitehalil.cakal10-324/+9
- Remove the tests that are not in the Characteristics - Set .625 seconds/operation for cm handle id search with module filter - Set 13 seconds/operation for cm handle search with module filter Issue-ID: CPS-2286 Change-Id: I88d5773abadb29ce46914029332384ae8e55e032 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2024-06-21Fix compile issue after facade introductiondanielhanrahan2-3/+3
Due to automatic rebase, a method got renamed in one commit but not the other. Issue-ID: CPS-2263 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Id0fa8eba79cb98bb24419bfddc0c9b9e8c9a42d3
2024-06-21Merge "Introducing NCMP Facades"Sourabh Sourabh44-1342/+1241
2024-06-21Merge "Spliting a data-job into sub-jobs for DMI Plugin"Sourabh Sourabh14-27/+502
2024-06-20Introducing NCMP FacadesToineSiebelink44-1342/+1241
- NetworkCmProxyDataService was polluted with many non-data operations - it is now split into: 1) NetworkCmProxyFacade, a single thin facade for the (main) controler to redirect calls to the correct services 2) CmHandleRegistrationService(Impl), methods related to registration only - introduced NetworkCmProxyInventoryFacade for the invenoty controller - renamed some services for consitency and clarification - Use facade to acces ncmp data request handlers (instead of direct from controller) - remove unnecesarry wrappings between request handlers and facade - split facades according to names: data & inventory (the REST controllers are not split properly so I think one rest controller will end up needing both facades) Issue-ID: CPS-2263 Change-Id: I250732aa16ec28b43ff642d2adf10ba36f67290e Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-20Bump CPS version to 3.5.1-SNAPSHOTmpriyank25-25/+53
- bump cps version to 3.5.1-SNAPSHOT - updated release notes to make it ready for the next release Issue-ID: CPS-2283 Change-Id: I242cae7c95a87c1a9e225cce3eb7b36097f1e5ba Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-20Maven container yaml for releasempriyank1-0/+8
- added maven container yaml to release cps 3.5.0 version Issue-ID: CPS-2283 Change-Id: I45ce5b440d8ca2f6ff3999971202f9fc3bd4a8fa Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-20Spliting a data-job into sub-jobs for DMI Pluginleventecsanyi14-27/+502
- algorithm for create sub-job requests - added new method to DmiServiceUrlBuilder to get the write job url - created WriteOperationExaminer, DmiSubJobClient & testware Issue-ID: CPS-2142 Change-Id: I258d334ef346cd388341a1deb4078d24d8bdb7cc Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-06-20Maven yaml for releasempriyank1-0/+4
- added maven yaml file to release cps 3.5.0 Issue-ID: CPS-2283 Change-Id: Ifc9cc9f33381d64bf573593949cf59303ff8d0fc Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-20Release notes and OpenApi syncmpriyank2-10/+151
- Release notes updated and openapi syncd for CPS-Core and NCMP Issue-ID: CPS-2283 Change-Id: Iafdebc65cbcec01bf0d6e6963bd9601fea5f5081 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-19Addressed an adaptability issuesourabh_sourabh1-5/+5
- Defined a constant instead of duplicating literal "No data nodes 4 times. Issue-ID: CPS-478 Change-Id: I2b980a228217e85424342d4c2b9e97c5cfa618d1 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-19Handle high frequency (faster then DMI) of passthrough request in NCMPsourabh_sourabh7-71/+113
- Added pendingAcquireMaxCount property into appliaction.yml. - Added findbugs google annotations dependency. - Supressed "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE" spotbugs low error for reactor.netty.resources.ConnectionProvider. Issue-ID: CPS-2262 Change-Id: Ie755e40282473933f2052fbe7654e7090bb9b337 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-06-17Merge "[k6] Add JVM warmup phase (#2)"Priyank Maheshwari4-9/+14
2024-06-17Merge "[k6] Refactoring k6 tests (#1)"Priyank Maheshwari15-117/+174
2024-06-17Refactor and Move NCMP Data Request HandlersToineSiebelink13-157/+126
- Simplified NCMP Rest Request Handlers - Moved responsEntity wrapping to Controller so most handler methods can have clear return types - Moved NCMP Rest Request Handlers to Service Layer - Moved related exceptions and utils to Service Layer - Used Lombok for constructors - Improved related testware Issue-ID: CPS-2266 Change-Id: I0025fab1c92e0d613825093b6e4b43dae044c01a Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-14[k6] Add JVM warmup phase (#2)danielhanrahan4-9/+14
To account for JVM warmup effect, the k6 test suite is run twice: initially, the whole test suite is run without recording results. - Added environment variables to allow setting total CM-handles and batch size for registration. By reducing total CM-handles during warm-up, many more operations will be run. Issue-ID: CPS-2264 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ib1d1e76d31719d788a3e026797faa0a425b320a2
2024-06-14[k6] Refactoring k6 tests (#1)danielhanrahan15-117/+174
This commit moves all common request logic into a common folder. It is needed to avoid duplication before adding JVM warmup phase. - move registration-related code into common folder - move passthrough operations into common folder Issue-ID: CPS-2208 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ia9ebf61d21044b43063bde153f9c526e67d607c8
2024-06-14Update ONAP DMI version in NCMPmpriyank2-2/+2
- update the docker compose file to point to latest version on onap-dmi-plugin. Same to be used to run the CSITs during build. Issue-ID: CPS-2271 Change-Id: Ifbb2ee9c9548d54979a04595e19062d9192bfd1d Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-06-13 #2: Used async version of web client for single cm handle read operationsourabh_sourabh16-344/+162
- Code change is done to use async web client for single cm handle read data operation. - CpsNcmpTaskExecutor class and groovy test code is removed. - Use of supplier code is removed from cm handle Query service. Issue-ID:CPS-2259 Change-Id: I2b7a36e8a151a9224937afd876fceb30be6a24ce Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>