summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2022-06-13Fix sonar code smellskissand11-53/+58
- https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYFC3OguDZ5Vb3SQMOU1 Issue-ID: CPS-1016 Change-Id: Ic8fdae78337da1ff2c239ae2dfae67e23e88a4bb Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
2022-06-09Merge "PoC Contract Stubs NCMP Rest Endpoints"Toine Siebelink8-0/+519
2022-06-09Merge "Handle errors during cm handle search"Toine Siebelink5-26/+25
2022-06-09Handle errors during cm handle searchkissand5-26/+25
Issue-ID: CPS-1067 Change-Id: Iadc3413a29f9a455e658ec5bcaffc4881b7f7684 Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
2022-06-09Merge "Fix sonar code smells"Toine Siebelink2-9/+6
2022-06-09Remove Model Sync From RegistrationToineSiebelink13-93/+65
Decouple the model sync from registration process Sync now only happens during the watchdog process Cm Handles are persisted in state ADVISED when registartion is successful Issue-ID: CPS-876 Change-Id: Ia3353a0ab1c65a9db553e09138d5690d4f915727 Signed-off-by: DylanB95EST <dylan.byrne@est.tech> Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2022-06-09Override timers advised-modules-sync sleep-time-mssourabh_sourabh1-0/+1
- Override timers advised-modules-sync sleep-time-ms from docker compose for CSIT test Issue-ID: CPS-876 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I2cbc76c03cd5907e2d3bf28b38dbf8209eaaddbd
2022-06-09Fix sonar code smellsemaclee2-9/+6
- Remove useless curly braces around statement (https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYD_5_HLFWip2-KRhcLs) - Define a constant (https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYEj9y6sq272EuFEMiu-) Issue-ID: CPS-475 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: Ib430fac481b29dba8725ed0dac4da3daa56a3984
2022-06-09Merge "Ncmp Producer Setup"Toine Siebelink6-61/+259
2022-06-08Merge "Merge 2 'query' end points in NCMP"Toine Siebelink37-504/+1252
2022-06-08Merge 2 'query' end points in NCMPkissand37-504/+1252
- merge two endpoint for a same backend - use xPath query instead of sql query - modify searches endpoint to return a cmHandle object with all public properties - handle old (deprecated) queries - handle public property queries - create useful examples - use more verbose error messages - simplify openapi yamls - create new query service - change second endpoint name to a better matched name - modify legacy tests with new requirements - create new tests for the new scenarios Issue-ID: CPS-1016 Change-Id: I7476e9dbd510ec93b5b48ce85d477ecb2dadffff Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
2022-06-07Ncmp Producer Setupmpriyank6-61/+259
- Ncmp Kafka Publisher setup - Test scenarios - Refactored existing test class which were using kafka producer and consumer properties to use from common MessageSpec - Upcoming : Implementation Proposal and Actual logic to publish the correct event Issue-ID: CPS-1035 Change-Id: I93ae392e8c4e4c85d88ca7858332e79b59e85535 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-06-07PoC Contract Stubs NCMP Rest Endpointsputhuparambil.aditya8-0/+519
Stubs defined for cmHandleSearch and passthrough operational Issue-ID: CPS-919 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I4fd7bee8fa70ed237f74c721068ffa39817d5c7a
2022-06-03Merge "CPS-1020 : DuplicatedYangResourceException error at parallel cmHandle ↵Toine Siebelink2-3/+9
registration"
2022-06-02CPS-1020 : DuplicatedYangResourceException error at parallel cmHandle ↵sourabh_sourabh2-3/+9
registration - @EnableRetry is added into application. - Added retry count into log to add more information about retry. Issue-ID: CPS-1020 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I00c58ef17a8c066f98711c1cf8e5e5cb5f22974b
2022-06-02Merge "Add module name to cps core output"Toine Siebelink10-54/+192
2022-06-02Merge "NcmpEvent creation for ModuleSync"Toine Siebelink2-1/+88
2022-06-02Add module name to cps core outputemaclee10-54/+192
- add withModuleName method - add getNodeIdentifierWithPrefix method - add unit test in DataMapUtilsSpec - add unit test in DataNodeBuilderSpec - fix all existing unit tests Issue-ID: CPS-870 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: I51b70fa2dd3381eef9500b4339d4922c017e3000
2022-06-01NcmpEvent creation for ModuleSyncmpriyank2-1/+88
- NcmpEvent schema creation which will be published when module sync is completed - Added cmHandleId in the event payload and made eventCorrelationId as optional - Upcoming : NcmpEvent publisher code and mapping of the events Issue-ID: CPS-1036 Change-Id: I7731e6e6a4a8f718967ce68cc6ae0e411eb8c12b Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-06-01Merge "Module Sync Lock State implementation"Toine Siebelink24-285/+367
2022-06-01Module Sync Lock State implementationDylanB95EST24-285/+367
Implementation of Lock state for module sync watchdog Cm Handle state is locked if any exception is found during sync process Make changes around READY state method in line with the new schema set Add last updated time to composite state Remove running datastore references as this is being done at a later time Issue-ID: CPS-875 Change-Id: I6bd159faefef2fa84dbf536c292ff0a132793381 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-06-01Merge "DMI-NCMP Asynchronously Publish Response Event to Client Topic"Toine Siebelink1-0/+67
2022-06-01Fixing CompositeState mappingmpriyank4-6/+23
- Mapper null check - NcmpServiceCmHandle mapping for the new composite state - Added global parameter for jackson to include only NON_NULL attributes in the response Issue-ID: CPS-1066 Change-Id: I1924fef45345c77873f9c788baa701311e72bea7 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-06-01DMI-NCMP Asynchronously Publish Response Event to Client Topicsourabh_sourabh1-0/+67
- [NCMP] Added Unit Tests for NcmpAsyncRequestResponseEventMapper.java Issue-ID: CPS-830 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I64dad7f0bb9b64e1864f19db5a5d74922dc6a83b
2022-06-01Merge "Handle RestTemplate Error handling so NCMP cna report correct server ↵Joseph Keenan9-229/+108
status"
2022-05-31Handle RestTemplate Error handling so NCMP cna report correct server statusToineSiebelink9-229/+108
- Moved resposne handling to DmRestClient - Clean up incorrect/redundant tests in CmProxyDataServiceImplSpec Issue-ID: CPS-1056 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I78ba87d6af7255d85758893cfef237d75227875a
2022-05-26Merge "CompositeStateBuilder added for building the compositeState"Joseph Keenan5-7/+241
2022-05-26CompositeStateBuilder added for building the compositeStateputhuparambil.aditya5-7/+241
Added composite state to YangModelCmHandleRetriever Issue-ID: CPS-878 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I8bdea55c0a8e27a906e24fc367dedf81c9b3501c Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
2022-05-25Async request response NCMP -> ClientJosephKeenan28-297/+1164
-Added consumer for DMI events and producer for forwarding to client -Added schemas for events -Updated tests -Added new module for ncmp events -Used mapstruct for event mapping Issue-ID: CPS-830 Change-Id: I096d08af9d69092cf8651e11eaa00ce441fc3605 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2022-05-24Enhanced response with Complex State in APImpriyank10-9/+259
- Introduced RestOutputCmHandleState in API specs of retrieveCmHandleDetailsById - Mapper to map CompositeState to RestOutputCmHandleState - Enhanced existing test cases and introduced new one to test the mapping result Issue-ID: CPS-1047 Change-Id: I34fa198287e5d920bc0cea312ee4e368f3be2b90 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-05-20Merge "Get cm-handle public properties endpoint"Toine Siebelink10-18/+128
2022-05-20Get cm-handle public properties endpointlukegleeson10-18/+128
Added RestOuputCmHandlePublicProperties OpenApi Object Added Get cm-handle public properties endpoint Added rest and service layer functionality for endpoint with tests Fixed Copyright Checker violations Issue-ID: CPS-1018 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: Ifc13cde350a49f6ba705a09e31853dc9c73be168
2022-05-20Merge "URI is not absolute when service name is not set"Joseph Keenan2-3/+15
2022-05-19Merge "Composite State to handle dmi-reg YANG updates"Toine Siebelink10-32/+211
2022-05-19Composite State to handle dmi-reg YANG updatesmpriyank10-32/+211
- Introduce CompositeState object which handles change in updated YANG for dmi-registry - Used Builder pattern as some of the fields are optional - Removed the abstract ready method from CmHandleState which was used as state machine - Fixed few test cases Issue-ID: CPS-1042 Change-Id: I8aaf6f819c66b3a9d30c5e8f0a0007f9528b247f Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-05-19URI is not absolute when service name is not setDylanB95EST2-3/+15
BUG - URI is not absolute exception when dmi-service-name is not set in the database, due to null String Has now been set to null value Issue-ID: CPS-1043 Change-Id: If48c34d8caee302a1849555755960dccfd26ab7a Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-05-16Remove NCMP tag from propertiesDylanB95EST4-21/+21
We have decided to remove the NCMP tag from properties and will add it later as part of our release process for KOHN. Issue-ID: CPS-875 Change-Id: I7282c3c11879f2252c8a1b193df17f3f4bb1cf14 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-05-13Merge "Watchdog-process that syncs 'ADVISED' CM Handles"Toine Siebelink8-24/+130
2022-05-12Watchdog-process that syncs 'ADVISED' CM HandlesDylanB95EST8-25/+131
- Sync and Create Schema Set during module sync watchdog process. - Add a cm handle state transition machine to handle state changes for a cm handle during watchdog which syncs module service. Issue-ID: CPS-875 Change-Id: I3b178f5693cb7ac30577dd81cdc82b462555389a Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-05-12Merge "Add graceful shutdown for Session Manager"Joseph Keenan7-44/+184
2022-05-12Add graceful shutdown for Session Manageremaclee7-44/+184
Introduce singleton session manager Add unit test for session manager Issue-Id: CPS-898 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: Iaf91f1aa6c1ebfe0ab907e7f7d80a01e940a0fdd
2022-05-11Merge "Update DMI Registry yang to support DataStoreSyncState"Toine Siebelink4-0/+239
2022-05-11Update DMI Registry yang to support DataStoreSyncStateLathish4-0/+239
- Added dmi-registry@2022-05-10 yang to support DataStoreSyncState - Added changelog 14 to add the dmi-registry Issue-ID: CPS-1014 Change-Id: I910d2496a359fdf2441e172ca270036272d31dc6 Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
2022-05-10Watchdog Process-Make ConfigurableDylanB95EST3-10/+23
Make time configurable for the watchdog process. Add documentation outlining this. Issue-ID: CPS-875 Change-Id: I1307c82d02789097efda1ba981eb1fd36c9efc38 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-05-10Merge "Add ncmp tag to application yaml"Toine Siebelink3-16/+17
2022-05-10Merge "Improve Local Running of CSIT Tests"Toine Siebelink1-1/+1
2022-05-10Improve Local Running of CSIT Testslukegleeson1-1/+1
Issue-ID: CPS-734 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: Iff92f43dc69cdaf3e1e78551f68ecfb08bde4b93
2022-05-09Add ncmp tag to application yamlDylanB95EST3-16/+17
Add an NCMP tag to Application.yml to store NCMP related propeties Issue-ID: CPS-875 Change-Id: I2bce3d765ae69cc2a4bb52a472eea7cae745fd2c Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-05-06Security Logging Fieldssourabh_sourabh1-1/+1
- Made logging.format value case insensitive for consistency as we did same change for cps-temporal, ncmp-dmi-plugin and oom. Issue-ID: CPS-986 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I085a3777e8f4cf9e6b62e40d05672ce455916a85 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2022-05-05Security Logging Fieldssourabh_sourabh4-56/+68
- logback core and encoder dependencies are added. - New appender is added to log JSON format content on console. Issue-ID: CPS-986 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: Ia72b27f306019fa259b3d6de4c5399f0ae734076