summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2024-07-12Print DMI stub logs in CSITsdanielhanrahan1-0/+3
Issue-ID: CPS-2313 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I4ecb5ce1713666b5e90b90eba3c98b737fd91896
2024-07-12Print docker logs in CSITs for 2 cps-and-ncmp instancesdanielhanrahan1-2/+5
Following introduction of 2 instances of cps-and-ncmp, CSIT logs show an error "No such container: cps-and-ncmp". This commit prints docker logs for each cps-and-ncmp container. Issue-ID: CPS-2038 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: If3ed4590cef0f5b59d74e62c84f6c6e72edfd411
2024-07-11Merge "Policy Executor Feature Toggle"Sourabh Sourabh8-16/+178
2024-07-11Policy Executor Feature ToggleToineSiebelink8-16/+178
- defined config parameters for feature toggle and server details - log request details when feature enabled - improved JavaDoc in Controller - improved configuration properties checks in HttpClientConfigurationSpec Issue-ID: CPS-2311 Change-Id: I1ff4bd3592ce2570ac74f9ec6e62b75001cb611a Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-07-11Merge "Fix timing issue in CmHandleCreateSpec"Priyank Maheshwari1-21/+8
2024-07-11Fix timing issue in CmHandleCreateSpecdanielhanrahan1-21/+8
The test for module sync retry on LOCKED handles has a timing issue, due the ordering of the steps. After a LOCKED handle gets reset to ADVISED state (but DMI is not yet set to available), the Module Sync Watchdog may wake up and put it back into LOCKED state again. This fix is to first make the DMI available before waiting for the LOCKED handle to reset. Issue-ID: CPS-2304 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I9d33b0eeea1e0a2e163489130c928b4d03182774
2024-07-11Documentation updated in docs/ncmp-inventory-querying.rstsourabh_sourabh1-0/+20
- Existing API docs in docs/ncmp-cmhandle-querying.rst is updated where CPS Path is now supported as ancestor axis. Issue-ID: CPS-2289 Change-Id: I065179fe7c294588580448a8467765e9d116d33a Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-10Merge "NCMP inventory cm handle search should support cps path query"Toine Siebelink4-15/+28
2024-07-10Remove nginx logs that not being used anywherehalil.cakal2-5/+0
Issue-ID: CPS-2038 Change-Id: Iba8950db4f3fcfc13f32bf915189f5fcb2ccee90 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2024-07-10NCMP inventory cm handle search should support cps path querysourabh_sourabh4-15/+28
- Added cps path query conditions for inventory search api Issue-ID: CPS-2289 Change-Id: I0bcc9a45af65ad9d41c4d4cf79b35bfb95f50cff Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-10Split integration tests into cps and ncmp packagesdanielhanrahan11-23/+23
Issue-ID: CPS-2309 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ie97c1430d1121c4c68b3fc6dacbc2466d48e1017
2024-07-10Policy Executor API, make Authorization header optionalToineSiebelink3-11/+15
Issue-ID: CPS-22291 Change-Id: I2b8f9b97c92dfc640c8b40b7053c609bbdcb2f6e Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-07-09NCMP: NCMP search API fixed to handle cps path that is ancestor axis assourabh_sourabh3-2/+24
well - Cps path builder is fixed to handle ancestor axis that is target as well while quering. Issue-ID: CPS-2308 Change-Id: Iaf215851ada17d21516ae83fa142ac77ff1c6c19 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-09Refactor remaining classes package structureToineSiebelink71-361/+122
-Introduced org.onap.cps.ncmp.config for all config type classes like http, kafka etc. -Introduced org.onap.cps.ncmp.impl.dmi for dmi specif classes like DmiRestClient etc. -Moved most exception classes to org.onap.cps.ncmp.api.exceptions (only two were 'internal' i.e. NOT used in REST so left in org.onap.cps.ncmp.exceptions) -Deleted unused DateNodeHelper class (and related testware) -Moved some classes to org.onap.cps.ncmp.impl.utils -Moved messaging test base classes to org.onap.cps.ncmp.impl.utils.events -All imports were reorganised automatically by IntelliJ -did NOT update any copyright dates (seems incorrect to me anyway) Issue-ID: CPS-2257 Change-Id: Ie28b1777ea278064b46c6a1c3a28f4d0696565e2 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-07-09Increase module sync wait time in tests to 10 secondsdanielhanrahan1-1/+1
Too small timeout is causing intermittant test failures. Issue-ID: CPS-2304 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ib6a25cb2f44e9a65b8f7d2d98e8d5e7dfe1f9ceb
2024-07-09Merge "Create PolicyExecutor Stub"Sourabh Sourabh11-12/+517
2024-07-09Merge "Setup automated tests with two replicas of cps-and-ncmp"Daniel Hanrahan6-8/+85
2024-07-09Merge "[k6] Measure CM-handle (de)registration in CM-handles/sec"Sourabh Sourabh10-231/+130
2024-07-09Merge "Remove forced module sync from NCMP integration tests"Lee Anjella Macabuhay5-54/+30
2024-07-09Merge "Refactor integration tests so only one DmiDispatcher is used"Lee Anjella Macabuhay2-34/+32
2024-07-08Create PolicyExecutor StubToineSiebelink11-12/+517
- Generate interface from OpenApi in RTD docs - Fixed Content Type in OpenAPI - Fixed Paths in OpenAPI - Made Authorization header compulsory in OpenAPI - All 'enum' values in OpenAPI lowercase (in linr with CPS/NCMP conventions) - Added impl with some basic functionality - Added testware - Pom includes docker image creation - Docker compose updated to deploy stub Issue-ID: CPS-2301 Change-Id: I462ad5c70474b2813fc04005c0d20a1b15b574ec Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-08Merge "Remove Mappers and Events Facade"Lee Anjella Macabuhay11-325/+56
2024-07-05[BUG] Fix handling of special characters in moduleSetTagdanielhanrahan3-7/+6
During CM-handle registration, moduleSetTag is sent as part of the JSON request body when getting modules from DMI. However, it incorrectly parses the moduleSetTag as JSON, instead of encoding to JSON. This results in parsing errors when moduleSetTag includes characters such as ':' Issue-ID: CPS-2302 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ie38008e0effac2423a4d069a91587e47d8747d66
2024-07-05Remove Mappers and Events Facadempriyank11-325/+56
- Removing Mappers and Events Facade and introducing the normal classes that this facade was wrapping - Corresponding changes in the testware Issue-ID: CPS-2298 Change-Id: I380d73ff3a9b3bf79633cd91580d6a4dee00a662 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-05[k6] Measure CM-handle (de)registration in CM-handles/secdanielhanrahan10-231/+130
As per characteristics requirements document: - measure registration in CM-handles/second - measure deregistration in CM-handles/second - summary table includes test case number, description, units of measurement, actual value and limit. Issue-ID: CPS-2269 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I838004da1c230ab722f49c2adacf34e730d7ac79
2024-07-05Merge "refactor cmsubscription code"Daniel Hanrahan52-1677/+1587
2024-07-04Remove forced module sync from NCMP integration testsdanielhanrahan5-54/+30
- remove forced module sync in tests - set module sync timers to 1 second in test application.yml - have tests wait up to 2 seconds for module sync to run Issue-ID: CPS-2304 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I727894dc1b4b9cee1ab82d05a9c31d1e3e067cf3
2024-07-04Refactor integration tests so only one DmiDispatcher is useddanielhanrahan2-34/+32
Issue-ID: CPS-2303 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I4d04fb9b7693a769e9059d3b2b7257a714da0532
2024-07-04refactor cmsubscription codempriyank52-1677/+1587
- Moved cmsubscription to the impl package instead of api. - Below packages are renamed or newly created for code and tests - moved ..api.cmsubsription to ..impl.cmsubscription - renamed ..api.cmsubscription.mappers to ..impl.cmsubscription.ncmp or dmi as per the functionality - renamed ..api.cmsubscription.model to ..impl.cmsubscription.models - removed ..api.cmsubscription.producer/consumer and classes moved to ..impl.cmsubscription.ncmp/dmi - new package ..impl.cmsubscription.cache to hold cache config and cache operations - new package ..impl.cmsubscription.avc to hold the CmAvcEventConsumer for the notifications emitted as a result of the subscriptions - Removed the prefix CmNotificationSubscription for majority of the classes , not removed for Config and model classes - Renamed the schemas and package structure as per the code refactoring Note: *EventsFacade and *MappersFacade to be removed in the next patchset Issue-ID: CPS-2298 Change-Id: I1d788ab745d65965570e28beaefa511cbe4a8547 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-07-04Release notes for Web Client prometheus metricssourabh_sourabh1-0/+1
- Release notes updated as we enabled http client prometheus metrics. Issue-ID: CPS-2121 Change-Id: I6918da7cd4e4523c1ec0ab6060bdc1686c141a9d Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-04Merge "Add Policy Executor Open API Interface definition"Sourabh Sourabh3-4/+250
2024-07-03Merge " CPS NCMP: Resolved high cardinality of prometheus metrics for dmi ↵Toine Siebelink19-491/+474
service url"
2024-07-03 CPS NCMP: Resolved high cardinality of prometheus metrics for dmi service urlsourabh_sourabh19-491/+474
- Used autoconfigured web client builder for http_client_requests_* prometheus metrics. - Refactored dmi service url builder to create url template and its variables. - Web client is modified to use uri(urlTemplate, urlvars) version. - Deleted InvalidDmiResourceUrlException that no longer needed. - Used DmiServiceUrlBuilder to build dmi health check service url. - Created a new pkg url.builder into utils to have all related classes and record. Issue-ID: CPS-2121 Change-Id: Id67e0f0d4e640bb8f9eea0b6c2db1dba3468e1d7 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-07-03Add Policy Executor Open API Interface definitionToineSiebelink3-4/+250
- OPenApi in RTD only (for now) - Bear authentication included in OpenApi - Placeholder RTD page (to be completed upon feature delivery) - For consistency (and color coding in editors) I put all Description and Example strings inside double qoutes "..." Issue-ID: CPS-2291 Change-Id: I7f16cdce2a06cb011997005fa8b86b54c044304a Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-07-03Fix sonar issue in performance test ResourceMeterdanielhanrahan1-3/+4
Replace busy loop with await().until as suggested by sonar Issue-ID: CPS-89 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ic6c870c419a67708082ceb05ef3ccba884ae375e
2024-07-01Setup automated tests with two replicas of cps-and-ncmphalil.cakal6-8/+85
- this change for two test suits: CSIT and K6 - increase cps-and-ncmp replicas to 2 - introduce nginx as load-balancer - set proxies inside nginx for the cps-and-ncmp URI paths - upgrade hazelcast-spring to 5.3.7 Issue-ID: CPS-2038 Change-Id: If1b6c1e1218af16b24cc061507ea9b25d277d143 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2024-07-01Merge "Improve handling of Invalid Operation exception"Sourabh Sourabh6-17/+22
2024-07-01Merge "Fix incorrect use of getAnchors(dataspace, schemasets)"Daniel Hanrahan10-73/+132
2024-07-01Improve handling of Invalid Operation exceptionToineSiebelink6-17/+22
- MOve to API package - Handle in REST Controller to return BAD REQUEST Issue-ID: CPS-2256 Change-Id: I4f96519aaf2e7f781729c8b8671ea02630a2e0a8 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-27repackage 'data' featureToineSiebelink84-312/+231
- moved relevant classes into these (new) packages: api.data.exceptions api.data.models impl.data impl.data.async impl.data.exceptions impl.data.models impl.data.utils utils.events - removed old unused event class - moves some missed inventory related class to the right place Issue-ID: CPS-2256 Change-Id: I75563e063acc0054769d8f2b13146e6c1d1c6054 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-27move lcm/common events classesToineSiebelink37-57/+55
-moved api.impl.events.lcm to impl.inventory.sync.lcm -moved most api.impl.events class to utils.events (remaining classes in api.impl.events belong to cmsubscrption and Priyank wil take care of those) Issue-ID: CPS-2258 Change-Id: I1818194e708aa0d9c713b470e878997c2f26fb13 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-27Merge "Simplify package structure cps-ncmp-rest"Priyank Maheshwari11-18/+20
2024-06-27Simplify package structure cps-ncmp-restToineSiebelink11-18/+20
Issue-ID: CPS-2294 Change-Id: Idc3605c1b877be13a8d344875612da6bef791fc7 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-26Merge "Move TrustLevel Feature"Priyank Maheshwari32-148/+146
2024-06-26Move TrustLevel FeatureToineSiebelink32-148/+146
-Moved TrustLevel impl from Controller to Inventory Facade -Applied new package name convention using impl\inventory\trustlevel for this (sub)feature -Renamed some trustlevel related classes to better describe their role -Disabled failing architecture test (agreed this is tech. debt and created CPS-2293) -Refactored YangDataConverter method names and signatures (moved Spec to correct place) -Cleaned up names and javadoc of class now called DeviceTrustLevelMessageConsumer -Applied conventions to modified test methods Issue-ID: CPS-2255 Change-Id: Iccd20541488e6b61444bb2c7406c90e61a34124d Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-06-26Merge "Disable the java debug port permanently"Sourabh Sourabh1-2/+2
2024-06-26Disable the java debug port permanentlyhalil.cakal1-2/+2
Issue-ID: CPS-1864 Change-Id: I0366b126920cf0bc706545bc5b4e469d3faa2486 Signed-off-by: halil.cakal <halil.cakal@est.tech>
2024-06-26Merge "Clean up the k6 test suite"Daniel Hanrahan10-324/+9
2024-06-25Fix incorrect use of getAnchors(dataspace, schemasets)danielhanrahan10-73/+132
There is an issue in a method deleteDataNodes(dataspace, anchors) where it doesn't send data update events. This is because it fetches anchors using a method getAnchors(dataspace, schemaSetNames), when it needs to fetch anchors by name: getAnchors(dataspace, anchorNames) Changes: - Rename getAnchors method using schemasets to getAnchorsBySchemaSetNames - Add a method getAnchors(dataspace, anchorNames) - Update test of deleteDataNodes method using getAnchors so it checks that data update events are sent Issue-ID: CPS-2254 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I55fe853f0a9278a66a5724bf4cf2723b0e2fbc8b
2024-06-24Repackage Inventory FeatureToineSiebelink117-493/+498
- decided that cm handle queries is part of 'inventory' feature - a lot of files (~100 total) have changes because of some files have been moved. - The reviewers should probably just focus on the MOVED/renamed (~30) files - New packages (top level only): -- org.onap.cps.ncmp.api.inventory -- org.onap.cps.ncmp.impl.inventory -- org.onap.cps.ncmp.impl.models (common models NOT used in API, this was unforeseen) -- org.onap.cps.ncmp.impl.utils - I am NOT updating copyright years as part of this commit since there are no real code changes and it is simply NOT worth the effort TODO: - extend scope to 'TrustLevel' as an 'internal feature' (TBD) Issue-ID: CPS-2255 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I40b4efc8326068ab9ae1f31b77f46b2fe8579431