summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2022-06-28Unable to change state from LOCKED to ADVISEDsourabh_sourabh14-57/+81
-Refactor Cm Handle Registration to deal with null pointer during Module Sync Retry -Add Last Update Time to cm handle registration -Add Fetch Descendants Option as paramater for get misbehaving locked cm handles -Fixes issue when state that goes to advised after retry mechanism won't be retried again Issue-ID: CPS-1097 Change-Id: Iffe1cef3479a796ea5c78b293a0bd24a86d13efd Signed-off-by: DylanB95EST <dylan.byrne@est.tech> Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2022-06-27Merge "Introducing DELETING and DELETED Cmhandle State"Joseph Keenan3-5/+6
2022-06-23Remove operation from NcmpEventmpriyank14-118/+24
- Remove operation field from NcmpEvent schema as it is not required - Code refactoring corresponding to removal of operation field - Fixed test cases around it - UPCOMING: Some sort of state machine to handle the event publishing Issue-ID: CPS-1100 Change-Id: Ib89b86bd1408de2808b01d37a48ee44a2601f83d Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-06-23Introducing DELETING and DELETED Cmhandle Statelukegleeson3-5/+6
Issue-ID: CPS-1101 Signed-off-by: lukegleeson <luke.gleeson@est.tech> Change-Id: I527b47cd98150a753c0d7ba89332a52b414b6834
2022-06-22Data Sync Watchdog Processsourabh_sourabh22-62/+499
- Get all the Cm Handles state in READY and Operational datastores sync state in UNSYNCHRONIZED - Get a random Cm Handle - Get the first resource data from the node - Save the data in Cps Db - Update the Operational datastores sync state to SYNCHRONIZED Issue-ID: CPS-1052 Issue-ID: CPS-1053 Issue-ID: CPS-1054 Change-Id: I9a20391ef30e6d56c4d789a92b8bf42cd3756c62 Signed-off-by: Lathish <lathishbabu.ganesan@est.tech> Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2022-06-22Merge "Eliminate cmhandle-properties tag"Joseph Keenan2-2/+3
2022-06-21Merge "Quick fix for performance degradation bug"Toine Siebelink2-11/+14
2022-06-21Eliminate cmhandle-properties tagmpriyank2-2/+3
- Eliminate the cmhandle-properties tag in case of DELETE operation - Fixed Test cases corresponding to that Issue-ID: CPS-1098 Change-Id: Icd5e08403e0b101baf682f5e558c36ee4ebfd5c3 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-06-21Merge "Publish LCM Events"Joseph Keenan9-9/+65
2022-06-21Merge "Exclude CM-Handles that are not in state 'READY'"Toine Siebelink3-1/+22
2022-06-20Publish LCM Eventsmpriyank9-9/+65
- Publish LCM Create Event when watchdog process moves the cmHandle state from ADVISED to READY - Publish LCM Update Event when public properties are updated, no event when DMI propertis are updated - Publish LCM Delete Event when a cmHandle is been removed - Related test scenarios update - See User Story CPS-1034 for related sub-tasks Issue-ID: CPS-1090 Change-Id: I70d81fde7c80794ea13a10cd1f235a7012b20b3c Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-06-17Merge "Fix release notes"Joseph Keenan1-7/+39
2022-06-17Quick fix for performance degradation bugkissand2-11/+14
Issue-ID: CPS-1085 Change-Id: I15715ef37909d4e2fe2f1f80e621a21c8037fbd0 Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
2022-06-16Merge "Fix sonar code smells"Joseph Keenan11-53/+58
2022-06-15Merge "Retry CM-Handles that are LOCKED, Failed-to-Sync"Joseph Keenan8-20/+105
2022-06-15Retry CM-Handles that are LOCKED, Failed-to-Syncputhuparambil.aditya8-20/+105
Watchdog added to fetched locked cm handles by Lock reason and operation sync state Tests updated Issue-ID: CPS-878 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I0ecc519e93b097ec3d309db7f686fb23a0fc59b2
2022-06-15Fix release notesBruno Sakoto1-7/+39
* Add missing 3.0.1 for Jakarta * Review 3.1.0 for Kohn (not released yet) Issue-ID: CPS-1087 Change-Id: Id0ba8246935edff100fb952e9955f462d2313a7e Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
2022-06-15NcmpEvent creation and Mappingmpriyank5-4/+278
- Mapping class to create header and event payload based on type of operation i.e CREATE, UPDATE and DELETE. - Service class to get CmHandle public properties, create event and delegate request to event publisher. - Modification in NcmpEvent schema json to mark field as String instead of URI - Test scenarios - UPCOMING: Call the service method from relevant code to actually publish the event. Issue-ID: CPS-1037 Change-Id: I6bb7de4b27e602c4d8ee6a5528a866e5f7e8799a Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-06-14Exclude CM-Handles that are not in state 'READY'JosephKeenan3-1/+22
Exclude CM-Handles which are not in state ready from ncmp operations Issue-ID: CPS-877 Change-Id: I59783c860091d99e328cec9ccafb34c09b277753 Signed-off-by: DylanB95EST <dylan.byrne@est.tech> Signed-off-by: lukegleeson <luke.gleeson@est.tech> Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2022-06-13Fix sonar code smellskissand11-53/+58
- https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYFC3OguDZ5Vb3SQMOU1 Issue-ID: CPS-1016 Change-Id: Ic8fdae78337da1ff2c239ae2dfae67e23e88a4bb Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
2022-06-09Merge "PoC Contract Stubs NCMP Rest Endpoints"Toine Siebelink8-0/+519
2022-06-09Merge "Handle errors during cm handle search"Toine Siebelink5-26/+25
2022-06-09Handle errors during cm handle searchkissand5-26/+25
Issue-ID: CPS-1067 Change-Id: Iadc3413a29f9a455e658ec5bcaffc4881b7f7684 Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
2022-06-09Merge "Fix sonar code smells"Toine Siebelink2-9/+6
2022-06-09Remove Model Sync From RegistrationToineSiebelink13-93/+65
Decouple the model sync from registration process Sync now only happens during the watchdog process Cm Handles are persisted in state ADVISED when registartion is successful Issue-ID: CPS-876 Change-Id: Ia3353a0ab1c65a9db553e09138d5690d4f915727 Signed-off-by: DylanB95EST <dylan.byrne@est.tech> Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2022-06-09Override timers advised-modules-sync sleep-time-mssourabh_sourabh1-0/+1
- Override timers advised-modules-sync sleep-time-ms from docker compose for CSIT test Issue-ID: CPS-876 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I2cbc76c03cd5907e2d3bf28b38dbf8209eaaddbd
2022-06-09Fix sonar code smellsemaclee2-9/+6
- Remove useless curly braces around statement (https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYD_5_HLFWip2-KRhcLs) - Define a constant (https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYEj9y6sq272EuFEMiu-) Issue-ID: CPS-475 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: Ib430fac481b29dba8725ed0dac4da3daa56a3984
2022-06-09Merge "Ncmp Producer Setup"Toine Siebelink6-61/+259
2022-06-08Merge "Merge 2 'query' end points in NCMP"Toine Siebelink37-504/+1252
2022-06-08Merge 2 'query' end points in NCMPkissand37-504/+1252
- merge two endpoint for a same backend - use xPath query instead of sql query - modify searches endpoint to return a cmHandle object with all public properties - handle old (deprecated) queries - handle public property queries - create useful examples - use more verbose error messages - simplify openapi yamls - create new query service - change second endpoint name to a better matched name - modify legacy tests with new requirements - create new tests for the new scenarios Issue-ID: CPS-1016 Change-Id: I7476e9dbd510ec93b5b48ce85d477ecb2dadffff Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
2022-06-07Ncmp Producer Setupmpriyank6-61/+259
- Ncmp Kafka Publisher setup - Test scenarios - Refactored existing test class which were using kafka producer and consumer properties to use from common MessageSpec - Upcoming : Implementation Proposal and Actual logic to publish the correct event Issue-ID: CPS-1035 Change-Id: I93ae392e8c4e4c85d88ca7858332e79b59e85535 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-06-07PoC Contract Stubs NCMP Rest Endpointsputhuparambil.aditya8-0/+519
Stubs defined for cmHandleSearch and passthrough operational Issue-ID: CPS-919 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I4fd7bee8fa70ed237f74c721068ffa39817d5c7a
2022-06-03Merge "CPS-1020 : DuplicatedYangResourceException error at parallel cmHandle ↵Toine Siebelink2-3/+9
registration"
2022-06-02CPS-1020 : DuplicatedYangResourceException error at parallel cmHandle ↵sourabh_sourabh2-3/+9
registration - @EnableRetry is added into application. - Added retry count into log to add more information about retry. Issue-ID: CPS-1020 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I00c58ef17a8c066f98711c1cf8e5e5cb5f22974b
2022-06-02Merge "Add module name to cps core output"Toine Siebelink10-54/+192
2022-06-02Merge "NcmpEvent creation for ModuleSync"Toine Siebelink2-1/+88
2022-06-02Add module name to cps core outputemaclee10-54/+192
- add withModuleName method - add getNodeIdentifierWithPrefix method - add unit test in DataMapUtilsSpec - add unit test in DataNodeBuilderSpec - fix all existing unit tests Issue-ID: CPS-870 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech> Change-Id: I51b70fa2dd3381eef9500b4339d4922c017e3000
2022-06-01NcmpEvent creation for ModuleSyncmpriyank2-1/+88
- NcmpEvent schema creation which will be published when module sync is completed - Added cmHandleId in the event payload and made eventCorrelationId as optional - Upcoming : NcmpEvent publisher code and mapping of the events Issue-ID: CPS-1036 Change-Id: I7731e6e6a4a8f718967ce68cc6ae0e411eb8c12b Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-06-01Merge "Module Sync Lock State implementation"Toine Siebelink24-285/+367
2022-06-01Module Sync Lock State implementationDylanB95EST24-285/+367
Implementation of Lock state for module sync watchdog Cm Handle state is locked if any exception is found during sync process Make changes around READY state method in line with the new schema set Add last updated time to composite state Remove running datastore references as this is being done at a later time Issue-ID: CPS-875 Change-Id: I6bd159faefef2fa84dbf536c292ff0a132793381 Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
2022-06-01Merge "DMI-NCMP Asynchronously Publish Response Event to Client Topic"Toine Siebelink1-0/+67
2022-06-01Fixing CompositeState mappingmpriyank4-6/+23
- Mapper null check - NcmpServiceCmHandle mapping for the new composite state - Added global parameter for jackson to include only NON_NULL attributes in the response Issue-ID: CPS-1066 Change-Id: I1924fef45345c77873f9c788baa701311e72bea7 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-06-01DMI-NCMP Asynchronously Publish Response Event to Client Topicsourabh_sourabh1-0/+67
- [NCMP] Added Unit Tests for NcmpAsyncRequestResponseEventMapper.java Issue-ID: CPS-830 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I64dad7f0bb9b64e1864f19db5a5d74922dc6a83b
2022-06-01Merge "Handle RestTemplate Error handling so NCMP cna report correct server ↵Joseph Keenan9-229/+108
status"
2022-05-31Handle RestTemplate Error handling so NCMP cna report correct server statusToineSiebelink9-229/+108
- Moved resposne handling to DmRestClient - Clean up incorrect/redundant tests in CmProxyDataServiceImplSpec Issue-ID: CPS-1056 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I78ba87d6af7255d85758893cfef237d75227875a
2022-05-26Merge "CompositeStateBuilder added for building the compositeState"Joseph Keenan5-7/+241
2022-05-26CompositeStateBuilder added for building the compositeStateputhuparambil.aditya5-7/+241
Added composite state to YangModelCmHandleRetriever Issue-ID: CPS-878 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I8bdea55c0a8e27a906e24fc367dedf81c9b3501c Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
2022-05-25Async request response NCMP -> ClientJosephKeenan28-297/+1164
-Added consumer for DMI events and producer for forwarding to client -Added schemas for events -Updated tests -Added new module for ncmp events -Used mapstruct for event mapping Issue-ID: CPS-830 Change-Id: I096d08af9d69092cf8651e11eaa00ce441fc3605 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Signed-off-by: JosephKeenan <joseph.keenan@est.tech> Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
2022-05-24Enhanced response with Complex State in APImpriyank10-9/+259
- Introduced RestOutputCmHandleState in API specs of retrieveCmHandleDetailsById - Mapper to map CompositeState to RestOutputCmHandleState - Enhanced existing test cases and introduced new one to test the mapping result Issue-ID: CPS-1047 Change-Id: I34fa198287e5d920bc0cea312ee4e368f3be2b90 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2022-05-20Merge "Get cm-handle public properties endpoint"Toine Siebelink10-18/+128