summaryrefslogtreecommitdiffstats
path: root/cps-service
diff options
context:
space:
mode:
authorputhuparambil.aditya <aditya.puthuparambil@bell.ca>2020-12-14 15:46:30 +0000
committerputhuparambil.aditya <aditya.puthuparambil@bell.ca>2020-12-16 11:49:42 +0000
commit008c0adc3712ba0aee6410e8cd7efc61f4cbeeac (patch)
tree255b28e757eecda25bb900d4b041902787a18d24 /cps-service
parentc040bcb4ae61177b1aa691f059d19c96c6cfff7b (diff)
Few Sonar Fixes
Add spock-spring testing Issue-ID: CPS-89 Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca> Change-Id: I1e12fb56916e2123fc1d29bdf1524accbb9eeffd
Diffstat (limited to 'cps-service')
-rw-r--r--cps-service/src/main/java/org/onap/cps/spi/CpsModulePersistenceService.java3
-rw-r--r--cps-service/src/main/java/org/onap/cps/spi/exceptions/CpsException.java22
-rw-r--r--cps-service/src/main/java/org/onap/cps/spi/model/DataNode.java3
3 files changed, 4 insertions, 24 deletions
diff --git a/cps-service/src/main/java/org/onap/cps/spi/CpsModulePersistenceService.java b/cps-service/src/main/java/org/onap/cps/spi/CpsModulePersistenceService.java
index 9749d8b2e..7feae367e 100644
--- a/cps-service/src/main/java/org/onap/cps/spi/CpsModulePersistenceService.java
+++ b/cps-service/src/main/java/org/onap/cps/spi/CpsModulePersistenceService.java
@@ -31,13 +31,14 @@ public interface CpsModulePersistenceService {
* TODO
* clean up method to conform with spi proposal - https://jira.onap.org/browse/CPS-103
* Store the module from a yang model in the database.
+ * @deprecated
*
* @param namespace module namespace
* @param moduleContent module content
* @param revision module revision
* @param dataspaceName the name of the dataspace the module is associated with
*/
- @Deprecated
+ @Deprecated(forRemoval = true)
void storeModule(final String namespace, final String moduleContent, final String revision,
final String dataspaceName);
diff --git a/cps-service/src/main/java/org/onap/cps/spi/exceptions/CpsException.java b/cps-service/src/main/java/org/onap/cps/spi/exceptions/CpsException.java
index 406ade688..96a067806 100644
--- a/cps-service/src/main/java/org/onap/cps/spi/exceptions/CpsException.java
+++ b/cps-service/src/main/java/org/onap/cps/spi/exceptions/CpsException.java
@@ -28,26 +28,8 @@ public class CpsException extends RuntimeException {
private static final long serialVersionUID = 1592619410918497467L;
- @Getter String details;
-
- /**
- * Constructor.
- *
- * @param cause the cause of the exception
- */
- public CpsException(final Throwable cause) {
- super(cause.getMessage(), cause);
- }
-
- /**
- * Constructor.
- *
- * @param message the error message
- * @param cause the cause of the exception
- */
- public CpsException(final String message, final Throwable cause) {
- super(message, cause);
- }
+ @Getter
+ final String details;
/**
* Constructor.
diff --git a/cps-service/src/main/java/org/onap/cps/spi/model/DataNode.java b/cps-service/src/main/java/org/onap/cps/spi/model/DataNode.java
index 5ed45ad6e..8bd404700 100644
--- a/cps-service/src/main/java/org/onap/cps/spi/model/DataNode.java
+++ b/cps-service/src/main/java/org/onap/cps/spi/model/DataNode.java
@@ -24,9 +24,6 @@ import java.util.Collection;
import java.util.Map;
import lombok.Builder;
import lombok.Data;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
@Data
@Builder