diff options
author | 2022-01-27 09:29:21 +0000 | |
---|---|---|
committer | 2022-01-27 09:29:21 +0000 | |
commit | 44644dec37be77c6d6940e1361cea831486927bc (patch) | |
tree | cda2c3573af29dee61b5ee4e0f7f702f5eebe471 /cps-service/src/test | |
parent | 05e7b8a207b1c641468e77d754fe1a5ae9e1a51e (diff) | |
parent | 01b6012396d1f42b411773faaee5d7eb69a07aa5 (diff) |
Merge "Improve logging in NCMP"
Diffstat (limited to 'cps-service/src/test')
-rw-r--r-- | cps-service/src/test/groovy/org/onap/cps/aop/CpsLoggingAspectServiceSpec.groovy | 61 |
1 files changed, 61 insertions, 0 deletions
diff --git a/cps-service/src/test/groovy/org/onap/cps/aop/CpsLoggingAspectServiceSpec.groovy b/cps-service/src/test/groovy/org/onap/cps/aop/CpsLoggingAspectServiceSpec.groovy new file mode 100644 index 000000000..b15af490e --- /dev/null +++ b/cps-service/src/test/groovy/org/onap/cps/aop/CpsLoggingAspectServiceSpec.groovy @@ -0,0 +1,61 @@ +/* + * ============LICENSE_START======================================================= + * Copyright (C) 2022 Nordix Foundation + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.cps.aop + +import org.aspectj.lang.ProceedingJoinPoint +import org.aspectj.lang.reflect.MethodSignature +import org.onap.cps.spi.exceptions.DataValidationException +import spock.lang.Specification + +class CpsLoggingAspectServiceSpec extends Specification { + + def mockProceedingJoinPoint = Mock(ProceedingJoinPoint) + def mockMethodSignature = Mock(MethodSignature); + def objectUnderTest = new CpsLoggingAspectService() + + def setup() { + mockMethodSignature.getDeclaringType() >> this.getClass() + mockMethodSignature.getDeclaringType().getSimpleName() >> 'CpsLoggingAspectServiceSpec' + mockMethodSignature.getName() >> 'logMethodExecutionTime' + mockProceedingJoinPoint.getSignature() >> mockMethodSignature + } + + def 'Log method execution time.'() { + given: 'mock valid arguments' + mockProceedingJoinPoint.getArgs() >> 'dataspace-name' + when: 'aop intercepts cps method and start calculation of time' + objectUnderTest.logMethodExecutionTime(mockProceedingJoinPoint) + then: 'process successfully and log details of executed method' + 1 * mockProceedingJoinPoint.proceed() + } + + def 'Creating a data validation exception for invalid args.'() { + given: 'a data validation exception is created' + mockProceedingJoinPoint.getArgs() >> { + throw new DataValidationException('invalid args', + 'invalid method arg(s) is passed', new Throwable()) + } + when: 'aop intercepts cps method and start calculation of time' + objectUnderTest.logMethodExecutionTime(mockProceedingJoinPoint) + then: 'data validation exception is thrown' + thrown(DataValidationException.class) + } +} |