summaryrefslogtreecommitdiffstats
path: root/cps-service/src/test/groovy
diff options
context:
space:
mode:
authorsourabh_sourabh <sourabh.sourabh@est.tech>2022-01-21 01:46:12 +0530
committersourabh_sourabh <sourabh.sourabh@est.tech>2022-01-25 23:08:56 +0530
commit01b6012396d1f42b411773faaee5d7eb69a07aa5 (patch)
tree5c7840d415d3f1e90aa1053a45febd04633343b1 /cps-service/src/test/groovy
parentdb1e983f40be1db7bca5acacf5a3369d74a29c95 (diff)
Improve logging in NCMP
Issue-ID: CPS-855 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech> Change-Id: I5d8a6a711d1c6b13d5d8eeba52a1dcd689dbdae2
Diffstat (limited to 'cps-service/src/test/groovy')
-rw-r--r--cps-service/src/test/groovy/org/onap/cps/aop/CpsLoggingAspectServiceSpec.groovy61
1 files changed, 61 insertions, 0 deletions
diff --git a/cps-service/src/test/groovy/org/onap/cps/aop/CpsLoggingAspectServiceSpec.groovy b/cps-service/src/test/groovy/org/onap/cps/aop/CpsLoggingAspectServiceSpec.groovy
new file mode 100644
index 0000000000..b15af490e7
--- /dev/null
+++ b/cps-service/src/test/groovy/org/onap/cps/aop/CpsLoggingAspectServiceSpec.groovy
@@ -0,0 +1,61 @@
+/*
+ * ============LICENSE_START=======================================================
+ * Copyright (C) 2022 Nordix Foundation
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.cps.aop
+
+import org.aspectj.lang.ProceedingJoinPoint
+import org.aspectj.lang.reflect.MethodSignature
+import org.onap.cps.spi.exceptions.DataValidationException
+import spock.lang.Specification
+
+class CpsLoggingAspectServiceSpec extends Specification {
+
+ def mockProceedingJoinPoint = Mock(ProceedingJoinPoint)
+ def mockMethodSignature = Mock(MethodSignature);
+ def objectUnderTest = new CpsLoggingAspectService()
+
+ def setup() {
+ mockMethodSignature.getDeclaringType() >> this.getClass()
+ mockMethodSignature.getDeclaringType().getSimpleName() >> 'CpsLoggingAspectServiceSpec'
+ mockMethodSignature.getName() >> 'logMethodExecutionTime'
+ mockProceedingJoinPoint.getSignature() >> mockMethodSignature
+ }
+
+ def 'Log method execution time.'() {
+ given: 'mock valid arguments'
+ mockProceedingJoinPoint.getArgs() >> 'dataspace-name'
+ when: 'aop intercepts cps method and start calculation of time'
+ objectUnderTest.logMethodExecutionTime(mockProceedingJoinPoint)
+ then: 'process successfully and log details of executed method'
+ 1 * mockProceedingJoinPoint.proceed()
+ }
+
+ def 'Creating a data validation exception for invalid args.'() {
+ given: 'a data validation exception is created'
+ mockProceedingJoinPoint.getArgs() >> {
+ throw new DataValidationException('invalid args',
+ 'invalid method arg(s) is passed', new Throwable())
+ }
+ when: 'aop intercepts cps method and start calculation of time'
+ objectUnderTest.logMethodExecutionTime(mockProceedingJoinPoint)
+ then: 'data validation exception is thrown'
+ thrown(DataValidationException.class)
+ }
+}