Reduce dataspace/anchor lookups in CpsDataPersistenceService

- Remove unneeded calls to DataspaceRepository::getByName
- Remove unneeded calls to AnchorRepository::getByDataspaceAndName
- Refactor FragmentRepository

Issue-ID: CPS-1536
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2121f6247070ee4a7c000e06ec66a6278b758540

2 files changed, 84 insertions, 144 deletions

diff --git a/cps-ri/src/main/java/org/onap/cps/spi/impl/CpsDataPersistenceServiceImpl.java b/cps-ri/src/main/java/org/onap/cps/spi/impl/CpsDataPersistenceServiceImpl.java
index 916baa8c2..e3be0137d 100644
--- a/cps-ri/src/main/java/org/onap/cps/spi/impl/CpsDataPersistenceServiceImpl.java
+++ b/cps-ri/src/main/java/org/onap/cps/spi/impl/CpsDataPersistenceServiceImpl.java
@@ -80,88 +80,83 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
     private final JsonObjectMapper jsonObjectMapper;
     private final SessionManager sessionManager;
 
-    private static final String REG_EX_FOR_OPTIONAL_LIST_INDEX = "(\\[@[\\s\\S]+?]){0,1})";
+    private static final String REG_EX_FOR_OPTIONAL_LIST_INDEX = "(\\[@[\\s\\S]+?])?)";
 
     @Override
     public void addChildDataNode(final String dataspaceName, final String anchorName, final String parentNodeXpath,
                                  final DataNode newChildDataNode) {
-        addNewChildDataNode(dataspaceName, anchorName, parentNodeXpath, newChildDataNode);
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
+        addNewChildDataNode(anchorEntity, parentNodeXpath, newChildDataNode);
     }
 
     @Override
     public void addChildDataNodes(final String dataspaceName, final String anchorName,
                                   final String parentNodeXpath, final Collection<DataNode> dataNodes) {
-        addChildrenDataNodes(dataspaceName, anchorName, parentNodeXpath, dataNodes);
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
+        addChildrenDataNodes(anchorEntity, parentNodeXpath, dataNodes);
     }
 
     @Override
     public void addListElements(final String dataspaceName, final String anchorName, final String parentNodeXpath,
                                 final Collection<DataNode> newListElements) {
-        addChildrenDataNodes(dataspaceName, anchorName, parentNodeXpath, newListElements);
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
+        addChildrenDataNodes(anchorEntity, parentNodeXpath, newListElements);
     }
 
     @Override
     public void addMultipleLists(final String dataspaceName, final String anchorName, final String parentNodeXpath,
                                  final Collection<Collection<DataNode>> newLists) {
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
         final Collection<String> failedXpaths = new HashSet<>();
-        newLists.forEach(newList -> {
+        for (final Collection<DataNode> newList : newLists) {
             try {
-                addChildrenDataNodes(dataspaceName, anchorName, parentNodeXpath, newList);
+                addChildrenDataNodes(anchorEntity, parentNodeXpath, newList);
             } catch (final AlreadyDefinedExceptionBatch e) {
                 failedXpaths.addAll(e.getAlreadyDefinedXpaths());
             }
-        });
-
+        }
         if (!failedXpaths.isEmpty()) {
             throw new AlreadyDefinedExceptionBatch(failedXpaths);
         }
-
     }
 
-    private void addNewChildDataNode(final String dataspaceName, final String anchorName,
-                                     final String parentNodeXpath, final DataNode newChild) {
-        final FragmentEntity parentFragmentEntity =
-            getFragmentEntity(dataspaceName, anchorName, parentNodeXpath);
-        final FragmentEntity newChildAsFragmentEntity =
-                convertToFragmentWithAllDescendants(parentFragmentEntity.getDataspace(),
-                        parentFragmentEntity.getAnchor(), newChild);
+    private void addNewChildDataNode(final AnchorEntity anchorEntity, final String parentNodeXpath,
+                                     final DataNode newChild) {
+        final FragmentEntity parentFragmentEntity = getFragmentEntity(anchorEntity, parentNodeXpath);
+        final FragmentEntity newChildAsFragmentEntity = convertToFragmentWithAllDescendants(anchorEntity, newChild);
         newChildAsFragmentEntity.setParentId(parentFragmentEntity.getId());
         try {
             fragmentRepository.save(newChildAsFragmentEntity);
         } catch (final DataIntegrityViolationException e) {
-            throw AlreadyDefinedException.forDataNode(newChild.getXpath(), anchorName, e);
+            throw AlreadyDefinedException.forDataNode(newChild.getXpath(), anchorEntity.getName(), e);
         }
-
     }
 
-    private void addChildrenDataNodes(final String dataspaceName, final String anchorName, final String parentNodeXpath,
+    private void addChildrenDataNodes(final AnchorEntity anchorEntity, final String parentNodeXpath,
                                       final Collection<DataNode> newChildren) {
-        final FragmentEntity parentFragmentEntity =
-            getFragmentEntity(dataspaceName, anchorName, parentNodeXpath);
+        final FragmentEntity parentFragmentEntity = getFragmentEntity(anchorEntity, parentNodeXpath);
         final List<FragmentEntity> fragmentEntities = new ArrayList<>(newChildren.size());
         try {
-            newChildren.forEach(newChildAsDataNode -> {
+            for (final DataNode newChildAsDataNode : newChildren) {
                 final FragmentEntity newChildAsFragmentEntity =
-                        convertToFragmentWithAllDescendants(parentFragmentEntity.getDataspace(),
-                                parentFragmentEntity.getAnchor(), newChildAsDataNode);
+                    convertToFragmentWithAllDescendants(anchorEntity, newChildAsDataNode);
                 newChildAsFragmentEntity.setParentId(parentFragmentEntity.getId());
                 fragmentEntities.add(newChildAsFragmentEntity);
-            });
+            }
             fragmentRepository.saveAll(fragmentEntities);
         } catch (final DataIntegrityViolationException e) {
             log.warn("Exception occurred : {} , While saving : {} children, retrying using individual save operations",
                     e, fragmentEntities.size());
-            retrySavingEachChildIndividually(dataspaceName, anchorName, parentNodeXpath, newChildren);
+            retrySavingEachChildIndividually(anchorEntity, parentNodeXpath, newChildren);
         }
     }
 
-    private void retrySavingEachChildIndividually(final String dataspaceName, final String anchorName,
-                                                  final String parentNodeXpath,
+    private void retrySavingEachChildIndividually(final AnchorEntity anchorEntity, final String parentNodeXpath,
                                                   final Collection<DataNode> newChildren) {
         final Collection<String> failedXpaths = new HashSet<>();
         for (final DataNode newChild : newChildren) {
             try {
-                addNewChildDataNode(dataspaceName, anchorName, parentNodeXpath, newChild);
+                addNewChildDataNode(anchorEntity, parentNodeXpath, newChild);
             } catch (final AlreadyDefinedException e) {
                 failedXpaths.add(newChild.getXpath());
             }
@@ -179,32 +174,26 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
     @Override
     public void storeDataNodes(final String dataspaceName, final String anchorName,
                                final Collection<DataNode> dataNodes) {
-        final DataspaceEntity dataspaceEntity = dataspaceRepository.getByName(dataspaceName);
-        final AnchorEntity anchorEntity = anchorRepository.getByDataspaceAndName(dataspaceEntity, anchorName);
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
         final List<FragmentEntity> fragmentEntities = new ArrayList<>(dataNodes.size());
         try {
             for (final DataNode dataNode: dataNodes) {
-                final FragmentEntity fragmentEntity = convertToFragmentWithAllDescendants(dataspaceEntity, anchorEntity,
-                        dataNode);
+                final FragmentEntity fragmentEntity = convertToFragmentWithAllDescendants(anchorEntity, dataNode);
                 fragmentEntities.add(fragmentEntity);
             }
             fragmentRepository.saveAll(fragmentEntities);
         } catch (final DataIntegrityViolationException exception) {
             log.warn("Exception occurred : {} , While saving : {} data nodes, Retrying saving data nodes individually",
                     exception, dataNodes.size());
-            storeDataNodesIndividually(dataspaceName, anchorName, dataNodes);
+            storeDataNodesIndividually(anchorEntity, dataNodes);
         }
     }
 
-    private void storeDataNodesIndividually(final String dataspaceName, final String anchorName,
-                                           final Collection<DataNode> dataNodes) {
-        final DataspaceEntity dataspaceEntity = dataspaceRepository.getByName(dataspaceName);
-        final AnchorEntity anchorEntity = anchorRepository.getByDataspaceAndName(dataspaceEntity, anchorName);
+    private void storeDataNodesIndividually(final AnchorEntity anchorEntity, final Collection<DataNode> dataNodes) {
         final Collection<String> failedXpaths = new HashSet<>();
         for (final DataNode dataNode: dataNodes) {
             try {
-                final FragmentEntity fragmentEntity = convertToFragmentWithAllDescendants(dataspaceEntity, anchorEntity,
-                        dataNode);
+                final FragmentEntity fragmentEntity = convertToFragmentWithAllDescendants(anchorEntity, dataNode);
                 fragmentRepository.save(fragmentEntity);
             } catch (final DataIntegrityViolationException e) {
                 failedXpaths.add(dataNode.getXpath());
@@ -219,30 +208,25 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
      * Convert DataNode object into Fragment and places the result in the fragments placeholder. Performs same action
      * for all DataNode children recursively.
      *
-     * @param dataspaceEntity       dataspace
      * @param anchorEntity          anchorEntity
      * @param dataNodeToBeConverted dataNode
      * @return a Fragment built from current DataNode
      */
-    private FragmentEntity convertToFragmentWithAllDescendants(final DataspaceEntity dataspaceEntity,
-                                                               final AnchorEntity anchorEntity,
+    private FragmentEntity convertToFragmentWithAllDescendants(final AnchorEntity anchorEntity,
                                                                final DataNode dataNodeToBeConverted) {
-        final FragmentEntity parentFragment = toFragmentEntity(dataspaceEntity, anchorEntity, dataNodeToBeConverted);
+        final FragmentEntity parentFragment = toFragmentEntity(anchorEntity, dataNodeToBeConverted);
         final Builder<FragmentEntity> childFragmentsImmutableSetBuilder = ImmutableSet.builder();
         for (final DataNode childDataNode : dataNodeToBeConverted.getChildDataNodes()) {
-            final FragmentEntity childFragment =
-                    convertToFragmentWithAllDescendants(parentFragment.getDataspace(), parentFragment.getAnchor(),
-                            childDataNode);
+            final FragmentEntity childFragment = convertToFragmentWithAllDescendants(anchorEntity, childDataNode);
             childFragmentsImmutableSetBuilder.add(childFragment);
         }
         parentFragment.setChildFragments(childFragmentsImmutableSetBuilder.build());
         return parentFragment;
     }
 
-    private FragmentEntity toFragmentEntity(final DataspaceEntity dataspaceEntity,
-                                            final AnchorEntity anchorEntity, final DataNode dataNode) {
+    private FragmentEntity toFragmentEntity(final AnchorEntity anchorEntity, final DataNode dataNode) {
         return FragmentEntity.builder()
-                .dataspace(dataspaceEntity)
+                .dataspace(anchorEntity.getDataspace())
                 .anchor(anchorEntity)
                 .xpath(dataNode.getXpath())
                 .attributes(jsonObjectMapper.asJsonString(dataNode.getLeaves()))
@@ -266,15 +250,13 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
     public Collection<DataNode> getDataNodesForMultipleXpaths(final String dataspaceName, final String anchorName,
                                                               final Collection<String> xpaths,
                                                               final FetchDescendantsOption fetchDescendantsOption) {
-        final Collection<FragmentEntity> fragmentEntities = getFragmentEntities(dataspaceName, anchorName, xpaths);
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
+        final Collection<FragmentEntity> fragmentEntities = getFragmentEntities(anchorEntity, xpaths);
         return toDataNodes(fragmentEntities, fetchDescendantsOption);
     }
 
-    private Collection<FragmentEntity> getFragmentEntities(final String dataspaceName, final String anchorName,
+    private Collection<FragmentEntity> getFragmentEntities(final AnchorEntity anchorEntity,
                                                            final Collection<String> xpaths) {
-        final DataspaceEntity dataspaceEntity = dataspaceRepository.getByName(dataspaceName);
-        final AnchorEntity anchorEntity = anchorRepository.getByDataspaceAndName(dataspaceEntity, anchorName);
-
         final Collection<String> nonRootXpaths = new HashSet<>(xpaths);
         final boolean haveRootXpath = nonRootXpaths.removeIf(CpsDataPersistenceServiceImpl::isRootXpath);
 
@@ -290,50 +272,39 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
             new HashSet<>(fragmentRepository.findByAnchorAndMultipleCpsPaths(anchorEntity.getId(), normalizedXpaths));
 
         if (haveRootXpath) {
-            final List<FragmentExtract> fragmentExtracts = fragmentRepository.getTopLevelFragments(dataspaceEntity,
-                anchorEntity);
+            final List<FragmentExtract> fragmentExtracts = fragmentRepository.findAllExtractsByAnchor(anchorEntity);
             fragmentEntities.addAll(FragmentEntityArranger.toFragmentEntityTrees(anchorEntity, fragmentExtracts));
         }
 
         return fragmentEntities;
     }
 
-    private FragmentEntity getFragmentEntity(final String dataspaceName, final String anchorName, final String xpath) {
-        final DataspaceEntity dataspaceEntity = dataspaceRepository.getByName(dataspaceName);
-        final AnchorEntity anchorEntity = anchorRepository.getByDataspaceAndName(dataspaceEntity, anchorName);
+    private FragmentEntity getFragmentEntity(final AnchorEntity anchorEntity, final String xpath) {
         final FragmentEntity fragmentEntity;
         if (isRootXpath(xpath)) {
-            final List<FragmentExtract> fragmentExtracts = fragmentRepository.getTopLevelFragments(dataspaceEntity,
-                    anchorEntity);
+            final List<FragmentExtract> fragmentExtracts = fragmentRepository.findAllExtractsByAnchor(anchorEntity);
             fragmentEntity = FragmentEntityArranger.toFragmentEntityTrees(anchorEntity, fragmentExtracts)
                 .stream().findFirst().orElse(null);
         } else {
-            final String normalizedXpath = getNormalizedXpath(xpath);
-            fragmentEntity =
-                fragmentRepository.getByDataspaceAndAnchorAndXpath(dataspaceEntity, anchorEntity, normalizedXpath);
+            fragmentEntity = fragmentRepository.getByAnchorAndXpath(anchorEntity, getNormalizedXpath(xpath));
         }
         if (fragmentEntity == null) {
-            throw new DataNodeNotFoundException(dataspaceEntity.getName(), anchorEntity.getName(), xpath);
+            throw new DataNodeNotFoundException(anchorEntity.getDataspace().getName(), anchorEntity.getName(), xpath);
         }
         return fragmentEntity;
-
     }
 
     private Collection<FragmentEntity> buildFragmentEntitiesFromFragmentExtracts(final AnchorEntity anchorEntity,
                                                                                  final String normalizedXpath) {
         final List<FragmentExtract> fragmentExtracts =
-                fragmentRepository.findByAnchorIdAndParentXpath(anchorEntity.getId(), normalizedXpath);
-        log.debug("Fetched {} fragment entities by anchor {} and cps path {}.",
-                fragmentExtracts.size(), anchorEntity.getName(), normalizedXpath);
+            fragmentRepository.findByAnchorAndParentXpath(anchorEntity, normalizedXpath);
         return FragmentEntityArranger.toFragmentEntityTrees(anchorEntity, fragmentExtracts);
-
     }
 
     @Override
     public List<DataNode> queryDataNodes(final String dataspaceName, final String anchorName, final String cpsPath,
                                          final FetchDescendantsOption fetchDescendantsOption) {
-        final DataspaceEntity dataspaceEntity = dataspaceRepository.getByName(dataspaceName);
-        final AnchorEntity anchorEntity = anchorRepository.getByDataspaceAndName(dataspaceEntity, anchorName);
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
         final CpsPathQuery cpsPathQuery;
         try {
             cpsPathQuery = CpsPathUtil.getCpsPathQuery(cpsPath);
@@ -441,8 +412,8 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
                                                     final CpsPathQuery cpsPathQuery) {
         final Set<String> ancestorXpath = new HashSet<>();
         final Pattern pattern =
-                Pattern.compile("([\\s\\S]*\\/" + Pattern.quote(cpsPathQuery.getAncestorSchemaNodeIdentifier())
-                        + REG_EX_FOR_OPTIONAL_LIST_INDEX + "\\/[\\s\\S]*");
+                Pattern.compile("([\\s\\S]*/" + Pattern.quote(cpsPathQuery.getAncestorSchemaNodeIdentifier())
+                        + REG_EX_FOR_OPTIONAL_LIST_INDEX + "/[\\s\\S]*");
         for (final FragmentEntity fragmentEntity : fragmentEntities) {
             final Matcher matcher = pattern.matcher(fragmentEntity.getXpath());
             if (matcher.matches()) {
@@ -487,7 +458,8 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
     @Override
     public void updateDataLeaves(final String dataspaceName, final String anchorName, final String xpath,
                                  final Map<String, Serializable> updateLeaves) {
-        final FragmentEntity fragmentEntity = getFragmentEntity(dataspaceName, anchorName, xpath);
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
+        final FragmentEntity fragmentEntity = getFragmentEntity(anchorEntity, xpath);
         final String currentLeavesAsString = fragmentEntity.getAttributes();
         final String mergedLeaves = mergeLeaves(updateLeaves, currentLeavesAsString);
         fragmentEntity.setAttributes(mergedLeaves);
@@ -497,7 +469,8 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
     @Override
     public void updateDataNodeAndDescendants(final String dataspaceName, final String anchorName,
                                              final DataNode dataNode) {
-        final FragmentEntity fragmentEntity = getFragmentEntity(dataspaceName, anchorName, dataNode.getXpath());
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
+        final FragmentEntity fragmentEntity = getFragmentEntity(anchorEntity, dataNode.getXpath());
         updateFragmentEntityAndDescendantsWithDataNode(fragmentEntity, dataNode);
         try {
             fragmentRepository.save(fragmentEntity);
@@ -511,12 +484,13 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
     @Override
     public void updateDataNodesAndDescendants(final String dataspaceName, final String anchorName,
                                               final List<DataNode> updatedDataNodes) {
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
+
         final Map<String, DataNode> xpathToUpdatedDataNode = updatedDataNodes.stream()
             .collect(Collectors.toMap(DataNode::getXpath, dataNode -> dataNode));
 
         final Collection<String> xpaths = xpathToUpdatedDataNode.keySet();
-        final Collection<FragmentEntity> existingFragmentEntities =
-            getFragmentEntities(dataspaceName, anchorName, xpaths);
+        final Collection<FragmentEntity> existingFragmentEntities = getFragmentEntities(anchorEntity, xpaths);
 
         for (final FragmentEntity existingFragmentEntity : existingFragmentEntities) {
             final DataNode updatedDataNode = xpathToUpdatedDataNode.get(existingFragmentEntity.getXpath());
@@ -526,45 +500,41 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
         try {
             fragmentRepository.saveAll(existingFragmentEntities);
         } catch (final StaleStateException staleStateException) {
-            retryUpdateDataNodesIndividually(dataspaceName, anchorName, existingFragmentEntities);
+            retryUpdateDataNodesIndividually(anchorEntity, existingFragmentEntities);
         }
     }
 
-    private void retryUpdateDataNodesIndividually(final String dataspaceName, final String anchorName,
+    private void retryUpdateDataNodesIndividually(final AnchorEntity anchorEntity,
                                                   final Collection<FragmentEntity> fragmentEntities) {
         final Collection<String> failedXpaths = new HashSet<>();
-
-        fragmentEntities.forEach(dataNodeFragment -> {
+        for (final FragmentEntity dataNodeFragment : fragmentEntities) {
             try {
                 fragmentRepository.save(dataNodeFragment);
             } catch (final StaleStateException e) {
                 failedXpaths.add(dataNodeFragment.getXpath());
             }
-        });
-
+        }
         if (!failedXpaths.isEmpty()) {
             final String failedXpathsConcatenated = String.join(",", failedXpaths);
             throw new ConcurrencyException("Concurrent Transactions", String.format(
                     "DataNodes : %s in Dataspace :'%s' with Anchor : '%s'  are updated by another transaction.",
-                    failedXpathsConcatenated, dataspaceName, anchorName));
+                    failedXpathsConcatenated, anchorEntity.getDataspace().getName(), anchorEntity.getName()));
         }
     }
 
     private void updateFragmentEntityAndDescendantsWithDataNode(final FragmentEntity existingFragmentEntity,
                                                                 final DataNode newDataNode) {
-
         existingFragmentEntity.setAttributes(jsonObjectMapper.asJsonString(newDataNode.getLeaves()));
 
         final Map<String, FragmentEntity> existingChildrenByXpath = existingFragmentEntity.getChildFragments().stream()
                 .collect(Collectors.toMap(FragmentEntity::getXpath, childFragmentEntity -> childFragmentEntity));
 
         final Collection<FragmentEntity> updatedChildFragments = new HashSet<>();
-
         for (final DataNode newDataNodeChild : newDataNode.getChildDataNodes()) {
             final FragmentEntity childFragment;
             if (isNewDataNode(newDataNodeChild, existingChildrenByXpath)) {
-                childFragment = convertToFragmentWithAllDescendants(
-                        existingFragmentEntity.getDataspace(), existingFragmentEntity.getAnchor(), newDataNodeChild);
+                childFragment = convertToFragmentWithAllDescendants(existingFragmentEntity.getAnchor(),
+                    newDataNodeChild);
             } else {
                 childFragment = existingChildrenByXpath.get(newDataNodeChild.getXpath());
                 updateFragmentEntityAndDescendantsWithDataNode(childFragment, newDataNodeChild);
@@ -580,7 +550,8 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
     @Transactional
     public void replaceListContent(final String dataspaceName, final String anchorName, final String parentNodeXpath,
                                    final Collection<DataNode> newListElements) {
-        final FragmentEntity parentEntity = getFragmentEntity(dataspaceName, anchorName, parentNodeXpath);
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
+        final FragmentEntity parentEntity = getFragmentEntity(anchorEntity, parentNodeXpath);
         final String listElementXpathPrefix = getListElementXpathPrefix(newListElements);
         final Map<String, FragmentEntity> existingListElementFragmentEntitiesByXPath =
                 extractListElementFragmentEntitiesByXPath(parentEntity.getChildFragments(), listElementXpathPrefix);
@@ -591,7 +562,6 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
                     existingListElementFragmentEntitiesByXPath.get(newListElement.getXpath());
             final FragmentEntity entityToBeAdded = getFragmentForReplacement(parentEntity, newListElement,
                     existingListElementEntity);
-
             updatedChildFragmentEntities.add(entityToBeAdded);
         }
         parentEntity.getChildFragments().addAll(updatedChildFragmentEntities);
@@ -630,15 +600,14 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
             return;
         }
 
-        final DataspaceEntity dataspaceEntity = dataspaceRepository.getByName(dataspaceName);
-        final AnchorEntity anchorEntity = anchorRepository.getByDataspaceAndName(dataspaceEntity, anchorName);
+        final AnchorEntity anchorEntity = getAnchorEntity(dataspaceName, anchorName);
 
         final Collection<String> deleteChecklist = new HashSet<>(xpathsToDelete.size());
         for (final String xpath : xpathsToDelete) {
             try {
                 deleteChecklist.add(CpsPathUtil.getNormalizedXpath(xpath));
             } catch (final PathParsingException e) {
-                log.debug("Error parsing xpath \"{}\": {}", xpath, e.getMessage());
+                log.warn("Error parsing xpath \"{}\": {}", xpath, e.getMessage());
             }
         }
 
@@ -702,8 +671,7 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
                                                      final DataNode newListElement,
                                                      final FragmentEntity existingListElementEntity) {
         if (existingListElementEntity == null) {
-            return convertToFragmentWithAllDescendants(
-                    parentEntity.getDataspace(), parentEntity.getAnchor(), newListElement);
+            return convertToFragmentWithAllDescendants(parentEntity.getAnchor(), newListElement);
         }
         if (newListElement.getChildDataNodes().isEmpty()) {
             copyAttributesFromNewListElement(existingListElementEntity, newListElement);
@@ -747,4 +715,9 @@ public class CpsDataPersistenceServiceImpl implements CpsDataPersistenceService
         }
         return jsonObjectMapper.asJsonString(currentLeavesAsMap);
     }
+
+    private AnchorEntity getAnchorEntity(final String dataspaceName, final String anchorName) {
+        final DataspaceEntity dataspaceEntity = dataspaceRepository.getByName(dataspaceName);
+        return anchorRepository.getByDataspaceAndName(dataspaceEntity, anchorName);
+    }
 }
diff --git a/cps-ri/src/main/java/org/onap/cps/spi/repository/FragmentRepository.java b/cps-ri/src/main/java/org/onap/cps/spi/repository/FragmentRepository.java
index 51ebcb412..996e55e77 100755
--- a/cps-ri/src/main/java/org/onap/cps/spi/repository/FragmentRepository.java
+++ b/cps-ri/src/main/java/org/onap/cps/spi/repository/FragmentRepository.java
@@ -25,10 +25,7 @@ package org.onap.cps.spi.repository;
 import java.util.Collection;

 import java.util.List;

 import java.util.Optional;

-import javax.validation.constraints.NotNull;

-import org.checkerframework.checker.nullness.qual.NonNull;

 import org.onap.cps.spi.entities.AnchorEntity;

-import org.onap.cps.spi.entities.DataspaceEntity;

 import org.onap.cps.spi.entities.FragmentEntity;

 import org.onap.cps.spi.entities.FragmentExtract;

 import org.onap.cps.spi.exceptions.DataNodeNotFoundException;

@@ -42,56 +39,26 @@ import org.springframework.stereotype.Repository;
 public interface FragmentRepository extends JpaRepository<FragmentEntity, Long>, FragmentRepositoryCpsPathQuery,

         FragmentRepositoryMultiPathQuery, FragmentNativeRepository {

 

-    Optional<FragmentEntity> findByDataspaceAndAnchorAndXpath(@NonNull DataspaceEntity dataspaceEntity,

-                                                              @NonNull AnchorEntity anchorEntity,

-                                                              @NonNull String xpath);

+    Optional<FragmentEntity> findByAnchorAndXpath(AnchorEntity anchorEntity, String xpath);

 

-    default FragmentEntity getByDataspaceAndAnchorAndXpath(@NonNull DataspaceEntity dataspaceEntity,

-                                                           @NonNull AnchorEntity anchorEntity,

-                                                           @NonNull String xpath) {

-        return findByDataspaceAndAnchorAndXpath(dataspaceEntity, anchorEntity, xpath)

-            .orElseThrow(() -> new DataNodeNotFoundException(dataspaceEntity.getName(), anchorEntity.getName(), xpath));

+    default FragmentEntity getByAnchorAndXpath(final AnchorEntity anchorEntity, final String xpath) {

+        return findByAnchorAndXpath(anchorEntity, xpath).orElseThrow(() ->

+            new DataNodeNotFoundException(anchorEntity.getDataspace().getName(), anchorEntity.getName(), xpath));

     }

 

-    @Query(

-        value = "SELECT * FROM FRAGMENT WHERE anchor_id = :anchor AND dataspace_id = :dataspace AND parent_id is NULL",

-        nativeQuery = true)

-    List<FragmentEntity> findRootsByDataspaceAndAnchor(@Param("dataspace") int dataspaceId,

-                                                       @Param("anchor") int anchorId);

-

-    @Query(value = "SELECT id, anchor_id AS anchorId, xpath, parent_id AS parentId,"

-            + " CAST(attributes AS TEXT) AS attributes"

-            + " FROM FRAGMENT WHERE anchor_id = :anchorId",

-            nativeQuery = true)

-    List<FragmentExtract> findRootsByAnchorId(@Param("anchorId") int anchorId);

+    boolean existsByAnchorId(int anchorId);

 

-    /**

-     * find top level fragment by anchor.

-     *

-     * @param dataspaceEntity dataspace entity

-     * @param anchorEntity anchor entity

-     * @return FragmentEntity fragment entity

-     */

-    default List<FragmentExtract> getTopLevelFragments(DataspaceEntity dataspaceEntity,

-                                                       AnchorEntity anchorEntity) {

-        final List<FragmentExtract> fragmentExtracts = findRootsByAnchorId(anchorEntity.getId());

-        if (fragmentExtracts.isEmpty()) {

-            throw new DataNodeNotFoundException(dataspaceEntity.getName(), anchorEntity.getName());

-        }

-        return fragmentExtracts;

-    }

+    @Query("SELECT f FROM FragmentEntity f WHERE anchor = :anchor")

+    List<FragmentExtract> findAllExtractsByAnchor(@Param("anchor") AnchorEntity anchorEntity);

 

     @Modifying

-    @Query("DELETE FROM FragmentEntity fe WHERE fe.anchor IN (:anchors)")

-    void deleteByAnchorIn(@NotNull @Param("anchors") Collection<AnchorEntity> anchorEntities);

+    @Query("DELETE FROM FragmentEntity WHERE anchor IN (:anchors)")

+    void deleteByAnchorIn(@Param("anchors") Collection<AnchorEntity> anchorEntities);

 

-    @Query(value = "SELECT id, anchor_id AS anchorId, xpath, parent_id AS parentId,"

-        + " CAST(attributes AS TEXT) AS attributes"

-        + " FROM FRAGMENT WHERE anchor_id = :anchorId"

-        + " AND ( xpath = :parentXpath OR xpath LIKE CONCAT(:parentXpath,'/%') )",

-           nativeQuery = true)

-    List<FragmentExtract> findByAnchorIdAndParentXpath(@Param("anchorId") int anchorId,

-                                                       @Param("parentXpath") String parentXpath);

+    @Query("SELECT f FROM FragmentEntity f WHERE anchor = :anchor"

+        + " AND (xpath = :parentXpath OR xpath LIKE CONCAT(:parentXpath,'/%'))")

+    List<FragmentExtract> findByAnchorAndParentXpath(@Param("anchor") AnchorEntity anchorEntity,

+                                                     @Param("parentXpath") String parentXpath);

 

     @Query(value = "SELECT id, anchor_id AS anchorId, xpath, parent_id AS parentId,"

         + " CAST(attributes AS TEXT) AS attributes"

@@ -101,7 +68,7 @@ public interface FragmentRepository extends JpaRepository<FragmentEntity, Long>,
     List<FragmentExtract> quickFindWithDescendants(@Param("anchorId") int anchorId,

                                                    @Param("xpathRegex") String xpathRegex);

 

-    @Query("SELECT f.xpath FROM FragmentEntity f WHERE f.anchor = :anchor AND f.xpath IN :xpaths")

+    @Query("SELECT xpath FROM FragmentEntity f WHERE anchor = :anchor AND xpath IN :xpaths")

     List<String> findAllXpathByAnchorAndXpathIn(@Param("anchor") AnchorEntity anchorEntity,

                                                 @Param("xpaths") Collection<String> xpaths);