diff options
author | JosephKeenan <joseph.keenan@est.tech> | 2021-08-20 10:33:54 +0100 |
---|---|---|
committer | JosephKeenan <joseph.keenan@est.tech> | 2021-08-30 17:38:03 +0100 |
commit | 0af60de4fbb3a3e6c828e179c667b173b1539b62 (patch) | |
tree | 0694c43ec6f905e250fd74be87c3b6627bbdbf44 /cps-ncmp-rest/src | |
parent | 7edbeb6d5853206cc1d3b4cadd7ba50e96f4f04d (diff) |
CPS-505 Retrieving modules for new CM handle
-Added some production code for getting missing modules for new CM
handle
-Groovy test template added by Toine for getting msissing modules
-Added json example for test
-Modified test to check map contents
-Differentiated restTemplate calls based on URL
-Fixed code review comment`s
-Groovy test now passing
-Modified behaviour for sending moduleReferences and added null to
namespace (jira to follow)
-Combined NetworkCmProxyDataServiceImpl tests into one class & addressed
code review comments
Issue-ID: CPS-505
Change-Id: I91ef65467496caea7834ba2e8af99cfe58d4f880
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Diffstat (limited to 'cps-ncmp-rest/src')
2 files changed, 2 insertions, 2 deletions
diff --git a/cps-ncmp-rest/src/main/java/org/onap/cps/ncmp/rest/controller/NetworkCmProxyController.java b/cps-ncmp-rest/src/main/java/org/onap/cps/ncmp/rest/controller/NetworkCmProxyController.java index d4e842a35a..f5ffdbeb92 100755 --- a/cps-ncmp-rest/src/main/java/org/onap/cps/ncmp/rest/controller/NetworkCmProxyController.java +++ b/cps-ncmp-rest/src/main/java/org/onap/cps/ncmp/rest/controller/NetworkCmProxyController.java @@ -109,7 +109,7 @@ public class NetworkCmProxyController implements NetworkCmProxyApi { final @Valid RestDmiPluginRegistration restDmiPluginRegistration) { final DmiPluginRegistration dmiPluginRegistration = convertRestObjectToJavaApiObject(restDmiPluginRegistration); - networkCmProxyDataService.updateDmiPluginRegistration(dmiPluginRegistration); + networkCmProxyDataService.updateDmiRegistrationAndSyncModule(dmiPluginRegistration); return new ResponseEntity<>(HttpStatus.CREATED); } diff --git a/cps-ncmp-rest/src/test/groovy/org/onap/cps/ncmp/rest/controller/NetworkCmProxyControllerSpec.groovy b/cps-ncmp-rest/src/test/groovy/org/onap/cps/ncmp/rest/controller/NetworkCmProxyControllerSpec.groovy index 1a2d3a204f..65946a9f97 100644 --- a/cps-ncmp-rest/src/test/groovy/org/onap/cps/ncmp/rest/controller/NetworkCmProxyControllerSpec.groovy +++ b/cps-ncmp-rest/src/test/groovy/org/onap/cps/ncmp/rest/controller/NetworkCmProxyControllerSpec.groovy @@ -191,7 +191,7 @@ class NetworkCmProxyControllerSpec extends Specification { .content(jsonData) ).andReturn().response then: 'the cm handles are registered with the service' - 1 * mockNetworkCmProxyDataService.updateDmiPluginRegistration(_) + 1 * mockNetworkCmProxyDataService.updateDmiRegistrationAndSyncModule(_) and: 'response status is created' response.status == HttpStatus.CREATED.value() } |