summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorToineSiebelink <toine.siebelink@est.tech>2021-09-21 17:29:04 +0100
committerToineSiebelink <toine.siebelink@est.tech>2021-09-21 17:31:26 +0100
commit8f254ba0f91be28ffdba801d03a7493d94bdc0b8 (patch)
tree75a6a89d5690a71fdcf4ce81d3b372a52e1dbc29
parent2ee46351129de73cf2cf2f0579e73b1ef8abdafc (diff)
Address Sonar Qube issues
- Add missing lombok.config to exclude lombok generated code in some modules - Increased Coverage treshold where possible Issue-ID: CPS-475 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech> Change-Id: I4974aa1abec47980e15c2da10afc7288c2cc7c54
-rw-r--r--cps-ncmp-rest/lombok.config20
-rw-r--r--cps-ncmp-service/lombok.config20
-rw-r--r--cps-ncmp-service/pom.xml4
-rwxr-xr-xcps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java2
-rw-r--r--cps-rest/lombok.config20
5 files changed, 61 insertions, 5 deletions
diff --git a/cps-ncmp-rest/lombok.config b/cps-ncmp-rest/lombok.config
new file mode 100644
index 0000000000..0736fc58c6
--- /dev/null
+++ b/cps-ncmp-rest/lombok.config
@@ -0,0 +1,20 @@
+# ============LICENSE_START=======================================================
+# Copyright (C) 2021 Nordix Foundation
+# ================================================================================
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# SPDX-License-Identifier: Apache-2.0
+# ============LICENSE_END=========================================================
+
+config.stopBubbling = true
+lombok.addLombokGeneratedAnnotation = true
diff --git a/cps-ncmp-service/lombok.config b/cps-ncmp-service/lombok.config
new file mode 100644
index 0000000000..0736fc58c6
--- /dev/null
+++ b/cps-ncmp-service/lombok.config
@@ -0,0 +1,20 @@
+# ============LICENSE_START=======================================================
+# Copyright (C) 2021 Nordix Foundation
+# ================================================================================
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# SPDX-License-Identifier: Apache-2.0
+# ============LICENSE_END=========================================================
+
+config.stopBubbling = true
+lombok.addLombokGeneratedAnnotation = true
diff --git a/cps-ncmp-service/pom.xml b/cps-ncmp-service/pom.xml
index ac2593998c..96aa4e5cc9 100644
--- a/cps-ncmp-service/pom.xml
+++ b/cps-ncmp-service/pom.xml
@@ -32,10 +32,6 @@
<artifactId>cps-ncmp-service</artifactId>
- <properties>
- <minimum-coverage>0.90</minimum-coverage>
- </properties>
-
<dependencies>
<dependency>
<groupId>${project.groupId}</groupId>
diff --git a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java
index dc5dc77334..08370ab890 100755
--- a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java
+++ b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java
@@ -459,7 +459,7 @@ public class NetworkCmProxyDataServiceImpl implements NetworkCmProxyDataService
private static ModuleReference toModuleReference(final JsonObject moduleReferenceAsJson) {
final var moduleReference = new ModuleReference();
moduleReference.setModuleName(moduleReferenceAsJson.get("moduleName").getAsString());
- moduleReference.setRevision(moduleReferenceAsJson.get("revision").getAsString());
+ moduleReference.setRevision(moduleReferenceAsJson.get(REVISION).getAsString());
return moduleReference;
}
}
diff --git a/cps-rest/lombok.config b/cps-rest/lombok.config
new file mode 100644
index 0000000000..0736fc58c6
--- /dev/null
+++ b/cps-rest/lombok.config
@@ -0,0 +1,20 @@
+# ============LICENSE_START=======================================================
+# Copyright (C) 2021 Nordix Foundation
+# ================================================================================
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# SPDX-License-Identifier: Apache-2.0
+# ============LICENSE_END=========================================================
+
+config.stopBubbling = true
+lombok.addLombokGeneratedAnnotation = true