diff options
| author |   Kanagaraj Manickam <kanagaraj.manickam@huawei.com> | 2022-04-12 06:15:23 +0000 |
|---|---|---|
| committer |   Gerrit Code Review <gerrit@onap.org> | 2022-04-12 06:15:23 +0000 |
| commit | 30112b24ada9a4ce0bfff2e1d8693f3dd30f8708 (patch) | |
| tree | 2f97bc3b6e974d27f2a15a10ad819b58c7a87b92 | |
| parent | ff9b488317f848c31f041040c15097f921a70dff (diff) | |
| parent | 23a3b1180c21e3cd33b758492d32dc827d60ccce (diff) | |
Merge "Refactored the code in order to not assign to the loop counter from within the loop body."
| -rw-r--r-- | main/src/main/java/org/onap/cli/main/utils/OnapCliArgsParser.java | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/main/src/main/java/org/onap/cli/main/utils/OnapCliArgsParser.java b/main/src/main/java/org/onap/cli/main/utils/OnapCliArgsParser.java index 123521bf..65a7f661 100644 --- a/main/src/main/java/org/onap/cli/main/utils/OnapCliArgsParser.java +++ b/main/src/main/java/org/onap/cli/main/utils/OnapCliArgsParser.java @@ -100,7 +100,8 @@ public class OnapCliArgsParser { } int positionalIdx = 0; - for (int i = 0; i < args.size(); i++) { + int i = 0; + while(i < args.size()) { String paramName = null; if (shortOptionMap.containsKey(args.get(i))) { paramName = shortOptionMap.get(args.get(i)); @@ -113,6 +114,7 @@ public class OnapCliArgsParser { if ((i + 1) == args.size() || args.get(i + 1).startsWith("-")) { if (paramMap.get(paramName).getParameterType().equals(OnapCommandParameterType.BOOL)) { paramMap.get(paramName).setValue(true); + i++; continue; } throw new OnapCliArgumentValueMissing(args.get(i)); @@ -121,26 +123,26 @@ public class OnapCliArgsParser { if (paramMap.get(paramName).getParameterType().equals(OnapCommandParameterType.JSON)) { paramMap.get(paramName).setValue(readJsonStringFromUrl(args.get(i + 1), paramMap.get(paramName).getName())); - i++; + i += 2; continue; } else if (paramMap.get(paramName).getParameterType().equals(OnapCommandParameterType.TEXT)) { paramMap.get(paramName).setValue(readTextStringFromUrl(args.get(i + 1), paramMap.get(paramName).getName())); - i++; + i += 2; continue; } else if (paramMap.get(paramName).getParameterType().equals(OnapCommandParameterType.YAML)) { String value = readYamlStringFromUrl(args.get(i + 1), paramMap.get(paramName).getName()); paramMap.get(paramName).setValue(value); - i++; + i += 2; continue; } else if (paramMap.get(paramName).getParameterType().equals(OnapCommandParameterType.BYTE)) { paramMap.get(paramName).setValue(readBytesFromUrl(args.get(i + 1), paramMap.get(paramName).getName())); - i++; + i += 2; continue; } else if (paramMap.get(paramName).getParameterType() @@ -150,7 +152,7 @@ public class OnapCliArgsParser { list.add(readTextStringFromUrl(args.get(i + 1), paramMap.get(paramName).getName())); paramMap.get(paramName).setValue(list); - i++; + i += 2; continue; } else if (paramMap.get(paramName).getParameterType() @@ -170,13 +172,13 @@ public class OnapCliArgsParser { map.put(argArr[0], argArr[1]); paramMap.get(paramName).setValue(map); - i++; + i += 2; continue; } paramMap.get(paramName).setValue(args.get(i + 1)); - i++; + i += 2; continue; } @@ -190,6 +192,7 @@ public class OnapCliArgsParser { paramMap.get(positionArgs.get(positionalIdx)).setValue(args.get(i)); positionalIdx++; + i++; } params.clear(); |