aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArindam Mondal <arind.mondal@samsung.com>2019-07-01 19:36:25 +0900
committerKanagaraj Manickam <kanagaraj.manickam@huawei.com>2019-08-08 05:38:03 +0000
commit0aa566639422e9a18c7b4e602ad718a79ae20177 (patch)
treeb8bd5a89f3451219e6b28c50d15ea0bb1cd57675
parent1b7553143682d82c9415c9d4341c652f1e49dc97 (diff)
Sonar fixes and improvements
+) Implement try-with-resources ++)Added ut Issue-ID: CLI-170 Change-Id: Id040a05c8f83666b26908bd4b29e9701a0544e98 Signed-off-by: arindamm <arind.mondal@samsung.com>
-rw-r--r--framework/src/main/java/org/onap/cli/fw/utils/ProcessRunner.java8
-rw-r--r--framework/src/test/java/org/onap/cli/fw/utils/ProcessRunnerTest.java45
2 files changed, 46 insertions, 7 deletions
diff --git a/framework/src/main/java/org/onap/cli/fw/utils/ProcessRunner.java b/framework/src/main/java/org/onap/cli/fw/utils/ProcessRunner.java
index db7245c7..d36a0d6c 100644
--- a/framework/src/main/java/org/onap/cli/fw/utils/ProcessRunner.java
+++ b/framework/src/main/java/org/onap/cli/fw/utils/ProcessRunner.java
@@ -153,17 +153,11 @@ public class ProcessRunner {
public String streamToString(InputStream stream) throws IOException {
StringBuilder sb = new StringBuilder();
- BufferedReader br = null;
- try {
- br = new BufferedReader(new InputStreamReader(stream));
+ try (BufferedReader br = new BufferedReader(new InputStreamReader(stream))) {
String line = null;
while ((line = br.readLine()) != null) {
sb.append(line + System.getProperty("line.separator"));
}
- } finally {
- if (br != null) {
- br.close();
- }
}
return sb.toString();
}
diff --git a/framework/src/test/java/org/onap/cli/fw/utils/ProcessRunnerTest.java b/framework/src/test/java/org/onap/cli/fw/utils/ProcessRunnerTest.java
new file mode 100644
index 00000000..2e5b2ab9
--- /dev/null
+++ b/framework/src/test/java/org/onap/cli/fw/utils/ProcessRunnerTest.java
@@ -0,0 +1,45 @@
+/*
+ * Copyright 2018 Samsung Electronics Co., Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.onap.cli.fw.utils;
+
+import java.io.IOException;
+import java.io.InputStream;
+import org.apache.commons.io.IOUtils;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+public class ProcessRunnerTest {
+ ProcessRunner processRunner;
+
+ @Before
+ public void setUp() throws Exception {
+ processRunner = new ProcessRunner("ls -l");
+ }
+
+ @After
+ public void tearDown() throws Exception {}
+
+ @Test
+ public void testStreamToString() throws IOException {
+ InputStream stubInputStream = IOUtils.toInputStream("Test stream", "UTF-8");
+ String out = processRunner.streamToString(stubInputStream);
+ Assert.assertEquals("Test stream\n", out);
+ }
+
+}