summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsurya-huawei <a.u.surya@huawei.com>2017-09-17 23:10:57 +0530
committersurya-huawei <a.u.surya@huawei.com>2017-09-17 23:13:35 +0530
commit58f195402881a8b59fe394578c133fb7689c06d1 (patch)
tree6ee6eb29f699940397c576b752f44d8fe14f1d32
parentb9e5ea7161c1f09fdf2a8955cb1ed3f1f93483f3 (diff)
Fix Sonar issue in sli/northbound module
One major issue * move string literals to left side of string comparison Issue-Id: CCSDK-87 Change-Id: Ibd1146a8a12dccc56fb620fe5830efb545ac39a1 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
-rw-r--r--dataChange/provider/src/main/java/org/onap/ccsdk/sli/northbound/DataChangeProvider.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/dataChange/provider/src/main/java/org/onap/ccsdk/sli/northbound/DataChangeProvider.java b/dataChange/provider/src/main/java/org/onap/ccsdk/sli/northbound/DataChangeProvider.java
index d47bcd1b..0977fa0b 100644
--- a/dataChange/provider/src/main/java/org/onap/ccsdk/sli/northbound/DataChangeProvider.java
+++ b/dataChange/provider/src/main/java/org/onap/ccsdk/sli/northbound/DataChangeProvider.java
@@ -148,7 +148,7 @@ public class DataChangeProvider implements AutoCloseable, DataChangeService {
String errorCode = serviceDataBuilder.getDataChangeResponseCode();
- if ( errorCode != null && errorCode.length() != 0 && !( errorCode.equals("0")|| errorCode.equals("200"))) {
+ if (!("0".equals(errorCode) || "200".equals(errorCode))) {
LOG.error("Returned FAILED for "+SVC_OPERATION+" error code: '" + errorCode + "'");
} else {
LOG.info("Returned SUCCESS for "+SVC_OPERATION+" ");