Age | Commit message (Collapse) | Author | Files | Lines |
|
Updated version to 0.2.3-SNAPSHOT and 1.0.3-SNAPSHOT parent pom
Change-Id: I2ac80137aa409d0d13b4bec12beb2b7e74bdfa40
Issue-ID: CCSDK-290
Signed-off-by: Stilwell, David (stilwelld) <stilwelld@att.com>
|
|
Updated pom.xmls to use released version of parent pom.
Change-Id: Ib3d1c856691556cbd4c5f51852888f4bfc791a9f
Issue-ID: CCSDK-286
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
|
|
Changes made:
* updated version of org.apache.karaf.shell.console plugin
Change-Id: I4cb0f5cb9e5a515473d2c60f693efd8dfc872dff
Issue-ID: CCSDK-182
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Changes made:
* Implemented code to decrypt password field in property file
Change-Id: I97e5f93fd1f8383c1e2a1e6170489dc1db9d6337
Issue-ID: CCSDK-182
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Roll to next version for next release candidate.
Change-Id: I0a76316934afd79f4ecf3588453ed4d6e34fb615
Issue-ID: CCSDK-257
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
|
|
Added unit tests for ccsdk/sli/core/sli
Change-Id: I0d2408c43b9e56a78f3e01e87985aedb6cad5953
Issue-ID: CCSDK-213
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
|
|
Changes made:
* Optimized TerminatingCachedDataSource
* Added additional unit tests
Change-Id: I0a83c993898e2bee11b8d3c5df8f95b4b216e9b8
Issue-ID: CCSDK-151
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Changes made:
* updated algorithm in DBResourceManager
* Updated CachedDataSource, JdbcDBCachedDataSource
* added new unit tests
Change-Id: I4f6bbeb3839f55d183d7e762743fbc9171b63b1a
Issue-ID: CCSDK-192
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Changes made:
* corrected sonar related issue in CachedDataSource class
Change-Id: If84b9abcd115ad042f2cc0527b5ab8c8e12cae5a
Issue-ID: CCSDK-151
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Use Apache derby for dblib SingleFeatureTest
Change-Id: I6b41f7ede1a98b33824fceea9100e75c1ce8dda4
Issue-ID: CCSDK-175
Signed-off-by: Dan Timoney <dtimoney@att.com>
Generalization of CCSDK core/utils framework
Changes made:
* Created generalized version of core/utils/dblib as core/utils/common
* Deprecated core/utils/dblib package
Change-Id: I0992c43910278fbe254674d1e39d7e4fcad0a592
Issue-ID: CCSDK-168
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Use Apache derby for dblib test
Use Apache derby for dblib SingleFeatureTest
Change-Id: Ie497557f162e203fa5c5c82c17ddc55ba0c11b38
Issue-ID: CCSDK-175
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Changes made:
* Created generalized version of core/utils/dblib as core/utils/common
* Deprecated core/utils/dblib package
Change-Id: I0992c43910278fbe254674d1e39d7e4fcad0a592
Issue-ID: CCSDK-168
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Bump minor version in preparation for Amsterdam
branching. (part 2)
Change-Id: Ib9f7cf7f98feb159ce1b136a3cd792820c99e659
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
|
|
Roll to next snapshot version to prepare for release cut
Change-Id: I2a4c8395630b461314291bc8e0f83bf114a21f61
Issue-ID: CCSDK-141
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
*This is improve readability of source code
Issue-Id: CCSDK-117
Change-Id: I4bb73a6e4b440ae861045c7548a7e985d1fbf02c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
Add unit test case for dblib/provider, using MariaDB4J as database.
Change-Id: I18492595a9d54999c3d52b56ecfe33d0d2cae019
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
|
|
*Remove unnecessary cast to "CachedDataSource"
These unnecessary casting expressions maked the
code harder to read and understand
*Replace type specification with diamond operator
This is to reduce the verbosity of generics code
Issue-Id: CCSDK-87
Change-Id: I6cd2f7d16886ffa6cc26e5dd300b8376705d9366
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
Changes made:
1. updated DBLibService definition by registering service on two interfaces:
a) javax.sql.DataSource
b) org.onap.ccsdk.sli.core.dblib.DbLibService
Change-Id: If187b07db83ebca5428c809a83f546d9178a2b7f
Issue-ID: CCSDK-102
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
|
|
Changes made:
1. updated DBLibService definition by adding javax.sql.DataSource
Change-Id: I5dd63a81420f451b0ce9bbbc878d351d62ccd819
Issue-ID: CCSDK-102
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Remove the hardcoded junit & common-lang version and rather take from parent pom.
Change-Id: Ibc71ff4b86a2fefc89365017f06333776cb2fed3
Issue-Id: CCSDK-105
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
|
|
Fix few Critical/Major sonar issues in CCSDK SLI Core module
* Define and throw a dedicated exception instead of using a generic one
* Either log or rethrow the exception
* Change "try" to a try-with-resources
* Remove useless assignment to local variable
* Use built-in logger method string formatting instead of string concatination
* code indentation
Change-Id: I83dc1fb931b8021118e259c722f7dfbc1621dce8
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
|
|
|
|
|
|
|
|
Added @Override annotation before method signature
*This is to improve the readability of code
Issue-Id: CCSDK-87
Change-Id: I979eb03ec81b9868012e5c16f48b595c8e53e26e
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
New utils jar was added in another change, but wasn't bundled as a karaf
feature and was not being installed in container. This broke odlsli
docker container. This change wraps that util package as a new
feature (sdnc-core-utils).
Change-Id: Ie8c1d608e2c67aa1635837bc400cec942761c81c
Issue-ID: CCSDK-54
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Rdundant code and complextity of methods reduced.
@override annotaiton added.
Exception handling and logging impoved.
Issue-ID:CCSDK-87
Change-Id: I3907be73a2f6ccdfadeaed79c87705ae7afdb4ab
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
|
|
Related to exception handling.
@Override method
Redundant code and resulable parameters
Issue-Id:CCSDK-87
Change-Id: I82e2aad453edf5cd647c87322fc75b2a56c37566
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
|
|
Few major issues
*Remove unused variables
To increase code readability
*Replace the type specification with the diamond operator
*Add the "@Override" annotation above this method signature
To increase code readability"
Issue-Id: CCSDK-87
Change-Id: I2f0c16a83ab10a0a3e39a2a1d4db3c195ec2bba8
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
|
|
|
|
|
|
When looking at the existing uses of BundleActivator(s), it became
immediately clear that other parts of the code have a strategy based
properties file resolution very similar to those abstracted by dblib.
This change aggregates a separate utils bundle for this functionality,
which is further abstracted for potential reuse with other use cases.
The next use case is in the sli bundle, which will be handled in
a follow-up patch.
Issue-Id: SDNC-54
Change-Id: Ie4d4bb679617474b1983e6044c08cca1742b9893
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
Few major issues
*Remove unused imports
To increase code readability
*Replace the type specification with the diamond operator
To reduce the verbosity of generics code
*Add the "@Override" annotation above this method signature
To increase code readability
*Remove this unnecessary cast to "String"
Unnecessary casting expressions pollutes code
Issue-Id: CCSDK-87
Change-Id: I38952f5026a5c61af73ac16706e8ddc278566b13
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
One blocker issue in sli/core module
*Check for null dereferencing
Issue-Id: CCSDK-87
Change-Id: I5ebaef24b3fd6534b5e818c3087e3d8213ed770c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
Remove lingering mysql dependencies in sli/core, which prevented odlsli
container from starting up clean. Note: tested this using bareodl container
and verified that these changes install clean AFTER changing incorrect
driver property name in dblib.properties. This patch is fine, but a second
patch to ccsdk/distribution is needed to fix that property file.
Change-Id: I6a900d1c29998867bfbae29d5e113c4e392a8bb9
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Update sli/core (including dblib, notably) to use mariadb-connector
for any jUnit tests. Update Import-Package in dblib provider pom.xml
to import org.mariadb.jdbc so that org.mariadb.jdbc.Driver will
be resolved
Change-Id: I39dfe2cafb955ba1bf05b0ecdb0212d766fcc96c
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Need to explicitly add com.mysql.jdbc to Import-Package in dblib/provider
pom.xml, so that Class.forName() can resolve com.mysql.jdbc.Driver.
Will also need to add org.mariadb.jdbc,but will do that in a separate
commit
Change-Id: I6a4be5d4e1841690919484940af75a2cb15c357b
Issue-ID: CCSDK-94
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Changes made:
1. removed hardcoded JDBC driver's name and made it a property.
2. Optimized connection pool initialization
3. Removed unused factories.
Change-Id: Id1d1868f7f1a6ae5a0429a97403042a8f6ee78d3
Issue-ID: CCSDK-92
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
|
|
|
|
|
|
The Java programming language assigns certain defaults for methods
and constants defined in interfaces. This change removes the
unnecessary redundant modifiers appropriately.
For example:
* interface methods are public by default
* interface constants are public by default
* interface methods are abstract unless "default" is specifically
used (as of JDK8+).
This is really just to get rid of annoying warnings present in
IDE(s).
Issue-Id: SDNC-79
Change-Id: I2e6b3e4fa02bad1beee2cbb49d3766722eff1ba0
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
|
|
This change isn't too big; it mainly just attempts to clean up the
BaseDBConfiguration class using best practices. For example:
* documentation is added surrounding public methods, public constants,
protected variables, and class headers.
* code logic for parsing "optional" integer properties is abstracted
into a separate private static function, which returns a default
value if the given input property cannot be parsed or is not present.
* public functions where the NumberFormatException RuntimeException
might be thrown have the appriorate "throws" modifier added to their
function signatures to indicate that the consumer is responsible for
exception handling.
* constants are extracted in place of "magic numbers"
This is really just code sanitation work.
Change-Id: Ifaf092e10b17f54c7cce0a888aa49bfe8377cdd3
Issue-Id: SDNC-79
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
|
|
Update sli/core to use oparent-odlparent. To prevent verify builds from
failing due to unit test errors, also changed unit tests that require
database access to use MariaDB4j to start up a local MariaDB database.
Change-Id: I928b7e1e83bdb328ca9e0785c8b81f67f982eeda
Issue-ID: CCSDK-43
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
|
|
|
|
Code sanitation-- remove unused imports.
Issue-Id: SDNC-79
Change-Id: I5306a9b90f302086459fcac98d04f541ba7c79a4
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|