summaryrefslogtreecommitdiffstats
path: root/dblib/provider/src/main/java
AgeCommit message (Collapse)AuthorFilesLines
2019-11-05minor updates to clean up codeAgarwal, Ruchira (ra1926)2-7/+21
clean up code to sync with internal Issue-ID: CCSDK-1873 Signed-off-by: Agarwal, Ruchira (ra1926) <ra1926@att.com> Change-Id: I1043e3f34176aebf2531bf0581b207694264d6f2
2019-10-30remove EncShellCommandSmokowski, Kevin (ks6305)2-97/+0
remove EncShellCommand to separate dblib from karaf and odl Issue-ID: CCSDK-1848 Signed-off-by: Smokowski, Kevin (ks6305) <kevin.smokowski@att.com> Change-Id: If43abeceb556b4075d2866a18b8c9e92765e14a2
2019-03-22Support system variables in property valuesRich Tabedzki3-25/+127
Changes made: * Added code in DBResourceManager to replace with its value * Expanded debug statement by adding processing time Change-Id: I22748daed50063e8e0ac7201e88d69a2609c1788 Issue-ID: CCSDK-1133 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2019-02-05Add dummy inputTimoney, Dan (dt5972)1-0/+1
Fluorine version of restconf does not handle RPCs with no input correctly. So, need to work around that by defining dummy input for SLI-API vlbcheck and healthcheck APIs Change-Id: I6a78a899937e1bb9bd7674530166a493875ca3bf Issue-ID: CCSDK-1035 Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
2019-02-01Hack to force classloader t find mariadb driverTimoney, Dan (dt5972)1-0/+7
Container is not coming up because dblib is getting ClassNotFoundException for mariadb driver, even though it is installed. To correct this temporarily, updated code to explicitly create a driver object. Change-Id: I210d042be2c71a4392781ad26f858c916dbd7364 Issue-ID: CCSDK-489 Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
2019-01-08Fix sonar issues in ccsdk-sli-coreRich Tabedzki2-11/+10
Changes made: * Updated message template handling in CachedDataSource Change-Id: I9a082753d80f790b77448a5b3de957b404d737fb Issue-ID: CCSDK-647 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2019-01-07fixed sonar issue in JdbcCachedDataSourceRich Tabedzki5-7/+60
Changes made: * updated cleanup code * added TerminatingConfiguration class Change-Id: Iee16116a5fc419065915b9f84488874dd192af7c Issue-ID: CCSDK-913 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2019-01-07Merge "Fixed sonar fix in DbConfigPool.java"Dan Timoney1-5/+4
2019-01-04Fixed sonar fix in DbConfigPool.javaezhil1-5/+4
Fixed major sonar issue Issue-ID: CCSDK-796 Change-Id: Id8a655875c972bb3df1f12f211b6a0068922b21d Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-28Merge "fixed sonar issue in PollingWorker.java"Dan Timoney1-1/+1
2018-12-20fixed sonar issue in PollingWorker.javaSandeep J1-1/+1
fixed sonar issue Issue-ID: CCSDK-525 Change-Id: If242b9995469c0b0a25b1285db1536ff52adce2c Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-20fixed sonar issues in DBResourceManager.javaSandeep J1-5/+5
fixed sonar issues Issue-ID: CCSDK-525 Change-Id: I169df48b14e1288271356a972c36e678da1ffa04 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-18fixed sonar issues and formatted codeSandeep J1-49/+78
formatted code and added equals and hashcode method as per sonar standards Issue-ID: CCSDK-525 Change-Id: Idaa0a6a0a82315189a9365064d4f196e4689ee57 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-13fixed sonar issue in JdbcCachedDataSourceRich Tabedzki2-21/+24
Changes made: * fixed sonar issue Change-Id: I2112b202f8b7eb628fc21c3a972e35704dc827f9 Issue-ID: CCSDK-525 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2018-12-11Merge "Fixed sonar issues in PollingWorker.java"Dan Timoney1-13/+16
2018-12-11Merge "fixed sonar issue in DBConfigFactory"Dan Timoney1-1/+3
2018-12-11Merge "fixed sonar issues in DbConfigPool.java"Dan Timoney1-2/+3
2018-12-11Merge "fixed sonar issues in DBResourceManager.java"Dan Timoney1-4/+7
2018-12-05Fixed sonar issues in PollingWorker.javaezhil1-13/+16
Fixed logger issues Issue-ID: CCSDK-791 Change-Id: Ie1759c8778ff896b2cff3e187308e6a10265e966 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-12-05fixed sonar issue in DBConfigFactorySandeep J1-1/+3
fixed sonar issue Issue-ID: CCSDK-525 Change-Id: I64adc9bc11c7e4fcac2c1caec614745ebe6887be Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-05fixed sonar issues in DbConfigPool.javaSandeep J1-2/+3
fixed sonar issue Issue-ID: CCSDK-525 Change-Id: Ibf082dc71b49b8d657dfbb79ac0ef396eb3f4aa8 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-05fixed sonar issues in DBResourceManager.javaSandeep J1-4/+7
fixed sonar issue Issue-ID: CCSDK-525 Change-Id: I29b85aa6066c6a940818443602e3e0e02fad59ab Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-12-05fixed sonar issues in CachedDataSourceFactorySandeep J1-1/+3
removed unnecessary cast to object Issue-ID: CCSDK-525 Change-Id: Iccd4430cdbbadfabbdc21820c1f0f962b7635444 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-11-30Fixed Sonar issue in BaseDBConfiguration.javaezhil1-2/+7
Logged exception in Logger Issue-ID: CCSDK-774 Change-Id: I28d10215daafd9f0dcaf7e0d765afbe72c184053 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-07-25Fix sonar issuesParshad Patel1-5/+2
Fix sonar issues in ccsdk/sli/core Issue-ID: CCSDK-332 Change-Id: I2aee69cf410d8f9cb63f3a22aeb793a99e27d2c7 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-05-11Provide support for properties encryptionRich Tabedzki2-0/+104
Changes made: * Implemented code to decrypt password field in property file Change-Id: I97e5f93fd1f8383c1e2a1e6170489dc1db9d6337 Issue-ID: CCSDK-182 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2018-03-27Add unit tests for sliTimoney, Dan (dt5972)1-1/+6
Added unit tests for ccsdk/sli/core/sli Change-Id: I0d2408c43b9e56a78f3e01e87985aedb6cad5953 Issue-ID: CCSDK-213 Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
2018-03-08Fix sonar related itemsRich Tabedzki3-48/+2
Changes made: * Optimized TerminatingCachedDataSource * Added additional unit tests Change-Id: I0a83c993898e2bee11b8d3c5df8f95b4b216e9b8 Issue-ID: CCSDK-151 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2018-03-02Updated master database detection algorithmRich Tabedzki5-252/+196
Changes made: * updated algorithm in DBResourceManager * Updated CachedDataSource, JdbcDBCachedDataSource * added new unit tests Change-Id: I4f6bbeb3839f55d183d7e762743fbc9171b63b1a Issue-ID: CCSDK-192 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2018-02-14Fixed Java Code Conventions issueRich Tabedzki1-512/+511
Changes made: * corrected sonar related issue in CachedDataSource class Change-Id: If84b9abcd115ad042f2cc0527b5ab8c8e12cae5a Issue-ID: CCSDK-151 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2018-02-09Upgrade sli/core to NitrogenDan Timoney1-496/+512
Use Apache derby for dblib SingleFeatureTest Change-Id: I6b41f7ede1a98b33824fceea9100e75c1ce8dda4 Issue-ID: CCSDK-175 Signed-off-by: Dan Timoney <dtimoney@att.com> Generalization of CCSDK core/utils framework Changes made: * Created generalized version of core/utils/dblib as core/utils/common * Deprecated core/utils/dblib package Change-Id: I0992c43910278fbe254674d1e39d7e4fcad0a592 Issue-ID: CCSDK-168 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com> Use Apache derby for dblib test Use Apache derby for dblib SingleFeatureTest Change-Id: Ie497557f162e203fa5c5c82c17ddc55ba0c11b38 Issue-ID: CCSDK-175 Signed-off-by: Dan Timoney <dtimoney@att.com>
2018-01-06Generalization of CCSDK core/utils frameworkRich Tabedzki2-888/+889
Changes made: * Created generalized version of core/utils/dblib as core/utils/common * Deprecated core/utils/dblib package Change-Id: I0992c43910278fbe254674d1e39d7e4fcad0a592 Issue-ID: CCSDK-168 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2017-10-12Add @Override annotationsurya-huawei1-0/+3
*This is improve readability of source code Issue-Id: CCSDK-117 Change-Id: I4bb73a6e4b440ae861045c7548a7e985d1fbf02c Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-28Remove redundant castssurya-huawei1-31/+31
*Remove unnecessary cast to "CachedDataSource" These unnecessary casting expressions maked the code harder to read and understand *Replace type specification with diamond operator This is to reduce the verbosity of generics code Issue-Id: CCSDK-87 Change-Id: I6cd2f7d16886ffa6cc26e5dd300b8376705d9366 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-26Updated DBLIB svc definitionRich Tabedzki1-1/+2
Changes made: 1. updated DBLibService definition by adding javax.sql.DataSource Change-Id: I5dd63a81420f451b0ce9bbbc878d351d62ccd819 Issue-ID: CCSDK-102 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2017-09-23Some minor refinements in CCSDK SLI Core moduleramu.n1-16/+15
Fix few Critical/Major sonar issues in CCSDK SLI Core module * Define and throw a dedicated exception instead of using a generic one * Either log or rethrow the exception * Change "try" to a try-with-resources * Remove useless assignment to local variable * Use built-in logger method string formatting instead of string concatination * code indentation Change-Id: I83dc1fb931b8021118e259c722f7dfbc1621dce8 Issue-Id: CCSDK-67 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-22Merge "Add "@Override" annotation"Dan Timoney1-0/+2
2017-09-22Merge "Resolved sonar issue."Dan Timoney2-347/+345
2017-09-22Add "@Override" annotationsurya-huawei1-0/+2
Added @Override annotation before method signature *This is to improve the readability of code Issue-Id: CCSDK-87 Change-Id: I979eb03ec81b9868012e5c16f48b595c8e53e26e Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-21Sql query blocker issue fixed.Bharat saraswal2-729/+627
Rdundant code and complextity of methods reduced. @override annotaiton added. Exception handling and logging impoved. Issue-ID:CCSDK-87 Change-Id: I3907be73a2f6ccdfadeaed79c87705ae7afdb4ab Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
2017-09-21Resolved sonar issue.Bharat saraswal2-347/+345
Related to exception handling. @Override method Redundant code and resulable parameters Issue-Id:CCSDK-87 Change-Id: I82e2aad453edf5cd647c87322fc75b2a56c37566 Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
2017-09-21Fix Sonar Issues in sli/core moduleBharat saraswal4-262/+249
Few major issues *Remove unused variables To increase code readability *Replace the type specification with the diamond operator *Add the "@Override" annotation above this method signature To increase code readability" Issue-Id: CCSDK-87 Change-Id: I2f0c16a83ab10a0a3e39a2a1d4db3c195ec2bba8 Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
2017-09-20Merge "Abstract utility classes for re-use"Dan Timoney6-324/+10
2017-09-20Merge "Fix Sonar Issues in sli/core module"Dan Timoney1-19/+20
2017-09-20Abstract utility classes for re-useRyan Goulding6-324/+10
When looking at the existing uses of BundleActivator(s), it became immediately clear that other parts of the code have a strategy based properties file resolution very similar to those abstracted by dblib. This change aggregates a separate utils bundle for this functionality, which is further abstracted for potential reuse with other use cases. The next use case is in the sli bundle, which will be handled in a follow-up patch. Issue-Id: SDNC-54 Change-Id: Ie4d4bb679617474b1983e6044c08cca1742b9893 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-20Fix Sonar Issues in sli/core modulesurya-huawei1-19/+20
Few major issues *Remove unused imports To increase code readability *Replace the type specification with the diamond operator To reduce the verbosity of generics code *Add the "@Override" annotation above this method signature To increase code readability *Remove this unnecessary cast to "String" Unnecessary casting expressions pollutes code Issue-Id: CCSDK-87 Change-Id: I38952f5026a5c61af73ac16706e8ddc278566b13 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-20Fix Sonar Issuesurya-huawei1-9/+1
One blocker issue in sli/core module *Check for null dereferencing Issue-Id: CCSDK-87 Change-Id: I5ebaef24b3fd6534b5e818c3087e3d8213ed770c Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-19Remove mysql dependencies in sli/coreDan Timoney1-216/+0
Remove lingering mysql dependencies in sli/core, which prevented odlsli container from starting up clean. Note: tested this using bareodl container and verified that these changes install clean AFTER changing incorrect driver property name in dblib.properties. This patch is fine, but a second patch to ccsdk/distribution is needed to fix that property file. Change-Id: I6a900d1c29998867bfbae29d5e113c4e392a8bb9 Issue-ID: CCSDK-95 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-15Prepared DBLIB for multi-verndor JDBC DriverRich Tabedzki8-499/+210
Changes made: 1. removed hardcoded JDBC driver's name and made it a property. 2. Optimized connection pool initialization 3. Removed unused factories. Change-Id: Id1d1868f7f1a6ae5a0429a97403042a8f6ee78d3 Issue-ID: CCSDK-92 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2017-09-14Clean up public interfacesRyan Goulding5-32/+32
The Java programming language assigns certain defaults for methods and constants defined in interfaces. This change removes the unnecessary redundant modifiers appropriately. For example: * interface methods are public by default * interface constants are public by default * interface methods are abstract unless "default" is specifically used (as of JDK8+). This is really just to get rid of annoying warnings present in IDE(s). Issue-Id: SDNC-79 Change-Id: I2e6b3e4fa02bad1beee2cbb49d3766722eff1ba0 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>