summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-09-20Changes to RestApiCall pluginGaurav Agrawal3-33/+69
Changes includes 1. Perform validation of URL syntax during parameter parsing phase. 2. StringBuilder to replace string concatenation within loop. 3. Testcase addition. 4. Sonar critical issue fix for XmlJsonUtil 5) Use logger built-in string formatting rather then string concatenation https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.plugins%3Accsdk-sli-plugins#resolved=false|severities=CRITICAL Change-Id: I884af51023bbd4983c43707aca97c398d24fc9de Issue-Id: CCSDK-67 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-19Remove unthrown exceptionDan Timoney1-3/+3
Merge build fails because catch statement is trying to catch JSONException which is not thrown in body of try Change-Id: I9e29e1698e04f8135799440ca4859aa418d1c54d Issue-ID: CCSDK-99 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-19Merge "Implement test case for Fabric Discovery Plugin"Dan Timoney1-0/+35
2017-09-19Merge "Refinements to RestApiCall plugin"Dan Timoney6-82/+114
2017-09-19Merge "Using specific exceptions in RestApiCallNode"Dan Timoney2-34/+154
2017-09-19Merge "Implement fabric discovery DG parameter validation"Dan Timoney1-1/+22
2017-09-19Refinements to RestApiCall pluginGaurav Agrawal6-82/+114
Changes includes: 1) Check for null in JsonParser.convertToProperties() which can otherwise result in null pointer exception 2) Use logger built-in string formatting rather then string concatenation 3) Use StringBuilder for multiple string concatenations 4) Making utility classes final and defines private constructor for them 5) Added testcases/testpoints https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.plugins%3Accsdk-sli-plugins#resolved=false|severities=CRITICAL Change-Id: Ic047b6d0369827a38a98c52e8365f1fe7266840f Issue-Id: CCSDK-67 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-19Using specific exceptions in RestApiCallNodeGaurav Agrawal2-34/+154
Changes includes 1) Sonar critical fixes stating use of specific exceptions instead of generic one 2) Throw exception for invalid input of repeat times. 3) Added testcases https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.plugins%3Accsdk-sli-plugins#resolved=false|severities=CRITICAL Change-Id: I2633f857e161bf7068c51ef835b7c2cd5eb5aa62 Issue-Id: CCSDK-67 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-19Fix Sonar Issuesurya-huawei1-14/+2
One major issue in sli/plugins module *Making anonymous inner class a lambda for better code readabilty Issue-Id: CCSDK-87 Change-Id: Ib650546c4c2c86411744379fe5beae828403453d Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-19Implement test case for Fabric Discovery PluginArun S. Yerra1-0/+35
Fabric Discovery plugin implements framework to connect to fabric update notifications from local domain controllers. This task is to implement unit test case for this module. Issue-Id: CCSDK-96 Change-Id: I3387f248e693a7da6b4817bc27f87dbc86aea806 Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
2017-09-18Implement fabric discovery DG parameter validationArun S. Yerra1-1/+22
Directed Graph to establish notification stream session with local domain controller passes the REST notification server address. It also passes a a boolean parameter to to either start or stop the session. This change adds logic to validate these input parameters, Issue-Id: CCSDK-88 Change-Id: I3fa05f5badeafbaa15e5ae89a3a60b8e237f212b Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
2017-09-18Merge "Implement framework to process REST notifications"Dan Timoney17-3/+1032
2017-09-18Implement framework to process REST notificationsArun S. Yerra17-3/+1032
Global SDNC controller needs information about network Devices (mostly PNFs) so as to instantiate/configure service. Domain Controllers control/manage the network devices within the fabric. This task is to implement RESTCONF notification processing framework, so that Global SDNC controller can process notifications from Domain controllers. Change-Id: Ia5edb5006ac3fd4ec71e55f92a05e79e40ce76d2 Issue-Id: CCSDK-88 Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
2017-09-17Fix Sonar Issue in sli/plugins modulesurya-huawei1-1/+1
One major issue * move string literal to left side of string comparison Issue-Id: CCSDK-87 Change-Id: I1277c4c5515bd45ad6854c63cf6160f17b7725d0 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-14Use oparent-odlparent in sli/pluginsDan Timoney1-1/+1
Update sli/plugins to use oparent-odlparent, used by latest version of ccsdk odlparent-carbon-sr1 parent. Change-Id: I315d3e0762f86d1a994c6b0d5c35b2f681b7e538 Issue-ID: CCSDK-43 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-14Fix Sonar Issuessurya-huawei2-7/+6
few critical/major issues in sli/plugins module Issue-Id: CCSDK-87 Change-Id: I4fc33df4ed782670252c9b550349f45b6618c77c Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-11Fix Sonar Issuessurya-huawei3-5/+5
Few major issues in Restapi call node Issue-Id: CCSDK-87 Change-Id: Ieb733fcf178cecb9983b5135be8d7737cb42a1f3 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-08Cleanup project's name in SonarJessica Wagantall1-1/+1
The name parameter in the root pom.xml should match the project name in gerrit to reflect consistency in Sonar. Change-Id: I5ea954dd39d9ca8e083978b1130393001b3e36be Issue-id: CIMAN-65 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2017-09-08Fix Blocker/Critical sonar issuesshashikanth1-2/+2
Fix Blocker/Critical sonar issues in vnfapi module https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.plugins%3Accsdk-sli-plugins#resolved=false|severities=BLOCKER Issue-Id: CCSDK-67 Change-Id: I6393ebbaf4bd6dc2dea4a325f2a7d106ba20dd81 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-07Fix sonar issues for ccsdk pluginsurya-huawei1-12/+12
few major issues https://sonar.onap.org/dashboard/index?id=org.onap.ccsdk.sli.plugins%3Arestapi-call-node-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fccsdk%2Fsli%2Fplugins%2Frestapicall%2FRestapiCallNode.java Issue-ID: SDNC-75 Change-Id: Ida6ea182545bf57513bcd958519e3b50dfa004b2 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-01Enable surefire unit testingMarcus G K Williams1-3/+3
Issue-Id: CCSDK-67 Change-Id: I428e0b03f94559929095c7a3fbf2af55e6567f6b Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-08-29Cleanup artifactId for ccsdk/sli/pluginsDan Timoney3-3/+3
ArtifactId for ccsdk/sli/plugins pom.xml should not be identical to that for sdnc/plugins, otherwise import to Eclipse of both will be confusing Updated parent artifactId in each module pom.xml under ccsdk/sli/plugins Change-Id: I13d0d09c9c6f125011942bfe700f6a2b3d1c271b Issue-ID: CCSDK-70 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-23Merge "Conform ccsdk/sli/plugins to ONAP Style"Dan Timoney32-2269/+2316
2017-08-23Conform ccsdk/sli/plugins to ONAP StyleMarcus G K Williams32-2269/+2316
Per ONAP Style Guide: 1. Convert tabs to 4 spaces. 2. Break lines to be less than 120 characters 3. Clean ecomp references 4. Remove extraneous spaces Issue-Id: CCSDK-1 Change-Id: I5638326170aa3ab26774b373ab573643840e97ab Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-08-23Remove obsolete settings.xml filesMarcus G K Williams2-331/+0
Issue-Id: CCSDK-1 Change-Id: I73a814f27ca83a3a78e35cea34a7516b705c5961 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-08-15Port sli/plugins to CarbonDan Timoney40-78/+78
Updated sli/plugins to compile against OpenDaylight Carbon SR1 Change-Id: I5ca937a5a9b51cb0dadd3648c71fe2c5dcefdcf1 Issue-ID: CCSDK-26 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-10Refactor plugins to org onap ccsdkStilwell, David (stilwelld)28-74/+74
Refactor code to use new package name org.onap.ccsdk.sli.plugins Change-Id: Ia5399b21e95d556890aef5ad27437f1ac120ef8d Issue-ID: CCSDK-21 Signed-off-by: Stilwell, David (stilwelld) <stilwelld@att.com>
2017-08-01[CCSDK-6] Populate seed codeDan Timoney61-0/+5002
Add seed code for sli/plugins repository Changed groupId to org.onap.ccsdk.sli.plugins Updated to compile against CCSDK version of SLI Change-Id: Ib392530ea79b8544087692964bd65179896aa595 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-06-27Initial empty repositoryJessica Wagantall0-0/+0