summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-11-08Fix Doc8 errorsMorgan Richomme1-2/+0
JIRA: CCSDK-139 Change-Id: I5b48d4189ae9fdd72bb85a4d98be7798452249df Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
2017-10-25Use version 0.1.0 of parentDan Timoney1-1/+1
Update to use version 0.1.0 (released version) of parent pom Change-Id: I3b62a0cab11425ae9eb7e074aa1c23585aede1c4 Issue-ID: CCSDK-80 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-25Add unit test case for PrintYangToPropDan Timoney2-0/+75
Add junit testing for PrintYangToProp Change-Id: I8c377bb51c812ea9ead32d8e9d5ef871157162a8 Issue-ID: CCSDK-129 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-25Fix parent tag in utils/providerDan Timoney1-1/+1
utils/provider parent should be utils, not ccsdk-sli-core. This was breaking release build. Change-Id: I3910189f9a989f93a0a8af4cb5a8512f0e9aca7a Issue-ID: CCSDK-80 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-24Fix release versionDan Timoney1-1/+1
version.properties contains wrong setting for release version Change-Id: Id76da3e2ad9009845e99ac1442cb66514733461c Issue-ID: CCSDK-80 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-18added code to convert yang to propertiesSheshi Chinthakayala1-0/+1367
this code is used by dgbuilder to convert the yang to context property names Change-Id: Ib53f57df6e8bd32a3a1b7ba6fa7854497c1f5c6c Issue-ID: SDNC-81 Signed-off-by: Sheshi Chinthakayala <sc2914@att.com>
2017-10-12Add @Override annotationsurya-huawei1-0/+3
*This is improve readability of source code Issue-Id: CCSDK-117 Change-Id: I4bb73a6e4b440ae861045c7548a7e985d1fbf02c Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-10-11Add readthedocs info to sli/coreDan Timoney8-45/+1586
Add additional information to sli/core readthedocs documentation. Change-Id: I9fe5e6185061ed6a05f373b6667f686e11d5f0aa Issue-ID: CCSDK-107 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-10Add readthedocs templatesDan Timoney7-9/+142
Add readthedocs templates for sli/core Change-Id: I2efaad7720997ef51c4dcb9036de5011bc6a1c4b Issue-ID: CCSDK-107 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-03Merge "SLI-API northbound add to docs"Dan Timoney2-2/+10
2017-10-03Merge "Add unit tests for dblib"Dan Timoney3-0/+99
2017-10-03Add unit tests for dblibDan Timoney3-0/+99
Add unit test case for dblib/provider, using MariaDB4J as database. Change-Id: I18492595a9d54999c3d52b56ecfe33d0d2cae019 Issue-ID: CCSDK-106 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-03Add unit test for ccsdk/coresurya-huawei1-0/+12
*Add a unit test for SliStringUtils This is to test substring method of SliStringUtils and improve code coverage Issue-Id: CCSDK-106 Change-Id: I73c5af3b036a92fdcb1d3d1be7eb0b3abc44fd5a Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-10-02Add test cases for MdsalHelperDan Timoney23-2742/+91
Fix test case for loadProperties, and added test cases for IpAddress types Change-Id: Iabf182d32ae3937871dc9656105fdda0c1a9411f Issue-ID: CCSDK-106 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-02Add test cases for MdsalHelperDan Timoney26-130/+3066
Add test cases for MdsalHelper methods toBuilder() and toProperties(). This requires a Yang model, so added a copy of sliapi/model to sli, since could not use sliapi directly otherwise would create circular dependency (since sliapi depends on sli). Change-Id: I4824afe250f93428c73dbeec9f4a4c36ee4f76e6 Issue-ID: CCSDK-106 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-28SLI-API northbound add to docsBrian Freeman2-2/+10
Issue-ID: CCSDK-107 Change-Id: Ic4a41466288229140ae3cad79e650d14c7877cc9 Signed-off-by: Brian Freeman <bf1936@att.com>
2017-09-28Merge "Added @Override annotation"Dan Timoney1-2/+2
2017-09-28Merge "Fix major sonar issue"Dan Timoney1-0/+2
2017-09-28Setup ReadTheDocsBrian Freeman1-0/+8
Issue-ID: CCSDK-107 Change-Id: I6f09524c02f899bd4e6df82e6eda8e94518fe8ec Signed-off-by: Brian Freeman <bf1936@att.com>
2017-09-28Merge "Remove redundant casts"Dan Timoney1-31/+31
2017-09-28Remove redundant castssurya-huawei1-31/+31
*Remove unnecessary cast to "CachedDataSource" These unnecessary casting expressions maked the code harder to read and understand *Replace type specification with diamond operator This is to reduce the verbosity of generics code Issue-Id: CCSDK-87 Change-Id: I6cd2f7d16886ffa6cc26e5dd300b8376705d9366 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-28Added @Override annotationshashikanth1-2/+2
Fix major sonar issues in ccsdk/sli/core module https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=MAJOR|rules=squid%3AS1161 Add the "@Override" annotation above this method signature Issue-Id:CCSDK-67 Change-Id: I233be3f88547049a5f78c438e87f2f8c0129df78 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-28Refined DBLIB blueprint configurationRich Tabedzki1-1/+6
Changes made: 1. updated DBLibService definition by registering service on two interfaces: a) javax.sql.DataSource b) org.onap.ccsdk.sli.core.dblib.DbLibService Change-Id: If187b07db83ebca5428c809a83f546d9178a2b7f Issue-ID: CCSDK-102 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2017-09-27Merge "Refinements to core"Dan Timoney4-326/+324
2017-09-27Add unit test for SliStringUtilssurya-huawei2-1/+7
*Made quotedOrNull method public This is done for accessing this in ut *Added a unit test for the SliStringUtils.quotedOrNull() This is done for increasing code coverage Issue-Id: CCSDK-106 Change-Id: I9d74c6645256227b23beded5179fbb28ac3d3c04 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-27Fix major sonar issueshashikanth1-0/+2
Fix major sonar issues in ccsdk/sli/core module https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=MAJOR|rules=squid%3AS1161 Add the "@Override" annotation above this method signature. Issue-Id:CCSDK-67 Change-Id: Ie074574c7bbd2ca394d116e73aa6aab47ad5b8de Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-27Refinements to coreGaurav Agrawal4-326/+324
Changes includes: 1. Simplifying the test cases. 2. Critical Sonar issue fix for MdsalHelper 3. Critical sonar issue fix for SvcLogicServiceImpl 4. Use logger in-built formatting. https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=CRITICAL Change-Id: Ib85637fcd2351970f8d96bf6b855db05cf7d9834 Issue-Id: CCSDK-67 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-27Merge "Use Long.toString instead"Dan Timoney1-1/+1
2017-09-27Merge "Some minor refinements in CCSDK SLI Core module"Dan Timoney2-2/+9
2017-09-27Merge "Remove hardcoded dependency versions"Dan Timoney9-9/+10
2017-09-27Merge "Fixes for SvcLogicActivator"Dan Timoney1-150/+141
2017-09-27Use Long.toString insteadsurya-huawei1-1/+1
Major sonar issue in sli/core module *Using static method to reduce memory and cycles Issue-Id: CCSDK-87 Change-Id: Iaf255892a4bd698934f865a707e54f8e740370ab Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-26Updated DBLIB svc definitionRich Tabedzki1-1/+2
Changes made: 1. updated DBLibService definition by adding javax.sql.DataSource Change-Id: I5dd63a81420f451b0ce9bbbc878d351d62ccd819 Issue-ID: CCSDK-102 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
2017-09-25Some minor refinements in CCSDK SLI Core moduleramu.n2-2/+9
*Remove useless braces while logging exception stack trace *Register all DG nodes in SvcLogicParser Test file Change-Id: I7916bec20e36e1def15c24806da2f7e01e79bf4b Issue-Id: CCSDK-106 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-25Remove hardcoded dependency versionsGaurav Agrawal9-9/+10
Remove the hardcoded junit & common-lang version and rather take from parent pom. Change-Id: Ibc71ff4b86a2fefc89365017f06333776cb2fed3 Issue-Id: CCSDK-105 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-25Fixes for SvcLogicActivatorGaurav Agrawal1-150/+141
1. Convert tabs to 4 spaces. 2. Break lines to be less than 120 characters 3. Remove extraneous spaces/parenthesis & redundant assignments. 4. Use logger built-in string format. 5. Fix critical sonar issues. https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=CRITICAL Change-Id: Idb348f125e92f0e9be30847c41b385411220fd96 Issue-Id: CCSDK-67 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-23Some minor refinements in CCSDK SLI Core moduleramu.n1-16/+15
Fix few Critical/Major sonar issues in CCSDK SLI Core module * Define and throw a dedicated exception instead of using a generic one * Either log or rethrow the exception * Change "try" to a try-with-resources * Remove useless assignment to local variable * Use built-in logger method string formatting instead of string concatination * code indentation Change-Id: I83dc1fb931b8021118e259c722f7dfbc1621dce8 Issue-Id: CCSDK-67 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-22Changes to fix failing utils featurePatrick Brady2-3/+3
Change-Id: I88d30aaf49da78008c62352d398323fbc0d4dd5b Signed-off-by: Patrick Brady <pb071s@att.com> Issue-id: CCSDK-102
2017-09-22Merge "Add "@Override" annotation"Dan Timoney1-0/+2
2017-09-22Merge "Resolved sonar issue."Dan Timoney2-347/+345
2017-09-22Merge "Sql query blocker issue fixed."Dan Timoney2-729/+627
2017-09-22Add "@Override" annotationsurya-huawei1-0/+2
Added @Override annotation before method signature *This is to improve the readability of code Issue-Id: CCSDK-87 Change-Id: I979eb03ec81b9868012e5c16f48b595c8e53e26e Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-21Install sdnc-core utils as karaf packageDan Timoney21-43/+501
New utils jar was added in another change, but wasn't bundled as a karaf feature and was not being installed in container. This broke odlsli docker container. This change wraps that util package as a new feature (sdnc-core-utils). Change-Id: Ie8c1d608e2c67aa1635837bc400cec942761c81c Issue-ID: CCSDK-54 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-21Sql query blocker issue fixed.Bharat saraswal2-729/+627
Rdundant code and complextity of methods reduced. @override annotaiton added. Exception handling and logging impoved. Issue-ID:CCSDK-87 Change-Id: I3907be73a2f6ccdfadeaed79c87705ae7afdb4ab Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
2017-09-21Resolved sonar issue.Bharat saraswal2-347/+345
Related to exception handling. @Override method Redundant code and resulable parameters Issue-Id:CCSDK-87 Change-Id: I82e2aad453edf5cd647c87322fc75b2a56c37566 Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
2017-09-21Merge "Improve code coverage for MdsalHelper"Dan Timoney3-78/+309
2017-09-21Merge "Remove unnecessary parentheses"Dan Timoney1-18/+18
2017-09-21Improve code coverage for MdsalHelperGaurav Agrawal3-78/+309
Changes includes 1. Modified pom to take JUNIT version from parent pom. 2. Added basic testcases for MdsalHelper utilities with test YANG. 3. Made necessary pom additions. Change-Id: Ib46bd9c8a87db33c90aaaf36736d709a7c17cbdd Issue-Id: CCSDK-101 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-21Remove unnecessary parenthesessurya-huawei1-18/+18
*Useless parentheses can sometimes be misleading and hence removed Issue-Id: CCSDK-87 Change-Id: I018d791500a42356296d07d04de45517d061bb7f Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-21Fix Sonar Issues in sli/core moduleBharat saraswal4-262/+249
Few major issues *Remove unused variables To increase code readability *Replace the type specification with the diamond operator *Add the "@Override" annotation above this method signature To increase code readability" Issue-Id: CCSDK-87 Change-Id: I2f0c16a83ab10a0a3e39a2a1d4db3c195ec2bba8 Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>