summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-10-12Remove IOException in method declarationsurya-huawei1-1/+1
*This is done because IOException cannot be thrown from the method and is hence superflous Issue-Id: CCSDK-117 Change-Id: I0712cfbf610f815e76ed33b0039ecb5e3cc7bbbe Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-10-09Add retry to ueb-listenerDan Timoney4-7/+48
Added retry mechanism to ueb-listener to handle case where ueb-listener comes up before DMaap or SDC. Change-Id: I0d96bd1fe4d3d0fdb5e01d9f42304b54bea0a550 Issue-ID: CCSDK-112 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-05Add a test for DummyDmaapConsumersurya-huawei1-0/+26
*Add a unit test in sli/northbound module This is to improve code coverage of DummyDmaapConsumer class Issue-Id: CCSDK-106 Change-Id: Iecd4970a0cd82c94a219b1a2e861fcc3da11f23c Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-10-05Add a test for SdncJsonDmaapConsumersurya-huawei1-0/+22
*Add a unit test in sli/northbound module This Test checks whether an InvalidMessageException is thrown when null is passed to processMsg method Issue-Id: CCSDK-106 Change-Id: I52327377f4582d8c24cef87f0360b977f2f216fc Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-10-04Test TOSCA table insertionDan Timoney7-6/+143
Add code to create TOSCA tables in test driver to test TOSCA table insertion in ueb-listener TOSCA parser test. Change-Id: Ib8c3fcdb25fbdba39b4700553d8c01b684efa384 Issue-ID: CCSDK-102 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-03Improve ueb-listener testsDan Timoney4-2/+87
Use Maria4JDB to improve test coverage of ueb-listener. Change-Id: Ifb88916434bb1b293b4bbd6fae069cd1e88c9d8d Issue-ID: CCSDK-106 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-03Add ueb-listener test caseDan Timoney1-0/+1
Add test case for license-model parsing in ueb-listener. Change-Id: I279e269f7ba3c6f37c09f71b99b20d4e9e661e23 Issue-ID: CCSDK-106 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-03Merge "Improve SDNC coverage"Dan Timoney2-59/+194
2017-10-03Add ueb-listener unit testDan Timoney12-87/+151
Enhance ueb-listener unit test to verify TOSCA parse Change-Id: Iedc675ead3ef69e4fa7151c8c4c500990c0ee6a7 Issue-ID: CCSDK-106 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-03Improve SDNC coverageshashikanth2-59/+194
Added initial test cases for dataChange. Issue-Id: SDNC-101 Change-Id: I112a6695f4d4ca92b78884d25fef12f382598b37 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-10-03Add unit test for dmaap-listenerDan Timoney5-4/+93
Add unit test case for dmaap-listener. Change-Id: I501614016c96d8300bc15cdf1819691f95c467f4 Issue-ID: CCSDK-106 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-03Add unit test for ueb-listenerDan Timoney5-6/+81
Add unit test case for ueb-listener. Change-Id: Ia61f8e5bc0e817aa0f4a042d8e05b02ec9e2013b Issue-ID: CCSDK-106 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-28Merge "Improve SDNC Sonar coverage"Dan Timoney2-54/+208
2017-09-28Merge "Deleted redundant try catch block"Dan Timoney1-12/+5
2017-09-28Setup ReadTheDocsBrian Freeman1-0/+8
Issue-ID: CCSDK-107 Change-Id: I98bc6f3a3827bb1f4e03eb08474b15e26662705f Signed-off-by: Brian Freeman <bf1936@att.com>
2017-09-27Improve SDNC Sonar coverageshashikanth2-54/+208
Added initial test cases for ASDC-APIs Issue-Id: SDNC-101 Change-Id: Iad8be979e39099e4ece8210dbd5d2c9c64b60990 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-26Deleted redundant try catch blockshashikanth1-12/+5
Extract this nested try block into a separate method. https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=MAJOR|rules=squid%3AS1141 Issue-Id: CCSDK-87 Change-Id: I989791d876b5a199f75983ba5137770f80995ef1 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-25Fix some sonar issues in sli/northboundsurya-huawei1-6/+6
*Replace type specification with diamond operator This is done to reduce the verbosity of generics code *Replace ("") with ('') in String.lastIndexOf() This is more efficient for single character *Remove temp variable which is immediately returned New variable is not necessary as the caller cannot see this Issue-Id: CCSDK-87 Change-Id: I353652de723a624935d819b2bc817b4907af98ed Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-22Merge "Fix sli dependency"Dan Timoney2-2/+2
2017-09-22Remove unnecessary constructssurya-huawei1-5/+4
*Remove unused imports *Remove useless paranthesis This is done as sometimes they can be misleading *Replace type specification with diamond operator(<>) This is done to reduce verbosity of generics code Issue-Id: CCSDK-87 Change-Id: Ic356859939fe40cecec2e65c96d79cd6a655787e Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-21Resolved below sonar issues.Bharat saraswal4-475/+475
Method complextity. Redudant code and varibales. Exception handling. Refacting of code. Issue-Id:CCSDK-87 Change-Id: I757c6a6d3c403f81f725ad97a7759225d0709468 Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
2017-09-21Use Integer.toString for type conversionsurya-huawei1-4/+3
*Used Integer.toString instead of implicit type conversion This is done to make use of static and reduce cycles *Removed one unused import *Removed unnecessary parantheses Sometimes useless parantheses can be misleading hence removed Issue-Id: CCSDK-87 Change-Id: I23f56cb7c5a6dafa79f64d5cd8faa0994f0ff288 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-20Merge "Some minor refinements in CCSDK SLI Northbound"Dan Timoney3-111/+88
2017-09-20Some minor refinements in CCSDK SLI Northboundramu.n3-113/+90
Fix few Critical/Major sonar issues in CCSDK SLI Northbound module * Remove useless parentheses * Remove useless assignment to local variable * Use built-in logger method string formatting instead of string concatination * code indentation * Replace for loop with foreach Change-Id: I9a2e3345f23feb2d96045ac714d8acc528de464b Issue-Id: CCSDK-67 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-20Remove useless assigment to local variablessurya-huawei3-6/+5
*Removed dead stores This is done to avoid waste of resources Issue-Id: CCSDK-87 Change-Id: Ie36255c6583792e2535000ee1bd5b2a3018632ff Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-19Merge "Fix critical sonar issues"Dan Timoney5-7/+6
2017-09-19Fix sli dependencyBrian Freeman2-2/+2
Issue-ID: SDNC-86 Change-Id: I91280ab218e2f1f25ab381eaa9f94dce8f2abdc9 Signed-off-by: Brian Freeman <bf1936@att.com>
2017-09-19Fix critical sonar issuesGaurav Agrawal5-7/+6
Fix critical sonar issues in CCSDK SLI Northbound by either logging or rethrowing the exception https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=CRITICAL Change-Id: I718f13b5801ea9d69b5c36f75b5387a0ae59cc6a Issue-Id: CCSDK-67 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-19Fix Sonar Issuessurya-huawei1-17/+5
few major issues in sli/northbound *Remove unused imports *Iterate over the "entrySet" instead of the "keySet" *Replace the type specification with the diamond operator ("<>") Issue-Id: CCSDK-87 Signed-off-by: surya-huawei <a.u.surya@huawei.com> Change-Id: Ib2a6f97d3de759b937c1e2acd2e39312e88ad10b
2017-09-18Merge "Replace deprecated APIs with newer one"Dan Timoney3-6/+11
2017-09-18Replace deprecated API with newer oneGaurav Agrawal2-12/+9
Replace following deprecated API 1) NotificationProviderService replaced with NotificationPublishService 2) InstanceIdentifier<T> toInstance() replace with build() Change-Id: I50195bf123052270edf3fd9f74af00262a01e650 Issue-Id: CCSDK-93 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-18Replace deprecated APIs with newer oneGaurav Agrawal3-6/+11
Replace following deprecated API 1) NotificationProviderService replaced with NotificationPublishService Change-Id: I3d5117e63083ce77553feb3d3f6d6265576da646 Issue-Id: CCSDK-93 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-17Fix Sonar issue in sli/northbound modulesurya-huawei1-1/+1
One major issue * move string literals to left side of string comparison Issue-Id: CCSDK-87 Change-Id: Ibd1146a8a12dccc56fb620fe5830efb545ac39a1 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-14Use oparent-odlparent in sli/northboundDan Timoney1-1/+1
Update sli/northbound to use oparent-odlparent, used by latest version of ccsdk odlparent-carbon-sr1 parent. Change-Id: I77c4452d4af04d3dc4cd0892a9a0dab6c77016bc Issue-ID: CCSDK-43 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-14Fix Sonar issuessurya-huawei1-7/+7
few major issues in sli/northbound module Issue-Id: CCSDK-87 Change-Id: I2c1a8b41266aae6941c5f2fdbb8b08ea91dde6ec Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-12Fix SDNC service registrationRyan Goulding11-325/+68
Move the northbound to utilize Aries Blueprint instead of ODL's configuration subsystem Change-Id: I7388391d40912136176bb28b817157676f71557d Issue-Id: SDNC-54 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-11Merge "Fix few Blocker sonar issues"Dan Timoney1-14/+4
2017-09-08Cleanup project's name in SonarJessica Wagantall1-1/+1
The name parameter in the root pom.xml should match the project name in gerrit to reflect consistency in Sonar. Change-Id: Iecfd1bf6a7937437728e5cf136b63c896da49b44 Issue-id: CIMAN-65 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2017-09-08Fix few Blocker sonar issuesGaurav Agrawal1-14/+4
Fix few Blocker sonar issues in CCSDK SLI Northbound https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=BLOCKER Change-Id: I7229c7e2a0dabc0ff789b91ae413b9a15ef3cbad Issue-Id: CCSDK-67 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-08Fix few Blocker sonar issuesGaurav Agrawal2-15/+3
Fix few Blocker sonar issues in CCSDK SLI Northbound https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=BLOCKER Change-Id: I8a2f2e9f3bc5bc5c007076e42f77fbf5da1304ac Issue-Id: CCSDK-67 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-07Fix SDNC service registrationRyan Goulding13-401/+73
This change converts AsdcApiProvider and AsdcApiSliClient to utilize Aries Blueprint for service instantiation instead of the ODL Config Subsystem. Change-Id: I5eaebe4c6e5b33fc8beb20b2cfe9acb6e8b6d808 Issue-Id: SDNC-54 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-06Fix unimplemented createInstanceDan Timoney2-8/+36
The createInstance() method in the provider yang-generated Module class has a default implementation that throws an UnsupportedOperationException. Replaced default implementation with correct code to create an instance of the asdcApi and dataChange provider classes. Change-Id: I1f2b199702a9094f6808ec077d6752c4c5c0c30d Issue-ID: CCSDK-77 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-05Fix staging variables for ccsdk/sli/northboundMarcus G K Williams1-3/+3
Issue-Id: CCSDK-67 Change-Id: Ib5fe6cc5cb46e9d25cf66b6ab30e0d8b8654c426 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-09-01Enable surefire unit testingMarcus G K Williams1-1/+1
Issue-Id: CCSDK-67 Change-Id: If05df01e829a7a12ef00a1d778d918664635a48a Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-08-29Cleanup artifactId for ccsdk/sli/northboundDan Timoney5-5/+5
ArtifactId for ccsdk/sli/northbound pom.xml should not be identical to that for sdnc/northbound, otherwise import to Eclipse of both will be confusing. Updated parent artifactId in module pom.xmls under ccsdk/sli/northbound Change-Id: Ie1e1b7a1cd6bb7442a27ca083f37539cbc0497fb Issue-ID: CCSDK-70 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-25Fix to start script and annotation dependencyBrian Freeman2-1/+6
Change-Id: I38d4ffad440ea5866a398b8a6a7244d8bf156138 Signed-off-by: Brian Freeman <bf1936@att.com> Issue-Id: SDNC-67
2017-08-15Port sli/northbound to CarbonDan Timoney62-131/+129
Updated sli/northbound repo to compile against OpenDaylight Carbon SR1 release Change-Id: I6aec68cf436e11f5fd5b7094eb5616536bead44f Issue-ID: CCSDK-25 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-15Refactor rest of sli/northboundDan Timoney20-373/+42
Update remainder of sli/northbound to replace references to openECOMP with references to ONAP Change-Id: I2c321c9ec3f3138f3b7377ce1e0a8ff7e8f29bcc Issue-ID: CCSDK-25 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-15Refactor dataChangeDan Timoney9-40/+24
Update dataChange to replace references to openECOMP with references to ONAP Change-Id: I2d495dbc13e6dd38e0c975070969b07e796eb82f Issue-ID: CCSDK-25 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-14Refactor asdcApiDan Timoney12-62/+44
Refactor asdcApi to replace openecomp references with onap Change-Id: Ic0d61ca75219a57331ba61908fba942a1c0dce7b Issue-ID: CCSDK-25 Signed-off-by: Dan Timoney <dtimoney@att.com>