1 files changed, 65 insertions, 46 deletions
diff --git a/adaptors/ansible-adapter/ansible-adapter-bundle/src/test/java/org/onap/ccsdk/adapter/ansible/model/TestAnsibleAdapter.java b/adaptors/ansible-adapter/ansible-adapter-bundle/src/test/java/org/onap/ccsdk/adapter/ansible/model/TestAnsibleAdapter.java
index 6fc90d012..3e1929bf5 100644
--- a/adaptors/ansible-adapter/ansible-adapter-bundle/src/test/java/org/onap/ccsdk/adapter/ansible/model/TestAnsibleAdapter.java
+++ b/adaptors/ansible-adapter/ansible-adapter-bundle/src/test/java/org/onap/ccsdk/adapter/ansible/model/TestAnsibleAdapter.java
@@ -1,11 +1,9 @@
 /*-
  * ============LICENSE_START=======================================================
- * ONAP : APPC
+ * ONAP : SLI
  * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2021 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
- * Copyright (C) 2017 Amdocs
- * =============================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -21,61 +19,82 @@
  * ECOMP is a trademark and service mark of AT&T Intellectual Property.
  * ============LICENSE_END=========================================================
  */
-package org.onap.ccsdk.adapter.ansible.model;
 
-import static org.junit.Assert.assertNotNull;
+package org.onap.ccsdk.adapter.ansible.model;
 
-import java.util.HashMap;
-import java.util.Map;
-import java.lang.reflect.*;
-import org.junit.After;
-import org.junit.Before;
+import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import org.json.JSONObject;
 import org.junit.Test;
 import org.onap.ccsdk.sli.adaptors.ansible.model.AnsibleMessageParser;
 import org.onap.ccsdk.sli.adaptors.ansible.model.AnsibleResult;
 import org.onap.ccsdk.sli.adaptors.ansible.model.AnsibleServerEmulator;
 
-public class TestAnsibleAdapter {
+import static org.junit.Assert.assertNotNull;
 
-    private Class[] parameterTypes;
-    private AnsibleMessageParser ansibleMessageParser;
-    private Method m;
-    private String name;
+public class TestAnsibleAdapter {
 
     @Test
-    public void callPrivateConstructorsMethodsForCodeCoverage() throws SecurityException, NoSuchMethodException, IllegalArgumentException, InstantiationException, IllegalAccessException, InvocationTargetException {
+    public void callPrivateConstructorsMethodsForCodeCoverage()
+            throws SecurityException, NoSuchMethodException, IllegalArgumentException, InstantiationException, IllegalAccessException,
+            InvocationTargetException {
 
-          /* test constructors */
-          Class<?>[] classesOne = {AnsibleMessageParser.class};
-          for(Class<?> clazz : classesOne) {
-                Constructor<?> constructor = clazz.getDeclaredConstructor();
-                name = constructor.getName();
-                constructor.setAccessible(true);
-                assertNotNull(constructor.newInstance());
-          }
-          Class<?>[] classesTwo = {AnsibleServerEmulator.class};
-          for(Class<?> clazz : classesTwo) {
-                Constructor<?> constructor = clazz.getDeclaredConstructor();
-                name = constructor.getName();
-                constructor.setAccessible(true);
-                assertNotNull(constructor.newInstance());
-          }
-          Class<?>[] classesThree = {AnsibleResult.class};
-          for(Class<?> clazz : classesThree) {
-                Constructor<?> constructor = clazz.getDeclaredConstructor();
-                name = constructor.getName();
-                constructor.setAccessible(true);
-                assertNotNull(constructor.newInstance());
-          }
+        /* test constructors */
+        Class<?>[] classesOne = {AnsibleMessageParser.class};
+        for (Class<?> clazz : classesOne) {
+            Constructor<?> constructor = clazz.getDeclaredConstructor();
+            constructor.setAccessible(true);
+            assertNotNull(constructor.newInstance());
+        }
+        Class<?>[] classesTwo = {AnsibleServerEmulator.class};
+        for (Class<?> clazz : classesTwo) {
+            Constructor<?> constructor = clazz.getDeclaredConstructor();
+            constructor.setAccessible(true);
+            assertNotNull(constructor.newInstance());
+        }
+        Class<?>[] classesThree = {AnsibleResult.class};
+        for (Class<?> clazz : classesThree) {
+            Constructor<?> constructor = clazz.getDeclaredConstructor();
+            constructor.setAccessible(true);
+            assertNotNull(constructor.newInstance());
+        }
 
-          /* test methods */
-          ansibleMessageParser = new AnsibleMessageParser();
-          parameterTypes = new Class[1];
-          parameterTypes[0] = java.lang.String.class;
+        /* test methods */
+        AnsibleMessageParser ansibleMessageParser = new AnsibleMessageParser();
+        Class<?>[] parameterTypes = new Class[1];
+        parameterTypes[0] = java.lang.String.class;
 
-          m = ansibleMessageParser.getClass().getDeclaredMethod("getFilePayload", parameterTypes);
-          m.setAccessible(true);
-          assertNotNull(m.invoke(ansibleMessageParser,"{\"test\": test}"));
+        Method m = ansibleMessageParser.getClass().getDeclaredMethod("getFilePayload", parameterTypes);
+        m.setAccessible(true);
+        assertNotNull(m.invoke(ansibleMessageParser, "{\"test\": test}"));
 
+        // test logging-suppression for an invalid host value (Fortify Log Forging fix)
+        String input = "{"
+                       + "  \"Results\": {"
+                       + "    \"192.168.1.10\": {"
+                       + "      \"Id\": \"101\","
+                       + "      \"StatusCode\": 200,"
+                       + "      \"StatusMessage\": \"SUCCESS\""
+                       + "    },"
+                       + "    \"192%168%1%10\": {"
+                       + "      \"Id\": \"102\","
+                       + "      \"StatusCode\": 200,"
+                       + "      \"StatusMessage\": \"SUCCESS\""
+                       + "    },"
+                       + "    \"server-dev.att.com\": {"
+                       + "      \"Id\": \"103\","
+                       + "      \"StatusCode\": 200,"
+                       + "      \"StatusMessage\": \"SUCCESS\""
+                       + "    }"
+                       + "  },"
+                       + "  \"StatusCode\": 200,"
+                       + "  \"StatusMessage\": \"FINISHED\""
+                       + "}";
+        Method m2 = ansibleMessageParser.getClass().getDeclaredMethod("parseGetResponseNested", AnsibleResult.class, JSONObject.class);
+        m2.setAccessible(true);
+        m2.invoke(ansibleMessageParser, new AnsibleResult(), new JSONObject(input));
     }
+
 }
+