Age | Commit message (Collapse) | Author | Files | Lines |
|
*Add a unit test for SliStringUtils
This is to test substring method of SliStringUtils
and improve code coverage
Issue-Id: CCSDK-106
Change-Id: I73c5af3b036a92fdcb1d3d1be7eb0b3abc44fd5a
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
|
|
*Made quotedOrNull method public
This is done for accessing this in ut
*Added a unit test for the SliStringUtils.quotedOrNull()
This is done for increasing code coverage
Issue-Id: CCSDK-106
Change-Id: I9d74c6645256227b23beded5179fbb28ac3d3c04
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
Fix major sonar issues in ccsdk/sli/core module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=MAJOR|rules=squid%3AS1161
Add the "@Override" annotation above this method signature.
Issue-Id:CCSDK-67
Change-Id: Ie074574c7bbd2ca394d116e73aa6aab47ad5b8de
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
|
|
Remove the hardcoded junit & common-lang version and rather take from parent pom.
Change-Id: Ibc71ff4b86a2fefc89365017f06333776cb2fed3
Issue-Id: CCSDK-105
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
|
|
Remove lingering mysql dependencies in sli/core, which prevented odlsli
container from starting up clean. Note: tested this using bareodl container
and verified that these changes install clean AFTER changing incorrect
driver property name in dblib.properties. This patch is fine, but a second
patch to ccsdk/distribution is needed to fix that property file.
Change-Id: I6a900d1c29998867bfbae29d5e113c4e392a8bb9
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Correct mariadb JDBC connector artifactId should be mariadb-java-client,
not mariadb-connector-java
Change-Id: If58a33a1ef22d47e1d5c138bad164b0ad89219eb
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Update sli/core (including dblib, notably) to use mariadb-connector
for any jUnit tests. Update Import-Package in dblib provider pom.xml
to import org.mariadb.jdbc so that org.mariadb.jdbc.Driver will
be resolved
Change-Id: I39dfe2cafb955ba1bf05b0ecdb0212d766fcc96c
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
The Java programming language assigns certain defaults for methods
and constants defined in interfaces. This change removes the
unnecessary redundant modifiers appropriately.
For example:
* interface methods are public by default
* interface constants are public by default
* interface methods are abstract unless "default" is specifically
used (as of JDK8+).
This is really just to get rid of annoying warnings present in
IDE(s).
Issue-Id: SDNC-79
Change-Id: I2e6b3e4fa02bad1beee2cbb49d3766722eff1ba0
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
|
|
|
|
Code sanitation-- remove unused imports.
Issue-Id: SDNC-79
Change-Id: I5306a9b90f302086459fcac98d04f541ba7c79a4
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
few major issues in sli/core module
Issue-Id: CCSDK-87
Change-Id: I1fb86f084d270906dcf61d33701da54a82f2c3a4
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
few major issues in sli/core module
Issue-Id: CCSDK-87
Change-Id: Id563cd2fb31f477f96e14b180501feeb37fb24a7
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
Remove cast to DBResourceManager, which no longer works after
DbLibService is advertised via Aries Blueprint and which is no
longer needed after DbLibService interface exposes getConnection()
method.
Updated version number - seems like an older 0.1.1-SNAPSHOT without
DbLibService change is being used, so trying to see if bumping version will
help.
Change-Id: Ia411d1514bca396cc052f4f16eda6c79e0d13648
Issue-ID: CCSDK-86
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Sonarqube report for SliPluginUtils identified some critical bugs. This fix will address these bugs.
Issue-Id: CCSDK-81
Change-Id: I9a1738c02f1364b17a0895b94f26c373e4a19f1f
Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
|
|
Fix the aaaUserName constant.
Change-Id: I4d9272e476874f6a7747970bc67f8f88ff803f21
Issue-Id: SDNC-54
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
|
|
Issue-Id: CCSDK-67
Change-Id: I3d03ff1a3e312edd4af7ab69508760d2fe49be78
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
|
|
sliPluginUtils was using a BundleActivator for Service Instantiation, which
is prone to heisenbugs due to indeterminate service instantiation logic. This
removes the BundleActivator and instantiates services using blueprint.
Since dme2.properties are parsed using Properties instead of using a
ManagedService, the decision was to just keep them immutable.
Future work may involve making instance variables private in DME2, since
currently Dme2Test performs direct member access on DME2 instance variables
which is considered bad practices (violates encapsulation).
Issue-Id: SDNC-54
Change-Id: Ib1155565e04e9a95d222bc4028a0845d9d81bd82
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
Behavior observed in the odlsli docker container suggests that it might
be picking up an old build of 0.1.0-SNAPSHOT version of sli/core. We
have observed this problem before due to issues with the Nexus staging
plugin. This change bumps the version of sli/core to 0.1.1-SNAPSHOT and
comments out the staging plugin from the sli/core pom.xml to make sure
that the current build is picked up. There will be a corresponding
change in ccsdk/distribution to change which version of sli/core is used
in the odlsli container
Change-Id: Ie3c2b4ff66191748df14240a69a7d461fc0d4639
Issue-ID: CCSDK-69
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
ArtifactId for ccsdk/sli/core pom.xml should not be identical to that for
sdnc/core, otherwise import to Eclipse of both will be confusing.
Update parent tag in each module pom under ccsdk/sli/core to new
artifactId
Change-Id: Ia78a11dc4f82dfda8fd863167daa8e8f4951b6f5
Issue-ID: CCSDK-70
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Licence headers were accidentally updated incorrectly by previous update.
This commit restores the license headers for seed code to the wording from
the original seed code
Change-Id: Ie73bc836079be7eb1b310c472ee39b58ffeaa01c
Issue-ID: CCSDK-31
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Update sli/core to compile against OpenDaylight Carbon SR1
Change-Id: Ibb4a3a4cfa64f0539b520f56f11d7bf1fce62357
Issue-ID: CCSDK-23
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Update Java package names from org.openecomp to org.onap
Issue: CCSDK-11
Change-Id: I7e318565197b5806f6a7d7131bd3118fbe9cf8e0
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Changed openecomp references in dblib, filters and sli to onap. Note: these
must be committed together to get a clean compile.
Issue: CCSDK-11
Change-Id: Ibe0f64fb20f3ae9cdda2f7ea969ca722bbde0d15
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Update groupIds from org.openecomp.sdnc.core to org.onap.ccsdk.sli.core
Issue: CCSDK-11
Change-Id: I0646adab34a88244ab10dc0d2775643ce2bb974d
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Add seed code for sli/core repository
Issue: CCSDK-6
Change-Id: Iaeb54c6135a94a6ffec0c7fd96505d72d18aeb00
Signed-off-by: Dan Timoney <dtimoney@att.com>
|