aboutsummaryrefslogtreecommitdiffstats
path: root/sli/common/src
AgeCommit message (Collapse)AuthorFilesLines
2018-09-12SvcLogicLoader ImprovementsSmokowski, Kevin (ks6305)5-60/+44
restore storing md5sum and add bulkActivate Change-Id: I27ea86c667d61f435bd2f0a77934d00db57bc218 Issue-ID: CCSDK-473 Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
2018-08-02add null check to format stringSmokowski, Kevin (ks6305)2-5/+14
add null check to format string Change-Id: If82f751ec679189620e02fafdcd2e1af9258268f Issue-ID: CCSDK-424 Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
2018-07-25Fix sonar issuesParshad Patel1-1/+1
Fix sonar issues in ccsdk/sli/core Issue-ID: CCSDK-332 Change-Id: I2aee69cf410d8f9cb63f3a22aeb793a99e27d2c7 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-07-06sonar issue fixONAP1-2/+2
Issue-ID: CCSDK-332 Change-Id: Iec65b1ff600518b04ab13fb3508827864074a31b Signed-off-by: ONAP <arind.mondal@samsung.com>
2018-05-03TestSvcLogicLoader for windowsSmokowski, Kevin (ks6305)1-4/+4
TestSvcLogicLoader fails when run against a machine running windows Change-Id: I3687ac21c50cde10b1e8a0ed816b67d48c5e77f9 Issue-ID: CCSDK-266 Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
2018-03-27Add unit tests for sliTimoney, Dan (dt5972)15-25/+604
Added unit tests for ccsdk/sli/core/sli Change-Id: I0d2408c43b9e56a78f3e01e87985aedb6cad5953 Issue-ID: CCSDK-213 Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
2018-03-07re-use parser instanceSmokowski, Kevin (ks6305)2-38/+50
add an additional logging statement and save memory Change-Id: Idc8bdefb00ac61317cc38848dce670d76b6d89f7 Issue-ID: CCSDK-204 Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
2018-03-02Favor interfacesKevin Smokowski2-109/+105
Favor using interfaces over concrete implementations Change-Id: Ie7541eeefa69671cc7ed39fba37fdd2e24380770 Issue-ID: CCSDK-189 Signed-off-by: Kevin Smokowski <ks6305@att.com> Favor interfaces Favor using interfaces over concrete implementations Change-Id: Ie3b71833c0f31f67288430c25ca31ca07c0449e0 Issue-ID: CCSDK-189 Signed-off-by: Kevin Smokowski <ks6305@att.com>
2018-02-09Reset MDC after invoking nodeKevin Smokowski1-0/+9
collapse get node into a common metho, reset MDC right before getting next node for certain executor Change-Id: I85b1cf0dfd595deee42dc93f4095ecbc6c831998 Issue-ID: CCSDK-187 Signed-off-by: Kevin Smokowski <ks6305@att.com>
2018-02-09Upgrade sli/core to NitrogenDan Timoney1-14/+28
Use Apache derby for dblib SingleFeatureTest Change-Id: I6b41f7ede1a98b33824fceea9100e75c1ce8dda4 Issue-ID: CCSDK-175 Signed-off-by: Dan Timoney <dtimoney@att.com> Generalization of CCSDK core/utils framework Changes made: * Created generalized version of core/utils/dblib as core/utils/common * Deprecated core/utils/dblib package Change-Id: I0992c43910278fbe254674d1e39d7e4fcad0a592 Issue-ID: CCSDK-168 Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com> Use Apache derby for dblib test Use Apache derby for dblib SingleFeatureTest Change-Id: Ie497557f162e203fa5c5c82c17ddc55ba0c11b38 Issue-ID: CCSDK-175 Signed-off-by: Dan Timoney <dtimoney@att.com>
2018-02-09Iso8601 format fixKevin Smokowski1-1/+1
fix format in method asIso8601 in metric logger Change-Id: I50de2397231ff8b298e3a75b3220315c255c26db Issue-ID: CCSDK-186 Signed-off-by: Kevin Smokowski <ks6305@att.com>
2017-12-18Service logic logging fixesDan Timoney2-7/+2
Update MetricLogger class to properly escape characters within body of response. Also, used SvcLogicGraph.toString method to simplify logging call. Change-Id: I6bcaaf3c67032df041c6d37372016990ff0199d3 Issue-ID: CCSDK-152 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-12-05SLI parser improvementsDan Timoney11-1128/+1167
Update SLI parser to remove validation based on NODE_TYPE table, which is no longer needed (was introduced prior to use of XSD schema validation). Also, use checksums to avoid needless recompilation if version being loaded already exists in database. Change-Id: Idfcba94de8fb71b17d5e0c5e69e04dee266988b1 Issue-ID: CCSDK-152 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-25Add unit test case for PrintYangToPropDan Timoney1-0/+69
Add junit testing for PrintYangToProp Change-Id: I8c377bb51c812ea9ead32d8e9d5ef871157162a8 Issue-ID: CCSDK-129 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-10-18added code to convert yang to propertiesSheshi Chinthakayala1-0/+1367
this code is used by dgbuilder to convert the yang to context property names Change-Id: Ib53f57df6e8bd32a3a1b7ba6fa7854497c1f5c6c Issue-ID: SDNC-81 Signed-off-by: Sheshi Chinthakayala <sc2914@att.com>
2017-09-28Added @Override annotationshashikanth1-2/+2
Fix major sonar issues in ccsdk/sli/core module https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=MAJOR|rules=squid%3AS1161 Add the "@Override" annotation above this method signature Issue-Id:CCSDK-67 Change-Id: I233be3f88547049a5f78c438e87f2f8c0129df78 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-27Refinements to coreGaurav Agrawal1-113/+78
Changes includes: 1. Simplifying the test cases. 2. Critical Sonar issue fix for MdsalHelper 3. Critical sonar issue fix for SvcLogicServiceImpl 4. Use logger in-built formatting. https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=CRITICAL Change-Id: Ib85637fcd2351970f8d96bf6b855db05cf7d9834 Issue-Id: CCSDK-67 Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
2017-09-27Merge "Use Long.toString instead"Dan Timoney1-1/+1
2017-09-27Use Long.toString insteadsurya-huawei1-1/+1
Major sonar issue in sli/core module *Using static method to reduce memory and cycles Issue-Id: CCSDK-87 Change-Id: Iaf255892a4bd698934f865a707e54f8e740370ab Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-25Some minor refinements in CCSDK SLI Core moduleramu.n2-2/+9
*Remove useless braces while logging exception stack trace *Register all DG nodes in SvcLogicParser Test file Change-Id: I7916bec20e36e1def15c24806da2f7e01e79bf4b Issue-Id: CCSDK-106 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-21Remove unnecessary parenthesessurya-huawei1-18/+18
*Useless parentheses can sometimes be misleading and hence removed Issue-Id: CCSDK-87 Change-Id: I018d791500a42356296d07d04de45517d061bb7f Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-20Fix few Major sonar issuesramu.n1-45/+44
Fix few Major sonar issues in CCSDK SLI Core module * Remove useless assignment to local variable * Use built-in logger method string formatting instead of string concatination * code indentation Change-Id: I20fc9d8f4c510f6169e6f989c6f5595371e5f2dd Issue-Id: CCSDK-67 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-19Merge "Use Junit4 instead of Junit3 in sli/common"Dan Timoney1-53/+84
2017-09-19Remove mysql dependencies in sli/coreDan Timoney1-1/+1
Remove lingering mysql dependencies in sli/core, which prevented odlsli container from starting up clean. Note: tested this using bareodl container and verified that these changes install clean AFTER changing incorrect driver property name in dblib.properties. This patch is fine, but a second patch to ccsdk/distribution is needed to fix that property file. Change-Id: I6a900d1c29998867bfbae29d5e113c4e392a8bb9 Issue-ID: CCSDK-95 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-20Use Junit4 instead of Junit3 in sli/commonramu.n1-53/+84
Modified sli/common pom.xml file to take Junit version from parent pom file and modified one Testfile as per Junit4 Change-Id: Iee4397125d9873def60c77ba8be5d541e0df62fa Issue-Id: CCSDK-98 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-19Merge "Fix few Major sonar issues"Dan Timoney1-297/+314
2017-09-19Merge "Fix few Major sonar issues"Dan Timoney3-56/+56
2017-09-18Fix few Major sonar issuesramu.n1-297/+314
Fix few Major sonar issues in CCSDK SLI Core module * Use logger method's built-in string formatting instead of string concatination * code formatting * Use Integer.toString() instead of concatenating empty string "" to a primitive Change-Id: I5a15c9b0049b71d7b0fa06c6791abe766a035c46 Issue-Id: CCSDK-67 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-18Fix few Major sonar issuesramu.n3-56/+56
Fix few Major sonar issues in CCSDK SLI Core module * Remove useless parentheses * Remove useless assignment to local variable * Use logger method instead of string formatting Change-Id: Ie9958d0bc4e754c36c127d465a1953160c2c3e2b Issue-Id: CCSDK-67 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-18Fix few Major sonar issuesramu.n2-181/+128
Fix few Major sonar issues in CCSDK SLI Core module * Remove useless parentheses * Either log or rethrow the exception * Add the "@Override" annotation * Change "try" to a try-with-resources * Replace duplicate string literals with constants Change-Id: If52163220d7231ae42ef42b0313d56435f6745e1 Issue-Id: CCSDK-67 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-16Merge "Fix few Major sonar issues"Dan Timoney1-94/+41
2017-09-15Merge "Fix Blocker/Critical sonar issues"Dan Timoney1-13/+12
2017-09-15Fix few Major sonar issuesramu.n1-94/+41
Fix few Major sonar issues in CCSDK SLI Core module * Remove useless parentheses * Either log or rethrow the exception * Remove unused variables * Add the "@Override" annotation * Change "try" to a try-with-resources Change-Id: I64c4bd3c746bb2f226f4f58c39f28a8b2d178953 Issue-Id: CCSDK-67 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-14Merge "Fix few sonar issues"Dan Timoney2-66/+93
2017-09-14Fix few sonar issuesramu.n2-66/+93
Fix few sonar issues in CCSDK SLI Core module Change-Id: I0e2454f7e23e73087ac42880c5e0b1e4c089dde8 Issue-Id: CCSDK-67 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-14Fix Blocker/Critical sonar issuesshashikanth1-13/+12
Fix Blocker/Critical sonar issues in vnfapi module https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.core%3Asdnc-core#resolved=false|severities=BLOCKER Issue-Id: CCSDK-67 Change-Id: Ie2ace1bc30bbb50d2b6f25a56e716c7a952e7ea0 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-13Use oparent-odlparent in sli/coreDan Timoney2-33/+57
Update sli/core to use oparent-odlparent. To prevent verify builds from failing due to unit test errors, also changed unit tests that require database access to use MariaDB4j to start up a local MariaDB database. Change-Id: I928b7e1e83bdb328ca9e0785c8b81f67f982eeda Issue-ID: CCSDK-43 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-13Remove unused imports in java filesRyan Goulding8-30/+5
Code sanitation-- remove unused imports. Issue-Id: SDNC-79 Change-Id: I5306a9b90f302086459fcac98d04f541ba7c79a4 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-11Remove cast to DBResourceManagerDan Timoney1-2/+2
Remove cast to DBResourceManager, which no longer works after DbLibService is advertised via Aries Blueprint and which is no longer needed after DbLibService interface exposes getConnection() method. Updated version number - seems like an older 0.1.1-SNAPSHOT without DbLibService change is being used, so trying to see if bumping version will help. Change-Id: Ia411d1514bca396cc052f4f16eda6c79e0d13648 Issue-ID: CCSDK-86 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-07Fix sonar blocker issues in ccsdk/core moduleArun S. Yerra1-4/+18
Sonarqube report for CCSDK core identfied some blcoker issues. This fix addresses those bugs. Issue-Id: CCSDK-84 Change-Id: Ie6ff19b7b0815a129f9809243e8e3eb0a64144ab Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
2017-09-07Update dblib service nameDan Timoney1-3/+3
Update name of dblib service to match the DbLibService interface name rather than implemtation class (previous advertised name). Change-Id: I999298c089e75fe3bd467241a473abcc04138852 Issue-ID: CCSDK-83 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-06Fix service registration for SDNCRyan Goulding1-1/+1
Addresses the inherit race conditions associated with the BundleActivator abstraction. From lessons learned in OpenDaylight project, dependency injection and service injection via Aries Blueprint is faster, more deterministic, and has better error messaging than using BundleActivator(s). This change addresses several aspects: 1) DBLIBResourceActivator is changed to DBLIBResourceProvider. This was done in order to imply that this is no longer an Activator or subclass of an Activator. The class is a POJO. 2) DBLIBResourceProvider is split from a single monolithic method into several more manageable and better documented methods. 3) Documentation surrounding the resolution of the DB properties is added so that a developer can more easily identify the strategy (priority) used for resolving properties. 4) dblib-blueprint.xml is added. This is used to register the configuration bean (DBLIBResourceProvider), and pass it as an argument to the actual Service (DBLIBResourceManager). 5) Tests are added to test the functionality and resolution of the properties file loading. Issue-Id: SDNC-54 Change-Id: Ie9d5fb423ae7a67e9aec026c78321537399cc308 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-08-28Change 2 sli/core unit tests to int. testsMarcus G K Williams1-1/+1
Change SvcLogicGraphExecutorTest and SvcLogicParserTest to IT Tests because they require outside dependencies (sql database). This change enables running jobs without skipping tests and futher enables SONAR scans of unit tests. Issue-Id: CCSDK-67 Change-Id: I74184b2f2d8cb5fcc7b065c3e2e859b85dd1630b Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-08-15Fix license headersDan Timoney41-41/+82
Licence headers were accidentally updated incorrectly by previous update. This commit restores the license headers for seed code to the wording from the original seed code Change-Id: Ie73bc836079be7eb1b310c472ee39b58ffeaa01c Issue-ID: CCSDK-31 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-11Compile against CarbonDan Timoney7-14/+14
Update sli/core to compile against OpenDaylight Carbon SR1 Change-Id: Ibb4a3a4cfa64f0539b520f56f11d7bf1fce62357 Issue-ID: CCSDK-23 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-11Remove remaining references to openecompDan Timoney15-215/+214
Remove remaining references to openecomp from properties and sample files Change-Id: I985bae5e80ae130ffb512c9574f13172252bf6f8 Issue-ID: CCSDK-11 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-01Refactor dblibDan Timoney42-194/+154
Changed openecomp references in dblib, filters and sli to onap. Note: these must be committed together to get a clean compile. Issue: CCSDK-11 Change-Id: Ibe0f64fb20f3ae9cdda2f7ea969ca722bbde0d15 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-07-20Populate seed codeDan Timoney50-0/+8151
Add seed code for sli/core repository Issue: CCSDK-6 Change-Id: Iaeb54c6135a94a6ffec0c7fd96505d72d18aeb00 Signed-off-by: Dan Timoney <dtimoney@att.com>