Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
This change isn't too big; it mainly just attempts to clean up the
BaseDBConfiguration class using best practices. For example:
* documentation is added surrounding public methods, public constants,
protected variables, and class headers.
* code logic for parsing "optional" integer properties is abstracted
into a separate private static function, which returns a default
value if the given input property cannot be parsed or is not present.
* public functions where the NumberFormatException RuntimeException
might be thrown have the appriorate "throws" modifier added to their
function signatures to indicate that the consumer is responsible for
exception handling.
* constants are extracted in place of "magic numbers"
This is really just code sanitation work.
Change-Id: Ifaf092e10b17f54c7cce0a888aa49bfe8377cdd3
Issue-Id: SDNC-79
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
|
|
Update sli/core to use oparent-odlparent. To prevent verify builds from
failing due to unit test errors, also changed unit tests that require
database access to use MariaDB4j to start up a local MariaDB database.
Change-Id: I928b7e1e83bdb328ca9e0785c8b81f67f982eeda
Issue-ID: CCSDK-43
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
|
|
|
|
Code sanitation-- remove unused imports.
Issue-Id: SDNC-79
Change-Id: I5306a9b90f302086459fcac98d04f541ba7c79a4
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
few major issues in sli/core/dblib module
Issue-id: CCSDK-87
Change-Id: Ie3b13468d23c1e7dc2228bb7a0cd1bde5cc632e8
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
few major issues in dblib module
Issue-Id: CCSDK-87
Change-Id: I6bc1fe2cf04cec0a5ad3bfb65bc3a10e5f488eea
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
Few major issues in sli/core module
Issue-id: CCSDK-67
Change-Id: Iad65b30a6b27814c1984d8db42d36f8569c5cb3f
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
|
|
Exposed getConnection from DbLibService class so that it can be accessed
from OSGi client. Prior to blueprint refactoring, this was accessible
by casting DbLibService as DBResourceManager, but that cast no longer
works if OSGi service is advertised by blueprint. It's cleaner to expose
that method in the interface anyway.
Change-Id: I36ed7fe82b0393a952d307a1c79d1d8c0ba11dd4
Issue-ID: CCSDK-86
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Fix Blocker/Critical sonar issues in ccsdk/core module
https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.core%3Asdnc-core#resolved=false|severities=BLOCKER
Issue-Id: CCSDK-67
Change-Id: Iec86b90f7085f4b96d4f92adf4064b70640fcf22
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
|
|
Fix Blocker/Critical sonar issues in vnfapi module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#severities=BLOCKER
Issue-Id: CCSDK-67
Change-Id: I9f1a7dc8144a2a3a777a2a4f24793bbf9317de33
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
|
|
Fix Blocker/Critical sonar issues in vnfapi module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#severities=BLOCKER
Issue-Id: CCSDK-67
Change-Id: I0b779cb0db33f0742776062bd7fa7173f08d5e62
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
|
|
Addresses the inherit race conditions associated with the
BundleActivator abstraction. From lessons learned in OpenDaylight
project, dependency injection and service injection via Aries Blueprint
is faster, more deterministic, and has better error messaging than
using BundleActivator(s).
This change addresses several aspects:
1) DBLIBResourceActivator is changed to DBLIBResourceProvider.
This was done in order to imply that this is no longer an
Activator or subclass of an Activator. The class is a POJO.
2) DBLIBResourceProvider is split from a single monolithic method
into several more manageable and better documented methods.
3) Documentation surrounding the resolution of the DB properties
is added so that a developer can more easily identify the
strategy (priority) used for resolving properties.
4) dblib-blueprint.xml is added. This is used to register the
configuration bean (DBLIBResourceProvider), and pass it as
an argument to the actual Service (DBLIBResourceManager).
5) Tests are added to test the functionality and resolution of
the properties file loading.
Issue-Id: SDNC-54
Change-Id: Ie9d5fb423ae7a67e9aec026c78321537399cc308
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
Changed openecomp references in dblib, filters and sli to onap. Note: these
must be committed together to get a clean compile.
Issue: CCSDK-11
Change-Id: Ibe0f64fb20f3ae9cdda2f7ea969ca722bbde0d15
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Add seed code for sli/core repository
Issue: CCSDK-6
Change-Id: Iaeb54c6135a94a6ffec0c7fd96505d72d18aeb00
Signed-off-by: Dan Timoney <dtimoney@att.com>
|