Age | Commit message (Collapse) | Author | Files | Lines |
|
Updated code for OpenDaylight Neon (using
ccsdk/parent/tools/fluorine2neon.sh)
Change-Id: Ic54b636f691cb2c9dd627dfc3b22b523c0f4f8da
Issue-ID: CCSDK-1389
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Changes made:
* Added code in DBResourceManager to replace with its value
* Expanded debug statement by adding processing time
Change-Id: I22748daed50063e8e0ac7201e88d69a2609c1788
Issue-ID: CCSDK-1133
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Fluorine version of restconf does not handle RPCs with no input
correctly. So, need to work around that by defining dummy input
for SLI-API vlbcheck and healthcheck APIs
Change-Id: I6a78a899937e1bb9bd7674530166a493875ca3bf
Issue-ID: CCSDK-1035
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Container is not coming up because dblib is getting
ClassNotFoundException for mariadb driver, even though
it is installed. To correct this temporarily, updated
code to explicitly create a driver object.
Change-Id: I210d042be2c71a4392781ad26f858c916dbd7364
Issue-ID: CCSDK-489
Signed-off-by: Timoney, Dan (dt5972) <dtimoney@att.com>
|
|
Changes made:
* Updated message template handling in CachedDataSource
Change-Id: I9a082753d80f790b77448a5b3de957b404d737fb
Issue-ID: CCSDK-647
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Changes made:
* updated cleanup code
* added TerminatingConfiguration class
Change-Id: Iee16116a5fc419065915b9f84488874dd192af7c
Issue-ID: CCSDK-913
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
|
|
Fixed major sonar issue
Issue-ID: CCSDK-796
Change-Id: Id8a655875c972bb3df1f12f211b6a0068922b21d
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
|
|
|
|
fixed sonar issue
Issue-ID: CCSDK-525
Change-Id: If242b9995469c0b0a25b1285db1536ff52adce2c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
fixed sonar issues
Issue-ID: CCSDK-525
Change-Id: I169df48b14e1288271356a972c36e678da1ffa04
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
formatted code and added equals and hashcode method as per sonar
standards
Issue-ID: CCSDK-525
Change-Id: Idaa0a6a0a82315189a9365064d4f196e4689ee57
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Changes made:
* fixed sonar issue
Change-Id: I2112b202f8b7eb628fc21c3a972e35704dc827f9
Issue-ID: CCSDK-525
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
|
|
|
|
|
|
|
|
Fixed logger issues
Issue-ID: CCSDK-791
Change-Id: Ie1759c8778ff896b2cff3e187308e6a10265e966
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
|
|
fixed sonar issue
Issue-ID: CCSDK-525
Change-Id: I64adc9bc11c7e4fcac2c1caec614745ebe6887be
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
fixed sonar issue
Issue-ID: CCSDK-525
Change-Id: Ibf082dc71b49b8d657dfbb79ac0ef396eb3f4aa8
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
fixed sonar issue
Issue-ID: CCSDK-525
Change-Id: I29b85aa6066c6a940818443602e3e0e02fad59ab
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
removed unnecessary cast to object
Issue-ID: CCSDK-525
Change-Id: Iccd4430cdbbadfabbdc21820c1f0f962b7635444
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
|
|
Logged exception in Logger
Issue-ID: CCSDK-774
Change-Id: I28d10215daafd9f0dcaf7e0d765afbe72c184053
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
|
|
Fix sonar issues in ccsdk/sli/core
Issue-ID: CCSDK-332
Change-Id: I2aee69cf410d8f9cb63f3a22aeb793a99e27d2c7
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
|
|
Changes made:
* Implemented code to decrypt password field in property file
Change-Id: I97e5f93fd1f8383c1e2a1e6170489dc1db9d6337
Issue-ID: CCSDK-182
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Added unit tests for ccsdk/sli/core/sli
Change-Id: I0d2408c43b9e56a78f3e01e87985aedb6cad5953
Issue-ID: CCSDK-213
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
|
|
Changes made:
* Optimized TerminatingCachedDataSource
* Added additional unit tests
Change-Id: I0a83c993898e2bee11b8d3c5df8f95b4b216e9b8
Issue-ID: CCSDK-151
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Changes made:
* updated algorithm in DBResourceManager
* Updated CachedDataSource, JdbcDBCachedDataSource
* added new unit tests
Change-Id: I4f6bbeb3839f55d183d7e762743fbc9171b63b1a
Issue-ID: CCSDK-192
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Changes made:
* corrected sonar related issue in CachedDataSource class
Change-Id: If84b9abcd115ad042f2cc0527b5ab8c8e12cae5a
Issue-ID: CCSDK-151
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Use Apache derby for dblib SingleFeatureTest
Change-Id: I6b41f7ede1a98b33824fceea9100e75c1ce8dda4
Issue-ID: CCSDK-175
Signed-off-by: Dan Timoney <dtimoney@att.com>
Generalization of CCSDK core/utils framework
Changes made:
* Created generalized version of core/utils/dblib as core/utils/common
* Deprecated core/utils/dblib package
Change-Id: I0992c43910278fbe254674d1e39d7e4fcad0a592
Issue-ID: CCSDK-168
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Use Apache derby for dblib test
Use Apache derby for dblib SingleFeatureTest
Change-Id: Ie497557f162e203fa5c5c82c17ddc55ba0c11b38
Issue-ID: CCSDK-175
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Changes made:
* Created generalized version of core/utils/dblib as core/utils/common
* Deprecated core/utils/dblib package
Change-Id: I0992c43910278fbe254674d1e39d7e4fcad0a592
Issue-ID: CCSDK-168
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
*This is improve readability of source code
Issue-Id: CCSDK-117
Change-Id: I4bb73a6e4b440ae861045c7548a7e985d1fbf02c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
|
|
*Remove unnecessary cast to "CachedDataSource"
These unnecessary casting expressions maked the
code harder to read and understand
*Replace type specification with diamond operator
This is to reduce the verbosity of generics code
Issue-Id: CCSDK-87
Change-Id: I6cd2f7d16886ffa6cc26e5dd300b8376705d9366
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
Changes made:
1. updated DBLibService definition by registering service on two interfaces:
a) javax.sql.DataSource
b) org.onap.ccsdk.sli.core.dblib.DbLibService
Change-Id: If187b07db83ebca5428c809a83f546d9178a2b7f
Issue-ID: CCSDK-102
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Changes made:
1. updated DBLibService definition by adding javax.sql.DataSource
Change-Id: I5dd63a81420f451b0ce9bbbc878d351d62ccd819
Issue-ID: CCSDK-102
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|
|
Fix few Critical/Major sonar issues in CCSDK SLI Core module
* Define and throw a dedicated exception instead of using a generic one
* Either log or rethrow the exception
* Change "try" to a try-with-resources
* Remove useless assignment to local variable
* Use built-in logger method string formatting instead of string concatination
* code indentation
Change-Id: I83dc1fb931b8021118e259c722f7dfbc1621dce8
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
|
|
|
|
|
|
Added @Override annotation before method signature
*This is to improve the readability of code
Issue-Id: CCSDK-87
Change-Id: I979eb03ec81b9868012e5c16f48b595c8e53e26e
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
Rdundant code and complextity of methods reduced.
@override annotaiton added.
Exception handling and logging impoved.
Issue-ID:CCSDK-87
Change-Id: I3907be73a2f6ccdfadeaed79c87705ae7afdb4ab
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
|
|
Related to exception handling.
@Override method
Redundant code and resulable parameters
Issue-Id:CCSDK-87
Change-Id: I82e2aad453edf5cd647c87322fc75b2a56c37566
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
|
|
Few major issues
*Remove unused variables
To increase code readability
*Replace the type specification with the diamond operator
*Add the "@Override" annotation above this method signature
To increase code readability"
Issue-Id: CCSDK-87
Change-Id: I2f0c16a83ab10a0a3e39a2a1d4db3c195ec2bba8
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
|
|
|
|
|
|
When looking at the existing uses of BundleActivator(s), it became
immediately clear that other parts of the code have a strategy based
properties file resolution very similar to those abstracted by dblib.
This change aggregates a separate utils bundle for this functionality,
which is further abstracted for potential reuse with other use cases.
The next use case is in the sli bundle, which will be handled in
a follow-up patch.
Issue-Id: SDNC-54
Change-Id: Ie4d4bb679617474b1983e6044c08cca1742b9893
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
|
|
Few major issues
*Remove unused imports
To increase code readability
*Replace the type specification with the diamond operator
To reduce the verbosity of generics code
*Add the "@Override" annotation above this method signature
To increase code readability
*Remove this unnecessary cast to "String"
Unnecessary casting expressions pollutes code
Issue-Id: CCSDK-87
Change-Id: I38952f5026a5c61af73ac16706e8ddc278566b13
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
One blocker issue in sli/core module
*Check for null dereferencing
Issue-Id: CCSDK-87
Change-Id: I5ebaef24b3fd6534b5e818c3087e3d8213ed770c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
|
|
Remove lingering mysql dependencies in sli/core, which prevented odlsli
container from starting up clean. Note: tested this using bareodl container
and verified that these changes install clean AFTER changing incorrect
driver property name in dblib.properties. This patch is fine, but a second
patch to ccsdk/distribution is needed to fix that property file.
Change-Id: I6a900d1c29998867bfbae29d5e113c4e392a8bb9
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
|
|
Changes made:
1. removed hardcoded JDBC driver's name and made it a property.
2. Optimized connection pool initialization
3. Removed unused factories.
Change-Id: Id1d1868f7f1a6ae5a0429a97403042a8f6ee78d3
Issue-ID: CCSDK-92
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
|