aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-09-14Merge "Clean up public interfaces"Marcus Williams7-74/+74
2017-09-14Merge "Use oparent-odlparent in sli/core"Marcus Williams10-231/+264
2017-09-14Fix SDNC service registrationRyan Goulding3-77/+20
Instead of registgering services via BundleActivator(s), use blueprint instead. This change deletes the RecordingActivator, as it was just used to kickstart the service registration using felix dm. The idea here is to instead use blueprint through recording-blueprint.xml. The decision was also made to register the Service(s) using the implementation class name instead of the interface class name for backwards compatibility reasons. In all reality, registering Service(s) under the implementation name is less future proof since clients are no longer able to easily swap in a separate implementation Service. In the future, we should consider finding usages of this Service and ensuring that they poll for the interface rather than the implementation. However, that is separate from this change and is considered future work. Issue-Id: SDNC-54 Change-Id: I757bb90f91d114668c153ec5debb5c65af44452a Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-14Merge "Clean up BaseDBConfiguration class"Marcus Williams1-78/+211
2017-09-14Clean up public interfacesRyan Goulding7-74/+74
The Java programming language assigns certain defaults for methods and constants defined in interfaces. This change removes the unnecessary redundant modifiers appropriately. For example: * interface methods are public by default * interface constants are public by default * interface methods are abstract unless "default" is specifically used (as of JDK8+). This is really just to get rid of annoying warnings present in IDE(s). Issue-Id: SDNC-79 Change-Id: I2e6b3e4fa02bad1beee2cbb49d3766722eff1ba0 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-14Fix few sonar issuesramu.n2-66/+93
Fix few sonar issues in CCSDK SLI Core module Change-Id: I0e2454f7e23e73087ac42880c5e0b1e4c089dde8 Issue-Id: CCSDK-67 Signed-off-by: Ramu N <ramu.n@huawei.com>
2017-09-14Fix Blocker/Critical sonar issuesshashikanth1-13/+12
Fix Blocker/Critical sonar issues in vnfapi module https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.core%3Asdnc-core#resolved=false|severities=BLOCKER Issue-Id: CCSDK-67 Change-Id: Ie2ace1bc30bbb50d2b6f25a56e716c7a952e7ea0 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-14Fix critical issuessurya-huawei1-16/+6
few critical/major issues in core/sli module Issue-Id: CCSDK-87 Change-Id: Ib7ef026ecb7fcf658ea8fc66ad5d9b739f02c55b Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-13Merge "Fix Blocker/Critical sonar issues"Dan Timoney1-25/+17
2017-09-13Clean up BaseDBConfiguration classRyan Goulding1-78/+211
This change isn't too big; it mainly just attempts to clean up the BaseDBConfiguration class using best practices. For example: * documentation is added surrounding public methods, public constants, protected variables, and class headers. * code logic for parsing "optional" integer properties is abstracted into a separate private static function, which returns a default value if the given input property cannot be parsed or is not present. * public functions where the NumberFormatException RuntimeException might be thrown have the appriorate "throws" modifier added to their function signatures to indicate that the consumer is responsible for exception handling. * constants are extracted in place of "magic numbers" This is really just code sanitation work. Change-Id: Ifaf092e10b17f54c7cce0a888aa49bfe8377cdd3 Issue-Id: SDNC-79 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-13Merge "Fix Blocker/Critical sonar issues"Dan Timoney1-5/+6
2017-09-13Use oparent-odlparent in sli/coreDan Timoney10-231/+264
Update sli/core to use oparent-odlparent. To prevent verify builds from failing due to unit test errors, also changed unit tests that require database access to use MariaDB4j to start up a local MariaDB database. Change-Id: I928b7e1e83bdb328ca9e0785c8b81f67f982eeda Issue-ID: CCSDK-43 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-13Merge "Fix Sonar Issues"Dan Timoney2-19/+21
2017-09-13Merge "Fix Sonar Issues"Dan Timoney1-4/+4
2017-09-13Merge "Fix sonar issues"Dan Timoney1-0/+10
2017-09-13Merge "Fix Sonar Issues"Dan Timoney2-3/+3
2017-09-13Merge "Fix Sonar Issues"Dan Timoney2-13/+13
2017-09-13Remove unused imports in java filesRyan Goulding24-56/+6
Code sanitation-- remove unused imports. Issue-Id: SDNC-79 Change-Id: I5306a9b90f302086459fcac98d04f541ba7c79a4 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-13Fix Sonar Issuessurya-huawei2-22/+21
few major issues in sli/core/dblib module Issue-id: CCSDK-87 Change-Id: Ie3b13468d23c1e7dc2228bb7a0cd1bde5cc632e8 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-13Fix Sonar Issuessurya-huawei1-4/+4
few major issues in sli/core/filters module Issue-Id- CCSDK-87 Change-Id: Idbf2b12b866d48161f089271a2403aaee6b8d04f Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-13Fix sonar issuessurya-huawei2-5/+10
few major issues in dblib module Issue-Id: CCSDK-87 Change-Id: I6bc1fe2cf04cec0a5ad3bfb65bc3a10e5f488eea Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-13Fix Sonar Issuessurya-huawei2-3/+3
few major issues in sli/core module Issue-Id: CCSDK-87 Change-Id: I1fb86f084d270906dcf61d33701da54a82f2c3a4 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-12Fix Sonar Issuessurya-huawei2-13/+13
few major issues in sli/core module Issue-Id: CCSDK-87 Change-Id: Id563cd2fb31f477f96e14b180501feeb37fb24a7 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-12Fix Sonar issuessurya-huawei1-4/+33
Few major issues in sli/core module Issue-id: CCSDK-67 Change-Id: Iad65b30a6b27814c1984d8db42d36f8569c5cb3f Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-11Merge "Fix Blocker/Critical sonar issues"Dan Timoney1-15/+15
2017-09-11Remove cast to DBResourceManagerDan Timoney25-32/+32
Remove cast to DBResourceManager, which no longer works after DbLibService is advertised via Aries Blueprint and which is no longer needed after DbLibService interface exposes getConnection() method. Updated version number - seems like an older 0.1.1-SNAPSHOT without DbLibService change is being used, so trying to see if bumping version will help. Change-Id: Ia411d1514bca396cc052f4f16eda6c79e0d13648 Issue-ID: CCSDK-86 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-11Merge "Expose getConnection from DblibSeervice"Dan Timoney1-2/+5
2017-09-11Expose getConnection from DblibSeerviceDan Timoney1-2/+5
Exposed getConnection from DbLibService class so that it can be accessed from OSGi client. Prior to blueprint refactoring, this was accessible by casting DbLibService as DBResourceManager, but that cast no longer works if OSGi service is advertised by blueprint. It's cleaner to expose that method in the interface anyway. Change-Id: I36ed7fe82b0393a952d307a1c79d1d8c0ba11dd4 Issue-ID: CCSDK-86 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-11Fix Blocker/Critical sonar issuesshashikanth1-27/+17
Fix Blocker/Critical sonar issues in ccsdk/core module https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.core%3Asdnc-core#resolved=false|severities=BLOCKER Issue-Id: CCSDK-67 Change-Id: Iec86b90f7085f4b96d4f92adf4064b70640fcf22 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-08Cleanup project's name in SonarJessica Wagantall1-1/+1
The name parameter in the root pom.xml should match the project name in gerrit to reflect consistency in Sonar. Change-Id: I73a561752044b0d1b03a1b52f4b432f4c3329269 Issue-id: CIMAN-65 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2017-09-08Merge "Fix Sonar issues within SliPluginUtils module"Dan Timoney1-0/+34
2017-09-08Fix Blocker/Critical sonar issuesshashikanth1-15/+15
Fix Blocker/Critical sonar issues in vnfapi module https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#severities=BLOCKER Issue-Id: CCSDK-67 Change-Id: I9f1a7dc8144a2a3a777a2a4f24793bbf9317de33 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-08Fix Blocker/Critical sonar issuesshashikanth1-6/+6
Fix Blocker/Critical sonar issues in vnfapi module https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#severities=BLOCKER Issue-Id: CCSDK-67 Change-Id: I0b779cb0db33f0742776062bd7fa7173f08d5e62 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-07Fix Sonar issues within SliPluginUtils moduleArun S. Yerra1-0/+34
Sonarqube report for SliPluginUtils identified some critical bugs. This fix will address these bugs. Issue-Id: CCSDK-81 Change-Id: I9a1738c02f1364b17a0895b94f26c373e4a19f1f Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
2017-09-07Fix sonar blocker issues in ccsdk/core moduleArun S. Yerra2-5/+29
Sonarqube report for CCSDK core identfied some blcoker issues. This fix addresses those bugs. Issue-Id: CCSDK-84 Change-Id: Ie6ff19b7b0815a129f9809243e8e3eb0a64144ab Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
2017-09-07Merge "Update dblib service name"Dan Timoney1-3/+3
2017-09-07Update dblib service nameDan Timoney1-3/+3
Update name of dblib service to match the DbLibService interface name rather than implemtation class (previous advertised name). Change-Id: I999298c089e75fe3bd467241a473abcc04138852 Issue-ID: CCSDK-83 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-09-07Merge "Fix SDNC service registration"Dan Timoney4-35/+17
2017-09-07Fix SDNC service registrationRyan Goulding1-2/+2
Fix the aaaUserName constant. Change-Id: I4d9272e476874f6a7747970bc67f8f88ff803f21 Issue-Id: SDNC-54 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-06Merge "Fix service registration for SDNC"Dan Timoney7-109/+290
2017-09-06Merge "Enable surefire unit testing"Dan Timoney4-4/+18
2017-09-06Enable surefire unit testingMarcus G K Williams4-4/+18
Issue-Id: CCSDK-67 Change-Id: I3d03ff1a3e312edd4af7ab69508760d2fe49be78 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-09-06Fix SDNC service registrationRyan Goulding4-35/+17
Convert the BundleActivator to a POJO provider, and do the service registration through blueprint instead. Issue-Id: SDNC-54 Change-Id: Ia5618ef443967803b31da1ac9e020d1092c3ab8d Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-06Fix service registration for SDNCRyan Goulding7-109/+290
sliPluginUtils was using a BundleActivator for Service Instantiation, which is prone to heisenbugs due to indeterminate service instantiation logic. This removes the BundleActivator and instantiates services using blueprint. Since dme2.properties are parsed using Properties instead of using a ManagedService, the decision was to just keep them immutable. Future work may involve making instance variables private in DME2, since currently Dme2Test performs direct member access on DME2 instance variables which is considered bad practices (violates encapsulation). Issue-Id: SDNC-54 Change-Id: Ib1155565e04e9a95d222bc4028a0845d9d81bd82 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-06Fix service registration for SDNCRyan Goulding15-175/+621
Addresses the inherit race conditions associated with the BundleActivator abstraction. From lessons learned in OpenDaylight project, dependency injection and service injection via Aries Blueprint is faster, more deterministic, and has better error messaging than using BundleActivator(s). This change addresses several aspects: 1) DBLIBResourceActivator is changed to DBLIBResourceProvider. This was done in order to imply that this is no longer an Activator or subclass of an Activator. The class is a POJO. 2) DBLIBResourceProvider is split from a single monolithic method into several more manageable and better documented methods. 3) Documentation surrounding the resolution of the DB properties is added so that a developer can more easily identify the strategy (priority) used for resolving properties. 4) dblib-blueprint.xml is added. This is used to register the configuration bean (DBLIBResourceProvider), and pass it as an argument to the actual Service (DBLIBResourceManager). 5) Tests are added to test the functionality and resolution of the properties file loading. Issue-Id: SDNC-54 Change-Id: Ie9d5fb423ae7a67e9aec026c78321537399cc308 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
2017-09-01Merge "Update mvn name in POM to CCSDK"Dan Timoney1-2/+2
2017-09-01Update mvn name in POM to CCSDKMarcus G K Williams1-2/+2
Issue-Id: CCSDK-67 Change-Id: Ie0413cd3099cdebac81b0586789354a1c98d0a31 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2017-08-31Add missing implementation codeDan Timoney3-2/+98
Due to an error in .gitignore, code that is initially generated from provider yang, but then customized was not submitted to gerrit. This in turn is causing the UnsupportedOperationException seen when sliapi installs in odlsli container. Change-Id: Iceec13b59e5e2bd6f0b868b548d300b76c7f7a38 Issue-ID: CCSDK-69 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-30Roll version to rule out staging issueDan Timoney25-32/+32
Behavior observed in the odlsli docker container suggests that it might be picking up an old build of 0.1.0-SNAPSHOT version of sli/core. We have observed this problem before due to issues with the Nexus staging plugin. This change bumps the version of sli/core to 0.1.1-SNAPSHOT and comments out the staging plugin from the sli/core pom.xml to make sure that the current build is picked up. There will be a corresponding change in ccsdk/distribution to change which version of sli/core is used in the odlsli container Change-Id: Ie3c2b4ff66191748df14240a69a7d461fc0d4639 Issue-ID: CCSDK-69 Signed-off-by: Dan Timoney <dtimoney@att.com>
2017-08-29Merge "Change 2 sli/core unit tests to int. tests"Dan Timoney2-2/+2