aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsurya-huawei <a.u.surya@huawei.com>2017-09-19 14:57:17 +0530
committerSURYA A U <a.u.surya@huawei.com>2017-09-20 06:24:56 +0000
commit5e31510dba7647b0d0873d9864a0ee6c309e2247 (patch)
treef5a832c8b74000ad771a5b8c81909ab8992ce610
parent9a236162e1c3fd5dcc425544c5ecf5290b0fafb2 (diff)
Fix Sonar Issue
One blocker issue in sli/core module *Check for null dereferencing Issue-Id: CCSDK-87 Change-Id: I5ebaef24b3fd6534b5e818c3087e3d8213ed770c Signed-off-by: surya-huawei <a.u.surya@huawei.com>
-rwxr-xr-xdblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/CachedDataSource.java10
1 files changed, 1 insertions, 9 deletions
diff --git a/dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/CachedDataSource.java b/dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/CachedDataSource.java
index a5902d54..4d920e6a 100755
--- a/dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/CachedDataSource.java
+++ b/dblib/provider/src/main/java/org/onap/ccsdk/sli/core/dblib/CachedDataSource.java
@@ -603,22 +603,14 @@ public abstract class CachedDataSource implements DataSource, SQLExecutionMonito
protected boolean unlockTable(Connection conn) {
boolean retValue = false;
- Statement lock = null;
- try {
+ try (Statement lock = conn.createStatement()){
if(LOGGER.isDebugEnabled()) {
LOGGER.debug("Executing 'UNLOCK TABLES' on connection " + conn.toString());
}
- lock = conn.createStatement();
retValue = lock.execute("UNLOCK TABLES");
} catch(Exception exc){
LOGGER.error("", exc);
retValue = false;
- } finally {
- try {
- lock.close();
- } catch(Exception exc) {
-
- }
}
return retValue;
}