diff options
author | Ryan Goulding <ryandgoulding@gmail.com> | 2017-09-13 16:58:19 -0400 |
---|---|---|
committer | Ryan Goulding <ryandgoulding@gmail.com> | 2017-09-13 17:04:55 -0400 |
commit | 222513c30f3c0c0e7bfce48b6c96d9ddfba75dba (patch) | |
tree | 87fa90d2c185337f1da46e793d3eefe06e69bf04 /.gitignore | |
parent | d315e6996052dc81c7e5deebd7fc4229a4e93c0c (diff) |
Clean up BaseDBConfiguration class
This change isn't too big; it mainly just attempts to clean up the
BaseDBConfiguration class using best practices. For example:
* documentation is added surrounding public methods, public constants,
protected variables, and class headers.
* code logic for parsing "optional" integer properties is abstracted
into a separate private static function, which returns a default
value if the given input property cannot be parsed or is not present.
* public functions where the NumberFormatException RuntimeException
might be thrown have the appriorate "throws" modifier added to their
function signatures to indicate that the consumer is responsible for
exception handling.
* constants are extracted in place of "magic numbers"
This is really just code sanitation work.
Change-Id: Ifaf092e10b17f54c7cce0a888aa49bfe8377cdd3
Issue-Id: SDNC-79
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions