summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Timoney <dtimoney@att.com>2018-12-28 02:45:03 +0000
committerGerrit Code Review <gerrit@onap.org>2018-12-28 02:45:03 +0000
commit071ba65325fc16e2648f789fa4dfbcace5b362fb (patch)
tree3c58884e4716e414c88e077f06f6e1574521f917
parenta9e07eb18d4e81199fc63a090b5c260a7442d900 (diff)
parent8a72139cd40e1fd6353b6c535c2ba3bd1e7290f1 (diff)
Merge "fixed sonar issues in SliPluginUtils.java"
-rw-r--r--sliPluginUtils/provider/src/main/java/org/onap/ccsdk/sli/core/slipluginutils/SliPluginUtils.java13
1 files changed, 7 insertions, 6 deletions
diff --git a/sliPluginUtils/provider/src/main/java/org/onap/ccsdk/sli/core/slipluginutils/SliPluginUtils.java b/sliPluginUtils/provider/src/main/java/org/onap/ccsdk/sli/core/slipluginutils/SliPluginUtils.java
index ebfe81718..fd3364ca4 100644
--- a/sliPluginUtils/provider/src/main/java/org/onap/ccsdk/sli/core/slipluginutils/SliPluginUtils.java
+++ b/sliPluginUtils/provider/src/main/java/org/onap/ccsdk/sli/core/slipluginutils/SliPluginUtils.java
@@ -65,6 +65,7 @@ public class SliPluginUtils implements SvcLogicJavaPlugin {
private static final Logger LOG = LoggerFactory.getLogger(SliPluginUtils.class);
private static final String LOG_MSG="extracting list from context memory";
private static final String LOG_MSG1="removing elements from list";
+ private static final String LENGTH="_length";
// ========== CONSTRUCTORS ==========
@@ -216,7 +217,7 @@ public class SliPluginUtils implements SvcLogicJavaPlugin {
i++;
}
// Reset list length (removed by ctxBulkErase above)
- ctx.setAttribute(ctx_list_str+"_length", Integer.toString(listSz));
+ ctx.setAttribute(ctx_list_str+LENGTH, Integer.toString(listSz));
}
/**
@@ -492,7 +493,7 @@ public class SliPluginUtils implements SvcLogicJavaPlugin {
* @since 1.0
*/
public static final int getArrayLength( SvcLogicContext ctx, String key, Logger log, LogLevel logLevel, String log_message ) {
- String ctxKey = key.endsWith("_length") ? key : key + "_length";
+ String ctxKey = key.endsWith(LENGTH) ? key : key + LENGTH;
try {
return Integer.parseInt(ctx.getAttribute(ctxKey));
}
@@ -829,7 +830,7 @@ public class SliPluginUtils implements SvcLogicJavaPlugin {
writeJsonObject(entry.getValue().getAsJsonObject(), ctx, root + entry.getKey() + ".");
} else if (entry.getValue().isJsonArray()) {
JsonArray array = entry.getValue().getAsJsonArray();
- ctx.setAttribute(root + entry.getKey() + "_length", String.valueOf(array.size()));
+ ctx.setAttribute(root + entry.getKey() + LENGTH, String.valueOf(array.size()));
Integer arrayIdx = 0;
for (JsonElement element : array) {
if (element.isJsonObject()) {
@@ -873,7 +874,7 @@ public class SliPluginUtils implements SvcLogicJavaPlugin {
try {
String ctxList = parameters.get("list");
- ctxList = (ctxList.endsWith("_length")) ? ctxList : ctxList + "_length";
+ ctxList = (ctxList.endsWith(LENGTH)) ? ctxList : ctxList + LENGTH;
int listLength = getArrayLength(ctx, ctxList);
if (listLength == 0) {
@@ -1063,9 +1064,9 @@ public class SliPluginUtils implements SvcLogicJavaPlugin {
setParametersToCtxList(parameters, ctx, prefixKeyWithIndex, valuePrefixKey);
// set length of list
- String ListLengthKeyName = prefixKey + "_length";
+ String ListLengthKeyName = prefixKey + LENGTH;
- ctxSetAttribute(ctx, prefixKey + "_length", listLength + 1);
+ ctxSetAttribute(ctx, prefixKey + LENGTH, listLength + 1);
LOG.debug("Updated _length: " + prefixKey + "_length is now " + ctx.getAttribute(ListLengthKeyName));
}