summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRupinder <rupinsi1@in.ibm.com>2020-04-02 12:51:23 +0530
committerRupinderjeet Singh <rupinsi1@in.ibm.com>2020-04-07 17:15:04 +0000
commitc3c435eb583ca80e3626a6811a0dce3ac7bd7411 (patch)
treeb99e7d309201c27314c7378e6324f9ff3c5b669e
parent3280b56349c8e5a3e00fdce2ff62b58b0d9e6508 (diff)
removed code smells
Reduced the code smells Issue-ID: CCSDK-2232 Change-Id: I30eec021ba50f28dc1df2fd554c4e349c4a76dd6 Signed-off-by: Rupinder<rupinsi1@in.ibm.com>
-rw-r--r--resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/rm/dao/jdbc/Resource.java4
-rw-r--r--resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/util/expr/ExpressionEvaluator.java3
-rw-r--r--resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/util/str/StrUtil.java3
-rw-r--r--saltstack-adapter/saltstack-adapter-provider/src/main/java/org/onap/ccsdk/sli/adaptors/saltstack/model/SaltstackMessageParser.java3
4 files changed, 9 insertions, 4 deletions
diff --git a/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/rm/dao/jdbc/Resource.java b/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/rm/dao/jdbc/Resource.java
index 4b0c82f92..6b764a7e1 100644
--- a/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/rm/dao/jdbc/Resource.java
+++ b/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/rm/dao/jdbc/Resource.java
@@ -24,7 +24,9 @@ package org.onap.ccsdk.sli.adaptors.rm.dao.jdbc;
public class Resource {
public long id;
- public String assetId, name, type;
+ public String assetId;
+ public String name;
+ public String type;
public long ltUsed;
public String llLabel;
public int llReferenceCount;
diff --git a/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/util/expr/ExpressionEvaluator.java b/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/util/expr/ExpressionEvaluator.java
index 8ba454bf4..8092a7515 100644
--- a/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/util/expr/ExpressionEvaluator.java
+++ b/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/util/expr/ExpressionEvaluator.java
@@ -193,7 +193,8 @@ public class ExpressionEvaluator {
int opl = op.length();
int sl = s.length();
String delimiters = " \0\t\r\n()";
- int pcount = 0, qcount = 0;
+ int pcount = 0;
+ int qcount = 0;
for (int i = 0; i < sl; i++) {
char c = s.charAt(i);
if (c == '(' && qcount == 0) {
diff --git a/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/util/str/StrUtil.java b/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/util/str/StrUtil.java
index ef889f0d5..126ec94e5 100644
--- a/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/util/str/StrUtil.java
+++ b/resource-assignment/provider/src/main/java/org/onap/ccsdk/sli/adaptors/util/str/StrUtil.java
@@ -215,7 +215,8 @@ public class StrUtil {
for (String s : str) {
try {
int i1 = s.indexOf('-');
- int start, end;
+ int start;
+ int end;
if (i1 > 0) {
String s1 = s.substring(0, i1);
String s2 = s.substring(i1 + 1);
diff --git a/saltstack-adapter/saltstack-adapter-provider/src/main/java/org/onap/ccsdk/sli/adaptors/saltstack/model/SaltstackMessageParser.java b/saltstack-adapter/saltstack-adapter-provider/src/main/java/org/onap/ccsdk/sli/adaptors/saltstack/model/SaltstackMessageParser.java
index 50d08e23a..3bb401ad4 100644
--- a/saltstack-adapter/saltstack-adapter-provider/src/main/java/org/onap/ccsdk/sli/adaptors/saltstack/model/SaltstackMessageParser.java
+++ b/saltstack-adapter/saltstack-adapter-provider/src/main/java/org/onap/ccsdk/sli/adaptors/saltstack/model/SaltstackMessageParser.java
@@ -307,7 +307,8 @@ public class SaltstackMessageParser {
public SaltstackResult parseResponse(SvcLogicContext ctx, String pfx,
SaltstackResult saltstackResult, boolean slsExec) throws IOException {
int code = saltstackResult.getStatusCode();
- boolean executionStatus = true, retCodeFound = false;
+ boolean executionStatus = true;
+ boolean retCodeFound = false;
if (code != SaltstackResultCodes.SUCCESS.getValue()) {
return saltstackResult;
}