Merge "Fix critical sonar issues"

5 files changed, 6 insertions, 7 deletions

diff --git a/asdcApi/provider/src/main/java/org/onap/ccsdk/sli/northbound/asdcapi/AsdcApiProvider.java b/asdcApi/provider/src/main/java/org/onap/ccsdk/sli/northbound/asdcapi/AsdcApiProvider.java
index b9c897ec0..cebcb9986 100644
--- a/asdcApi/provider/src/main/java/org/onap/ccsdk/sli/northbound/asdcapi/AsdcApiProvider.java
+++ b/asdcApi/provider/src/main/java/org/onap/ccsdk/sli/northbound/asdcapi/AsdcApiProvider.java
@@ -157,8 +157,7 @@ public class AsdcApiProvider implements AutoCloseable, ASDCAPIService {
             LOG.info("Create Containers succeeded!: ");
 
         } catch (InterruptedException | ExecutionException e) {
-            LOG.error("Create Containers Failed: " + e);
-            e.printStackTrace();
+            LOG.error("Create Containers Failed: ", e);
         }
         } else {
             LOG.warn("createContainers : cannot find dataBroker to create containers");
diff --git a/dmaap-listener/src/main/java/org/onap/ccsdk/sli/northbound/dmaapclient/DmaapListener.java b/dmaap-listener/src/main/java/org/onap/ccsdk/sli/northbound/dmaapclient/DmaapListener.java
index 91afe1d1a..ec34fe402 100644
--- a/dmaap-listener/src/main/java/org/onap/ccsdk/sli/northbound/dmaapclient/DmaapListener.java
+++ b/dmaap-listener/src/main/java/org/onap/ccsdk/sli/northbound/dmaapclient/DmaapListener.java
@@ -106,7 +106,7 @@ public class DmaapListener {
 				try {
 					consumerClass = Class.forName(consumerClassName);
 				} catch (Exception e) {
-					LOG.error("Could not find DMaap consumer class " + consumerClassName);
+					LOG.error("Could not find DMaap consumer class {}", consumerClassName, e);
 				}
 
 				if (consumerClass != null) {
diff --git a/dmaap-listener/src/main/java/org/onap/ccsdk/sli/northbound/dmaapclient/SdncFlatJsonDmaapConsumer.java b/dmaap-listener/src/main/java/org/onap/ccsdk/sli/northbound/dmaapclient/SdncFlatJsonDmaapConsumer.java
index a3d70c8d9..aa3f7261a 100644
--- a/dmaap-listener/src/main/java/org/onap/ccsdk/sli/northbound/dmaapclient/SdncFlatJsonDmaapConsumer.java
+++ b/dmaap-listener/src/main/java/org/onap/ccsdk/sli/northbound/dmaapclient/SdncFlatJsonDmaapConsumer.java
@@ -123,7 +123,7 @@ public class SdncFlatJsonDmaapConsumer extends SdncDmaapConsumer {
 				LOG.info("POST message body would be:\n"+rpcMsgbody);
 			}
 		} catch (Exception e) {
-
+			LOG.error("Unable to process message", e);
 		}
 
 	}
diff --git a/ueb-listener/src/main/java/org/onap/ccsdk/sli/northbound/uebclient/SdncArtifactMap.java b/ueb-listener/src/main/java/org/onap/ccsdk/sli/northbound/uebclient/SdncArtifactMap.java
index dd9437ce9..9b36cb6b3 100644
--- a/ueb-listener/src/main/java/org/onap/ccsdk/sli/northbound/uebclient/SdncArtifactMap.java
+++ b/ueb-listener/src/main/java/org/onap/ccsdk/sli/northbound/uebclient/SdncArtifactMap.java
@@ -66,7 +66,7 @@ public class SdncArtifactMap {
 			try {
 				this.pass = Integer.parseInt(pass);
 			} catch (Exception e) {
-				LOG.error("Invalid pass value for artifact map entry ("+tag+","+rpc+","+pass+")");
+				LOG.error("Invalid pass value for artifact map entry ({} {} {})", tag, rpc, pass, e);
 			}
 		}
 	}
diff --git a/ueb-listener/src/main/java/org/onap/ccsdk/sli/northbound/uebclient/SdncUebConfiguration.java b/ueb-listener/src/main/java/org/onap/ccsdk/sli/northbound/uebclient/SdncUebConfiguration.java
index 3c561118e..3ea092d47 100644
--- a/ueb-listener/src/main/java/org/onap/ccsdk/sli/northbound/uebclient/SdncUebConfiguration.java
+++ b/ueb-listener/src/main/java/org/onap/ccsdk/sli/northbound/uebclient/SdncUebConfiguration.java
@@ -132,7 +132,7 @@ public class SdncUebConfiguration implements IConfiguration{
 			try {
 				pollingInterval = Integer.parseInt(curval);
 			} catch (Exception e) {
-				LOG.warn("Illegal value for org.onap.ccsdk.sli.northbound.uebclient.polling-interval ("+curval+")");
+				LOG.warn("Illegal value for org.onap.ccsdk.sli.northbound.uebclient.polling-interval ({}) ", curval, e);
 			}
 		}
 
@@ -141,7 +141,7 @@ public class SdncUebConfiguration implements IConfiguration{
 			try {
 				pollingTimeout = Integer.parseInt(curval);
 			} catch (Exception e) {
-				LOG.warn("Illegal value for org.onap.ccsdk.sli.northbound.uebclient.polling-timeout ("+curval+")");
+				LOG.warn("Illegal value for org.onap.ccsdk.sli.northbound.uebclient.polling-timeout ({}) ", curval, e);
 			}
 		}