fix some sdnr sonar bugs

sonar fixes for some sdnr components

Issue-ID: SDNC-1590
Change-Id: I02e44b6f5477bcd0490c3499caf20228eb9772ed
Signed-off-by: Michael DÜrre <michael.duerre@highstreet-technologies.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/sdnr/wt/apigateway/provider/src/main/java/org/onap/ccsdk/features/sdnr/wt/apigateway/MyProperties.java b/sdnr/wt/apigateway/provider/src/main/java/org/onap/ccsdk/features/sdnr/wt/apigateway/MyProperties.java
index 66cbd02e9..560330f85 100644
--- a/sdnr/wt/apigateway/provider/src/main/java/org/onap/ccsdk/features/sdnr/wt/apigateway/MyProperties.java
+++ b/sdnr/wt/apigateway/provider/src/main/java/org/onap/ccsdk/features/sdnr/wt/apigateway/MyProperties.java
@@ -150,7 +150,7 @@ public class MyProperties {
         in.close();
 
         this.aaiBase = getProperty(defaultProps,"aai", DEFAULT_AAI);
-        this.aaiHeaders = _parseHeadersMap(getProperty(defaultProps,"aaiHeaders", DEFAULT_AAI_HEADERS));
+        this.aaiHeaders = parseHeadersMap(getProperty(defaultProps,"aaiHeaders", DEFAULT_AAI_HEADERS));
         this.esBase = getProperty(defaultProps,"database", DEFAULT_ESDATABASE);
         this.tilesBase = getProperty(defaultProps,"tiles", DEFAULT_TILES, DEFAULT_URL_OFF);
         this.topologyBase = getProperty(defaultProps,"topology", DEFAULT_TOPOLOGY, DEFAULT_URL_OFF);
@@ -187,12 +187,12 @@ public class MyProperties {
             }
             value = tmp;
         }
-        if((value==null || value == "") && valueIfEmpty!=null) {
+        if((value==null || value.isEmpty()) && valueIfEmpty!=null) {
             value = valueIfEmpty;
         }
         return value;
     }
-    private static Map<String, String> _parseHeadersMap(String s) {
+    private static Map<String, String> parseHeadersMap(String s) {
         Map<String, String> r = new HashMap<>();
         try {
             JSONArray a = new JSONArray(s);