diff options
| author |   surya-huawei <a.u.surya@huawei.com> | 2017-09-22 10:30:39 +0530 |
|---|---|---|
| committer | surya-huawei <a.u.surya@huawei.com> | 2017-09-22 10:33:29 +0530 |
| commit | 4b23fde59f0ddb4802d162f7fa97f2e18d43ffe2 (patch) | |
| tree | d3bd28abfe4bf9f0ccded845d05c1eba10d5583f | |
| parent | 97662b28b1cfd66c167e6a13fbac1d1567780e10 (diff) | |
Use isEmpty() to check collection size
Major sonar issue in dashboard module
*Using collection.isEmpty() instead of collection.size()
makes code more readable and is more performant
Issue-Id: CCSDK-87
Change-Id: I201d1c7982ce6a1509a462d7d151a41ab2912f91
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
| -rw-r--r-- | oom-app-common/src/main/java/org/onap/oom/dashboard/controller/HealthCheckController.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/HealthCheckController.java b/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/HealthCheckController.java index fe54790..7ed3fbe 100644 --- a/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/HealthCheckController.java +++ b/oom-app-common/src/main/java/org/onap/oom/dashboard/controller/HealthCheckController.java @@ -72,7 +72,7 @@ public class HealthCheckController extends UnRestrictedBaseController { @SuppressWarnings("unchecked") // Get the single app. List<App> list = dataAccessService.getList(App.class, null); - if (list.size() > 0) + if (!list.isEmpty()) healthStatus = new HealthStatus(200, SystemProperties.getProperty(SystemProperties.APP_DISPLAY_NAME) + " health check succeeded"); else healthStatus = new HealthStatus(500, SystemProperties.getProperty(SystemProperties.APP_DISPLAY_NAME) + " health check failed to run db query"); |