aboutsummaryrefslogtreecommitdiffstats
path: root/ms/blueprintsprocessor
AgeCommit message (Collapse)AuthorFilesLines
2020-08-10Merge "Make use of Kafka Key for Audit service and Kafka listener"KAPIL SINGAL11-56/+48
2020-08-07Kafka Audit Service: Error during sensitive data hidingJulien Fontaine2-54/+120
Changed behaviour during sensitive data hiding. Instead of looking for every node template defined in the CBA we only check for the ones declared for the current executed workflow. This prevent the issue when you have two independant workflows defined in the same CBA and one of those has a node template using a get_input expression for template-prefix in a component-resource-resolution. If you execute the other workflow audit service was still trying to resolve this expression which was making it fail. Issue-ID: CCSDK-2636 Signed-off-by: Julien Fontaine <julien.fontaine@bell.ca> Change-Id: Ib232c26ebf930917e19e7970e1a56c15e676888f
2020-08-04Make use of Kafka Key for Audit service and Kafka listenerJulien Fontaine11-56/+50
* When message is sent by audit service, key will be the CBA name * When sent by kafka listener (self-service api), key is the same as the request message key consumed. If not specified, a random UUID * MessageProducer interface refactoring : * add 'key' parameter to specify a key * add default value null to paramater 'headers' to remove some unnecessary method Issue-ID: CCSDK-2628 Signed-off-by: Julien Fontaine <julien.fontaine@bell.ca> Change-Id: I68580151184c87104c07037f379276dd8c8c71c7
2020-08-04cds-exec shouldn't return "N/A" as outputOleg Mitsura1-8/+8
Issue-ID: CCSDK-2603 * execute-command-logs" should always be a list (in some cases, we had a string causing possible parsing problems) * response-data should be JSON and "N/A" not acceptible. Signed-off-by: Oleg Mitsura <oleg.mitsura@amdocs.com> Change-Id: Ie6fceb6e1f4c86bfcdeb7671bacd74b909628096
2020-07-29Improve Kafka Producer callback messagesJulien Fontaine1-2/+13
Check if message sent is a BP request/response to print CBA name and version in the callback message. Issue-ID: CCSDK-2623 Signed-off-by: Julien Fontaine <julien.fontaine@bell.ca> Change-Id: I526a01299a3bfca3d1c4a10ae19dead46393a9ae
2020-07-24Change EventListener functions to non-blocking scopeJozsef Csongvai2-3/+5
BluePrintProcessingKafkaConsumer and BluePrintProcessorCluster were both defining EventListener functions which were executed with runBlocking. When both were enabled, kafkaconsumer would block and cluster would never run. Issue-ID: CCSDK-2609 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: I91813208f0474869f174da6c99280b5159859232
2020-07-23Disable jython testsJozsef Csongvai1-1/+3
BlueprintJythonServiceTest started failing in Jenkins for unknown reasons. Seeing as jython is deprecated and should be removed, its not worth tracing the cause. Issue-ID: CCSDK-2602 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: I495409a18fc324e00c373c99bcc6da803666240a
2020-07-14cmd-exec payload should be payload, not err msg.Oleg Mitsura1-67/+50
Issue-ID: CCSDK-2549 fixes: 1. CMD-exec returns payload as JSON object. There was some regression where we overwrite returned JSON with errMsg. 2. adds 100ms delta to executionTimeout, as was in our downstream version (want to guarantee that we get grpc timeout exception on BP side rather than coroutine w/o waiting extra) 3. setNodeOutputErrors should not have ability to set execution status to success. rev1. initial import rev2. reworked the calls to setNodeOutputErrors: addError was brought out of it as we can set the node execution error based on prepare.env or execution. rev3. did not mean to add BlueprintRuntimeService change Signed-off-by: Oleg Mitsura <oleg.mitsura@amdocs.com> Change-Id: I6d509df5ae51598f33ab9f0ea53806d653cf79c0
2020-07-09single /enrichandupload endpoint.Oleg Mitsura2-0/+37
Issue-ID: CCSDK-2540 rev1. initial commit rev2. spacing Signed-off-by: Oleg Mitsura <oleg.mitsura@amdocs.com> Change-Id: I14c8ffa42214faf064d8697b00190dee80f5da1c
2020-07-09Set EventType for GRPC response in designer APIJozsef Csongvai2-0/+10
Issue-ID: CCSDK-2539 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: Iaaf64e4b6683c564c1022b609496fec55ad0df6d
2020-07-08cmd-exec server-side timeout.Oleg Mitsura1-1/+1
Issue-ID: CCSDK-2535 Signed-off-by: Oleg Mitsura <oleg.mitsura@amdocs.com> Change-Id: I897678a5a8a23503a878f2d3eb836ba4597a6e6e
2020-07-06Merge "Fix misleading errormessages in script exeutors"KAPIL SINGAL2-2/+2
2020-07-06Fix misleading errormessages in script exeutorsJozsef Csongvai2-2/+2
Issue-ID: CCSDK-2528 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: I1a8dfc14b1fbddced4a3c2a06f8a35df34303976
2020-07-03Add error handling for CDS Kafka Producer callbackJulien Fontaine1-1/+2
Issue-ID: CCSDK-2522 Signed-off-by: Julien Fontaine <julien.fontaine@bell.ca> Change-Id: Ia7aabaa6d978a13fbf657ea6b406e0b37bc02222
2020-07-02Command Executor : Invalid response_data when executed script failsJulien Fontaine1-18/+18
* Modified command exec returned value in case of failure during execution. It now prints the response_data defined by the user * Modified truncation method of the gRPC returned object to use ByteSize() to get the exact sizxe consumed within the buffer Issue-ID: CCSDK-2501 Signed-off-by: Julien Fontaine <julien.fontaine@bell.ca> Change-Id: Ie1db8db265623b5137ab3946ff4e3abda1c54a78
2020-07-02Merge "Fix incorrect error handling for resolveWorkflowOutputs"KAPIL SINGAL2-2/+62
2020-06-30RemoteAnsibleExecutor delay vs Thread.sleep bugOleg Mitsura1-2/+3
Issue-ID: CCSDK-2505 Signed-off-by: Oleg Mitsura <oleg.mitsura@amdocs.com> Change-Id: I0115a484c61169f2cc031553ecd664796aff6bf8
2020-06-30Fix incorrect error handling for resolveWorkflowOutputsJozsef Csongvai2-2/+62
Issue-ID: CCSDK-2504 Change-Id: Ie910e47bb97be2db4f4a4e94653e5ae474a78c0d Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca>
2020-06-26cmdexec should return status=FAILURE on errorsOleg Mitsura1-40/+47
Issue-ID: CCSDK-2445 In certain cases, status message is returned on error instead of status=FAILURE. rev 2: reuse same msg rev 3: past elalto, compoment level timeout is implementation.timeout Signed-off-by: Oleg Mitsura <oleg.mitsura@amdocs.com> Change-Id: I2651e5706b7e62894c5e071dc1563fb1b9dd67e1
2020-06-24Remove service annotation for ImperativeBluePrintWorkflowServiceJozsef Csongvai2-12/+4
Even with the PROTOTYPE_SCOPE annotation the bean was in effect a Singleton, as it was only injected in one other service. The class has field variables which would be shared by every thread, potentially causing severe errors under parallel execution. Removed annotations to disable dependency injection, and instead create a new instance with every execution call. Issue-ID: CCSDK-2473 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: I9e7148540781dcd869d55d932f4187c5f81cb3f5
2020-06-23Fix hazelcast issuesJozsef Csongvai6-51/+63
- confined lock tests to individual threads to ensure correct unlocking - removed silent failure in clusterlock.unlock function when unlock is called by a thread that doesnt own the lock. - added isLockedByCurrentThread method to ClusterLock interface - disabled multicast discovery, tcp-ip should be more stable for tests - fix Hazlecast typo Issue-ID: CCSDK-2429 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: Idfe723fff04fcd9c48510cf429eb15b33662c49d
2020-06-23Merge "Kafka Audit Service : Improve error handling and miscellaneous ↵KAPIL SINGAL9-95/+112
refactoring"
2020-06-22Kafka Audit Service : Improve error handling and miscellaneous refactoringJulien Fontaine9-95/+112
When Kafka Audit Service fails it no longer stops Blueprint Processor execution * Add error handling when trying to hide sensitive data * Add error handling when trying to send kafka message * Set timeout for blocking loop when sending messages with kafka producer -> When broker is not available producer tries to reconnect in a blocking loop * Refactor Audit Service interface to give more explict name for publish methods * Modify publishExecutionOutput() to a non-blocking function Issue-ID: CCSDK-2459 Signed-off-by: Julien Fontaine <julien.fontaine@bell.ca> Change-Id: I809a5f34f81889aa9eed499608348f149984bc38
2020-06-22Fix exception handling in AbstractComponentFunctionJozsef Csongvai2-15/+38
Moved try-catch to applyNB so that it also catches exceptions in prepareRequestNB. This restores exception handling to the way it was before introduction of locking feature. Issue-ID: CCSDK-2460 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: I20326d9a79ac5fbae630eda8530e8428cdb4f84c
2020-06-22solving continuous savingShaabanEltanany1-1/+1
Issue-ID: CCSDK-2336 Signed-off-by: ShaabanEltanany <shaaban.eltanany.ext@orange.com> Change-Id: I7e488950a77a19b7b1b4ac2e4c9044698b9ff757
2020-06-19Implement nodetemplate locking featureJozsef Csongvai13-34/+287
Enables locking execution of a nodetemplate using a lock key and lock acquire timeout. Issue-ID: CCSDK-2460 Change-Id: I308d4d89dab44b7f7a766d5b62258e67b051eab1 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca>
2020-06-19Error when template-prefix-names list is set as an inputJulien Fontaine2-2/+13
Case when template-prefix-names list for resource resolution is passed as an input was not handled. When the audit service was trying to get input-prefix-names values he was only getting {"get_input": "..."} and was not resolving this expression. Issue-ID: CCSDK-2456 Change-Id: If9ebbf0aa6b6eae3e44a7bfe0b930f622dfd3c1e Signed-off-by: Julien Fontaine <julien.fontaine@bell.ca>
2020-06-18Missing note of timeout differences.Oleg Mitsura1-3/+8
rev1. initial commit rev2. spacing (silly klint!) Issue-ID: CCSDK-2445 Signed-off-by: Oleg Mitsura <oleg.mitsura@amdocs.com> Change-Id: Ie8cc62c89e212efbf5240304856b79c173c88abb
2020-06-16Merge "providing search packages functionalities"Dan Timoney3-4/+4
2020-06-16add sort by versionShaabanEltanany1-1/+2
Issue-ID: CCSDK-2431 Signed-off-by: ShaabanEltanany <shaaban.eltanany.ext@orange.com> Change-Id: Idfeab7ba0757adea3c837b281d5da83b2dc95c4e
2020-06-16providing search packages functionalitiesShaabanEltanany3-4/+4
- provide search package by (UpdatedBy or Tags or ArtifactName or ArtifactVersion or ArtifactType) Containing IgnoreCase Issue-ID: CCSDK-2434 Signed-off-by: ShaabanEltanany <shaaban.eltanany.ext@orange.com> Change-Id: I92167e916643dbbf17601a0d9fb7654d8940a537
2020-06-15add package description to be at Entry definitionShaabanEltanany2-1/+3
Issue-ID: CCSDK-2438 Signed-off-by: ShaabanEltanany <shaaban.eltanany.ext@orange.com> Change-Id: I8657560cd55a21421dc6849d7aac64c02e83db42
2020-06-12add error-messages_en.properties to the blueprint processor docker imageAbdelmuhaimen Seaudi1-0/+1
Issue-ID: CCSDK-2444 Signed-off-by: Abdelmuhaimen Seaudi <abdelmuhaimen.seaudi@orange.com> Change-Id: Iccdd77676606fc3007568a76402ef0696e6a1653
2020-06-09Add ResourceResolutionResult to ResourceResolutionServiceJozsef Csongvai11-56/+106
In order to ensure consistent behavior for assignment-map, supporting occurences and multiple artifact-prefixes, ResourceResolutionService needs to return assignment-map alongside generated template content. Issue-ID: CCSDK-2389 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: I54c1991d23d65217f3492b08a2170a6d41b6482d
2020-06-05Merge "Changed sli-provider dependency"Dan Timoney1-1/+2
2020-06-04Changed sli-provider dependencyDan Timoney1-1/+2
Due to refactoring in sli/core, the dependency sli-provider-base should now be used in place of sli-provider. Issue-ID: CCSDK-2412 Signed-off-by: Dan Timoney <dtimoney@att.com> Change-Id: I35e356dd80cc355aedf74a9adb49665a1292d77c
2020-06-03Set explicit uid and gid in dockerfilesJozsef Csongvai1-1/+1
This fixes permission issues with shared nfs volumes caused by mismatch in dynamically assigned gid and uid between containers. Issue-ID: CCSDK-2398 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: Ie47873c98211b280490ee7a6bcc60ceef49dd690
2020-05-27REST endpoint for fetching templates resolution results does not expose ↵Serge Simard1-3/+7
occurence parameter Issue-ID: CCSDK-2384 Change-Id: I8a6abfea32c7aacade1e9b3140eeed22fa58b4a9 Signed-off-by: Serge Simard <serge@agilitae.com>
2020-05-27Fix sub-attribute parsing for accessing resolved valuesJozsef Csongvai6-1/+43
Added assignment-map attribute to ResourceResolutionComponent. This attribute will hold a json object with the resolved values for each artifact-prefix. It will enable accessing any resolved value, using get_attribute with JsonPath. Issue-ID: CCSDK-2389 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: I3441569d9766fbd79703d2f224de448edd56dbb2
2020-05-19Improve logging for ResourceAssingmentUtilsJozsef Csongvai2-7/+16
Sort keys for generated resource param data logging Issue-ID: CCSDK-2381 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: Iea0a88fbe915e41e399ced45d842a8ef14d052c1
2020-05-19Fix incorrect encoding for query paramsJozsef Csongvai2-1/+37
Issue-ID: CCSDK-2380 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: I3a49f2c5a3a29383e43e2a4a3d6a9c13a9f933c2
2020-05-19Merge "Add Naming Service & IP Assign custom resource resolution capability"Dan Timoney10-28/+1076
2020-05-18Add Naming Service & IP Assign custom resource resolution capabilityPaira, Saurav(sp694w)10-28/+1076
Issue-ID: CCSDK-2185 Signed-off-by: Paira, Saurav(sp694w) <sp694w@att.com> Change-Id: I70550fe9582b2db0a70c7b66591438b674173411
2020-05-13Kafka Audit Service : Error with CBA using dg-generic node templateJulien Fontaine2-27/+37
* Fixed issue with dg-generic node template * Changed behaviour for hiding sensitive data -> Instead of just checking the node-template targeted by the workflow, we check every node-template declared in the CBA. If we find one or more component-resource-resolution node-template, we verify if we need to hide sensitive data in the kafka message. Issue-ID: CCSDK-2372 Signed-off-by: Julien Fontaine <julien.fontaine@bell.ca> Change-Id: I079ee29ae532b3947cdc8efe3438678309ca50b7
2020-05-11Kafka Audit Service : CorrelationUUID from request is not matching the ↵Julien Fontaine5-9/+7
correct response in Kafka Moved out CorrelationUUID linking between the request and the response from the Kafka Audit Service to the ExecutionServiceHandler. This prevents the race condition happening when several ExecutionServiceOutputs try to set the CorrelationUUID related to their ExecutionServiceInput. Issue-ID: CCSDK-2370 Signed-off-by: Julien Fontaine <julien.fontaine@bell.ca> Change-Id: I0c5934d4486961fbfcb34fd2d2492cd843350025
2020-05-06Merge "fix sort at package list"Dan Timoney1-4/+8
2020-05-06Merge "Truncate message published on Kafka / Spike: Define solution for logs ↵Dan Timoney9-47/+174
separation"
2020-05-05Truncate message published on Kafka / Spike: Define solution for logs separationJulien Fontaine9-47/+174
Refactoring of cmd-exec component - Improve display of error messages within the response - Fix gRPC buffer limitation (4Mb) by truncating error messages and cmd-exec logs if too heavy (>3Mb) Truncation of BP responses (<4Kb) before sending them in kafka audit topics. - Truncation if needed of error messages for every response - Truncation of cmd-exec logs in cmd-exec responses (Spike) Add a flag in the application.properties to enable/disable the display of cmd-exec responses on the BP side (Fix) Correction of BP processing with kafka regression (Fix) Changed default SSL Endpoint Algo Issue-ID: CCSDK-2326 Change-Id: If4d0e661117d1dd156cf19c95774824e754d870a Signed-off-by: Julien Fontaine <julien.fontaine@bell.ca>
2020-05-05fix sort at package listShaabanEltanany1-4/+8
Issue-ID: CCSDK-2320 Signed-off-by: ShaabanEltanany <shaaban.eltanany.ext@orange.com> Change-Id: Ia91d519c315b6ef0c01089422253599b137eceec
2020-04-30Fix null safety - ResourceResolutionDBService.writeJozsef Csongvai2-5/+29
Issue-ID: CCSDK-2352 Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca> Change-Id: I49a56dff0636617111f02be141764600e0a1e082