fixed sonar issues in ConfigModelService.java

fixed sonar issues

Issue-ID: CCSDK-552
Change-Id: Iab02d1cee2b0cb9e182f9d4af839000307ec99bf
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>

1 files changed, 4 insertions, 3 deletions

diff --git a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java
index a2f653c67..b2fff26ef 100644
--- a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java
+++ b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java
@@ -55,6 +55,7 @@ public class ConfigModelService {
     private ConfigModelRepository configModelRepository;

     private ConfigModelContentRepository configModelContentRepository;

     private ConfigModelCreateService configModelCreateService;

+    private static final String CONFIG_MODEL_ID_FAILURE_MSG= "failed to get config model id(%d) from repo";

 

     /**

      * This is a ConfigModelService constructor.

@@ -174,7 +175,7 @@ public class ConfigModelService {
         if (dbConfigModel.isPresent()) {

             configModel = dbConfigModel.get();

         } else {

-            throw new BluePrintException(String.format("failed to get config model id(%d) from repo", id));

+            throw new BluePrintException(String.format(CONFIG_MODEL_ID_FAILURE_MSG, id));

         }

 

         return configModel;

@@ -232,7 +233,7 @@ public class ConfigModelService {
                 }

             }

         } else {

-            throw new BluePrintException(String.format("failed to get config model id(%d) from repo", id));

+            throw new BluePrintException(String.format(CONFIG_MODEL_ID_FAILURE_MSG, id));

         }

 

         return cloneConfigModel;

@@ -252,7 +253,7 @@ public class ConfigModelService {
             configModelContentRepository.deleteByConfigModel(dbConfigModel.get());

             configModelRepository.delete(dbConfigModel.get());

         } else {

-            throw new BluePrintException(String.format("failed to get config model id(%d) from repo", id));

+            throw new BluePrintException(String.format(CONFIG_MODEL_ID_FAILURE_MSG, id));

         }

     }