Fix doc-rules job and cds-ui build

- Doc changes to satisfy new doc-rules
- Fixo f CDS-UI build

Issue-ID: CCSDK-3859
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@t-mobile.pl>
Change-Id: I9471e845afd39d06466da9a5db8fde5acdf15ea1

8 files changed, 39 insertions, 51 deletions

diff --git a/docs/modelingconcepts/artifact-type.rst b/docs/modelingconcepts/artifact-type.rst
index 3dda2c4ed..cc4b0dc3e 100644
--- a/docs/modelingconcepts/artifact-type.rst
+++ b/docs/modelingconcepts/artifact-type.rst
@@ -39,14 +39,14 @@ This node was created, derived from ``tosca.artifacts.Root`` to be the root TOSC
       File must have **.vtl** extension.
 
       The **template** can represent anything, such as device config, payload to interact with 3rd party systems,
-      :ref:`resource-accumulator template`, etc...
+      resource-accumulator template, etc...
 
       Often a template will be **parameterized**, and each **parameter**
       must be defined within an mapping file (see 'Mapping' in this tab).
 
       `Velocity reference document <http://velocity.apache.org/engine/1.7/user-guide.html>`_
 
-      `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/artifact_type/artifact-template-velocity.json>`_
+      `Velocity artifact <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/artifact_type/artifact-template-velocity.json>`_
       is the TOSCA artifact type:
 
       .. code-block:: json
@@ -69,13 +69,13 @@ This node was created, derived from ``tosca.artifacts.Root`` to be the root TOSC
       File must have **.jinja** extension.
 
       The **template** can represent **anything**, such as device config,
-      payload to interact with 3rd party systems, :ref:`resource-accumulator template`, etc...
+      payload to interact with 3rd party systems, resource-accumulator template, etc...
 
-      Often a template will be parameterized, and each parameter must be defined within an :ref:`mapping file`.
+      Often a template will be parameterized, and each parameter must be defined within an mapping file.
 
       `Jinja reference document <https://jinja.palletsprojects.com/en/2.10.x/>`_
 
-      `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/artifact_type/artifact-template-jinja.json>`_
+      `Jinja artifact <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/artifact_type/artifact-template-jinja.json>`_
       is the TOSCA artifact type:
 
       .. code-block:: json
@@ -107,7 +107,7 @@ This node was created, derived from ``tosca.artifacts.Root`` to be the root TOSC
       The **template** can represent **anything**, such as device config,
       payload to interact with 3rd party systems, resource-accumulator template, etc...
 
-      `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/artifact_type/artifact-mapping-resource.json>`_
+      `Mapping artifact <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/artifact_type/artifact-mapping-resource.json>`_
       is the TOSCA artifact type:
 
       .. code-block:: json
diff --git a/docs/modelingconcepts/data-dictionary.rst b/docs/modelingconcepts/data-dictionary.rst
index 9f9699a05..0f098d7ef 100644
--- a/docs/modelingconcepts/data-dictionary.rst
+++ b/docs/modelingconcepts/data-dictionary.rst
@@ -35,7 +35,7 @@ As part of modelling a data dictionary entry, the following generic information
      - Information related
      - Mandatory
    * - sources
-     - List of resource source instance (see :ref:`resource source`)
+     - List of resource source instance (see :ref:`node_type`)
      - Mandatory
    * - property
      - Defines type and description, as nested JSON
@@ -108,4 +108,4 @@ Here is how input-key-mapping, output-key-mapping and key-dependencies can be us
                   }
                 }
               }
-            }
\ No newline at end of file
+            }
diff --git a/docs/modelingconcepts/data-type.rst b/docs/modelingconcepts/data-type.rst
index ee5908002..548c2c28c 100644
--- a/docs/modelingconcepts/data-type.rst
+++ b/docs/modelingconcepts/data-type.rst
@@ -98,7 +98,7 @@ List of existing data type:
          * - dictionary-name
            - Reference to the name of the data dictionary (see :ref:`data_dictionary`).
          * - dictionary-source
-           - Reference the source to use to resolve the resource (see :ref:`resource source`).
+           - Reference the source to use to resolve the resource (see :ref:`node_type`).
          * - dependencies
            - List of dependencies required to resolve this resource.
          * - updated-date
@@ -215,4 +215,4 @@ List of existing data type:
              }
            },
            "derived_from": "tosca.datatypes.Root"
-         }
\ No newline at end of file
+         }
diff --git a/docs/modelingconcepts/expression.rst b/docs/modelingconcepts/expression.rst
index 9ce5659dc..59145d26e 100644
--- a/docs/modelingconcepts/expression.rst
+++ b/docs/modelingconcepts/expression.rst
@@ -23,7 +23,7 @@ TOSCA provides for a set of functions to reference elements within the template
 
       Within CDS, this is mainly Workflow inputs.
 
-      `TOSCA specification
+      `TOSCA specification - get_input
       <http://docs.oasis-open.org/tosca/TOSCA-Simple-Profile-YAML/v1.2/csd01/TOSCA-Simple-Profile-YAML-v1.2-csd01.html#_Toc494454178>`_
 
       **Example:**
@@ -59,7 +59,7 @@ TOSCA provides for a set of functions to reference elements within the template
       The **get_attribute** function is used to retrieve the values of named attributes declared
       by the referenced node or relationship template name.
 
-      `TOSCA specification
+      `TOSCA specification - get_attribute
       <http://docs.oasis-open.org/tosca/TOSCA-Simple-Profile-YAML/v1.2/csd01/TOSCA-Simple-Profile-YAML-v1.2-csd01.html#_Toc494454178>`_
 
       **Example:**
@@ -80,7 +80,7 @@ TOSCA provides for a set of functions to reference elements within the template
       The **get_operation_output** function is used to retrieve the values of variables
       exposed / exported from an interface operation.
 
-      `TOSCA specification
+      `TOSCA specification - get_operation_output
       <http://docs.oasis-open.org/tosca/TOSCA-Simple-Profile-YAML/v1.2/csd01/TOSCA-Simple-Profile-YAML-v1.2-csd01.html#_Toc494454180>`_
 
       **Example:**
@@ -96,11 +96,11 @@ TOSCA provides for a set of functions to reference elements within the template
       The **get_artifact** function is used to retrieve artifact location between modelable
       entities defined in the same service template.
 
-      `TOSCA specification
+      `TOSCA specification - get_artifact
       <http://docs.oasis-open.org/tosca/TOSCA-Simple-Profile-YAML/v1.2/csd01/TOSCA-Simple-Profile-YAML-v1.2-csd01.html#_Toc494454182>`_
 
       **Example:**
 
       .. code-block:: json
 
-         "get_artifact" : ["SELF", "artifact-template", "location", true]
\ No newline at end of file
+         "get_artifact" : ["SELF", "artifact-template", "location", true]
diff --git a/docs/modelingconcepts/external-system.rst b/docs/modelingconcepts/external-system.rst
index 598cd451e..120accb94 100644
--- a/docs/modelingconcepts/external-system.rst
+++ b/docs/modelingconcepts/external-system.rst
@@ -30,7 +30,6 @@ Here are some examples on how to populate the system information within the pack
    * - .. code-block:: json
 
         {
-          . . .
           "dsl_definitions": {
           "ipam-1": {
             "type": "token-auth",
@@ -47,7 +46,6 @@ Here are some examples on how to populate the system information within the pack
    * - .. code-block:: json
 
         {
-          . . .
           "dsl_definitions": {
             "ipam-1": {
               "type": "basic-auth",
@@ -56,7 +54,6 @@ Here are some examples on how to populate the system information within the pack
               "password": "marley"
             }
           }
-          . . .
         }
 
 .. list-table::
@@ -67,19 +64,17 @@ Here are some examples on how to populate the system information within the pack
    * - .. code-block:: json
 
         {
-          . . .
           "dsl_definitions": {
             "ipam-1": {
-              "type" : "ssl-basic-auth",
-              "url" : "http://localhost:32778",
+              "type": "ssl-basic-auth",
+              "url": "http://localhost:32778",
               "keyStoreInstance": "JKS or PKCS12",
               "sslTrust": "trusture",
               "sslTrustPassword": "trustore password",
               "sslKey": "keystore",
-              "sslKeyPassword: "keystore password"
+              "sslKeyPassword": "keystore password"
             }
           }
-          . . .
         }
 
 .. list-table::
@@ -90,7 +85,6 @@ Here are some examples on how to populate the system information within the pack
    * - .. code-block:: json
 
         {
-          . . .
           "dsl_definitions": {
             "remote-executor": {
               "type": "token-auth",
@@ -99,7 +93,6 @@ Here are some examples on how to populate the system information within the pack
               "token": "Basic Y2NzZGthcHBzOmNjc2RrYXBwcw=="
             }
           }
-          . . .
         }
 
 .. list-table::
@@ -109,7 +102,6 @@ Here are some examples on how to populate the system information within the pack
    * - .. code-block:: json
 
         {
-          . . .
           "dsl_definitions": {
             "netprog-db": {
               "type": "maria-db",
@@ -118,5 +110,4 @@ Here are some examples on how to populate the system information within the pack
               "password": "netprog"
             }
           }
-          . . .
         }
diff --git a/docs/modelingconcepts/node-type.rst b/docs/modelingconcepts/node-type.rst
index 034a6b063..98c99a61e 100644
--- a/docs/modelingconcepts/node-type.rst
+++ b/docs/modelingconcepts/node-type.rst
@@ -22,7 +22,7 @@ listed in the other section.
 
       Used to represent a **functionality** along with its **contract**, such as **inputs**, **ouputs**, and **attributes**
 
-      `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/tosca.nodes.Component.json>`_
+      `Component type <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/tosca.nodes.Component.json>`_
       is the root component TOSCA node type from which other node type will derive:
 
       .. code-block:: json
@@ -51,7 +51,7 @@ listed in the other section.
 
             Will put the resolution result as an **attribute** in the workflow context called **assignment-params**.
 
-            Using the :ref:`undefined <get_attribute expression>`, this attribute can be retrieve to be
+            Using the **get_attribute** expression, this attribute can be retrieve to be
             provided as workflow output (see :ref:`workflow`).
 
             **Specify which template to resolve:**
@@ -90,7 +90,7 @@ listed in the other section.
 
             This feature is useful when you need to apply the same configuration accross network elements.
 
-            `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/component-resource-resolution.json>`_
+            `Resource resolution <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/component-resource-resolution.json>`_
             is the definition:
 
             .. code-block:: json
@@ -201,7 +201,7 @@ listed in the other section.
             * for kotlin: the package name up to the class. e.g. com.example.Bob
             * for python: it has to be the path from the Scripts folder, e.g. Scripts/python/Bob.py
 
-            `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/component-script-executor.json>`_
+            `Script executor type <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/component-script-executor.json>`_
             is the definition
 
             .. _test_test_test:
@@ -330,7 +330,7 @@ listed in the other section.
             script that couldn't be passed as an argument, such as JSON object, etc... If used, they will be passed
             in as the last argument of the Python script.
 
-            `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/component-remote-python-executor.json>`_
+            `Remote executor type <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/component-remote-python-executor.json>`_
             is the definition
 
             .. code-block:: json
@@ -421,7 +421,7 @@ listed in the other section.
 
             TBD
 
-            `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/component-remote-ansible-executor.json>`_
+            `Ansible executor <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/component-remote-ansible-executor.json>`_
             is the definition
 
             .. code-block:: json
@@ -501,7 +501,7 @@ listed in the other section.
 
       Defines the **contract** to resolve a resource.
 
-      `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/tosca.nodes.ResourceSource.json>`_
+      `Resource source type <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/tosca.nodes.ResourceSource.json>`_
       is the root component TOSCA node type from which other node type will derive:
 
       .. code-block::
@@ -523,7 +523,7 @@ listed in the other section.
 
             Expects the **value to be provided as input** to the request.
 
-            `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/source-input.json>`_
+            `Input source <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/source-input.json>`_
             is the Definition
 
             .. code-block::
@@ -542,7 +542,7 @@ listed in the other section.
 
             Expects the **value to be defaulted** in the model itself.
 
-            `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/source-default.json>`_
+            `Default source type <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/source-default.json>`_
             is the Definition
 
             .. code-block:: json
@@ -593,7 +593,7 @@ listed in the other section.
                  - Path expression type - default value is JSON_PATH
                  - Optional
 
-            `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/source-rest.json>`_
+            `Rest source <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/source-rest.json>`_
             is the definition:
 
             .. code-block:: json
@@ -712,7 +712,7 @@ listed in the other section.
                  - Mandatory
 
 
-            `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/source-processor-db.json>`_
+            `DB source type <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/source-processor-db.json>`_
             is the definition:
 
             .. code-block:: json
@@ -786,7 +786,7 @@ listed in the other section.
                        - The name of the class to use to create an instance of the script
                        - Mandatory
 
-            `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/source-capability.json>`_
+            `Capability source type <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/source-capability.json>`_
             is the definition:
 
             .. code-block:: json
@@ -850,7 +850,7 @@ listed in the other section.
                  - The node template the workflow depends on
                  - Required
 
-            `Here <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/dg-generic.json>`_
+            `DG source type <https://github.com/onap/ccsdk-cds/blob/master/components/model-catalog/definition-type/starter-type/node_type/dg-generic.json>`_
             is the definition:
 
             .. code-block:: json
diff --git a/docs/modelingconcepts/tosca-meta.rst b/docs/modelingconcepts/tosca-meta.rst
index 095defe13..a61d2fbde 100644
--- a/docs/modelingconcepts/tosca-meta.rst
+++ b/docs/modelingconcepts/tosca-meta.rst
@@ -53,11 +53,11 @@ Tosca meta file captures the model entities that compose the cba package name, v
      - String
      - | The attribute that holds the blueprint package types.
        | Valid Options:
-       * "DEFAULT" – .JSON file consistent of tosca based cba package that describes the package intent.
-       * "KOTLIN_DSL" – .KT file consistent of tosca based cba package that describes the package intent
-         composed using Domain Specific Language (DSL).
-       * "GENERIC_SCRIPT" – Script file consistent of NONE tosca based cba package that describes the package intent
-         using DSL Language.
+         * "DEFAULT" – .JSON file consistent of tosca based cba package that describes the package intent.
+         * "KOTLIN_DSL" – .KT file consistent of tosca based cba package that describes the package intent
+            composed using Domain Specific Language (DSL).
+         * "GENERIC_SCRIPT" – Script file consistent of NONE tosca based cba package that describes the package intent
+            using DSL Language.
        | If not specified in the tosca.meta file the default is "DEFAULT"
    * - Template-Tags
      - Required
@@ -76,4 +76,4 @@ https://git.onap.org/ccsdk/cds/tree/components/model-catalog/blueprint-model/tes
 
 **GENERIC_SCRIPT Template Type**
 
-https://git.onap.org/ccsdk/cds/tree/components/model-catalog/blueprint-model/test-blueprint/capability_python/TOSCA-Metadata/TOSCA.meta
\ No newline at end of file
+https://git.onap.org/ccsdk/cds/tree/components/model-catalog/blueprint-model/test-blueprint/capability_python/TOSCA-Metadata/TOSCA.meta
diff --git a/docs/modelingconcepts/workflow.rst b/docs/modelingconcepts/workflow.rst
index 7e21cfe0c..1578c3217 100644
--- a/docs/modelingconcepts/workflow.rst
+++ b/docs/modelingconcepts/workflow.rst
@@ -42,7 +42,6 @@ which actually is the name of the ``node_template`` defined after, of type ``com
 .. code-block:: json
    :caption: **Example**
 
-      . . .
       "topology_template": {
         "workflows": {
           "resource-assignment": {
@@ -101,7 +100,6 @@ which actually is the name of the ``node_template`` defined after, of type ``com
           }
         }
       }
-      . . .
 
 .. _workflow_multiple_actions:
 
@@ -123,7 +121,6 @@ In the example above, you can see the target of the workflow's steps execute-scr
 .. code-block:: json
    :caption: **workflow plan example**
 
-    . . .
     "topology_template": {
       "workflows": {
         "execute-remote-ansible": {
@@ -268,7 +265,7 @@ Properties of a workflow
               - value resolvable using :ref:`expression` -> get_attribute
    * - steps
      - | Defines the actual step to execute as part of the workflow
-       |
+
        .. list-table::
           :widths: 25 25 50
           :header-rows: 1
@@ -284,7 +281,7 @@ Properties of a workflow
 
 Example:
 
-.. code-block:: json
+.. code-block::
    :caption: **workflow example**
 
     {